September 2012 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: core: AuditLog for Activate/Deactivate VmNic (#858719)
by msalem＠redhat.com 24 Sep '12

24 Sep '12

Muli Salem has submitted this change and it was merged. Change subject: core: AuditLog for Activate/Deactivate VmNic (#858719) ...................................................................... core: AuditLog for Activate/Deactivate VmNic (#858719) https://bugzilla.redhat.com/858719 Adding AuditLog message for activating/deactivating nic success/failure. Change-Id: I8b88a4e0b6c94ebe671a8fe9a215a94231eaeef8 Signed-off-by: Muli Salem <msalem(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ActivateDeactivateVmNicCommand.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/AuditLogType.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/auditloghandling/AuditLogDirector.java M backend/manager/modules/dal/src/main/resources/bundles/AuditLogMessages.properties 4 files changed, 36 insertions(+), 1 deletion(-) Approvals: Muli Salem: Verified; Looks good to me, approved Moti Asayag: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/8152 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8b88a4e0b6c94ebe671a8fe9a215a94231eaeef8 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Muli Salem <msalem(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Muli Salem <msalem(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Error Code Handling for AddVmNic (#858719)
by msalem＠redhat.com 24 Sep '12

24 Sep '12

Muli Salem has submitted this change and it was merged. Change subject: core: Error Code Handling for AddVmNic (#858719) ...................................................................... core: Error Code Handling for AddVmNic (#858719) https://bugzilla.redhat.com/858719 This patch makes sure the activating/deactivating failure is passed on from ActivateDeactivateVmNicCommand to AddVmInterfaceCommand. It also adds the vdsm error codes for activation/deactivation failure. Change-Id: I2b2ac5495f3b85d4b8b9a9f8b68e7eaf2c2af145 Signed-off-by: Muli Salem <msalem(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmInterfaceCommand.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/VdcBllErrors.java M backend/manager/modules/dal/src/main/resources/bundles/VdsmErrors.properties M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/VdsmErrors.java M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/VdsmErrors.properties M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/VdsmErrors.properties 6 files changed, 20 insertions(+), 4 deletions(-) Approvals: Muli Salem: Verified; Looks good to me, approved Moti Asayag: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/8150 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2b2ac5495f3b85d4b8b9a9f8b68e7eaf2c2af145 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Muli Salem <msalem(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Muli Salem <msalem(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: fix checkstyle in tests
by yzaslavs＠redhat.com 24 Sep '12

24 Sep '12

Yair Zaslavsky has submitted this change and it was merged. Change subject: core: fix checkstyle in tests ...................................................................... core: fix checkstyle in tests Adds NON-NLS to the tests Change-Id: I91f931fd176d8c96b11a4ac2ec8c1ec0dbe0dcf5 Signed-off-by: Laszlo Hornyak <lhornyak(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/test/java/org/ovirt/engine/ui/uicommonweb/LinqTest.java 1 file changed, 6 insertions(+), 6 deletions(-) Approvals: Yair Zaslavsky: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/8159 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I91f931fd176d8c96b11a4ac2ec8c1ec0dbe0dcf5 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Laszlo Hornyak <lhornyak(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: engine: Unifying (parts of) engine and vdsm commit templates
by dfediuck＠redhat.com 24 Sep '12

24 Sep '12

Doron Fediuck has submitted this change and it was merged. Change subject: engine: Unifying (parts of) engine and vdsm commit templates ...................................................................... engine: Unifying (parts of) engine and vdsm commit templates As agreed in arch mailing-list[1], we'd like the engine's commit template andvdsm conventions to agree on BZ referencing. This change will make engine template add a 'Bug-Url:' to the message, which will be done also by vdsm developers. [1] http://lists.ovirt.org/pipermail/arch/2012-September/000838.html Change-Id: I54f5c6890a1ea2393498c3ecffd2661d030ed226 Signed-off-by: Doron Fediuck <dfediuck(a)redhat.com> Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M config/engine-commit-template.txt 1 file changed, 3 insertions(+), 3 deletions(-) Approvals: Doron Fediuck: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/7696 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I54f5c6890a1ea2393498c3ecffd2661d030ed226 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Doron Fediuck <dfediuck(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Barak Azulay <bazulay(a)redhat.com> Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com> Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Livnat Peer <lpeer(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: engine: Remove unnecessary code and add check for NPE.
by lhornyak＠redhat.com 24 Sep '12

24 Sep '12

Laszlo Hornyak has submitted this change and it was merged. Change subject: engine: Remove unnecessary code and add check for NPE. ...................................................................... engine: Remove unnecessary code and add check for NPE. 'for' loop should not be called when lists is null. Change-Id: Id771f4bd5342dc90a03ee1bd6a52dc285fb85765 Signed-off-by: Sharad Mishra <snmishra(a)linux.vnet.ibm.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/Linq.java 1 file changed, 3 insertions(+), 4 deletions(-) Approvals: Laszlo Hornyak: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/7916 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id771f4bd5342dc90a03ee1bd6a52dc285fb85765 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Sharad Mishra <snmishra(a)linux.vnet.ibm.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Laszlo Hornyak <lhornyak(a)redhat.com> Gerrit-Reviewer: Sharad Mishra <snmishra(a)linux.vnet.ibm.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: test for Linq.Intersection
by lhornyak＠redhat.com 24 Sep '12

24 Sep '12

Laszlo Hornyak has submitted this change and it was merged. Change subject: core: test for Linq.Intersection ...................................................................... core: test for Linq.Intersection This patch adds a test for Linq.Intersection Change-Id: I0cc1664af85ef1997e95e459c90e7d5dd87d7706 Signed-off-by: Laszlo Hornyak <lhornyak(a)redhat.com> --- A frontend/webadmin/modules/uicommonweb/src/test/java/org/ovirt/engine/ui/uicommonweb/LinqTest.java 1 file changed, 34 insertions(+), 0 deletions(-) Approvals: Laszlo Hornyak: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/8138 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0cc1664af85ef1997e95e459c90e7d5dd87d7706 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Laszlo Hornyak <lhornyak(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Laszlo Hornyak <lhornyak(a)redhat.com> Gerrit-Reviewer: Sharad Mishra <snmishra(a)linux.vnet.ibm.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin: hiding DC in Host tab - GlusterOnly mode
by gchaplik＠redhat.com 24 Sep '12

24 Sep '12

Gilad Chaplik has submitted this change and it was merged. Change subject: webadmin: hiding DC in Host tab - GlusterOnly mode ...................................................................... webadmin: hiding DC in Host tab - GlusterOnly mode Data Center column in the Host tab table will not be shown in GlusterOnly mode. Change-Id: Icb406ba70b7d256eb7b6772931ba8078084dc9a0 Signed-off-by: Kanagaraj M <kmayilsa(a)redhat.com> --- M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/MainTabHostView.java 1 file changed, 9 insertions(+), 7 deletions(-) Approvals: Kanagaraj M: Verified Gilad Chaplik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/8001 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Icb406ba70b7d256eb7b6772931ba8078084dc9a0 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Kanagaraj M <kmayilsa(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayilsa(a)redhat.com> Gerrit-Reviewer: Shireesh Anjal <sanjal(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin: Import gluster cluster
by gchaplik＠redhat.com 24 Sep '12

24 Sep '12

Gilad Chaplik has submitted this change and it was merged. Change subject: webadmin: Import gluster cluster ...................................................................... webadmin: Import gluster cluster Cluster dialog is extended to support import an existing gluster cluster. The user has to enter the details of any server(host) in the gluster cluster to import. The flow is 1. At the time of creating a new cluster the user enables Gluster service and selects import existing cluster configuration. 2. Provides the details (hostname/IP, password) of any server in the existing gluster cluster 3. When the user lose focus on the hostname/IP field, a rpc call is fired to fetch the fingerprint of the host 4. User validates the fingerprint and clicks on Ok in cluster dialog. 5. A new dialog will be shown with all hosts in the gluster cluster 6. User validates the fingerprint of all the hosts and provides passwords. Clicks on ok, cluster will be created and the hosts will be added to the cluster. Change-Id: I502acdb461c0b8557be2f933c7fd6ba5da469f23 Signed-off-by: Kanagaraj M <kmayilsa(a)redhat.com> --- A frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/table/column/PasswordTextInputCell.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/dataprovider/AsyncDataProvider.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/clusters/ClusterListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/clusters/ClusterModel.java A frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostDetailModel.java A frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/MultipleHostsModel.java M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/Constants.java M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/Messages.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/ApplicationConstants.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/gin/PresenterModule.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/gin/uicommon/ClusterModule.java A frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/presenter/popup/host/MultipleHostsPopupPresenterWidget.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/cluster/ClusterPopupView.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/cluster/ClusterPopupView.ui.xml A frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/MultipleHostsPopupView.java A frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/MultipleHostsPopupView.ui.xml 16 files changed, 995 insertions(+), 8 deletions(-) Approvals: Kanagaraj M: Verified Gilad Chaplik: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/7261 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I502acdb461c0b8557be2f933c7fd6ba5da469f23 Gerrit-PatchSet: 13 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Kanagaraj M <kmayilsa(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayilsa(a)redhat.com> Gerrit-Reviewer: Shireesh Anjal <sanjal(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: webadmin: Add quota usage tooltip (#848028)
by gchaplik＠redhat.com 24 Sep '12

24 Sep '12

Gilad Chaplik has submitted this change and it was merged. Change subject: webadmin: Add quota usage tooltip (#848028) ...................................................................... webadmin: Add quota usage tooltip (#848028) https://bugzilla.redhat.com/848028 A tooltip added to the usage column in the Quota>storage sub-tab to explain the differences between that value and the value shown in the Storage>VMs sub-tab. The value in Quota>storage sub-tab uses the max growth potential of a disk to calculate the quota consumption. The value in Storage>VMs sub-tab shows the actual current use of the disk. Change-Id: Ic3f3c0243650e9822509c1249f0f6ca9c512d543 Signed-off-by: Ofri Masad <omasad(a)redhat.com> --- A frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/table/column/TextCellWithEditableTooltip.java A frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/table/column/TextColumnWithEditableTooltip.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/ApplicationConstants.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/quota/SubTabQuotaStorageView.java 4 files changed, 75 insertions(+), 1 deletion(-) Approvals: Gilad Chaplik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/8153 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic3f3c0243650e9822509c1249f0f6ca9c512d543 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: ofri masad <omasad(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: ofri masad <omasad(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Auto-Recovery should check whether getVdsStats return...
by mkublin＠redhat.com 24 Sep '12

24 Sep '12

Michael Kublin has submitted this change and it was merged. Change subject: core: Auto-Recovery should check whether getVdsStats returns 'lastCheck<60' before it proclaims host as up (#844438) ...................................................................... core: Auto-Recovery should check whether getVdsStats returns 'lastCheck<60' before it proclaims host as up (#844438) https://bugzilla.redhat.com/844438 The described bug is a private case of regular activate host operation. The problem is that the condition for moving host to NonOperational is different for those that move host to Active state. Solution is during IniVdsOnUpCommand perform getVdsStats in order to get info about storage domains that host can see, if all Active domins in cluster is seen by host it will be moved Active, otherwise it will be left as NonOperational with reason: STORAGE_DOMAIN_UNREACHABLE Change-Id: Id88ef24829d5fae61dddd34f0265ae3132672783 Signed-off-by: Michael Kublin <mkublin(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/InitVdsOnUpCommand.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/AuditLogType.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/VDSCommandType.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/auditloghandling/AuditLogDirector.java M backend/manager/modules/dal/src/main/resources/bundles/AuditLogMessages.properties M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/IrsBrokerCommand.java 6 files changed, 83 insertions(+), 8 deletions(-) Approvals: Michael Kublin: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/8131 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id88ef24829d5fae61dddd34f0265ae3132672783 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Michael Kublin <mkublin(a)redhat.com> Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com> Gerrit-Reviewer: Barak Azulay <bazulay(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Michael Kublin <mkublin(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0