September 2012 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: core: Refactor manage-domains permission handling (#856581)
by yzaslavs＠redhat.com 20 Sep '12

20 Sep '12

Yair Zaslavsky has submitted this change and it was merged. Change subject: core: Refactor manage-domains permission handling (#856581) ...................................................................... core: Refactor manage-domains permission handling (#856581) https://bugzilla.redhat.com/856581 As part of fixing this bug, a method for handling the permission is extracted, in order to provide code reuse for add and edit actions Change-Id: I7636e84ffc66ae6fda3d3bc5f5c48d9e1449da6f Signed-off-by: Yair Zaslavsky <yzaslavs(a)redhat.com> --- M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/kerberos/ManageDomains.java 1 file changed, 10 insertions(+), 10 deletions(-) Approvals: Yair Zaslavsky: Verified Oved Ourfali: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/8061 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7636e84ffc66ae6fda3d3bc5f5c48d9e1449da6f Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine-cli[master]: cli: do not log /connect command in history
by mpastern＠redhat.com 20 Sep '12

20 Sep '12

Michael Pasternak has submitted this change and it was merged. Change subject: cli: do not log /connect command in history ...................................................................... cli: do not log /connect command in history Change-Id: Ieb983ecec4ae30fbae2411f0bf2eaef194e96f21 Signed-off-by: Michael Pasternak <mpastern(a)redhat.com> --- M src/ovirtcli/command/connect.py M src/ovirtcli/historymanager.py 2 files changed, 13 insertions(+), 0 deletions(-) Approvals: Michael Pasternak: Verified; Looks good to me, approved Oved Ourfali: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/8054 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ieb983ecec4ae30fbae2411f0bf2eaef194e96f21 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine-cli Gerrit-Branch: master Gerrit-Owner: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>

1 0

Change in ovirt-engine-cli[master]: cli: disable /history while not connected
by mpastern＠redhat.com 20 Sep '12

20 Sep '12

Michael Pasternak has submitted this change and it was merged. Change subject: cli: disable /history while not connected ...................................................................... cli: disable /history while not connected Change-Id: I1bb7e7e2d631587bebc8dd27fef577a48dbe43d1 Signed-off-by: Michael Pasternak <mpastern(a)redhat.com> --- M src/ovirtcli/command/connect.py M src/ovirtcli/command/disconnect.py M src/ovirtcli/command/history.py M src/ovirtcli/historymanager.py 4 files changed, 53 insertions(+), 18 deletions(-) Approvals: Michael Pasternak: Verified; Looks good to me, approved Oved Ourfali: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/8053 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1bb7e7e2d631587bebc8dd27fef577a48dbe43d1 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine-cli Gerrit-Branch: master Gerrit-Owner: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>

1 0

Change in ovirt-engine-cli[master]: cli: enable --port option
by mpastern＠redhat.com 20 Sep '12

20 Sep '12

Michael Pasternak has submitted this change and it was merged. Change subject: cli: enable --port option ...................................................................... cli: enable --port option Change-Id: I19cd224deb7d1d080a7422d4193531eda79804eb Signed-off-by: Michael Pasternak <mpastern(a)redhat.com> --- M src/ovirtcli/options.py 1 file changed, 1 insertion(+), 2 deletions(-) Approvals: Michael Pasternak: Verified; Looks good to me, approved Oved Ourfali: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/8052 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I19cd224deb7d1d080a7422d4193531eda79804eb Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine-cli Gerrit-Branch: master Gerrit-Owner: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>

1 0

Change in ovirt-engine-cli[master]: cli: add username/password prompt/command-line functionality
by mpastern＠redhat.com 19 Sep '12

19 Sep '12

Michael Pasternak has submitted this change and it was merged. Change subject: cli: add username/password prompt/command-line functionality ...................................................................... cli: add username/password prompt/command-line functionality - removed --password option from cli options - added configuration file: ~/.ovirtshellrc - if used auto-connect mode (-c/--connect) and config file lacks url/username/password, user will be prompted for these options Change-Id: I7f468af34955ef37ce975d61519d8b3959dc7a0f Signed-off-by: Michael Pasternak <mpastern(a)redhat.com> --- M src/cli/context.py M src/cli/settings.py M src/ovirtcli/context.py M src/ovirtcli/main.py M src/ovirtcli/options.py M src/ovirtcli/settings.py 6 files changed, 158 insertions(+), 20 deletions(-) Approvals: Michael Pasternak: Verified; Looks good to me, approved Keith Robertson: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/8035 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7f468af34955ef37ce975d61519d8b3959dc7a0f Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine-cli Gerrit-Branch: master Gerrit-Owner: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Keith Robertson <kroberts(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com>

1 0

Change in ovirt-engine[master]: Fix setParentParameters name typos
by lhornyak＠redhat.com 19 Sep '12

19 Sep '12

Laszlo Hornyak has submitted this change and it was merged. Change subject: Fix setParentParameters name typos ...................................................................... Fix setParentParameters name typos Signed-off-by: Federico Simoncelli <fsimonce(a)redhat.com> Change-Id: I01a9bcfe32c6f78f6fd43fcba1d45d48e3f47f61 --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddDiskCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmAndCloneImageCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmFromScratchCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmTemplateCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AttachUserToVmFromPoolAndRunCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CreateAllSnapshotsFromVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ExportVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ExportVmTemplateCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImportVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImportVmTemplateCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MoveOrCopyDiskCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MoveOrCopyImageGroupCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MoveOrCopyTemplateCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveAllVmImagesCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveAllVmTemplateImageTemplatesCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveDiskCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveVmTemplateCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveVmTemplateFromImportExportCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RestoreAllSnapshotsCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/TryBackToAllSnapshotsOfVmCommand.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/BackwardCompatibilityTaskCreationTest.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/VdcActionParametersBase.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/AsyncTaskDAODbFacadeImpl.java 25 files changed, 27 insertions(+), 27 deletions(-) Approvals: Laszlo Hornyak: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/8024 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I01a9bcfe32c6f78f6fd43fcba1d45d48e3f47f61 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli <fsimonce(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com> Gerrit-Reviewer: Laszlo Hornyak <lhornyak(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Sharad Mishra <snmishra(a)linux.vnet.ibm.com>

1 0

Change in ovirt-engine[master]: packaging: Increase Apache AJP timeout (#845832)
by juan.hernandez＠redhat.com 19 Sep '12

19 Sep '12

Juan Hernandez has submitted this change and it was merged. Change subject: packaging: Increase Apache AJP timeout (#845832) ...................................................................... packaging: Increase Apache AJP timeout (#845832) https://bugzilla.redhat.com/845832 The default timeout that Apache uses when waiting to receive network data from the application server is 60 seconds. Some of the RESTAPI request can take longer than that and will fail with this setting, so we need to increase it to account for the slowest operations. Change-Id: Id43ff3b79de8d7955018809cce66c2c06984298d Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M packaging/fedora/setup/ovirt-engine-proxy.conf.in 1 file changed, 26 insertions(+), 4 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/7933 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id43ff3b79de8d7955018809cce66c2c06984298d Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Barak Azulay <bazulay(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Michael Kublin <mkublin(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Renamed Execute() to execute() in BrokerCommandBase cl...
by lhornyak＠redhat.com 19 Sep '12

19 Sep '12

Laszlo Hornyak has submitted this change and it was merged. Change subject: core: Renamed Execute() to execute() in BrokerCommandBase class ...................................................................... core: Renamed Execute() to execute() in BrokerCommandBase class To conform to java method naming convention of starting with lower case letter. Change-Id: I79b772729aaabe3293546691b88cc2e2b0a18d58 Signed-off-by: Sharad Mishra <snmishra(a)linux.vnet.ibm.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/adbroker/BrokerCommandBase.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/adbroker/InternalBrokerCommandBase.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/adbroker/LdapBrokerBase.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/adbroker/LdapBrokerCommandBase.java 4 files changed, 4 insertions(+), 4 deletions(-) Approvals: Laszlo Hornyak: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/7996 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I79b772729aaabe3293546691b88cc2e2b0a18d58 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Sharad Mishra <snmishra(a)linux.vnet.ibm.com> Gerrit-Reviewer: Laszlo Hornyak <lhornyak(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Sharad Mishra <snmishra(a)linux.vnet.ibm.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: AddStoragePool - enable forceCompensation (#817339)
by derez＠redhat.com 19 Sep '12

19 Sep '12

Daniel Erez has submitted this change and it was merged. Change subject: core: AddStoragePool - enable forceCompensation (#817339) ...................................................................... core: AddStoragePool - enable forceCompensation (#817339) https://bugzilla.redhat.com/817339 Set 'forceCompensation' to true in AddStoragePoolWithStoragesCommand (needed for compensating storage domain attach failure). Change-Id: Iaac9ec848f23a230d57568fb15779037cb56ee77 Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/AddStoragePoolWithStoragesCommand.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Daniel Erez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/8042 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iaac9ec848f23a230d57568fb15779037cb56ee77 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Michael Kublin <mkublin(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: check host time-drift in getVdsStat(#848862)
by emesika＠redhat.com 19 Sep '12

19 Sep '12

Eli Mesika has submitted this change and it was merged. Change subject: core: check host time-drift in getVdsStat(#848862) ...................................................................... core: check host time-drift in getVdsStat(#848862) Change-Id: Ie1f38149c0a7fb1d6e1627e86b1a3c231352e1a0 Signed-off-by: Eli Mesika <emesika(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/GetStatsVDSCommand.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsBrokerObjectsBuilder.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsProperties.java 3 files changed, 42 insertions(+), 0 deletions(-) Approvals: Eli Mesika: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/7830 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie1f38149c0a7fb1d6e1627e86b1a3c231352e1a0 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Michael Kublin <mkublin(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0