September 2012 - Engine-commits - Ovirt List Archives

Change in ovirt-engine-cli[master]: cli: valid UUIDs are treated as syntax error #854391

by mpastern＠redhat.com

Michael Pasternak has submitted this change and it was merged. Change subject: cli: valid UUIDs are treated as syntax error #854391 ...................................................................... cli: valid UUIDs are treated as syntax error #854391 https://bugzilla.redhat.com/show_bug.cgi?id=854391 Change-Id: Ie46e4f959d80e7e35a33b419e1f52424cd464956 Signed-off-by: Michael Pasternak <mpastern(a)redhat.com> --- M src/cli/parser.py 1 file changed, 8 insertions(+), 2 deletions(-) Approvals: Michael Pasternak: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/7869 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie46e4f959d80e7e35a33b419e1f52424cd464956 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine-cli Gerrit-Branch: master Gerrit-Owner: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>

12 years, 4 months

1
0
0 / 0

Change in ovirt-engine[master]: core: Improve VmDevice's toString (#851991)

by mkolesni＠redhat.com

Mike Kolesnik has submitted this change and it was merged. Change subject: core: Improve VmDevice's toString (#851991) ...................................................................... core: Improve VmDevice's toString (#851991) https://bugzilla.redhat.com/851991 1. Improved VmDevice's to string to print the field names. 2. Added enclosing brackets. 3. Added spacing between field names. Change-Id: I35434973e5cc9fe4f06d35b1b24afdfca484f6dc Signed-off-by: Mike Kolesnik <mkolesni(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VmDevice.java 1 file changed, 13 insertions(+), 12 deletions(-) Approvals: Mike Kolesnik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/7875 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I35434973e5cc9fe4f06d35b1b24afdfca484f6dc Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Muli Salem <msalem(a)redhat.com>

12 years, 4 months

1
0
0 / 0

Change in ovirt-engine[master]: core: Add toString to params & entities (#851991)

by mkolesni＠redhat.com

Mike Kolesnik has submitted this change and it was merged. Change subject: core: Add toString to params & entities (#851991) ...................................................................... core: Add toString to params & entities (#851991) https://bugzilla.redhat.com/851991 Added toString for logging networking VDSM command invocations, for ease of debugging. Change-Id: I825db07b7320c4768a38d89fd83177774e22a9fd Signed-off-by: Mike Kolesnik <mkolesni(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/Network.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/NetworkClusterId.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VdsNetworkInterface.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VmNetworkInterface.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/network_cluster.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/HotPlugUnplgNicVDSParameters.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/NetworkVdsmVDSCommandParameters.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/SetupNetworksVdsCommandParameters.java 8 files changed, 160 insertions(+), 8 deletions(-) Approvals: Mike Kolesnik: Verified Moti Asayag: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/7873 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I825db07b7320c4768a38d89fd83177774e22a9fd Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Muli Salem <msalem(a)redhat.com>

12 years, 4 months

1
0
0 / 0

Change in ovirt-engine[master]: engine: Map interfaces from DB correctly (#851991)

by mkolesni＠redhat.com

Mike Kolesnik has submitted this change and it was merged. Change subject: engine: Map interfaces from DB correctly (#851991) ...................................................................... engine: Map interfaces from DB correctly (#851991) https://bugzilla.redhat.com/851991 Map back the interfaces to their true instances instead of the generic ones, in order to show precise log data. Change-Id: I053edab2398b0d0e01a4051a32b7a34a2a742108 Signed-off-by: Mike Kolesnik <mkolesni(a)redhat.com> --- M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/InterfaceDAODbFacadeImpl.java 1 file changed, 44 insertions(+), 8 deletions(-) Approvals: Mike Kolesnik: Verified Moti Asayag: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/7872 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I053edab2398b0d0e01a4051a32b7a34a2a742108 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Muli Salem <msalem(a)redhat.com>

12 years, 4 months

1
0
0 / 0

Change in ovirt-engine[master]: core: Add network business entities (#851991)

by mkolesni＠redhat.com

Mike Kolesnik has submitted this change and it was merged. Change subject: core: Add network business entities (#851991) ...................................................................... core: Add network business entities (#851991) https://bugzilla.redhat.com/851991 Currently they will be used to better distinguish the logs, in the future they will be more extensively used. Change-Id: Id5d94f30c3d6a196744736f44a7d6e20c86e2e37 Signed-off-by: Mike Kolesnik <mkolesni(a)redhat.com> --- A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/network/Bond.java A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/network/Nic.java A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/network/Vlan.java M frontend/webadmin/modules/gwt-common/src/main/resources/org/ovirt/engine/core/Common.gwt.xml 4 files changed, 162 insertions(+), 0 deletions(-) Approvals: Mike Kolesnik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/7871 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id5d94f30c3d6a196744736f44a7d6e20c86e2e37 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Muli Salem <msalem(a)redhat.com>

12 years, 4 months

1
0
0 / 0

Change in ovirt-engine[master]: core: Added collectionToString to utils (#851991)

by mkolesni＠redhat.com

Mike Kolesnik has submitted this change and it was merged. Change subject: core: Added collectionToString to utils (#851991) ...................................................................... core: Added collectionToString to utils (#851991) https://bugzilla.redhat.com/851991 Added method capable of creating formatted string out of a collection of element. Change-Id: I8a3c45ae9d875733b90c9c9e327a20202c404caf Signed-off-by: Mike Kolesnik <mkolesni(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/Entities.java M backend/manager/modules/common/src/test/java/org/ovirt/engine/core/common/businessentities/EntitiesTest.java 2 files changed, 69 insertions(+), 0 deletions(-) Approvals: Mike Kolesnik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/7874 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8a3c45ae9d875733b90c9c9e327a20202c404caf Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Muli Salem <msalem(a)redhat.com>

12 years, 4 months

1
0
0 / 0

Change in ovirt-engine[master]: bootstrap: introduce soft timeouts for operations

by yzaslavs＠redhat.com

Yair Zaslavsky has submitted this change and it was merged. Change subject: bootstrap: introduce soft timeouts for operations ...................................................................... bootstrap: introduce soft timeouts for operations The only place non default ssh timeout was enforced is when getting node id. AddVdsCommand::canDoAction() So it relatively simple to add soft timeout / hard timeout support by just modify the defaults. Hard timeout - maximum duration of command. Soft timeout - maximum duration since last network activity. Reduce the default of SSHInactivityTimoutSeconds to 5 minutes, it is now the soft timeout limit. Add a new configuration parameter of SSHInactivityHardTimoutSeconds which is 30 minutes. Change-Id: Ic37e4384fda412f92bffd7a8aa809d0dfd4d8157 Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M backend/manager/dbscripts/upgrade/pre_upgrade/0000_config.sql M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/config/ConfigValues.java M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/hostinstall/VdsInstallerSSH.java M backend/manager/tools/engine-config/src/main/resources/engine-config.properties 4 files changed, 35 insertions(+), 9 deletions(-) Approvals: Yair Zaslavsky: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/7734 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic37e4384fda412f92bffd7a8aa809d0dfd4d8157 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alex Lourie <alourie(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Barak Azulay <bazulay(a)redhat.com> Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

12 years, 4 months

1
0
0 / 0

Change in ovirt-engine[master]: core: Do Not Fail RunVm on Non-Activated Vnic (#854978)

by msalem＠redhat.com

Muli Salem has submitted this change and it was merged. Change subject: core: Do Not Fail RunVm on Non-Activated Vnic (#854978) ...................................................................... core: Do Not Fail RunVm on Non-Activated Vnic (#854978) https://bugzilla.redhat.com/854978 Makes sure the Vds is not required to have networks that are defined on non-active Vnics of the VM, for running the VM. Signed-off-by: Muli Salem <msalem(a)redhat.com> Change-Id: I1834acde0800562b653ba19648f5b8a1fa64733b --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VdsSelector.java 1 file changed, 9 insertions(+), 1 deletion(-) Approvals: Muli Salem: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/7878 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1834acde0800562b653ba19648f5b8a1fa64733b Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Muli Salem <msalem(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Muli Salem <msalem(a)redhat.com>

12 years, 4 months

1
0
0 / 0

Change in ovirt-engine[master]: webadmin: Cleanup in QuotaModel (#848289)

by gchaplik＠redhat.com

Gilad Chaplik has submitted this change and it was merged. Change subject: webadmin: Cleanup in QuotaModel (#848289) ...................................................................... webadmin: Cleanup in QuotaModel (#848289) https://bugzilla.redhat.com/848289 Cleanup of literals. Change-Id: I30466414921d859cc6cffbcef2d80eb717ddcdde Signed-off-by: Ofri Masad <omasad(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/quota/QuotaModel.java 1 file changed, 9 insertions(+), 9 deletions(-) Approvals: Gilad Chaplik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/7823 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I30466414921d859cc6cffbcef2d80eb717ddcdde Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: ofri masad <omasad(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: ofri masad <omasad(a)redhat.com>

12 years, 4 months

1
0
0 / 0

Change in ovirt-engine[master]: Revert "core: fix NPE is Challenger"

by masayag＠redhat.com

Moti Asayag has submitted this change and it was merged. Change subject: Revert "core: fix NPE is Challenger" ...................................................................... Revert "core: fix NPE is Challenger" This reverts commit 01ee24bc2010252f71d47dc950835fccbeed0110. Reverted due to failed unit-tests. Signed-off-by: Moti Asayag <masayag(a)redhat.com> Change-Id: I2130b5f5af1d8d3167aa5b5246c58a4bc0773808 --- M backend/manager/modules/restapi/interface/common/jaxrs/src/main/java/org/ovirt/engine/api/common/security/auth/Challenger.java 1 file changed, 4 insertions(+), 6 deletions(-) Approvals: Moti Asayag: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/7876 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2130b5f5af1d8d3167aa5b5246c58a4bc0773808 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com> Gerrit-Reviewer: Sharad Mishra <snmishra(a)linux.vnet.ibm.com>

12 years, 4 months

1
0
0 / 0

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

Engine-commits September 2012