September 2012 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: core: fix NPE is Challenger
by yzaslavs＠redhat.com 09 Sep '12

09 Sep '12

Yair Zaslavsky has submitted this change and it was merged. Change subject: core: fix NPE is Challenger ...................................................................... core: fix NPE is Challenger Calling executeBasicAuthentication() with null httpSession can lead to NPE. Change-Id: I545a2b0b12510b1eed11fde7fe8e4dc25696953a Signed-off-by: Sharad Mishra <snmishra(a)linux.vnet.ibm.com> --- M backend/manager/modules/restapi/interface/common/jaxrs/src/main/java/org/ovirt/engine/api/common/security/auth/Challenger.java 1 file changed, 6 insertions(+), 4 deletions(-) Approvals: Yair Zaslavsky: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/7850 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I545a2b0b12510b1eed11fde7fe8e4dc25696953a Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Sharad Mishra <snmishra(a)linux.vnet.ibm.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: formated -> formatted
by oourfali＠redhat.com 09 Sep '12

09 Sep '12

Oved Ourfali has submitted this change and it was merged. Change subject: core: formated -> formatted ...................................................................... core: formated -> formatted Spelling correction in message. Change-Id: I4d02a9650a3e79e12f2d7f18fb81c0f22ef53eed Signed-off-by: Sharad Mishra <snmishra(a)linux.vnet.ibm.com> --- M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties 4 files changed, 4 insertions(+), 4 deletions(-) Approvals: Oved Ourfali: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/7775 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4d02a9650a3e79e12f2d7f18fb81c0f22ef53eed Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Sharad Mishra <snmishra(a)linux.vnet.ibm.com> Gerrit-Reviewer: Laszlo Hornyak <lhornyak(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Sharad Mishra <snmishra(a)linux.vnet.ibm.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: fix corner case of random number (Long.MIN_VALUE) in R...
by yzaslavs＠redhat.com 08 Sep '12

08 Sep '12

Yair Zaslavsky has submitted this change and it was merged. Change subject: core: fix corner case of random number (Long.MIN_VALUE) in RandomUtils. ...................................................................... core: fix corner case of random number (Long.MIN_VALUE) in RandomUtils. This code generates a random signed long and then computes the absolute value of that random long. If the number returned by the random number generator is Long.MIN_VALUE, then the result will be negative as well (since Math.abs(Long.MIN_VALUE) == Long.MIN_VALUE). Change-Id: Ic6fd4d0304c3ffa382fe20afa1a8d41f93a47bed Signed-off-by: Sharad Mishra <snmishra(a)linux.vnet.ibm.com> --- M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/RandomUtils.java 1 file changed, 5 insertions(+), 1 deletion(-) Approvals: Yair Zaslavsky: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/7851 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic6fd4d0304c3ffa382fe20afa1a8d41f93a47bed Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Sharad Mishra <snmishra(a)linux.vnet.ibm.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Added final to member variables.
by yzaslavs＠redhat.com 08 Sep '12

08 Sep '12

Yair Zaslavsky has submitted this change and it was merged. Change subject: core: Added final to member variables. ...................................................................... core: Added final to member variables. These varibles should only be initialized from within the constructor. Change-Id: Ibb4ac2d69adc7bab06c3bea3d8bc71c763ed14d5 Signed-off-by: Sharad Mishra <snmishra(a)linux.vnet.ibm.com> --- M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/CLIParser.java 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Yair Zaslavsky: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/7189 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ibb4ac2d69adc7bab06c3bea3d8bc71c763ed14d5 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Sharad Mishra <snmishra(a)linux.vnet.ibm.com> Gerrit-Reviewer: Michael Kublin <mkublin(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Sharad Mishra <snmishra(a)linux.vnet.ibm.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: packaging: Updated allinone plugin for new security mode
by juan.hernandez＠redhat.com 07 Sep '12

07 Sep '12

Juan Hernandez has submitted this change and it was merged. Change subject: packaging: Updated allinone plugin for new security mode ...................................................................... packaging: Updated allinone plugin for new security mode Change-Id: I0cec49b25fedba3994b84571e8a4845f3d0da536 Signed-off-by: Alex Lourie <alourie(a)redhat.com> --- M packaging/fedora/setup/plugins/all_in_one_100.py 1 file changed, 3 insertions(+), 1 deletion(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/7719 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0cec49b25fedba3994b84571e8a4845f3d0da536 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alex Lourie <alourie(a)redhat.com> Gerrit-Reviewer: Alex Lourie <alourie(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Kiril Nesenko <knesenko(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Moran Goldboim <mgoldboi(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: packaging: moving .pgpass to a common location
by juan.hernandez＠redhat.com 07 Sep '12

07 Sep '12

Juan Hernandez has submitted this change and it was merged. Change subject: packaging: moving .pgpass to a common location ...................................................................... packaging: moving .pgpass to a common location Change-Id: I2dece89583f3066fbd7d3ccd68cdbd14d94cf12a Signed-off-by: Alex Lourie <alourie(a)redhat.com> --- M backend/manager/dbscripts/dbcustomfunctions.sh M backend/manager/dbscripts/engine-db-install.sh M packaging/fedora/setup/basedefs.py M packaging/fedora/setup/common_utils.py M packaging/fedora/setup/engine-cleanup.py M packaging/fedora/setup/engine-upgrade.py 6 files changed, 65 insertions(+), 19 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/7665 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2dece89583f3066fbd7d3ccd68cdbd14d94cf12a Gerrit-PatchSet: 9 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alex Lourie <alourie(a)redhat.com> Gerrit-Reviewer: Alex Lourie <alourie(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Barak Azulay <bazulay(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Kiril Nesenko <knesenko(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: packaging: updated storage format in AIO host creation.
by juan.hernandez＠redhat.com 07 Sep '12

07 Sep '12

Juan Hernandez has submitted this change and it was merged. Change subject: packaging: updated storage format in AIO host creation. ...................................................................... packaging: updated storage format in AIO host creation. Change-Id: I768fddbb387cc31c941c3fdcbb84b6b65ed8ed16 Signed-off-by: Alex Lourie <alourie(a)redhat.com> --- M packaging/fedora/setup/plugins/all_in_one_100.py 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/6199 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I768fddbb387cc31c941c3fdcbb84b6b65ed8ed16 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alex Lourie <alourie(a)redhat.com> Gerrit-Reviewer: Alex Lourie <alourie(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Moran Goldboim <mgoldboi(a)redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: cleanup AddBondCommand
by lhornyak＠redhat.com 07 Sep '12

07 Sep '12

Laszlo Hornyak has submitted this change and it was merged. Change subject: core: cleanup AddBondCommand ...................................................................... core: cleanup AddBondCommand - use failCanDoAction Change-Id: If6aa13e96f3361e03010b72c62b94f2ebdc8b0fb Signed-off-by: Laszlo Hornyak <lhornyak(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddBondCommand.java 1 file changed, 9 insertions(+), 18 deletions(-) Approvals: Laszlo Hornyak: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/7741 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If6aa13e96f3361e03010b72c62b94f2ebdc8b0fb Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Laszlo Hornyak <lhornyak(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Laszlo Hornyak <lhornyak(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Sharad Mishra <snmishra(a)linux.vnet.ibm.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: cleanup ActivateVdsCommand
by lhornyak＠redhat.com 07 Sep '12

07 Sep '12

Laszlo Hornyak has submitted this change and it was merged. Change subject: core: cleanup ActivateVdsCommand ...................................................................... core: cleanup ActivateVdsCommand - use failCanDoAction Change-Id: Ic7e0ec29144e8de15eacec019e2ba9d82782335e Signed-off-by: Laszlo Hornyak <lhornyak(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ActivateVdsCommand.java 1 file changed, 4 insertions(+), 7 deletions(-) Approvals: Laszlo Hornyak: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/7740 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic7e0ec29144e8de15eacec019e2ba9d82782335e Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Laszlo Hornyak <lhornyak(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Laszlo Hornyak <lhornyak(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Sharad Mishra <snmishra(a)linux.vnet.ibm.com>

1 0

Change in ovirt-engine[master]: core: cleanup RemoveStoragePoolCommand
by lhornyak＠redhat.com 07 Sep '12

07 Sep '12

Laszlo Hornyak has submitted this change and it was merged. Change subject: core: cleanup RemoveStoragePoolCommand ...................................................................... core: cleanup RemoveStoragePoolCommand - use failCanDoAction Change-Id: I7ec1ec996325c17b9fa95aaf761a605e3db6a9a2 Signed-off-by: Laszlo Hornyak <lhornyak(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/RemoveStoragePoolCommand.java 1 file changed, 4 insertions(+), 8 deletions(-) Approvals: Laszlo Hornyak: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/7739 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7ec1ec996325c17b9fa95aaf761a605e3db6a9a2 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Laszlo Hornyak <lhornyak(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Laszlo Hornyak <lhornyak(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Sharad Mishra <snmishra(a)linux.vnet.ibm.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0