Change in ovirt-engine[master]: core: Clear current SPM upon "Not SPM" error
by tnisan＠redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: core: Clear current SPM upon "Not SPM" error
......................................................................
core: Clear current SPM upon "Not SPM" error
Clear the current SPM when we get a "Not SPM" error from the
current SPM, this is needed when we have a host which is not an SPM
anymore (Cause of being fenced for instance) which still gets SPM
commands sent to it and returns "Not SPM", so instead waiting for the
next SPM status check, we immediately remove it and start spmStart process
to find an SPM host
Change-Id: I9209d35c54269a9d4db1d8daf52b56687d80a38f
Signed-off-by: Tal Nisan <tnisan(a)redhat.com>
---
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/IrsBrokerCommand.java
1 file changed, 3 insertions(+), 0 deletions(-)
Approvals:
Tal Nisan: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/7682
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I9209d35c54269a9d4db1d8daf52b56687d80a38f
Gerrit-PatchSet: 6
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
12 years, 4 months
Change in ovirt-engine[master]: webadmin: Assign quota for disk (#848310)
by gchaplik＠redhat.com
Gilad Chaplik has submitted this change and it was merged.
Change subject: webadmin: Assign quota for disk (#848310)
......................................................................
webadmin: Assign quota for disk (#848310)
https://bugzilla.redhat.com/848310
implemented the rest of the bug, added assign quota to vm & template
disk's sub tab (previously added in disk's main tab).
same logic is implemented here (the button will be shown in iff quota isn't
disalbed and in DC tree context).
Reused the Assign quota view.
Change-Id: Ieb2d52f6caf15c1e7e4b65e75657c0f62438af4b
Signed-off-by: Gilad Chaplik <gchaplik(a)redhat.com>
---
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/CommonApplicationConstants.java
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/vm/VmDiskListModelTable.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/templates/TemplateDiskListModel.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/templates/TemplateListModel.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmDiskListModel.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmListModel.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/ApplicationConstants.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/gin/uicommon/TemplateModule.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/gin/uicommon/VirtualMachineModule.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/template/SubTabTemplateDiskView.java
10 files changed, 267 insertions(+), 11 deletions(-)
Approvals:
Daniel Erez: Looks good to me, approved
Gilad Chaplik: Verified
--
To view, visit http://gerrit.ovirt.org/7681
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ieb2d52f6caf15c1e7e4b65e75657c0f62438af4b
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Gilad Chaplik <gchaplik(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com>
12 years, 4 months
Change in ovirt-engine[master]: engine: Send port mirroring when hot-plug NIC (#853709)
by msalem＠redhat.com
Muli Salem has submitted this change and it was merged.
Change subject: engine: Send port mirroring when hot-plug NIC (#853709)
......................................................................
engine: Send port mirroring when hot-plug NIC (#853709)
https://bugzilla.redhat.com/853709
Port mirroring should be sent if it is set on the NIC in case we're hot
plugging the NIC to the VM.
Change-Id: I0ba6a47b4ab42bc2a07f106e51eb9a9fe6baba7b
Signed-off-by: Mike Kolesnik <mkolesni(a)redhat.com>
Signed-off-by: Dan Kenigsberg <danken(a)redhat.com>
---
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/HotPlugNicVDSCommand.java
1 file changed, 5 insertions(+), 0 deletions(-)
Approvals:
Muli Salem: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/7672
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I0ba6a47b4ab42bc2a07f106e51eb9a9fe6baba7b
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Mike Kolesnik <mkolesni(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Meni Yakove <myakove(a)redhat.com>
Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: Muli Salem <msalem(a)redhat.com>
12 years, 4 months
Change in ovirt-engine[master]: core: Add migration start message (#744813)
by dfediuck＠redhat.com
Doron Fediuck has submitted this change and it was merged.
Change subject: core: Add migration start message (#744813)
......................................................................
core: Add migration start message (#744813)
When migration of a VM was initiated by the system as in order to carry
out a resources distribution policy, no message was presented in the
log (only completion message presented).
The massaging mechanism was fitted to internal calls.
Change-Id: I61d7ba796253ea05d7c9c41647538bc11beafc5f
Signed-off-by: Ofri Masad <omasad(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MigrateVmCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VdsLoadBalancingAlgorithm.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/AuditLogType.java
M backend/manager/modules/dal/src/main/resources/bundles/AuditLogMessages.properties
4 files changed, 16 insertions(+), 13 deletions(-)
Approvals:
Doron Fediuck: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/7694
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I61d7ba796253ea05d7c9c41647538bc11beafc5f
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: ofri masad <omasad(a)redhat.com>
Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>
Gerrit-Reviewer: ofri masad <omasad(a)redhat.com>
12 years, 4 months
Change in ovirt-engine[master]: webadmin: sort iso images list
by gchaplik＠redhat.com
Gilad Chaplik has submitted this change and it was merged.
Change subject: webadmin: sort iso images list
......................................................................
webadmin: sort iso images list
List in Storage / (select iso domain) / Images subtab is
not sorted by name
Change-Id: I9eab5186b92efcf8d49d788b4bff59794dc1560e
Signed-off-by: Gilad Chaplik <gchaplik(a)redhat.com>
---
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/StorageIsoListModel.java
1 file changed, 23 insertions(+), 12 deletions(-)
Approvals:
Gilad Chaplik: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/7633
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I9eab5186b92efcf8d49d788b4bff59794dc1560e
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Gilad Chaplik <gchaplik(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com>
Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com>
12 years, 4 months
Change in ovirt-engine[master]: core: avoid NPE in rollback quota (#846777)
by gchaplik＠redhat.com
Gilad Chaplik has submitted this change and it was merged.
Change subject: core: avoid NPE in rollback quota (#846777)
......................................................................
core: avoid NPE in rollback quota (#846777)
https://bugzilla.redhat.com/846777
Ensuring rollback quota succeeds and doesn't interrupt the
normal flow of command ending. this solution of try/catch should be revisited
because it may hide errors in quota mechanism.
Change-Id: I688ef23e96c94e34852c02682d0bca243718cdbb
Signed-off-by: Gilad Chaplik <gchaplik(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandBase.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveVmTemplateCommand.java
2 files changed, 17 insertions(+), 7 deletions(-)
Approvals:
Gilad Chaplik: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/7632
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I688ef23e96c94e34852c02682d0bca243718cdbb
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Gilad Chaplik <gchaplik(a)redhat.com>
Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-Reviewer: ofri masad <omasad(a)redhat.com>
12 years, 4 months
Change in ovirt-engine[master]: restapi: making gluster enums lower case in request/response
by oliel＠redhat.com
Ori Liel has submitted this change and it was merged.
Change subject: restapi: making gluster enums lower case in request/response
......................................................................
restapi: making gluster enums lower case in request/response
All the gluster related enums will be converted to lower cases
in request and response. In case of POST request in glusterVolumes
the user can give it in either lower or upper cases.
New mapper methods are added to convert the Gluster enums.
Change-Id: I1aeec51d82ad650b9e1364295e6794e0b0861618
Signed-off-by: Kanagaraj M <kmayilsa(a)redhat.com>
---
M backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/model/AccessProtocol.java
M backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/model/GlusterState.java
M backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/model/GlusterVolumeType.java
M backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/model/TransportType.java
M backend/manager/modules/restapi/interface/definition/src/main/resources/api.xsd
M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/gluster/BackendGlusterVolumesResource.java
M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/gluster/BackendGlusterVolumeResourceTest.java
M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/gluster/BackendGlusterVolumesResourceTest.java
M backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/GlusterBrickMapper.java
M backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/GlusterVolumeMapper.java
M backend/manager/modules/restapi/types/src/test/java/org/ovirt/engine/api/restapi/types/GlusterBrickMapperTest.java
M backend/manager/modules/restapi/types/src/test/java/org/ovirt/engine/api/restapi/types/GlusterVolumeMapperTest.java
12 files changed, 209 insertions(+), 39 deletions(-)
Approvals:
Ori Liel: Looks good to me, approved
Kanagaraj M: Verified
--
To view, visit http://gerrit.ovirt.org/6093
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I1aeec51d82ad650b9e1364295e6794e0b0861618
Gerrit-PatchSet: 9
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Kanagaraj M <kmayilsa(a)redhat.com>
Gerrit-Reviewer: Kanagaraj M <kmayilsa(a)redhat.com>
Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>
Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com>
Gerrit-Reviewer: Shireesh Anjal <sanjal(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
12 years, 4 months
Change in ovirt-engine[master]: core: Rename Methods in ActivateDeactivateVmNicCommand (#850...
by msalem＠redhat.com
Muli Salem has submitted this change and it was merged.
Change subject: core: Rename Methods in ActivateDeactivateVmNicCommand (#850854)
......................................................................
core: Rename Methods in ActivateDeactivateVmNicCommand (#850854)
https://bugzilla.redhat.com/850854
This patch changes the method names:
isActivateDeactivateAllowedForVmStatus to activateDeactivateVmNicAllowed
isHotPlugNicAllowedForVmStatus to hotPlugVmNicRequired
It also moves the latter method from VmHandler to the
command itself, since it is only needed there.
Change-Id: I02e005bb6c3448d8114f96b2b6cc3ab4967eed25
Signed-off-by: Muli Salem <msalem(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ActivateDeactivateVmNicCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmHandler.java
2 files changed, 8 insertions(+), 14 deletions(-)
Approvals:
Muli Salem: Verified; Looks good to me, approved
Moti Asayag: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/7685
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I02e005bb6c3448d8114f96b2b6cc3ab4967eed25
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Muli Salem <msalem(a)redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: Muli Salem <msalem(a)redhat.com>
12 years, 4 months
Change in ovirt-engine[master]: userportal: createRequestToken should use getHashName (#8507...
by derez＠redhat.com
Daniel Erez has submitted this change and it was merged.
Change subject: userportal: createRequestToken should use getHashName (#850749)
......................................................................
userportal: createRequestToken should use getHashName (#850749)
https://bugzilla.redhat.com/850749
* AbstractSideTabWithDetailsPresenter -> createRequestToken:
subTabName should be composed of the HashName and not the Title
(i.e. as in the WebAdmin).
Getting the tab's name by its title:
- is wrong due to translation issues (HashName is not translated).
- caused a problem in Templates-Disks sub-tab revealing
after changing 'Virtual Disks' to 'Disks'.
* Renaming HashName from 'virtual_disks' to 'disks' just to
keep on consistency.
Change-Id: I769538944b014ddd69a37ed4c151b607d6266ca1
Signed-off-by: Daniel Erez <derez(a)redhat.com>
---
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/pools/PoolDiskListModel.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/templates/TemplateDiskListModel.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmDiskListModel.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmMonitorModel.java
M frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/place/ApplicationPlaces.java
M frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/section/main/presenter/AbstractSideTabWithDetailsPresenter.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/place/ApplicationPlaces.java
7 files changed, 9 insertions(+), 8 deletions(-)
Approvals:
Daniel Erez: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/7687
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I769538944b014ddd69a37ed4c151b607d6266ca1
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com>
12 years, 4 months
Change in ovirt-engine[master]: packaging, tools: Use JVM selected during setup (#834436)
by juan.hernandez＠redhat.com
Juan Hernandez has submitted this change and it was merged.
Change subject: packaging, tools: Use JVM selected during setup (#834436)
......................................................................
packaging, tools: Use JVM selected during setup (#834436)
https://bugzilla.redhat.com/834436
This patch moves the scripts of the tools and the notifier to the
/usr/share/ovirt-engine/bin directory and adds there a prolog that is
included by all these scripts. This prolog contains the functions that
load the configuration generated by the setup tool so that the scripts
will use the JVM selected during installation.
Change-Id: I501e5e5cca615f5bfffef225d9ebb3204f16b7c5
Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com>
---
M Makefile
M backend/manager/conf/kerberos/engine-manage-domains
M backend/manager/modules/utils/src/main/resources/engine-manage-domains.conf
M backend/manager/tools/engine-config/src/main/resources/engine-config
M backend/manager/tools/engine-notifier/engine-notifier-resources/src/main/resources/engine-notifierd
M backend/manager/tools/engine-notifier/engine-notifier-resources/src/main/resources/notifier.sh
A backend/manager/tools/engine-tools-common/src/main/shell/engine-prolog.sh
M packaging/fedora/setup/basedefs.py
M packaging/fedora/spec/ovirt-engine.spec.in
9 files changed, 66 insertions(+), 53 deletions(-)
Approvals:
Juan Hernandez: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/7556
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I501e5e5cca615f5bfffef225d9ebb3204f16b7c5
Gerrit-PatchSet: 9
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Alex Lourie <alourie(a)redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Moran Goldboim <mgoldboi(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
12 years, 4 months