Change in ovirt-engine[master]: engine: Fix message-id typo (#852076)
by masayag＠redhat.com
Moti Asayag has submitted this change and it was merged.
Change subject: engine: Fix message-id typo (#852076)
......................................................................
engine: Fix message-id typo (#852076)
https://bugzilla.redhat.com/852076
The patch modifies a typo in message-id:
NETWROK --> NETWORK
Change-Id: I3958fa20f12f5b9e5edbe382505946d819b66d1f
Signed-off-by: Moti Asayag <masayag(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddBondCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AttachNetworkToVdsGroupCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AttachNetworkToVdsInterfaceCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/DetachNetworkFromVdsInterfaceCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateNetworkToVdsInterfaceCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/AddNetworkCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/UpdateNetworkCommand.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/AttachNetworkToVdsGroupCommandTest.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/AddBondParameters.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/AttachNetworkToVdsParameters.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/Network.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VdsNetworkInterface.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/validation/NetworkInterfaceValidator.java
M backend/manager/modules/common/src/test/java/org/ovirt/engine/core/common/utils/IPAddressPatternTest.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/VdcBllMessages.java
M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties
M backend/manager/modules/utils/src/test/resources/AppErrors.properties
M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java
M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties
M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties
20 files changed, 121 insertions(+), 121 deletions(-)
Approvals:
Moti Asayag: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/7650
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I3958fa20f12f5b9e5edbe382505946d819b66d1f
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: Livnat Peer <lpeer(a)redhat.com>
Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: Muli Salem <msalem(a)redhat.com>
11 years, 7 months
Change in ovirt-engine[master]: core: Add validation for IP Addresses (#852076)
by masayag＠redhat.com
Moti Asayag has submitted this change and it was merged.
Change subject: core: Add validation for IP Addresses (#852076)
......................................................................
core: Add validation for IP Addresses (#852076)
https://bugzilla.redhat.com/852076
Any IP address being sent from the clients to the engine is being
verifies to its correct format. Clients are allowed to pass empty string
or null values or a valid IP address.
Change-Id: I883deb575455c0cc2d0b7d45619a007421766df7
Signed-off-by: Moti Asayag <masayag(a)redhat.com>
---
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/AddBondParameters.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/AddNetworkStoragePoolParameters.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/AttachNetworkToVdsGroupParameter.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/AttachNetworkToVdsParameters.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/UpdateNetworkToVdsParameters.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/Network.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VdsNetworkInterface.java
7 files changed, 51 insertions(+), 6 deletions(-)
Approvals:
Moti Asayag: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/7636
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I883deb575455c0cc2d0b7d45619a007421766df7
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: Livnat Peer <lpeer(a)redhat.com>
Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: Muli Salem <msalem(a)redhat.com>
11 years, 7 months
Change in ovirt-engine[master]: webadmin: "Power management" confirmation fix (#848133)
by achub＠redhat.com
Alexey Chub has submitted this change and it was merged.
Change subject: webadmin: "Power management" confirmation fix (#848133)
......................................................................
webadmin: "Power management" confirmation fix (#848133)
Change-Id: I7636e84ffc66ae6fda3d3bc5f5c48d9e1449da6a
Signed-off-by: Alexey Chub <achub(a)redhat.com>
---
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/clusters/ClusterGuideModel.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/datacenters/DataCenterGuideModel.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostListModel.java
M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/Constants.java
4 files changed, 27 insertions(+), 20 deletions(-)
Approvals:
Alexey Chub: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/7670
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I7636e84ffc66ae6fda3d3bc5f5c48d9e1449da6a
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alexey Chub <achub(a)redhat.com>
Gerrit-Reviewer: Alexey Chub <achub(a)redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com>
11 years, 7 months
Change in ovirt-engine[master]: core: RemoveImageDisk - race when updating snapshots ovf (#8...
by mlipchuk＠redhat.com
Maor Lipchuk has submitted this change and it was merged.
Change subject: core: RemoveImageDisk - race when updating snapshots ovf (#828192)
......................................................................
core: RemoveImageDisk - race when updating snapshots ovf (#828192)
https://bugzilla.redhat.com/show_bug.cgi?id=828192
When removing an image disk it should be removed from all the snapshots
that contain it. The removal from the vm snapshots includes an
update to the snapshot ovf (saved in the DB). The update is a
read-update-write operation, so when two or more disks are removed from
the same snapshot a race condition might occur.
This patch adds a lock on the snapshot when performing the operations on
the snapshot ovf to prevent the race condition.
Change-Id: Iccb44f1aa9d204477955343167133849a4146753
Signed-off-by: Liron Aravot <laravot(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveImageCommand.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/locks/LockingGroup.java
2 files changed, 80 insertions(+), 36 deletions(-)
Approvals:
Maor Lipchuk: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/7482
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Iccb44f1aa9d204477955343167133849a4146753
Gerrit-PatchSet: 22
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Liron Aravot <laravot(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Daniel Paikov <paikov(a)gmail.com>
Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Michael Kublin <mkublin(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
11 years, 7 months
Change in ovirt-reports[master]: reports: set max to bars width (#850012)
by ydary＠redhat.com
Yaniv Dary has submitted this change and it was merged.
Change subject: reports: set max to bars width (#850012)
......................................................................
reports: set max to bars width (#850012)
https://bugzilla.redhat.com/850012
Change-Id: If0c045570fcfbba11dffc18fd60db153d5169db2
Signed-off-by: Yaniv Dary <ydary(a)redhat.com>
---
M reports/jars/ChartsCustomizers/src/main/java/com/ovirt/reports/jasper/DrBarChartCustomizer.java
A reports/jars/ChartsCustomizers/src/main/java/com/ovirt/reports/jasper/DrStackedBarChartCustomizer.java
M reports/repository_files/resources/reports_resources/embedded_reports/webadmin_dashboards/cluster_dashboard/no_used/top_five_ha_virtual_servers_uptime_dr19_files/top_five_ha_virtual_servers_uptime_dr19_jrxml.data
M reports/repository_files/resources/reports_resources/embedded_reports/webadmin_dashboards/cluster_dashboard/no_used/top_five_hosts_uptime_dr17_files/top_five_hosts_uptime_dr17_jrxml.data
M reports/repository_files/resources/reports_resources/embedded_reports/webadmin_dashboards/cluster_dashboard/top_five_ha_virtual_servers_downtime_dr20_files/top_five_ha_virtual_servers_downtime_dr20_jrxml.data
M reports/repository_files/resources/reports_resources/embedded_reports/webadmin_dashboards/cluster_dashboard/top_five_hosts_downtime_dr18_files/top_five_hosts_downtime_dr18_jrxml.data
M reports/repository_files/resources/reports_resources/embedded_reports/webadmin_dashboards/dc_dashboard/not_used/top_five_clusters_host_uptime_dr15_files/top_five_clusters_host_uptime_dr15_jrxml.data
M reports/repository_files/resources/reports_resources/embedded_reports/webadmin_dashboards/dc_dashboard/top_five_clusters_host_downtime_dr16_files/top_five_clusters_host_downtime_dr16_jrxml.data
M reports/repository_files/resources/reports_resources/webadmin_dashboards/ce/cluster_dashboard_files/top_five_ha_virtual_servers_downtime_dr20_jrxml.data
M reports/repository_files/resources/reports_resources/webadmin_dashboards/ce/cluster_dashboard_files/top_five_hosts_downtime_dr18_jrxml.data
M reports/repository_files/resources/reports_resources/webadmin_dashboards/ce/datacenter_dashboard_files/top_five_clusters_host_downtime_dr16_jrxml.data
M reports/repository_files/resources/reports_resources/webadmin_dashboards/ce/datacenter_dashboard_files/top_five_clusters_host_uptime_dr15_jrxml.data
12 files changed, 76 insertions(+), 10 deletions(-)
Approvals:
Yaniv Dary: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/7675
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: If0c045570fcfbba11dffc18fd60db153d5169db2
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-reports
Gerrit-Branch: master
Gerrit-Owner: Yaniv Dary <ydary(a)redhat.com>
Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com>
11 years, 7 months
Change in ovirt-engine[master]: core: Host can not be restarted by ...(#852464)
by emesika＠redhat.com
Eli Mesika has submitted this change and it was merged.
Change subject: core: Host can not be restarted by ...(#852464)
......................................................................
core: Host can not be restarted by ...(#852464)
Host can not be restarted by Power Management if not in maintenance status
https://bugzilla.redhat.com/show_bug.cgi?id=852464
Adding a condition to StopVdsCommand canDoAction to perform the Host
status check only if Stop was activated as a single command and not as
part of the Restart implementation which is Stop->Wait for
Status to be off->Start->Wait for Status to be on
Change-Id: I19a0bf8ace353047274290f309fd0468d6e9c8b7
Signed-off-by: Eli Mesika <emesika(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/StopVdsCommand.java
1 file changed, 7 insertions(+), 4 deletions(-)
Approvals:
Eli Mesika: Verified; Looks good to me, approved
Omer Frenkel: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/7559
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I19a0bf8ace353047274290f309fd0468d6e9c8b7
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
11 years, 7 months
Change in ovirt-engine[master]: webadmin: [SetupNetworks] detach unmanaged net causes NPE (#...
by alkaplan＠redhat.com
Alona Kaplan has submitted this change and it was merged.
Change subject: webadmin: [SetupNetworks] detach unmanaged net causes NPE (#848354)
......................................................................
webadmin: [SetupNetworks] detach unmanaged net causes NPE (#848354)
https://bugzilla.redhat.com/848354
Fixing bug 848354- caused NPE when detching unmanaged network.
The fix was- that when detaching unsync network the is_vm, vlan-id,
and mtu parameters should be set to the values defined in the dc
logical network level. The problem is that unmanaged network also
marked as unsync. And on detach it just have to be deleted, no need
to set the dc parameters.
Change-Id: Ic63105d7e352845d795fd99f4099c812723bca6e
Signed-off-by: Alona Kaplan <alkaplan(a)redhat.com>
---
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/network/LogicalNetworkModel.java
1 file changed, 7 insertions(+), 4 deletions(-)
Approvals:
Alona Kaplan: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/7669
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ic63105d7e352845d795fd99f4099c812723bca6e
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alona Kaplan <alkaplan(a)redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com>
11 years, 7 months
Change in ovirt-engine[master]: core: Don't erroneously remove template->storage mappings
by mlipchuk＠redhat.com
Maor Lipchuk has submitted this change and it was merged.
Change subject: core: Don't erroneously remove template->storage mappings
......................................................................
core: Don't erroneously remove template->storage mappings
If a storage domain is force removed and a template has a disk on that
SD, the image is removed regardless of whether that image also resides
on other SDs. In the case where the template disk has been copied, the
template and images should remain intact and only the references for the
specific SD being removed should be deleted.
Change-Id: I058d160622990d2b42ccc02a61551c6f61550ade
Signed-off-by: Greg Padgett <gpadgett(a)redhat.com>
---
M backend/manager/dbscripts/storages_sp.sql
1 file changed, 9 insertions(+), 3 deletions(-)
Approvals:
Maor Lipchuk: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/7192
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I058d160622990d2b42ccc02a61551c6f61550ade
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Greg Padgett <gpadgett(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Greg Padgett <gpadgett(a)redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
11 years, 7 months
Change in ovirt-engine[master]: core: Change Error Message in DetachNetwork (#842748)
by msalem＠redhat.com
Muli Salem has submitted this change and it was merged.
Change subject: core: Change Error Message in DetachNetwork (#842748)
......................................................................
core: Change Error Message in DetachNetwork (#842748)
https://bugzilla.redhat.com/842748
Please refer to subject.
Change-Id: Id0332467769237c7fd4e4bbf3b52e05919978351
Signed-off-by: Muli Salem <msalem(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/DetachNetworkFromVdsInterfaceCommand.java
M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties
M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java
M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties
M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties
5 files changed, 5 insertions(+), 5 deletions(-)
Approvals:
Muli Salem: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/7666
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Id0332467769237c7fd4e4bbf3b52e05919978351
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Muli Salem <msalem(a)redhat.com>
Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com>
Gerrit-Reviewer: Muli Salem <msalem(a)redhat.com>
11 years, 7 months
Change in ovirt-engine[master]: engine: ManageDomainsResult prints null when setConfigValue ...
by oourfali＠redhat.com
Oved Ourfali has submitted this change and it was merged.
Change subject: engine: ManageDomainsResult prints null when setConfigValue fails (#851069)
......................................................................
engine: ManageDomainsResult prints null when setConfigValue fails
(#851069)
When deleting domain we get wrong error messages. This fix it:
1. In ConfigurationProvider we throw ManageDomainsResult with list
of strings instead initializing it with the entry, and the error
has two sperate arguments. This results in printing a default
message instead of the real one.
2. ManageDomainsResult didn't override getMessage method.
3. The output for ManageDomainsResult with no default message was
changed to include also enumResult message.
Change-Id: If5b7abde0edb700f42563f06160cd7278848ad0e
Signed-off-by: Yaniv Bronhaim <ybronhei(a)redhat.com>
---
M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/kerberos/ConfigurationProvider.java
M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/kerberos/ManageDomainsResult.java
2 files changed, 15 insertions(+), 9 deletions(-)
Approvals:
Oved Ourfali: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/7627
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: If5b7abde0edb700f42563f06160cd7278848ad0e
Gerrit-PatchSet: 6
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
11 years, 7 months