Change in ovirt-engine[master]: webadmin: i18n validation in import vm/temp
by gchaplik＠redhat.com
Gilad Chaplik has submitted this change and it was merged.
Change subject: webadmin: i18n validation in import vm/temp
......................................................................
webadmin: i18n validation in import vm/temp
Instead of very limited name validation
Change-Id: I5640c943f2f5144e851dfd7660093b083ccc8530
Signed-off-by: Gilad Chaplik <gchaplik(a)redhat.com>
---
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/TemplateBackupModel.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/VmBackupModel.java
M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/Messages.java
3 files changed, 26 insertions(+), 30 deletions(-)
Approvals:
Gilad Chaplik: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/11150
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I5640c943f2f5144e851dfd7660093b083ccc8530
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Gilad Chaplik <gchaplik(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>
11 years, 3 months
Change in ovirt-engine[master]: core : fix template import message
by tnisan＠redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: core : fix template import message
......................................................................
core : fix template import message
assignment was missing
Change-Id: Iedfbcb4da2ab32b4151825780c1e1a09f59ce2cc
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=902872
Signed-off-by: Liron Aravot <laravot(a)redhat.com>
---
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/TemplateBackupModel.java
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Tal Nisan: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/11456
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Iedfbcb4da2ab32b4151825780c1e1a09f59ce2cc
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Liron Aravot <laravot(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
11 years, 3 months
Change in ovirt-engine[master]: host-deploy: utilize engine correlation id
by yzaslavs＠redhat.com
Yair Zaslavsky has submitted this change and it was merged.
Change subject: host-deploy: utilize engine correlation id
......................................................................
host-deploy: utilize engine correlation id
1. Apply correlation id to events.
2. Add correlation id to deploy log file name.
3. Add correlation id eye catcher to otopi environment, it is ignored by
otopi and ovirt-host-deploy, but usable for debugging.
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=902949
Change-Id: I5dba5b6d1319f0b4caa6f0d3e77683a098df31e5
Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/InstallVdsCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/InstallerMessages.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/OVirtNodeUpgrade.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VdsDeploy.java
4 files changed, 28 insertions(+), 2 deletions(-)
Approvals:
Yair Zaslavsky: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/11287
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I5dba5b6d1319f0b4caa6f0d3e77683a098df31e5
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>
11 years, 3 months
Change in ovirt-engine[master]: core:DB upgrade from 3.0 to 3.1 fails
by emesika＠redhat.com
Eli Mesika has submitted this change and it was merged.
Change subject: core:DB upgrade from 3.0 to 3.1 fails
......................................................................
core:DB upgrade from 3.0 to 3.1 fails
Fixing the general functions that creates/drops constraint to be
case-insensitive since entity names are case-insensitive in postgres
while values are case-sensitive.
Since the 03_01_1520_add_fk_vm_interface_vm_static_template.sql tries to
insert a new constraint named FK_vm_interface_vm_static_template while
in the database there was already a fk_vm_interface_vm_static_template
constraint install, there was an attempt to install this FK again which
failed.
The solution turns the '=' operation to 'ilike' when we look for an
existing constraint by its name.
Change-Id: Id36c83154559d6062609d08068989d3ce3d2c468
Signed-off-by: Eli Mesika <emesika(a)redhat.com>
Bug-Url:https://bugzilla.redhat.com/show_bug.cgi?id=892532
---
M backend/manager/dbscripts/common_sp.sql
1 file changed, 2 insertions(+), 2 deletions(-)
Approvals:
Eli Mesika: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/11419
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Id36c83154559d6062609d08068989d3ce3d2c468
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>
11 years, 3 months
Change in ovirt-engine[master]: core+ui: Added 5 new events to event notifier
by gchaplik＠redhat.com
Gilad Chaplik has submitted this change and it was merged.
Change subject: core+ui: Added 5 new events to event notifier
......................................................................
core+ui: Added 5 new events to event notifier
Added new host performance events to event notifier:
- Host memory usage exceeded defined threshold
- Host network usage exceeded defined threshold
- Host cpu usage exceeded defined threshold
- Host swap memory usage exceeded defined threshold
- Host free swap memory is under defined
threshold
Change-Id: Ie6e7949cae8729c38f1cacc36e39b51b53559f13
Signed-off-by: Ofri Masad <omasad(a)redhat.com>
---
A backend/manager/dbscripts/upgrade/03_02_0370_add_vds_performance_notifications.sql
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/VdcEventNotificationUtils.java
M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/LocalizedEnums.java
M frontend/webadmin/modules/uicompat/src/main/resources/org/ovirt/engine/ui/uicompat/LocalizedEnums.properties
4 files changed, 26 insertions(+), 0 deletions(-)
Approvals:
ofri masad: Verified
Gilad Chaplik: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/10969
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ie6e7949cae8729c38f1cacc36e39b51b53559f13
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: ofri masad <omasad(a)redhat.com>
Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>
Gerrit-Reviewer: ofri masad <omasad(a)redhat.com>
11 years, 3 months
Change in ovirt-engine[master]: core: Add 5 new Events to AuditLog
by gchaplik＠redhat.com
Gilad Chaplik has submitted this change and it was merged.
Change subject: core: Add 5 new Events to AuditLog
......................................................................
core: Add 5 new Events to AuditLog
Added 5 new events to AuditLog:
- Host memory use over threshold
- Host cpu use over threshold
- Host network use over threshold
- Host free swap memory under threshold
- Host swap memory use over threshold
Change-Id: Id382c4688bdcf46f7b343ff0661893a97b5dc726
Signed-off-by: Ofri Masad <omasad(a)redhat.com>
---
M backend/manager/dbscripts/upgrade/pre_upgrade/0000_config.sql
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/AuditLogType.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/config/ConfigValues.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/auditloghandling/AuditLogDirector.java
M backend/manager/modules/dal/src/main/resources/bundles/AuditLogMessages.properties
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsUpdateRunTimeInfo.java
M backend/manager/tools/engine-config/src/main/resources/engine-config.properties
7 files changed, 150 insertions(+), 8 deletions(-)
Approvals:
ofri masad: Verified
Gilad Chaplik: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/10865
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Id382c4688bdcf46f7b343ff0661893a97b5dc726
Gerrit-PatchSet: 6
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: ofri masad <omasad(a)redhat.com>
Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>
Gerrit-Reviewer: ofri masad <omasad(a)redhat.com>
11 years, 3 months
Change in ovirt-engine[master]: core: Streamline RestoreAllSnapshots.canDoAction
by amureini＠redhat.com
Allon Mureinik has submitted this change and it was merged.
Change subject: core: Streamline RestoreAllSnapshots.canDoAction
......................................................................
core: Streamline RestoreAllSnapshots.canDoAction
Refactored RestoreAllSnapshostsCommand's canDoAction() to use validators
and the setActionMessageParameters() to be more readable.
Change-Id: Ic06cd91e90cbe8ec10ad3e50b98c04796222e813
Signed-off-by: Allon Mureinik <amureini(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RestoreAllSnapshotsCommand.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/RestoreAllSnapshotCommandTest.java
2 files changed, 38 insertions(+), 23 deletions(-)
Approvals:
Allon Mureinik: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/11446
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ic06cd91e90cbe8ec10ad3e50b98c04796222e813
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com>
11 years, 3 months
Change in ovirt-engine-sdk-java[master]: codegen: generate action() overloads using header/url params
by mpastern＠redhat.com
Michael Pasternak has submitted this change and it was merged.
Change subject: codegen: generate action() overloads using header/url params
......................................................................
codegen: generate action() overloads using header/url params
Change-Id: I04677486b168ed0b41449889cf80e01ea6841a9c
Signed-off-by: Michael Pasternak <mpastern(a)redhat.com>
---
M ovirt-engine-sdk-java-codegen/src/main/java/org/ovirt/engine/sdk/codegen/documentation/DocsGen.java
M ovirt-engine-sdk-java-codegen/src/main/java/org/ovirt/engine/sdk/codegen/rsdl/RsdlCodegen.java
A ovirt-engine-sdk-java-codegen/src/main/java/org/ovirt/engine/sdk/codegen/templates/AbstractOverloadableTemplate.java
M ovirt-engine-sdk-java-codegen/src/main/java/org/ovirt/engine/sdk/codegen/templates/AbstractTemplate.java
M ovirt-engine-sdk-java-codegen/src/main/java/org/ovirt/engine/sdk/codegen/templates/CollectionActionMethodTemplate
M ovirt-engine-sdk-java-codegen/src/main/java/org/ovirt/engine/sdk/codegen/templates/CollectionActionMethodTemplate.java
M ovirt-engine-sdk-java-codegen/src/main/java/org/ovirt/engine/sdk/codegen/templates/CollectionTemplate
A ovirt-engine-sdk-java-codegen/src/main/java/org/ovirt/engine/sdk/codegen/templates/ExtraMethodParameterTemplate
A ovirt-engine-sdk-java-codegen/src/main/java/org/ovirt/engine/sdk/codegen/templates/ExtraMethodParameterTemplate.java
A ovirt-engine-sdk-java-codegen/src/main/java/org/ovirt/engine/sdk/codegen/templates/HeaderBuilderParameterTemplate
A ovirt-engine-sdk-java-codegen/src/main/java/org/ovirt/engine/sdk/codegen/templates/HeaderBuilderParameterTemplate.java
M ovirt-engine-sdk-java-codegen/src/main/java/org/ovirt/engine/sdk/codegen/templates/ListMethodTemplate.java
M ovirt-engine-sdk-java-codegen/src/main/java/org/ovirt/engine/sdk/codegen/templates/ResourceActionMethodTemplate
M ovirt-engine-sdk-java-codegen/src/main/java/org/ovirt/engine/sdk/codegen/templates/ResourceActionMethodTemplate.java
M ovirt-engine-sdk-java-codegen/src/main/java/org/ovirt/engine/sdk/codegen/templates/ResourceTemplate
M ovirt-engine-sdk-java-codegen/src/main/java/org/ovirt/engine/sdk/codegen/templates/SubCollectionTemplate
M ovirt-engine-sdk-java-codegen/src/main/java/org/ovirt/engine/sdk/codegen/templates/SubResourceTemplate
A ovirt-engine-sdk-java-codegen/src/main/java/org/ovirt/engine/sdk/codegen/templates/UrlBuilderParameterTemplate
A ovirt-engine-sdk-java-codegen/src/main/java/org/ovirt/engine/sdk/codegen/templates/UrlBuilderParameterTemplate.java
M ovirt-engine-sdk-java-codegen/src/main/java/org/ovirt/engine/sdk/codegen/utils/FileUtils.java
A ovirt-engine-sdk-java-codegen/src/main/java/org/ovirt/engine/sdk/codegen/utils/FormatUtils.java
M ovirt-engine-sdk-java-codegen/src/main/java/org/ovirt/engine/sdk/codegen/utils/StringTemplateWrapper.java
M ovirt-engine-sdk-java-codegen/src/main/java/org/ovirt/engine/sdk/codegen/utils/StringUtils.java
A ovirt-engine-sdk-java-codegen/src/main/java/org/ovirt/engine/sdk/codegen/utils/TypeUtils.java
A ovirt-engine-sdk-java-codegen/src/main/java/org/ovirt/engine/sdk/codegen/utils/UrlUtils.java
M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/Cluster.java
M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/ClusterGlusterVolume.java
M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/ClusterGlusterVolumeGlusterBrick.java
M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/ClusterGlusterVolumeGlusterBricks.java
M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/ClusterGlusterVolumes.java
M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/ClusterNetwork.java
M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/ClusterNetworks.java
M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/ClusterPermission.java
M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/ClusterPermissions.java
M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/Clusters.java
M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/DataCenter.java
M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/DataCenterPermission.java
M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/DataCenterPermissions.java
M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/DataCenterQuota.java
M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/DataCenterQuotas.java
M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/DataCenterStorageDomain.java
M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/DataCenterStorageDomains.java
M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/DataCenters.java
M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/Disk.java
M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/DiskPermission.java
M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/DiskPermissions.java
M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/DiskStatistic.java
M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/DiskStatistics.java
M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/Disks.java
M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/Domain.java
M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/DomainGroup.java
M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/DomainGroups.java
M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/DomainUser.java
M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/DomainUsers.java
M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/Domains.java
M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/Event.java
M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/Events.java
M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/Group.java
M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/GroupPermission.java
M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/GroupPermissions.java
M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/GroupRole.java
M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/GroupRolePermit.java
M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/GroupRolePermits.java
M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/GroupRoles.java
M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/GroupTag.java
M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/GroupTags.java
M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/Groups.java
M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/Host.java
M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/HostHook.java
M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/HostHooks.java
M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/HostNIC.java
M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/HostNICStatistic.java
M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/HostNICStatistics.java
M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/HostNICs.java
M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/HostPermission.java
M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/HostPermissions.java
M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/HostStatistic.java
M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/HostStatistics.java
M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/HostTag.java
M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/HostTags.java
M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/Hosts.java
M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/Network.java
M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/NetworkPermission.java
M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/NetworkPermissions.java
M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/Networks.java
M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/Role.java
M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/RolePermit.java
M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/RolePermits.java
M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/Roles.java
M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/StorageDomain.java
M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/StorageDomainFile.java
M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/StorageDomainFiles.java
M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/StorageDomainPermission.java
M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/StorageDomainPermissions.java
M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/StorageDomainTemplate.java
M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/StorageDomainTemplates.java
M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/StorageDomainVM.java
M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/StorageDomainVMs.java
M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/StorageDomains.java
M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/Tag.java
M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/Tags.java
M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/Template.java
M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/TemplateCdRom.java
M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/TemplateCdRoms.java
M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/TemplateDisk.java
M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/TemplateDisks.java
M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/TemplateNIC.java
M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/TemplateNICs.java
M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/TemplatePermission.java
M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/TemplatePermissions.java
M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/Templates.java
M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/User.java
M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/UserPermission.java
M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/UserPermissions.java
M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/UserRole.java
M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/UserRolePermit.java
M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/UserRolePermits.java
M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/UserRoles.java
M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/UserTag.java
M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/UserTags.java
M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/Users.java
M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/VM.java
M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/VMCdRom.java
M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/VMCdRoms.java
M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/VMDisk.java
M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/VMDiskPermission.java
M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/VMDiskPermissions.java
M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/VMDiskStatistic.java
M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/VMDiskStatistics.java
M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/VMDisks.java
M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/VMNIC.java
M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/VMNICReportedDevice.java
M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/VMNICReportedDevices.java
M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/VMNICStatistic.java
M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/VMNICStatistics.java
M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/VMNICs.java
M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/VMPermission.java
M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/VMPermissions.java
M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/VMReportedDevice.java
M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/VMReportedDevices.java
M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/VMSnapshot.java
M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/VMSnapshotCdRom.java
M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/VMSnapshotCdRoms.java
M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/VMSnapshotDisk.java
M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/VMSnapshotDisks.java
M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/VMSnapshotNIC.java
M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/VMSnapshotNics.java
M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/VMSnapshots.java
M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/VMStatistic.java
M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/VMStatistics.java
M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/VMTag.java
M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/VMTags.java
M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/VMs.java
M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/VmPool.java
M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/VmPoolPermission.java
M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/VmPoolPermissions.java
M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/VmPools.java
M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/entities/ObjectFactory.java
A ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/utils/HttpHeaderBuilder.java
M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/utils/StringUtils.java
M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/utils/UrlBuilder.java
M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/web/UrlParameterType.java
162 files changed, 3,954 insertions(+), 1,306 deletions(-)
Approvals:
Michael Pasternak: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/11441
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I04677486b168ed0b41449889cf80e01ea6841a9c
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine-sdk-java
Gerrit-Branch: master
Gerrit-Owner: Michael Pasternak <mpastern(a)redhat.com>
Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com>
11 years, 3 months
Change in ovirt-engine-sdk-java[master]: codegen: implements doc support for overloads using header/u...
by mpastern＠redhat.com
Michael Pasternak has submitted this change and it was merged.
Change subject: codegen: implements doc support for overloads using header/url params
......................................................................
codegen: implements doc support for overloads using header/url params
Change-Id: I2b66cdc07bd7ececf8a2a8f0581c8bb1d04ce495
Signed-off-by: Michael Pasternak <mpastern(a)redhat.com>
---
A ovirt-engine-sdk-java-codegen/src/main/java/org/ovirt/engine/sdk/codegen/common/IDocCodegen.java
M ovirt-engine-sdk-java-codegen/src/main/java/org/ovirt/engine/sdk/codegen/documentation/DocsGen.java
M ovirt-engine-sdk-java-codegen/src/main/java/org/ovirt/engine/sdk/codegen/rsdl/RsdlCodegen.java
M ovirt-engine-sdk-java-codegen/src/main/java/org/ovirt/engine/sdk/codegen/templates/AbstractOverloadableTemplate.java
M ovirt-engine-sdk-java-codegen/src/main/java/org/ovirt/engine/sdk/codegen/templates/CollectionActionMethodTemplate.java
M ovirt-engine-sdk-java-codegen/src/main/java/org/ovirt/engine/sdk/codegen/templates/ResourceActionMethodTemplate.java
M ovirt-engine-sdk-java-codegen/src/main/java/org/ovirt/engine/sdk/codegen/utils/StringUtils.java
M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/Cluster.java
M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/ClusterGlusterVolume.java
M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/ClusterGlusterVolumeGlusterBrick.java
M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/ClusterGlusterVolumeGlusterBricks.java
M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/ClusterGlusterVolumes.java
M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/ClusterNetwork.java
M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/ClusterNetworks.java
M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/ClusterPermissions.java
M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/Clusters.java
M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/DataCenter.java
M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/DataCenterPermissions.java
M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/DataCenterQuotas.java
M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/DataCenterStorageDomain.java
M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/DataCenterStorageDomains.java
M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/DataCenters.java
M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/DiskPermissions.java
M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/Disks.java
M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/Events.java
M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/GroupPermissions.java
M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/GroupRolePermits.java
M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/GroupRoles.java
M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/GroupTags.java
M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/Groups.java
M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/Host.java
M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/HostNIC.java
M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/HostNICs.java
M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/HostPermissions.java
M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/HostTags.java
M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/Hosts.java
M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/Network.java
M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/NetworkPermissions.java
M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/Networks.java
M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/Role.java
M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/RolePermits.java
M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/Roles.java
M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/StorageDomain.java
M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/StorageDomainPermissions.java
M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/StorageDomainTemplate.java
M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/StorageDomainVM.java
M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/StorageDomains.java
M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/Tag.java
M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/Tags.java
M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/Template.java
M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/TemplateDisk.java
M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/TemplateNIC.java
M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/TemplateNICs.java
M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/TemplatePermissions.java
M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/Templates.java
M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/UserPermissions.java
M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/UserRolePermits.java
M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/UserRoles.java
M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/UserTags.java
M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/Users.java
M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/VM.java
M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/VMCdRom.java
M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/VMCdRoms.java
M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/VMDisk.java
M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/VMDiskPermissions.java
M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/VMDisks.java
M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/VMNIC.java
M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/VMNICs.java
M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/VMPermissions.java
M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/VMSnapshot.java
M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/VMSnapshots.java
M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/VMTags.java
M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/VMs.java
M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/VmPool.java
M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/VmPoolPermissions.java
M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/VmPools.java
M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/entities/ObjectFactory.java
77 files changed, 2,727 insertions(+), 2,529 deletions(-)
Approvals:
Michael Pasternak: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/11443
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I2b66cdc07bd7ececf8a2a8f0581c8bb1d04ce495
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine-sdk-java
Gerrit-Branch: master
Gerrit-Owner: Michael Pasternak <mpastern(a)redhat.com>
Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com>
11 years, 3 months
Change in ovirt-engine[master]: engine: Replacing search for vms by query
by mkolesni＠redhat.com
Mike Kolesnik has submitted this change and it was merged.
Change subject: engine: Replacing search for vms by query
......................................................................
engine: Replacing search for vms by query
The following patch will replace the search for VMs which belong to some cluster, by query from DB.
The query is much more efficient than search , and easy to understand.
The patch contains:
1. Introducing new query
2. Replace all searches by new query
3. Removed class HighAvailableVmsDirector (The following class also uses a search query, but
the class is not used anywhere, that's why I remove it instead of replacing search query)
Change-Id: I12cee2c66aed35ed357f2ee739232d95fe9fa0c1
Signed-off-by: Michael Kublin <mkublin(a)redhat.com>
---
M backend/manager/dbscripts/vms_sp.sql
D backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/HighAvailableVmsDirector.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVdsGroupCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/cluster/DetachNetworkToVdsGroupCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/host/RemoveBondCommand.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/FenceVdsBaseCommandTest.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/UpdateVdsGroupCommandTest.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/auditloghandling/AuditLogableBase.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VmDAO.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VmDAODbFacadeImpl.java
M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dal/dbbroker/auditloghandling/AuditLogableBaseTest.java
M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/VmDAOTest.java
12 files changed, 84 insertions(+), 171 deletions(-)
Approvals:
Mike Kolesnik: Looks good to me, approved
Michael Kublin: Verified
--
To view, visit http://gerrit.ovirt.org/11426
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I12cee2c66aed35ed357f2ee739232d95fe9fa0c1
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Michael Kublin <mkublin(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Michael Kublin <mkublin(a)redhat.com>
Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>
11 years, 3 months