Change in ovirt-engine[master]: core: ImportVm - avoid early run of end method
by mlipchuk＠redhat.com
Maor Lipchuk has submitted this change and it was merged.
Change subject: core: ImportVm - avoid early run of end method
......................................................................
core: ImportVm - avoid early run of end method
When creating tasks for the imported vm images, the parameters entity id
was set to the disk id - this caused that the end method of import vm
command will be called before the tasks on all disks were finished -
causing to the vm and it's disks appear as OK while there not all tasks
has finished running which can cause to hazardous issues and to the end
method to be called for each disk separately.
NOTE: ImportVmTemplate is handled in a different patch.
Change-Id: I0598698bb85c8359b981b643ee26e7cb777707b9
Signed-off-by: Liron Aravot <laravot(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImportVmCommand.java
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Maor Lipchuk: Looks good to me, approved
Liron Aravot: Verified
--
To view, visit http://gerrit.ovirt.org/11326
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I0598698bb85c8359b981b643ee26e7cb777707b9
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Liron Aravot <laravot(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>
11 years, 3 months
Change in ovirt-engine[master]: core:Create snapshot will be blocked on hibernate.
by mlipchuk＠redhat.com
Maor Lipchuk has submitted this change and it was merged.
Change subject: core:Create snapshot will be blocked on hibernate.
......................................................................
core:Create snapshot will be blocked on hibernate.
VM which is in hibernate process, will not be able to create live
snapshot.
The proposed fix is to block create snapshot process when VM is in
saving or restoring state.
Change-Id: I286ca81b157062feb6ff77a96936c0d0dba87b2a
Related-to: https://bugzilla.redhat.com/877978
Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CreateAllSnapshotsFromVmCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/VmValidator.java
2 files changed, 16 insertions(+), 6 deletions(-)
Approvals:
Maor Lipchuk: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/11267
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I286ca81b157062feb6ff77a96936c0d0dba87b2a
Gerrit-PatchSet: 7
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>
Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
11 years, 3 months
Change in ovirt-engine[master]: core: Lock VM on hibernate process.
by mlipchuk＠redhat.com
Maor Lipchuk has submitted this change and it was merged.
Change subject: core: Lock VM on hibernate process.
......................................................................
core: Lock VM on hibernate process.
Race between live snapshot and VM hibernate,
cause results which might be undefined.
The proposed fix is adding hibernateVM lock on the VM to avoid this
behaviour.
Change-Id: I3d35780a00a66fc0cc8708af2bc4cb6d292446f0
Related-to: https://bugzilla.redhat.com/877978
Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/HibernateVmCommand.java
1 file changed, 15 insertions(+), 5 deletions(-)
Approvals:
Maor Lipchuk: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/11232
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I3d35780a00a66fc0cc8708af2bc4cb6d292446f0
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>
Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com>
11 years, 3 months
Change in ovirt-engine[master]: engine: different log message for graceful shutdown
by dfediuck＠redhat.com
Doron Fediuck has submitted this change and it was merged.
Change subject: engine: different log message for graceful shutdown
......................................................................
engine: different log message for graceful shutdown
Modifies the notifier service to write a different logmessage if the
engine service was shut down by administrator by checking if the pid
file exists. If the pid file exists, the engine crashed, the proper
shutdown script removes the pid file. The availability of the engine
will be logged in any way, the logic only decides the message and the
level.
Change-Id: I409f335fd98959aab4bc1633191a853777b050fa
Signed-off-by: Laszlo Hornyak <lhornyak(a)redhat.com>
---
M backend/manager/tools/engine-notifier/engine-notifier-service/src/main/java/org/ovirt/engine/core/notifier/EngineMonitorService.java
M backend/manager/tools/engine-notifier/engine-notifier-service/src/main/java/org/ovirt/engine/core/notifier/utils/NotificationProperties.java
2 files changed, 34 insertions(+), 8 deletions(-)
Approvals:
Doron Fediuck: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/10875
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I409f335fd98959aab4bc1633191a853777b050fa
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Laszlo Hornyak <lhornyak(a)redhat.com>
Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com>
Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com>
Gerrit-Reviewer: Laszlo Hornyak <lhornyak(a)redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>
11 years, 3 months
Change in ovirt-host-deploy[master]: core: support separate execution directory in development mo...
by Alon Bar-Lev
Alon Bar-Lev has submitted this change and it was merged.
Change subject: core: support separate execution directory in development mode
......................................................................
core: support separate execution directory in development mode
Change-Id: Ieaf26cfc08f9689f9ca0208269c30f632350eb4a
Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com>
---
M src/bin/ovirt-host-deploy.in
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Alon Bar-Lev: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/11318
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ieaf26cfc08f9689f9ca0208269c30f632350eb4a
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-host-deploy
Gerrit-Branch: master
Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>
11 years, 3 months
Change in ovirt-engine[master]: core: improve logging
by amureini＠redhat.com
Allon Mureinik has submitted this change and it was merged.
Change subject: core: improve logging
......................................................................
core: improve logging
This patch introduces several logging improvements, mostly around
backend classes initialized on system startup.
1. Remove new Date() from logging statements - the timestamp is already
part of the log on each line, no need to write it twice
2. Wherever there are no parameters in log statement, just a string, call to log.info
instead of infoFormat which performs several unneeded expensive transformations on
strings.
3. Move initialization log statements to the classes which are
initialized, instead of putting them in the calling class.
4. Make the log statements more clear - instead of just mentioning
hardcoded name of class in the log, specify whether this is start/end of its
initialization so whoever reads the log can understand at which phase
the system is or at which point it failed/stuck.
5. Make logged class name extracted generically instead of hardcoding it
Change-Id: Iaea9c16e9913cdee4eef88de920e87bde8bc6b5d
Signed-off-by: Alissa Bonas <abonas(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AsyncTaskManager.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AuditLogCleanupManager.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AutoRecoveryManager.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/Backend.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CpuFlagsManagerHandler.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/InitBackendServicesOnStartupBean.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/IsoDomainListSyncronizer.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/TagsDirector.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VdsLoadBalancer.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/job/JobRepositoryCleanupManager.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/MacPoolManager.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/job/ExecutionMessageDirector.java
M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ErrorTranslatorImpl.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/ResourceManager.java
14 files changed, 64 insertions(+), 61 deletions(-)
Approvals:
Allon Mureinik: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/10823
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Iaea9c16e9913cdee4eef88de920e87bde8bc6b5d
Gerrit-PatchSet: 9
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alissa Bonas <abonas(a)redhat.com>
Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com>
Gerrit-Reviewer: Laszlo Hornyak <lhornyak(a)redhat.com>
Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
11 years, 3 months
Change in otopi[master]: core: support separate execution directory in development mo...
by Alon Bar-Lev
Alon Bar-Lev has submitted this change and it was merged.
Change subject: core: support separate execution directory in development mode
......................................................................
core: support separate execution directory in development mode
Change-Id: Ie2cde8afc3cc2af4cef8343b94b0169363416c16
Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com>
---
M src/bin/otopi
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Alon Bar-Lev: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/11317
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ie2cde8afc3cc2af4cef8343b94b0169363416c16
Gerrit-PatchSet: 1
Gerrit-Project: otopi
Gerrit-Branch: master
Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>
11 years, 3 months
Change in otopi[master]: core: survive reexec and different execution directory
by Alon Bar-Lev
Alon Bar-Lev has submitted this change and it was merged.
Change subject: core: survive reexec and different execution directory
......................................................................
core: survive reexec and different execution directory
Store the original execution directory within environment of process.
Change-Id: I2673cc2ade4320da1008b39c9c36659cbc306910
Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com>
---
M src/otopi/__main__.py
M src/otopi/constants.py
M src/otopi/context.py
3 files changed, 10 insertions(+), 2 deletions(-)
Approvals:
Alon Bar-Lev: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/11316
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I2673cc2ade4320da1008b39c9c36659cbc306910
Gerrit-PatchSet: 1
Gerrit-Project: otopi
Gerrit-Branch: master
Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>
11 years, 3 months
Change in ovirt-dwh[master]: build: sync with ovirt-engine build
by ydary＠redhat.com
Yaniv Dary has submitted this change and it was merged.
Change subject: build: sync with ovirt-engine build
......................................................................
build: sync with ovirt-engine build
Change-Id: Ie89b465f0bb96a42c3b397b2b2bb92fbda0a7fd6
Signed-off-by: Alon Bar-Lev <alon.barlev(a)gmail.com>
---
M Makefile
1 file changed, 5 insertions(+), 6 deletions(-)
Approvals:
Yaniv Dary: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/11121
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ie89b465f0bb96a42c3b397b2b2bb92fbda0a7fd6
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-dwh
Gerrit-Branch: master
Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com>
11 years, 3 months
Change in ovirt-engine-sdk-java[master]: sdk: add ReportedDevice entity
by mpastern＠redhat.com
Michael Pasternak has submitted this change and it was merged.
Change subject: sdk: add ReportedDevice entity
......................................................................
sdk: add ReportedDevice entity
Change-Id: Ibfd7d1e6294a706b7eb8736aa4c7c5d7f130524a
Signed-off-by: Michael Pasternak <mpastern(a)redhat.com>
---
A ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/entities/ReportedDevice.java
1 file changed, 181 insertions(+), 0 deletions(-)
Approvals:
Michael Pasternak: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/11306
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ibfd7d1e6294a706b7eb8736aa4c7c5d7f130524a
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine-sdk-java
Gerrit-Branch: master
Gerrit-Owner: Michael Pasternak <mpastern(a)redhat.com>
Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com>
11 years, 3 months
