Change in ovirt-engine[master]: webadmin: wrong compatibility version prompt in new DC
by alkaplan＠redhat.com
Alona Kaplan has submitted this change and it was merged.
Change subject: webadmin: wrong compatibility version prompt in new DC
......................................................................
webadmin: wrong compatibility version prompt in new DC
In case a DC was selected in grid and new DC button was pressed, we
opened the compatibility version changed dialog wrongfuly.
Added isNew DC check.
Change-Id: I85fbabe1117c64896772a52f533868d3c4a349b2
Signed-off-by: Gilad Chaplik <gchaplik(a)redhat.com>
---
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/datacenters/DataCenterListModel.java
1 file changed, 3 insertions(+), 3 deletions(-)
Approvals:
Alona Kaplan: Looks good to me, approved
Gilad Chaplik: Verified
--
To view, visit http://gerrit.ovirt.org/11255
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I85fbabe1117c64896772a52f533868d3c4a349b2
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Gilad Chaplik <gchaplik(a)redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com>
Gerrit-Reviewer: ofri masad <omasad(a)redhat.com>
11 years, 3 months
Change in ovirt-engine-sdk-java[master]: codegen: perform repo cleanup on XsdCodegen
by mpastern＠redhat.com
Michael Pasternak has submitted this change and it was merged.
Change subject: codegen: perform repo cleanup on XsdCodegen
......................................................................
codegen: perform repo cleanup on XsdCodegen
Change-Id: I9bc698282143f09f19bf6495be4980ef9e112cc8
Signed-off-by: Michael Pasternak <mpastern(a)redhat.com>
---
M ovirt-engine-sdk-java-codegen/src/main/java/org/ovirt/engine/sdk/codegen/rsdl/RsdlCodegen.java
M ovirt-engine-sdk-java-codegen/src/main/java/org/ovirt/engine/sdk/codegen/xsd/XsdCodegen.java
D ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/VMDevice.java
R ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/VMNICReportedDevice.java
M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/VMNICReportedDevices.java
C ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/VMReportedDevice.java
M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/VMReportedDevices.java
D ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/entities/Device.java
M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/entities/ObjectFactory.java
9 files changed, 1,274 insertions(+), 1,544 deletions(-)
Approvals:
Michael Pasternak: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/11253
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I9bc698282143f09f19bf6495be4980ef9e112cc8
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine-sdk-java
Gerrit-Branch: master
Gerrit-Owner: Michael Pasternak <mpastern(a)redhat.com>
Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com>
11 years, 3 months
Change in ovirt-engine[engine_3.2]: restapi: Add Href To Host Hooks
by oliel＠redhat.com
Ori Liel has submitted this change and it was merged.
Change subject: restapi: Add Href To Host Hooks
......................................................................
restapi: Add Href To Host Hooks
Change-Id: I3fbc218d1fb143173fda5dc15988dfa6cd6b285f
Signed-off-by: Ori Liel <oliel(a)redhat.com>
---
M backend/manager/modules/restapi/interface/common/jaxrs/src/main/java/org/ovirt/engine/api/common/util/LinkHelper.java
M backend/manager/modules/restapi/interface/definition/src/main/resources/api.xsd
M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendHostHooksResource.java
M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendHostsResource.java
M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendHostHookResourceTest.java
M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendHostHooksResourceTest.java
6 files changed, 24 insertions(+), 5 deletions(-)
Approvals:
Michael Pasternak: Looks good to me, approved
Ori Liel: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/11250
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I3fbc218d1fb143173fda5dc15988dfa6cd6b285f
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: engine_3.2
Gerrit-Owner: Ori Liel <oliel(a)redhat.com>
Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com>
Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com>
11 years, 3 months
Change in ovirt-engine[master]: webadmin: Default host for RunOnce dialog enabled
by tjelinek＠redhat.com
Tomas Jelinek has submitted this change and it was merged.
Change subject: webadmin: Default host for RunOnce dialog enabled
......................................................................
webadmin: Default host for RunOnce dialog enabled
New panel with default host selection is added to the RunOnce dialog.
The appearance is similar to the VM edit dialog Host tab.
The RunOnce dialog host panel is invisible in the User Portal application.
Change-Id: I1906caf40c91e12a56523ddda794c72690947d4c
Bug-Url: https://bugzilla.redhat.com/560981
Signed-off-by: Libor Spevak <lspevak(a)redhat.com>
---
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/vm/VmRunOncePopupWidget.java
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/vm/VmRunOncePopupWidget.ui.xml
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/userportal/UserPortalListModel.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/RunOnceModel.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/UnitVmModel.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmListModel.java
6 files changed, 233 insertions(+), 4 deletions(-)
Approvals:
Tomas Jelinek: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/10654
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I1906caf40c91e12a56523ddda794c72690947d4c
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Libor Spevak <lspevak(a)redhat.com>
Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com>
Gerrit-Reviewer: Libor Spevak <lspevak(a)redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>
11 years, 3 months
Change in ovirt-engine[master]: packaging: Don't change identity if no ENGINE_USER
by juan.hernandez＠redhat.com
Juan Hernandez has submitted this change and it was merged.
Change subject: packaging: Don't change identity if no ENGINE_USER
......................................................................
packaging: Don't change identity if no ENGINE_USER
Currently the parameters ENGINE_USER and ENGINE_GROUP in
/etc/sysconfig/ovirt-engine need to have a value. In order to simplify
use for developers this patch makes the value optional, so if they don't
have a value the service script will not change the identity before
starting the engine.
Change-Id: I0a56d73ad347011421ddd4f35671f3e39a610aec
Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com>
---
M packaging/fedora/engine-service.py.in
1 file changed, 20 insertions(+), 16 deletions(-)
Approvals:
Juan Hernandez: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/11161
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I0a56d73ad347011421ddd4f35671f3e39a610aec
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Alex Lourie <alourie(a)redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com>
11 years, 3 months
Change in ovirt-engine[master]: restapi: Add Href To Host Hooks
by oliel＠redhat.com
Ori Liel has submitted this change and it was merged.
Change subject: restapi: Add Href To Host Hooks
......................................................................
restapi: Add Href To Host Hooks
Change-Id: If6c10c4ca6c13cafed89b1c408a1ec70e6eacbc9
Signed-off-by: Ori Liel <oliel(a)redhat.com>
---
M backend/manager/modules/restapi/interface/common/jaxrs/src/main/java/org/ovirt/engine/api/common/util/LinkHelper.java
M backend/manager/modules/restapi/interface/definition/src/main/resources/api.xsd
M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendHostHooksResource.java
M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendHostsResource.java
M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendHostHookResourceTest.java
M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendHostHooksResourceTest.java
6 files changed, 24 insertions(+), 5 deletions(-)
Approvals:
Ori Liel: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/11247
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: If6c10c4ca6c13cafed89b1c408a1ec70e6eacbc9
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Ori Liel <oliel(a)redhat.com>
Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com>
Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com>
11 years, 3 months
Change in ovirt-engine[master]: engine: Allow null values to ReplacementUtils
by masayag＠redhat.com
Moti Asayag has submitted this change and it was merged.
Change subject: engine: Allow null values to ReplacementUtils
......................................................................
engine: Allow null values to ReplacementUtils
Since there is no enforcement for the property value not to contain
a null as its value, a null value should be supported as a valid value.
Change-Id: I04f2ab1c328a6eae3470448c6bb77dbf45dbf18c
Signed-off-by: Moti Asayag <masayag(a)redhat.com>
---
M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ReplacementUtils.java
M backend/manager/modules/utils/src/test/java/org/ovirt/engine/core/utils/ReplacementUtilsTest.java
2 files changed, 9 insertions(+), 1 deletion(-)
Approvals:
Moti Asayag: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/11125
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I04f2ab1c328a6eae3470448c6bb77dbf45dbf18c
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: Muli Salem <msalem(a)redhat.com>
Gerrit-Reviewer: Sharad Mishra <snmishra(a)linux.vnet.ibm.com>
11 years, 3 months
Change in ovirt-engine[master]: engine: quota caching fix
by lhornyak＠redhat.com
Laszlo Hornyak has submitted this change and it was merged.
Change subject: engine: quota caching fix
......................................................................
engine: quota caching fix
reverts the memory and vcpu usage to it's original value when the quota
request is rejected
Change-Id: I0fad37c170e27d5cb78445c7c2fbcd9b3c7f9116
Signed-off-by: Laszlo Hornyak <lhornyak(a)redhat.com>
Bug-Url: https://bugzilla.redhat.com/894869
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/quota/QuotaManager.java
1 file changed, 7 insertions(+), 7 deletions(-)
Approvals:
Laszlo Hornyak: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/11083
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I0fad37c170e27d5cb78445c7c2fbcd9b3c7f9116
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Laszlo Hornyak <lhornyak(a)redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com>
Gerrit-Reviewer: Laszlo Hornyak <lhornyak(a)redhat.com>
Gerrit-Reviewer: ofri masad <omasad(a)redhat.com>
11 years, 3 months
Change in ovirt-engine[master]: userportal, webadmin: console error message translation ignor...
by tjelinek＠redhat.com
Tomas Jelinek has submitted this change and it was merged.
Change subject: userportal,webadmin: console error message translation ignored
......................................................................
userportal,webadmin: console error message translation ignored
When the SPICE or RDP console returns an error code, it was ignored.
Fixed by creating a common ConsoleModelErrorEventListener which listens on the
error events and if one occures, shows a popup dialog with the message. It
also translates the error code to human readable form.
This listener is than used in both userportal and webadmin for both RDP and
SPICE
This patch also deletes the unused ResourceManager and Assembly classes which
where not used anymore and had only empty implementations.
Change-Id: Iaa0b0d144dcaafffba8911c0cfa41670e179a7c5
Bug-Url: https://bugzilla.redhat.com/888774
Signed-off-by: Tomas Jelinek <tjelinek(a)redhat.com>
---
A frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/ConsoleErrorTranslator.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/userportal/IUserPortalListModel.java
A frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/ConsoleModelErrorEventListener.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmListModel.java
D frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/Assembly.java
M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/Messages.java
D frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/ResourceManager.java
7 files changed, 112 insertions(+), 131 deletions(-)
Approvals:
Tomas Jelinek: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/11052
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Iaa0b0d144dcaafffba8911c0cfa41670e179a7c5
Gerrit-PatchSet: 6
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Tomas Jelinek <tjelinek(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Frank Kobzik <fkobzik(a)redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>
11 years, 3 months
Change in ovirt-engine[master]: gluster: Fetch brick statuses only for UP volumes
by sanjal＠redhat.com
Shireesh Anjal has submitted this change and it was merged.
Change subject: gluster: Fetch brick statuses only for UP volumes
......................................................................
gluster: Fetch brick statuses only for UP volumes
Brick statuses are fetched by executing the gluster cli command
'gluster volume status' which works only on UP volumes. Hence
we should not try to fetch and update brick statuses for volumes
that are currently DOWN.
Also made sure that whenever a volume status changes, we update
the status of it's bricks as well.
Introduced more specific audit log types when we detect that a
volume was started/stopped from the gluster cli.
Change-Id: If7f28948036993423d5baad2f4af41875670a18a
Signed-off-by: Shireesh Anjal <sanjal(a)redhat.com>
---
A backend/manager/dbscripts/upgrade/03_02_0340_gluster_volume_status_events.sql
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GlusterManager.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/gluster/GlusterManagerTest.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/AuditLogType.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/auditloghandling/AuditLogDirector.java
M backend/manager/modules/dal/src/main/resources/bundles/AuditLogMessages.properties
6 files changed, 38 insertions(+), 16 deletions(-)
Approvals:
Shireesh Anjal: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/11156
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: If7f28948036993423d5baad2f4af41875670a18a
Gerrit-PatchSet: 6
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Shireesh Anjal <sanjal(a)redhat.com>
Gerrit-Reviewer: Kanagaraj M <kmayilsa(a)redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>
Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com>
Gerrit-Reviewer: Shireesh Anjal <sanjal(a)redhat.com>
11 years, 3 months