January 2013 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: ui: replacing favicon.ico file
by ecohen＠redhat.com 22 Jan '13

22 Jan '13

Einav Cohen has submitted this change and it was merged. Change subject: ui: replacing favicon.ico file ...................................................................... ui: replacing favicon.ico file New oVirt (greenish) favicon.ico file (website icon). Change-Id: I37424dcd6c422d6ffdfff4b8d8befb07d481190d Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M backend/manager/modules/root/src/main/webapp/favicon.ico 1 file changed, 0 insertions(+), 0 deletions(-) Approvals: Daniel Erez: Verified Einav Cohen: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/10949 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I37424dcd6c422d6ffdfff4b8d8befb07d481190d Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com>

1 0

Change in otopi[master]: core: chdir('/') during install
by Alon Bar-Lev 21 Jan '13

21 Jan '13

Alon Bar-Lev has submitted this change and it was merged. Change subject: core: chdir('/') during install ...................................................................... core: chdir('/') during install Avoid errors from programs that do not know to run from removed directory. Change-Id: I467c3a8eaadf88f5060a96eefefd1872519cb32f Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M README.API M README.environment M src/otopi/__main__.py M src/otopi/constants.py M src/otopi/context.py M src/otopi/plugin.py M src/plugins/otopi/core/log.py M src/plugins/otopi/dialog/cli.py 8 files changed, 38 insertions(+), 2 deletions(-) Approvals: Alon Bar-Lev: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/11274 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I467c3a8eaadf88f5060a96eefefd1872519cb32f Gerrit-PatchSet: 1 Gerrit-Project: otopi Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>

1 0

Change in ovirt-engine[master]: gluster: Reuse Command methods
by masayag＠redhat.com 21 Jan '13

21 Jan '13

Moti Asayag has submitted this change and it was merged. Change subject: gluster: Reuse Command methods ...................................................................... gluster: Reuse Command methods The perform few cleanups: using a class level method (getDbFacade()) instead of static access to DbFacade. In addition, it adds missing default case to switch statements. Change-Id: I05042649259efa596c255360174127335a4d8a1b Signed-off-by: Moti Asayag <masayag(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/CreateGlusterVolumeCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GlusterVolumeCommandBase.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/ReplaceGlusterVolumeBrickCommand.java 3 files changed, 7 insertions(+), 5 deletions(-) Approvals: Moti Asayag: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/10989 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I05042649259efa596c255360174127335a4d8a1b Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Shireesh Anjal <sanjal(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: make log statements more clear
by tnisan＠redhat.com 21 Jan '13

21 Jan '13

Tal Nisan has submitted this change and it was merged. Change subject: core: make log statements more clear ...................................................................... core: make log statements more clear Improve log statements in DbUserCacheManager and UsersDomainsCacheManagerService - remove "new Date", improve the log statement itself, add logging statements for start/finish initialization Change-Id: I87111a8c5ca3392dca77944252687fdca9d3588d Signed-off-by: Alissa Bonas <abonas(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/DbUserCacheManager.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/adbroker/UsersDomainsCacheManagerService.java 2 files changed, 4 insertions(+), 2 deletions(-) Approvals: Tal Nisan: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/11266 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I87111a8c5ca3392dca77944252687fdca9d3588d Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Laszlo Hornyak <lhornyak(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: [RFE] Display Address Override
by tjelinek＠redhat.com 21 Jan '13

21 Jan '13

Tomas Jelinek has submitted this change and it was merged. Change subject: core: [RFE] Display Address Override ...................................................................... core: [RFE] Display Address Override This patch introduces the possibility to override the display address of the host by an IP or FQDN Detailed description: http://wiki.ovirt.org/wiki/Features/Display_Address_Override - vds_static enriched by a new field console_address - if it is null, it means the address has not been overridden - if it is not null, the address has been overridden and all VMs on this host will be considered to have the display address to be the the one in defined in console_address - the vds_static can be a valid FQDN or IP or null - to support this a new validator NullEnabledHostnameOrIp has been introduced Change-Id: Idacc0161a104c1de0969d86d98ddd5458c6787b8 Signed-off-by: Tomas Jelinek <tjelinek(a)redhat.com> --- M backend/manager/dbscripts/create_views.sql A backend/manager/dbscripts/upgrade/03_02_0350_add_console_address.sql M backend/manager/dbscripts/vds_sp.sql M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VdsHandler.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/BusinessEntitiesDefinitions.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VDS.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VdsStatic.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VdsDAODbFacadeImpl.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VdsStaticDAODbFacadeImpl.java M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/ExtendedVmDynamic.java 11 files changed, 60 insertions(+), 15 deletions(-) Approvals: Tomas Jelinek: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/9022 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Idacc0161a104c1de0969d86d98ddd5458c6787b8 Gerrit-PatchSet: 8 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Frank Kobzik <fkobzik(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Change disks status to illegal.
by mlipchuk＠redhat.com 21 Jan '13

21 Jan '13

Maor Lipchuk has submitted this change and it was merged. Change subject: core: Change disks status to illegal. ...................................................................... core: Change disks status to illegal. Event log is reporting changing disk status to illegal but disks stay in locked state The proposed fix is to change the disks statuses to ILLEGAL and log which disks were not at ILLEGAL state in the first place to make it easy to resolve bugs. Change-Id: Ic4075c03b8d70d50b69222c73169ccc63e3ab66e Related-to: https://bugzilla.redhat.com/880687 Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveVmCommand.java 1 file changed, 8 insertions(+), 0 deletions(-) Approvals: Maor Lipchuk: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/11248 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic4075c03b8d70d50b69222c73169ccc63e3ab66e Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Remove vmId from PerformImagesChecks
by amureini＠redhat.com 21 Jan '13

21 Jan '13

Allon Mureinik has submitted this change and it was merged. Change subject: core: Remove vmId from PerformImagesChecks ...................................................................... core: Remove vmId from PerformImagesChecks Removed the VM ID from PerformImagesChecks, Since this function is all about validating images, not VMs. In order to achieve this support for passing a null list of disks was dropped, and in the one(!) place it was used (RemoveSnaphotCommand), an explicit DAO call was added. Change-Id: Ia628932ca7767aa9cca4b572523321346828dfa0 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddDiskCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmTemplateCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CreateAllSnapshotsFromVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ExportVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImagesHandler.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MoveVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveDiskCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveSnapshotCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RestoreAllSnapshotsCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/TryBackToAllSnapshotsOfVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmPoolCommandBase.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmRunHandler.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/AddDiskToVmCommandTest.java 14 files changed, 19 insertions(+), 20 deletions(-) Approvals: Allon Mureinik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/11230 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia628932ca7767aa9cca4b572523321346828dfa0 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: VM ImageIllegal status check in ImagesHandler
by amureini＠redhat.com 21 Jan '13

21 Jan '13

Allon Mureinik has submitted this change and it was merged. Change subject: core: VM ImageIllegal status check in ImagesHandler ...................................................................... core: VM ImageIllegal status check in ImagesHandler Since we now have statuses per disk, checking a VM's status for ImageInvalid seems unrelated to ImagesHandler. In fact, this has become a more "logical" illegal status, not directly associated to the VM's images. The relevant code was removed from ImagesHandler and moved to VmValidator, where it belongs. Note that only place that used this validation (i.e., checkIsValid=true && checkImagesIllegal=true) and did not explicitly validate the VM's state beforhand (regardless) is CreateAllSnapshotFromVmCommad. To seal the deal, the API of the relevant methods was changed to use VM ID instead of a VM, to show it is no longer needed. Change-Id: I0578a91929689a95845b51a6cd5b1f42ef497c91 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddDiskCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmTemplateCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CreateAllSnapshotsFromVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ExportVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImagesHandler.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MoveVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveDiskCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveSnapshotCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RestoreAllSnapshotsCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/TryBackToAllSnapshotsOfVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmPoolCommandBase.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmRunHandler.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/VmValidator.java 14 files changed, 37 insertions(+), 36 deletions(-) Approvals: Allon Mureinik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/11212 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0578a91929689a95845b51a6cd5b1f42ef497c91 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: VM ImageLocked status check in ImagesHandler
by amureini＠redhat.com 21 Jan '13

21 Jan '13

Allon Mureinik has submitted this change and it was merged. Change subject: core: VM ImageLocked status check in ImagesHandler ...................................................................... core: VM ImageLocked status check in ImagesHandler Since we now have statuses per disk, checking a VM's status for ImageLocked seems unrelated to ImagesHandler. In fact, this has become a more "logical" locked status, not directly associated to the VM's images. The relevant code was removed from ImagesHandler and moved to VmValidator, where it belongs. Note that most places that required this validation already validated first that the VM was in fact down, so adding an additional status check there was pointless. In the places where the additional check was warranted, care was taken to make the VM's status check /AFTER/ the disks', so that the most informative error message (containing the aliases of the locked disks) could be produced. To seal the deal, the API of the relevant methods was changed to use VM ID instead of a VM, to show it is no longer needed. Change-Id: Iacfcb81df64b778b2093c7c84a8582cfd59be29c Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddDiskCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmFromSnapshotCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CreateAllSnapshotsFromVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImagesHandler.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmPoolCommandBase.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmRunHandler.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/lsm/LiveMigrateVmDisksCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/VmValidator.java 9 files changed, 60 insertions(+), 21 deletions(-) Approvals: Allon Mureinik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/11190 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iacfcb81df64b778b2093c7c84a8582cfd59be29c Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Fix for VmBase
by derez＠redhat.com 21 Jan '13

21 Jan '13

Daniel Erez has submitted this change and it was merged. Change subject: core: Fix for VmBase ...................................................................... core: Fix for VmBase Fix for patch: I9ccb4fc0b807c77bc17cfe02903341cdf4e51d54 Removed 'final' from disk list to allow RPC Serialization. Change-Id: Id3aa95b2c93fb9cd3cc737f88b8a9ac970d42ba3 Signed-off-by: Ofri Masad <omasad(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VmBase.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Daniel Erez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/11254 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id3aa95b2c93fb9cd3cc737f88b8a9ac970d42ba3 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: ofri masad <omasad(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Frank Kobzik <fkobzik(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: ofri masad <omasad(a)redhat.com>

1 0