January 2013 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: core: Adding locks in case of gluster hosts
by sanjal＠redhat.com 16 Jan '13

16 Jan '13

Shireesh Anjal has submitted this change and it was merged. Change subject: core: Adding locks in case of gluster hosts ...................................................................... core: Adding locks in case of gluster hosts If the host being added/removed belongs to a gluster enabled cluster, an exclusive lock will be acquired on the cluster. Change-Id: If9d4fec2fafd5f9f32521025da301f8b07b6e713 Signed-off-by: Shireesh Anjal <sanjal(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVdsCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveVdsCommand.java 2 files changed, 38 insertions(+), 17 deletions(-) Approvals: Shireesh Anjal: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/10850 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If9d4fec2fafd5f9f32521025da301f8b07b6e713 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shireesh Anjal <sanjal(a)redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayilsa(a)redhat.com> Gerrit-Reviewer: Michael Kublin <mkublin(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Shireesh Anjal <sanjal(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: packaging: add new line at end of lock file
by oschreib＠redhat.com 16 Jan '13

16 Jan '13

Ofer Schreiber has submitted this change and it was merged. Change subject: packaging: add new line at end of lock file ...................................................................... packaging: add new line at end of lock file Change-Id: I06622d9a87dfd8d7854fff39fc677f430f9fe847 Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M packaging/fedora/setup/common_utils.py 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Ofer Schreiber: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/11091 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I06622d9a87dfd8d7854fff39fc677f430f9fe847 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alex Lourie <alourie(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com>

1 0

Change in ovirt-engine[master]: packaging: branding cleanup
by oschreib＠redhat.com 16 Jan '13

16 Jan '13

Ofer Schreiber has submitted this change and it was merged. Change subject: packaging: branding cleanup ...................................................................... packaging: branding cleanup Two changes to ease branding. Change-Id: I62e31f8a50f7e1db575e9bd5f5388d4c60e5c34a Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M packaging/fedora/setup/output_messages.py M packaging/fedora/spec/ovirt-engine.spec.in 2 files changed, 2 insertions(+), 2 deletions(-) Approvals: Ofer Schreiber: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/11000 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I62e31f8a50f7e1db575e9bd5f5388d4c60e5c34a Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alex Lourie <alourie(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Moran Goldboim <mgoldboi(a)redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com>

1 0

Change in ovirt-engine-cli[master]: cli: detailed command syntax in help
by mpastern＠redhat.com 16 Jan '13

16 Jan '13

Michael Pasternak has submitted this change and it was merged. Change subject: cli: detailed command syntax in help ...................................................................... cli: detailed command syntax in help Change-Id: I7f1f15a01f49a179038084d5e67c83a0fa64ba41 Signed-off-by: Michael Pasternak <mpastern(a)redhat.com> --- M src/ovirtcli/command/list.py M src/ovirtcli/command/remove.py M src/ovirtcli/command/show.py M src/ovirtcli/command/update.py 4 files changed, 4 insertions(+), 4 deletions(-) Approvals: Michael Pasternak: Verified; Looks good to me, approved Ori Liel: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/10967 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7f1f15a01f49a179038084d5e67c83a0fa64ba41 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine-cli Gerrit-Branch: master Gerrit-Owner: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com>

1 0

Change in ovirt-engine-sdk[master]: sdk: document errors
by mpastern＠redhat.com 16 Jan '13

16 Jan '13

Michael Pasternak has submitted this change and it was merged. Change subject: sdk: document errors ...................................................................... sdk: document errors Change-Id: Ia6194cef427e7202a0bd77488efd3bb77fabe89e Signed-off-by: Michael Pasternak <mpastern(a)redhat.com> --- M src/codegen/entrypoint/entrypoint.py M src/ovirtsdk/api.py 2 files changed, 35 insertions(+), 5 deletions(-) Approvals: Michael Pasternak: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/11089 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia6194cef427e7202a0bd77488efd3bb77fabe89e Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine-sdk Gerrit-Branch: master Gerrit-Owner: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin: Status label is not update on IE
by gchaplik＠redhat.com 16 Jan '13

16 Jan '13

Gilad Chaplik has submitted this change and it was merged. Change subject: webadmin: Status label is not update on IE ...................................................................... webadmin: Status label is not update on IE On dragStart we setData on the dragDropEvent. Later we use this data as a key to the dragged object. On dragenter, dragleave, dragover we update the status label. We use the getData to find out the dragged element. On firefox it works fine, but on most of the browsers drag, dragenter, dragleave, dragover and dragend don't have access to event's data. It is part of the DnD specification itself and firefox is the exception here. So, to workaround it- the dragged element key is saved as a static member of NetworkItemPanel class. Change-Id: Id72896117ce2b26f99607f3d34a55642fbe548bd Signed-off-by: Alona Kaplan <alkaplan(a)redhat.com> --- M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/panels/NetworkGroup.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/panels/NetworkItemPanel.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/panels/UnassignedNetworksPanel.java 3 files changed, 19 insertions(+), 4 deletions(-) Approvals: Gilad Chaplik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/11079 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id72896117ce2b26f99607f3d34a55642fbe548bd Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Livnat Peer <lpeer(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin: support IE10
by gchaplik＠redhat.com 16 Jan '13

16 Jan '13

Gilad Chaplik has submitted this change and it was merged. Change subject: webadmin: support IE10 ...................................................................... webadmin: support IE10 Running an application in IE9 does not necessarily mean you are running IE9 standards mode. IE9 has many modes that can be defined in the page head tag ("Document Mode"). GWT IE permutations work best with each version of "standards" mode. Mixing modes, say browser mode = 7 and document mode = 9, is not recommended and the behavior is undefined. Gwt's recommendation is "try to keep browser modes and document modes the same. If you must use mixed mode, be aware that you may run into issues that are still not supported. The exception is if you are emulating an older browser when you still do not support the new version, for instance, you emulate IE7 (EmulateIE7) on IE9." It means adding this line- <meta http-equiv="X-UA-Compatible" content="IE=9"> (tells Internet Explorer to display a webpage in IE9 mode, if possible) can cause- 1. Problems when using browser with older the IE9 version. 2. Forces IE10 to behave as IE9. Because of the first cause this line was removed and not changed to IE=10. Change-Id: I3ebd720dec57b890b8119ff39efcfb50d34da9e2 Signed-off-by: Alona Kaplan <alkaplan(a)redhat.com> --- M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/server/gwt/GwtDynamicHostPageServlet.java 1 file changed, 0 insertions(+), 1 deletion(-) Approvals: Gilad Chaplik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/11078 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3ebd720dec57b890b8119ff39efcfb50d34da9e2 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Livnat Peer <lpeer(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin: ie10 drag&drop support
by gchaplik＠redhat.com 16 Jan '13

16 Jan '13

Gilad Chaplik has submitted this change and it was merged. Change subject: webadmin: ie10 drag&drop support ...................................................................... webadmin: ie10 drag&drop support DragDropEvent.setData recives two parameters- dataFormat and data. IE suuports just "Text" and "URL" as the dataFormat (while all the other browsers support arbitrary string). In order to support IE the format was changed to "Text". Change-Id: I5150a6c2b62322969d88d0e2f2a9a85621352d9c Signed-off-by: Alona Kaplan <alkaplan(a)redhat.com> --- M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/panels/NetworkGroup.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/panels/NetworkItemPanel.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/panels/UnassignedNetworksPanel.java 3 files changed, 33 insertions(+), 8 deletions(-) Approvals: Gilad Chaplik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/11077 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5150a6c2b62322969d88d0e2f2a9a85621352d9c Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Livnat Peer <lpeer(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: DB - Snapshot Materialized Views support
by emesika＠redhat.com 16 Jan '13

16 Jan '13

Eli Mesika has submitted this change and it was merged. Change subject: core: DB - Snapshot Materialized Views support ...................................................................... core: DB - Snapshot Materialized Views support Adding Snapshot Materialized Views support to the database. A Snapshot Materialized View is actually a table built on top of a real view that enables to select data from the Snapshot Materialized View easily and efficiently. Candidates for Snapshot Materialized Views are views that are based on slowly-changing data. The Snapshot Materialized Views is actually functioning as a cache. The Snapshot Materialized View is refreshed per request. The Snapshot Materialized View definitions are stored in the materialized_views table. Change-Id: I17333db996f0e3b1856e2df02a621810c3ebaa53 Signed-off-by: Eli Mesika <emesika(a)redhat.com> --- M backend/manager/dbscripts/dbfunctions.sh A backend/manager/dbscripts/materialized_views_sp.sql A backend/manager/dbscripts/upgrade/post_upgrade/0020_create_materialized_views.sql A backend/manager/dbscripts/upgrade/pre_upgrade/0030_add_materialized_views_table.sql 4 files changed, 368 insertions(+), 0 deletions(-) Approvals: Eli Mesika: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/10105 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I17333db996f0e3b1856e2df02a621810c3ebaa53 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: packaging: Updated cleanup to clean postgresql 9.2 connecti...
by oschreib＠redhat.com 16 Jan '13

16 Jan '13

Ofer Schreiber has submitted this change and it was merged. Change subject: packaging: Updated cleanup to clean postgresql 9.2 connections ...................................................................... packaging: Updated cleanup to clean postgresql 9.2 connections * Updated the command in common_utils that clears the DB connections. The difference in 9.2: the field 'procpid' was renamed to 'pid'. Bug-Url: https://bugzilla.redhat.com/782176 Change-Id: Idfad6d478a647ee91d818f1f377490a29a1a2ddb Signed-off-by: Alex Lourie <alourie(a)redhat.com> --- M packaging/fedora/setup/common_utils.py M packaging/fedora/setup/output_messages.py 2 files changed, 28 insertions(+), 1 deletion(-) Approvals: Ofer Schreiber: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/10389 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Idfad6d478a647ee91d818f1f377490a29a1a2ddb Gerrit-PatchSet: 9 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alex Lourie <alourie(a)redhat.com> Gerrit-Reviewer: Alex Lourie <alourie(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Kiril Nesenko <knesenko(a)redhat.com> Gerrit-Reviewer: Moran Goldboim <mgoldboi(a)redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com> Gerrit-Reviewer: Ohad Basan <obasan(a)redhat.com>

1 0