January 2013 - Engine-commits - oVirt List Archives

Change in ovirt-dwh[master]: etl: fixed aggregation process (#894716)
by ydary＠redhat.com 15 Jan '13

15 Jan '13

Yaniv Dary has submitted this change and it was merged. Change subject: etl: fixed aggregation process (#894716) ...................................................................... etl: fixed aggregation process (#894716) Fixed issue that caused tables not to aggregate. Bug-Url: https://bugzilla.redhat.com/894716 Change-Id: I5155b6d57e8d838c8234e93b49d36fbd45960f5c Signed-off-by: Yaniv Dary <ydary(a)redhat.com> --- M data-warehouse/history_etl/etl_sources/historyETLProcedure/src/main/java/ovirt_engine_dwh/aggregationtodaily_3_2/AggregationToDaily.java M data-warehouse/history_etl/etl_sources/historyETLProcedure/src/main/java/ovirt_engine_dwh/aggregationtohourly_3_2/AggregationToHourly.java M data-warehouse/history_etl/tos_project/process/AggregationToDaily_3.2.item M data-warehouse/history_etl/tos_project/process/AggregationToDaily_3.2.properties M data-warehouse/history_etl/tos_project/process/AggregationToHourly_3.2.item M data-warehouse/history_etl/tos_project/process/AggregationToHourly_3.2.properties 6 files changed, 13 insertions(+), 13 deletions(-) Approvals: Yaniv Dary: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/11039 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5155b6d57e8d838c8234e93b49d36fbd45960f5c Gerrit-PatchSet: 1 Gerrit-Project: ovirt-dwh Gerrit-Branch: master Gerrit-Owner: Yaniv Dary <ydary(a)redhat.com> Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com>

1 0

Change in ovirt-dwh[master]: history: change enum translator lang codes
by ydary＠redhat.com 15 Jan '13

15 Jan '13

Yaniv Dary has submitted this change and it was merged. Change subject: history: change enum translator lang codes ...................................................................... history: change enum translator lang codes Codes are now in standard form. Change-Id: Iaa95c0d3ce2757cff3d710ff4bef22ba72717bee Signed-off-by: Yaniv Dary <ydary(a)redhat.com> --- A data-warehouse/historydbscripts_postgres/upgrade/post_upgrade/0010_change_enum_lang_code.sql D data-warehouse/historydbscripts_postgres/upgrade/post_upgrade/dummy_post.sql A data-warehouse/historydbscripts_postgres/upgrade/pre_upgrade/set_default_lang_code.sql 3 files changed, 13 insertions(+), 1 deletion(-) Approvals: Yaniv Dary: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/11038 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iaa95c0d3ce2757cff3d710ff4bef22ba72717bee Gerrit-PatchSet: 1 Gerrit-Project: ovirt-dwh Gerrit-Branch: master Gerrit-Owner: Yaniv Dary <ydary(a)redhat.com> Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: fix NPE when mounting run once CD
by rgolan＠redhat.com 15 Jan '13

15 Jan '13

Roy Golan has submitted this change and it was merged. Change subject: core: fix NPE when mounting run once CD ...................................................................... core: fix NPE when mounting run once CD A payload is valid a device (e.g. CD) that has specParams field set with a structure containing vmPayload key. when checking for a vmPayload using isPayload method we should fail fast if specParams is null, avoid NPE and return false. Change-Id: I7312102ab6f93122f06ae7c7bd6b1c3158e54ea0 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=893115 Signed-off-by: Roy Golan <rgolan(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VmPayload.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Roy Golan: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/10827 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7312102ab6f93122f06ae7c7bd6b1c3158e54ea0 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com>

1 0

Change in ovirt-engine[master]: Remove unsupported vdsm version 4.5 (2.2)
by iheim＠redhat.com 15 Jan '13

15 Jan '13

Itamar Heim has submitted this change and it was merged. Change subject: Remove unsupported vdsm version 4.5 (2.2) ...................................................................... Remove unsupported vdsm version 4.5 (2.2) Change-Id: I3d92743bd7e8a5e949110a0271482e3e0b842a37 Signed-off-by: Itamar Heim <iheim(a)redhat.com> --- M backend/manager/dbscripts/upgrade/pre_upgrade/0000_config.sql 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Itamar Heim: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/10410 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3d92743bd7e8a5e949110a0271482e3e0b842a37 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine-sdk-java[master]: sdk: add release/deploy plugins to pom
by mpastern＠redhat.com 15 Jan '13

15 Jan '13

Michael Pasternak has submitted this change and it was merged. Change subject: sdk: add release/deploy plugins to pom ...................................................................... sdk: add release/deploy plugins to pom Change-Id: I6bdef342e5fe9540a51be7c29c787b5ad6f4e538 Signed-off-by: Michael Pasternak <mpastern(a)redhat.com> --- M ovirt-engine-sdk-java/pom.xml 1 file changed, 236 insertions(+), 69 deletions(-) Approvals: Michael Pasternak: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/11026 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6bdef342e5fe9540a51be7c29c787b5ad6f4e538 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine-sdk-java Gerrit-Branch: master Gerrit-Owner: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: RemoveDiskCommand project standards
by amureini＠redhat.com 15 Jan '13

15 Jan '13

Allon Mureinik has submitted this change and it was merged. Change subject: core: RemoveDiskCommand project standards ...................................................................... core: RemoveDiskCommand project standards Fixed RemoveDiskCommand's formatting to comply with project standards of Eclipse auto-formatting (imports order, @Override annotations). Change-Id: I714682fb039d3c5d47038d42fbb6a95e6e7abf38 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveDiskCommand.java 1 file changed, 5 insertions(+), 4 deletions(-) Approvals: Allon Mureinik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/11011 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I714682fb039d3c5d47038d42fbb6a95e6e7abf38 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin: disk search overridden by default upon tab reveal
by derez＠redhat.com 15 Jan '13

15 Jan '13

Daniel Erez has submitted this change and it was merged. Change subject: webadmin: disk search overridden by default upon tab reveal ...................................................................... webadmin: disk search overridden by default upon tab reveal If a search was done on disks and revealing the tab caused the radio button for the disk view to switch (from All or Luns to Images), the default search would run instead of the one entered. The function to filter the search based on the selected image type was overwriting the entire search string in some instances. It will now normalize the input before filtering so ensure that the current search string can be filtered according to image type. Change-Id: Iebf63fc5e6343819062959cd85219b1a965daf95 Bug-Url: https://bugzilla.redhat.com/893259 Signed-off-by: Greg Padgett <gpadgett(a)redhat.com> --- M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/MainTabDiskView.java 1 file changed, 40 insertions(+), 22 deletions(-) Approvals: Daniel Erez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/10897 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iebf63fc5e6343819062959cd85219b1a965daf95 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Greg Padgett <gpadgett(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com> Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Greg Padgett <gpadgett(a)redhat.com>

1 0

Change in ovirt-engine[master]: packaging: Clean files generated from templates
by juan.hernandez＠redhat.com 15 Jan '13

15 Jan '13

Juan Hernandez has submitted this change and it was merged. Change subject: packaging: Clean files generated from templates ...................................................................... packaging: Clean files generated from templates Remove files that have been generated from templates when running the clean target. Change-Id: I14825c95da9091b06967ed81393a1f3eee6eb820 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M Makefile 1 file changed, 4 insertions(+), 0 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/11020 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I14825c95da9091b06967ed81393a1f3eee6eb820 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Alex Lourie <alourie(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Remove VMStatus#isGuestUp method
by ofrenkel＠redhat.com 15 Jan '13

15 Jan '13

Omer Frenkel has submitted this change and it was merged. Change subject: core: Remove VMStatus#isGuestUp method ...................................................................... core: Remove VMStatus#isGuestUp method The method VMStatus#isGuestUp is removed. The method was called from one place in VdsUpdateRunTimeInfo to check whether the status of a VM that was in MigrationFrom status changed to Up/PoweringDown/PoweredDown/PoweringUp in the source host, which means that the migration failed and needs to be re-run. The above call was replaced with a check that the VM is not in MigrationFrom status and a call to VMStatus#isRunning - in those cases (which include WaitForLaunch + RebootInProgress in addition to the statuses mentioned above) we want the migration process to re-run. Change-Id: Iab3535e3bd6abaf61b244ac456bb93eb0218174e Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VMStatus.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsUpdateRunTimeInfo.java 2 files changed, 4 insertions(+), 10 deletions(-) Approvals: Omer Frenkel: Looks good to me, approved Arik Hadas: Verified -- To view, visit http://gerrit.ovirt.org/10978 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iab3535e3bd6abaf61b244ac456bb93eb0218174e Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com>

1 0

Change in ovirt-engine[master]: packaging: Adjust configuration when using PREFIX
by juan.hernandez＠redhat.com 15 Jan '13

15 Jan '13

Juan Hernandez has submitted this change and it was merged. Change subject: packaging: Adjust configuration when using PREFIX ...................................................................... packaging: Adjust configuration when using PREFIX When using the PREFIX make variable to install to a different directory some files that contain paths need to be updated. Change-Id: I69042e4c959a8849a370b458d2304fbf9d6ab0c4 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M .gitignore M Makefile R backend/manager/conf/engine.conf.defaults.in R backend/manager/tools/engine-tools-common/src/main/shell/engine-prolog.sh.in R packaging/fedora/engine-service.py.in M packaging/fedora/spec/ovirt-engine.spec.in 6 files changed, 63 insertions(+), 15 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/10982 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I69042e4c959a8849a370b458d2304fbf9d6ab0c4 Gerrit-PatchSet: 8 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Alex Lourie <alourie(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Ewoud Kohl van Wijngaarden <ewoud(a)kohlvanwijngaarden.nl> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com>

1 0