Change in ovirt-engine[master]: core: unlock_entity.sh fails if pwd is not...
by emesika＠redhat.com
Eli Mesika has submitted this change and it was merged.
Change subject: core: unlock_entity.sh fails if pwd is not...
......................................................................
core: unlock_entity.sh fails if pwd is not...
unlock_entity.sh script fails if executed from a directory other than
/usr/share/ovirt-engine/dbscripts
Actually, that's true for all shell scripts under dbscripts dir.
Code was changed to change to the dbscripts directory when a script
starts and restore the original directory upon script completion.
Change-Id: Iceeb2f28ce17dd117ecc2cded79077a9aca5e512
Signed-off-by: Eli Mesika <emesika(a)redhat.com>
---
M backend/manager/dbscripts/backup.sh
M backend/manager/dbscripts/create_db.sh
M backend/manager/dbscripts/create_db_devel.sh
M backend/manager/dbscripts/fkvalidator.sh
M backend/manager/dbscripts/refreshStoredProcedures.sh
M backend/manager/dbscripts/restore.sh
M backend/manager/dbscripts/unlock_entity.sh
M backend/manager/dbscripts/upgrade.sh
8 files changed, 34 insertions(+), 28 deletions(-)
Approvals:
Eli Mesika: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/11081
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Iceeb2f28ce17dd117ecc2cded79077a9aca5e512
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Michael Kublin <mkublin(a)redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>
11 years, 11 months
Change in ovirt-engine[master]: core: Fix error cause when exporting a VM with sharable disk...
by tnisan＠redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: core: Fix error cause when exporting a VM with sharable disks
......................................................................
core: Fix error cause when exporting a VM with sharable disks
Fix error caused when exporting a VM that contains sharable disks along
with regular disks, after the export an update on the VM copy in SPM
is executed and trying to get the image info of the sharable images also
and fails since they do not exist since they are not exported in the first
place
Change-Id: Ibd85529186e29f602496764687794b9075a7f84f
Bug-Url: https://bugzilla.redhat.com/885452
Signed-off-by: Tal Nisan <tnisan(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ExportVmCommand.java
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Tal Nisan: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/10977
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ibd85529186e29f602496764687794b9075a7f84f
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
11 years, 11 months
Change in ovirt-engine[master]: packaging: updated setup to fail immediately if adding host ...
by oschreib＠redhat.com
Ofer Schreiber has submitted this change and it was merged.
Change subject: packaging: updated setup to fail immediately if adding host fails
......................................................................
packaging: updated setup to fail immediately if adding host fails
* Updated retry() function in utils to recieve an Exception
that will not be ignored.
* Updated host status check with the additional Exception that
if raised will fail the setup.
Change-Id: I404af2b1702dbe5881cbd60d06a1b976b7a651a7
Signed-off-by: Alex Lourie <alourie(a)redhat.com>
---
M packaging/fedora/setup/common_utils.py
M packaging/fedora/setup/plugins/all_in_one_100.py
2 files changed, 15 insertions(+), 6 deletions(-)
Approvals:
Ofer Schreiber: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/10578
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I404af2b1702dbe5881cbd60d06a1b976b7a651a7
Gerrit-PatchSet: 7
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alex Lourie <alourie(a)redhat.com>
Gerrit-Reviewer: Alex Lourie <alourie(a)redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Moran Goldboim <mgoldboi(a)redhat.com>
Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com>
11 years, 11 months
Change in ovirt-engine[master]: core: RemoveImageCommand - avoid image staying LOCKED, rever...
by tnisan＠redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: core: RemoveImageCommand - avoid image staying LOCKED, revert to ILLEGAL
......................................................................
core: RemoveImageCommand - avoid image staying LOCKED, revert to ILLEGAL
When running remove image command, a DeleteImageGroup vdsm task is being
initiated by the engine. In case of failure or engine crash, the engine
can't tell whether the task has been initiated on vdsm side or not -
therefore the image status should be set to ILLEGAL, in the current
situation the image just stayed LOCKED.
NOTE: the lockImage() with no compensation was left in BaseImagesCommand
as it's used by commands that are being executed within transaction,
so until they will changed to be non transactive, there's no need to
start new transaction within their execution.
Change-Id: Ib5ec91a5f8b8495b8cfd11b19016fee5993644ba
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=840525
Signed-off-by: Liron Aravot <laravot(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/BaseImagesCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveImageCommand.java
2 files changed, 30 insertions(+), 16 deletions(-)
Approvals:
Tal Nisan: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/11075
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ib5ec91a5f8b8495b8cfd11b19016fee5993644ba
Gerrit-PatchSet: 6
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Liron Aravot <laravot(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
11 years, 11 months
Change in ovirt-engine[master]: Verify vdsm cluster level support before send getHardwareInf...
by yzaslavs＠redhat.com
Yair Zaslavsky has submitted this change and it was merged.
Change subject: Verify vdsm cluster level support before send getHardwareInfo request
......................................................................
Verify vdsm cluster level support before send getHardwareInfo request
Without verifying vdsm cluster support level the engine sends API
request that does not exist in vdsm. This raises exception in engine.
This path adds verification for vdsm cluster support.
Change-Id: I240786444bdf393f6df4e53daf94d0ee197ecb73
Bug-Id: https://bugzilla.redhat.com/show_bug.cgi?id=894317
Signed-off-by: Yaniv Bronhaim <ybronhei(a)redhat.com>
---
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/FeatureSupported.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsManager.java
2 files changed, 20 insertions(+), 2 deletions(-)
Approvals:
Yair Zaslavsky: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/11027
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I240786444bdf393f6df4e53daf94d0ee197ecb73
Gerrit-PatchSet: 7
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com>
Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
11 years, 11 months
Change in ovirt-engine[master]: core: VM cleanup
by ofrenkel＠redhat.com
Omer Frenkel has submitted this change and it was merged.
Change subject: core: VM cleanup
......................................................................
core: VM cleanup
- Reduce the code duplication in the constructors by replacing duplicate
code with delegations
- Replace direct assignments to fields in the constructors with calls to
setters (to make the code consistent)
- Fix typo in comment (mechanizm -> mechanism)
- Remove redundant override of hashCode method
- Move comments from private fields to their getters
- Move comment that describe Version structure to Version class
Change-Id: I833e9574d1753e03e6e5b875cbe1d2bc4de50819
Signed-off-by: Arik Hadas <ahadas(a)redhat.com>
---
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VM.java
M backend/manager/modules/compat/src/main/java/org/ovirt/engine/core/compat/Version.java
2 files changed, 36 insertions(+), 62 deletions(-)
Approvals:
Omer Frenkel: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/10991
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I833e9574d1753e03e6e5b875cbe1d2bc4de50819
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>
Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com>
11 years, 11 months
Change in ovirt-engine[master]: engine: Fixed broken imports
by tjelinek＠redhat.com
Tomas Jelinek has submitted this change and it was merged.
Change subject: engine: Fixed broken imports
......................................................................
engine: Fixed broken imports
This patch fixes broken imports introduced by commit
29887aba0ec992151c4e964fe540d3bb3532292e.
Change-Id: Idbb108755dd96752721a91cfc62fec08fe213aee
Signed-off-by: Frantisek Kobzik <fkobzik(a)redhat.com>
---
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VmBase.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/UnitVmModel.java
2 files changed, 3 insertions(+), 0 deletions(-)
Approvals:
Tomas Jelinek: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/11076
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Idbb108755dd96752721a91cfc62fec08fe213aee
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Frank Kobzik <fkobzik(a)redhat.com>
Gerrit-Reviewer: Frank Kobzik <fkobzik(a)redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>
11 years, 11 months
Change in ovirt-engine[master]: engine: VM Linux Boot options aren't parsing properly
by tjelinek＠redhat.com
Tomas Jelinek has submitted this change and it was merged.
Change subject: engine: VM Linux Boot options aren't parsing properly
......................................................................
engine: VM Linux Boot options aren't parsing properly
Steps to Reproduce:
1. have VM & init & kernel file on ISO domain
2. use Boot params => kernel/initrd params
3. put to initrd: "iso://rhel6.initrd " (without quotes, with space at the end)
After starting the VM it runs for a moment and then it crashes with VDSM error:
libvirtError('virDomainCreateXML() failed', conn=self).
Fixed by adding validation of the user input (on frontend) and setting of
VmBase parameters (on backend).
Change-Id: I9ccb4fc0b807c77bc17cfe02903341cdf4e51d54
Signed-off-by: Frantisek Kobzik <fkobzik(a)redhat.com>
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=872178
---
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VmBase.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/utils/ValidationUtils.java
M backend/manager/modules/common/src/test/java/org/ovirt/engine/core/common/utils/ValidationUtilsTest.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/VdcBllMessages.java
M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties
M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/UnitVmModel.java
A frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/validation/NoTrimmingWhitespacesValidation.java
M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/Constants.java
M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties
M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties
11 files changed, 102 insertions(+), 54 deletions(-)
Approvals:
Tomas Jelinek: Looks good to me, approved
Frank Kobzik: Verified
--
To view, visit http://gerrit.ovirt.org/9550
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I9ccb4fc0b807c77bc17cfe02903341cdf4e51d54
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Frank Kobzik <fkobzik(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Frank Kobzik <fkobzik(a)redhat.com>
Gerrit-Reviewer: Libor Spevak <lspevak(a)redhat.com>
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>
Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>
11 years, 11 months
Change in ovirt-dwh[master]: history: fixed post upgrade enum change issue
by ydary＠redhat.com
Yaniv Dary has submitted this change and it was merged.
Change subject: history: fixed post upgrade enum change issue
......................................................................
history: fixed post upgrade enum change issue
Change-Id: I9e2139f436a42135ded32e14d02687c1057e8cd3
Signed-off-by: Yaniv Dary <ydary(a)redhat.com>
---
M data-warehouse/historydbscripts_postgres/upgrade/post_upgrade/0010_change_enum_lang_code.sql
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Yaniv Dary: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/11055
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I9e2139f436a42135ded32e14d02687c1057e8cd3
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-dwh
Gerrit-Branch: master
Gerrit-Owner: Yaniv Dary <ydary(a)redhat.com>
Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com>
11 years, 11 months
Change in ovirt-engine[master]: gluster: GlusterMultipleActionRunner
by sanjal＠redhat.com
Shireesh Anjal has submitted this change and it was merged.
Change subject: gluster: GlusterMultipleActionRunner
......................................................................
gluster: GlusterMultipleActionRunner
Gluster commands always acquire a lock on the cluster. This means that
if user selects multiple objects belonging to the same cluster and
performs an action on them, all of them try to acquire a lock on the
same cluster. The logic in MultipleActionsRunner is such that
canDoActionOnly() is called for all actions first, before trying to
execute them. This can result in a deadlock as the second action will
get blocked trying to acquire lock on the same cluster, and
executeAction() will never be invoked on first action because of this.
This is seems like a gluster-specific scenario for now, hence
introducing GlusterMultipleActionsRunner that extends from
MultipleActionsRunner and alters the behavior as follows:
- Releases the lock after invoking CanDoActionOnly
- Re-acquires the lock invoking executing executeAction
Also, MultipleActionsRunnersFactory is enhanced to create and return
object of GlusterMultipleActionsRunner for gluster related actions.
Change-Id: I0e3dc1fa0b21ab6e0fcaff518bf9696f6c9796ca
Signed-off-by: Shireesh Anjal <sanjal(a)redhat.com>
---
A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GlusterMultipleActionsRunner.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MultipleActionsRunner.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MultipleActionsRunnersFactory.java
3 files changed, 126 insertions(+), 35 deletions(-)
Approvals:
Shireesh Anjal: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/10812
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I0e3dc1fa0b21ab6e0fcaff518bf9696f6c9796ca
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Shireesh Anjal <sanjal(a)redhat.com>
Gerrit-Reviewer: Michael Kublin <mkublin(a)redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>
Gerrit-Reviewer: Shireesh Anjal <sanjal(a)redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>
11 years, 11 months
