January 2013 - Engine-commits - oVirt List Archives

Change in otopi[master]: services: rhel: support upstart
by Alon Bar-Lev 10 Jan '13

10 Jan '13

Alon Bar-Lev has submitted this change and it was merged. Change subject: services: rhel: support upstart ...................................................................... services: rhel: support upstart vdsm developers moved libvirtd to upstart, it is the only service that is using upstart. The reason for this move is to provide a watch dog for restarting libvirtd service when it dies. Although it could have been implemented using various simpler methods, the upstart approach was selected. Implementation of rhel services should prefer upstart services over the sysvinit services. Change-Id: If7289ee08f8a397665e2becfadd0a32b3af167d9 Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M src/plugins/otopi/services/rhel.py 1 file changed, 82 insertions(+), 18 deletions(-) Approvals: Alon Bar-Lev: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/10894 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If7289ee08f8a397665e2becfadd0a32b3af167d9 Gerrit-PatchSet: 1 Gerrit-Project: otopi Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: add isDebugEnabled to Log class
by masayag＠redhat.com 10 Jan '13

10 Jan '13

Moti Asayag has submitted this change and it was merged. Change subject: core: add isDebugEnabled to Log class ...................................................................... core: add isDebugEnabled to Log class Add isDebugEnabled to debug methods of Log class for performance Change-Id: I14598886a3b9269d0a9b4b04febee0aa0f2eec98 Signed-off-by: Alissa Bonas <abonas(a)redhat.com> --- M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/log/Log.java 1 file changed, 6 insertions(+), 2 deletions(-) Approvals: Moti Asayag: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/10806 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I14598886a3b9269d0a9b4b04febee0aa0f2eec98 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>

1 0

Change in ovirt-engine[master]: engine: remove Config dependency from frontend
by gchaplik＠redhat.com 10 Jan '13

10 Jan '13

Gilad Chaplik has submitted this change and it was merged. Change subject: engine: remove Config dependency from frontend ...................................................................... engine: remove Config dependency from frontend The only use of class org.ovirt.engine.core.common.config.Config is to get the default configuration version. Replacing it with a static const in the client, which is fetch from server side using a new query during client init. Change-Id: I47e6f47bff95ca630f192c0b3197688c5caf2948 Signed-off-by: Gilad Chaplik <gchaplik(a)redhat.com> --- A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetDefaultConfigurationVersionQuery.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/VdcQueryType.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/dataprovider/AsyncDataProvider.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/LoginModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/SpiceConsoleModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/volumes/VolumeListModel.java M frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/section/main/presenter/AboutPopupPresenterWidget.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/presenter/AboutPopupPresenterWidget.java 8 files changed, 124 insertions(+), 56 deletions(-) Approvals: Gilad Chaplik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/10330 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I47e6f47bff95ca630f192c0b3197688c5caf2948 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: fixing NPE in CommandBase
by emesika＠redhat.com 10 Jan '13

10 Jan '13

Eli Mesika has submitted this change and it was merged. Change subject: core: fixing NPE in CommandBase ...................................................................... core: fixing NPE in CommandBase Change-Id: If3daf13b840c38567755a79b963f159d4789d441 Signed-off-by: Eli Mesika <emesika(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandBase.java 1 file changed, 2 insertions(+), 1 deletion(-) Approvals: Eli Mesika: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/10876 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If3daf13b840c38567755a79b963f159d4789d441 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: remove head leftover from AuditLogMessages
by derez＠redhat.com 10 Jan '13

10 Jan '13

Daniel Erez has submitted this change and it was merged. Change subject: core: remove head leftover from AuditLogMessages ...................................................................... core: remove head leftover from AuditLogMessages Change-Id: I0a3da0dcacee4bf033db17472785cab09dd28500 Signed-off-by: Liron Aravot <laravot(a)redhat.com> --- M backend/manager/modules/dal/src/main/resources/bundles/AuditLogMessages.properties 1 file changed, 0 insertions(+), 1 deletion(-) Approvals: Daniel Erez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/10872 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0a3da0dcacee4bf033db17472785cab09dd28500 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com>

1 0

Change in ovirt-engine[master]: packaging: Add support for SSLv3
by juan.hernandez＠redhat.com 10 Jan '13

10 Jan '13

Juan Hernandez has submitted this change and it was merged. Change subject: packaging: Add support for SSLv3 ...................................................................... packaging: Add support for SSLv3 With the current configuration when we don't use Apache as a proxy we only support TLSv1. This patch makes the set of supported protocols configurable. In order to change the configuration the user can change the ENGINE_HTTPS_PROTOCOLS parameter in /etc/sysconfig/ovirt-engine. The default is the following: ENGINE_HTTPS_PROTOCOLS=SSLv3,TLSv1,TLSv1.1,TLSv1.2 Note that SSLv2 is not implemented in OpenJDK, so it can't be enabled. Change-Id: If5f98ede332d717468bf4f55a03e38956fb8e875 Bug-Url: https://bugzilla.redhat.com/893979 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M backend/manager/conf/engine.conf.defaults M packaging/fedora/engine-service.xml.in 2 files changed, 13 insertions(+), 1 deletion(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/10858 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If5f98ede332d717468bf4f55a03e38956fb8e875 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Alex Lourie <alourie(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com>

1 0

Change in ovirt-engine[master]: packaging: Updated dropdb command with correct environment
by juan.hernandez＠redhat.com 10 Jan '13

10 Jan '13

Juan Hernandez has submitted this change and it was merged. Change subject: packaging: Updated dropdb command with correct environment ...................................................................... packaging: Updated dropdb command with correct environment Change-Id: I0889e7e2c94256a98ae341b1f8972beb482895ba Bug-Url: https://bugzilla.redhat.com/893965 Signed-off-by: Alex Lourie <alourie(a)redhat.com> --- M packaging/fedora/setup/engine-upgrade.py 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/10856 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0889e7e2c94256a98ae341b1f8972beb482895ba Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alex Lourie <alourie(a)redhat.com> Gerrit-Reviewer: Alex Lourie <alourie(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Moran Goldboim <mgoldboi(a)redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: deadlock and unneeded db/vdsm calls when creating dis...
by derez＠redhat.com 10 Jan '13

10 Jan '13

Daniel Erez has submitted this change and it was merged. Change subject: core: deadlock and unneeded db/vdsm calls when creating diskless snapshots. ...................................................................... core: deadlock and unneeded db/vdsm calls when creating diskless snapshots. This patch removes uneeded vdsm and db calls in case of an diskless snapshots and also solves a occuring deadlock. 1. No need to call endSuccesfully method when creating diskless snapshots at the moment, the call to endSuccesfully can perform uneeded vdsm call if the VM is running. 2. When creating diskless snapshot, a new transaction is opened within endSuccesfully, calling endSuccesfully in case that we already run in transaction will cause that we won't see newly added data from the new transaction and FK caused deadlock in the db, as a new snapshot that references a vm is inserted(acquires FK db lock on the vm row) and later on we try to update the same row from the newly created transaction thus creating a deadlock. Change-Id: I2ca72a2b7b881827493ddec5c53bd2c485a74084 Signed-off-by: Liron Aravot <laravot(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CreateAllSnapshotsFromVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/snapshots/SnapshotsManager.java 2 files changed, 25 insertions(+), 11 deletions(-) Approvals: Daniel Erez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/10857 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2ca72a2b7b881827493ddec5c53bd2c485a74084 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Renamed test AppErrors.properties files
by mkolesni＠redhat.com 10 Jan '13

10 Jan '13

Mike Kolesnik has submitted this change and it was merged. Change subject: core: Renamed test AppErrors.properties files ...................................................................... core: Renamed test AppErrors.properties files Since these files are only used for tests, renamed them so that there is no confusion. Change-Id: I7b503dd718252da2d331f40702123142f3e8e8d3 Signed-off-by: Mike Kolesnik <mkolesni(a)redhat.com> --- M backend/manager/modules/utils/src/test/java/org/ovirt/engine/core/utils/ErrorTranslatorTest.java R backend/manager/modules/utils/src/test/resources/TestAppErrors.properties R backend/manager/modules/utils/src/test/resources/TestAppErrors_de.properties R backend/manager/modules/utils/src/test/resources/TestAppErrors_it.properties 4 files changed, 10 insertions(+), 8 deletions(-) Approvals: Mike Kolesnik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/10859 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7b503dd718252da2d331f40702123142f3e8e8d3 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Replace test keys in AppErrors.properties
by mkolesni＠redhat.com 10 Jan '13

10 Jan '13

Mike Kolesnik has submitted this change and it was merged. Change subject: core: Replace test keys in AppErrors.properties ...................................................................... core: Replace test keys in AppErrors.properties Test keys should be used only by tests and not mimic real keys since someone could accidentally change the test key. Change-Id: I3789faa2721154a7ab31dacf0661861af5e9b4d4 Signed-off-by: Mike Kolesnik <mkolesni(a)redhat.com> --- M backend/manager/modules/utils/src/test/java/org/ovirt/engine/core/utils/ErrorTranslatorTest.java M backend/manager/modules/utils/src/test/resources/AppErrors.properties M backend/manager/modules/utils/src/test/resources/AppErrors_de.properties M backend/manager/modules/utils/src/test/resources/AppErrors_it.properties 4 files changed, 16 insertions(+), 13 deletions(-) Approvals: Mike Kolesnik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/10853 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3789faa2721154a7ab31dacf0661861af5e9b4d4 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0