January 2013 - Engine-commits - Ovirt List Archives

Change in ovirt-engine[master]: restapi: adding support for moving a VM disk

by derez＠redhat.com

Daniel Erez has submitted this change and it was merged. Change subject: restapi: adding support for moving a VM disk ...................................................................... restapi: adding support for moving a VM disk * Added move action to VmDiskResource interface. * Added the implementation in BackendVmDiskResource. * Added tests to BackendVmDiskResourceTest (similar to the tests of copy disk in BackendTemplateDiskResourceTest). * Updated rsdl yaml accordingly (similar to copy disk). * Deprecated move VM (replaced by move disk) I.e. deprecated '/api/vms/{vm:id}/move|rel=move' replaced by '/api/vms/{vm:id}/disks/{disk:id}/move|rel=move' Change-Id: I1c864a81463388f8ac82eba6f909c5a4359efab6 Bug-Url: https://bugzilla.redhat.com/883871 Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/resource/VmDiskResource.java M backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/resource/VmResource.java M backend/manager/modules/restapi/interface/definition/src/main/resources/rsdl_metadata_v-3.1.yaml M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendVmDiskResource.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendVmResource.java M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendVmDiskResourceTest.java M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendVmResourceTest.java 7 files changed, 185 insertions(+), 22 deletions(-) Approvals: Daniel Erez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/10676 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1c864a81463388f8ac82eba6f909c5a4359efab6 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com>

11 years, 9 months

1
0
0 / 0

Change in ovirt-engine[master]: restapi: copy disk - fixing rsdl and SD lookup method

by derez＠redhat.com

Daniel Erez has submitted this change and it was merged. Change subject: restapi: copy disk - fixing rsdl and SD lookup method ...................................................................... restapi: copy disk - fixing rsdl and SD lookup method * rsdl: mandatory arguments - changing to 'storagedomain.id|name' optional arguments - adding 'action.grace_period.expiry: 'xs:long' * AbstractBackendActionableResource: lookupStorageDomainIdByName - using 'GetAllStorageDomains' query instead of search to allow usage for non-admins. * BackendTemplateDiskResource: GetDiskByDiskId query for getting Disk entity. Change-Id: Ic8bea5e02d1a14599cefbeada241f132df8ccda8 Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M backend/manager/modules/restapi/interface/definition/src/main/resources/rsdl_metadata_v-3.1.yaml M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/AbstractBackendActionableResource.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendTemplateDiskResource.java M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendTemplateDiskResourceTest.java 4 files changed, 84 insertions(+), 20 deletions(-) Approvals: Daniel Erez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/10688 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic8bea5e02d1a14599cefbeada241f132df8ccda8 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com>

11 years, 9 months

1
0
0 / 0

Change in ovirt-engine[master]: core: Clean test AppErrors.properties files

by mkolesni＠redhat.com

Mike Kolesnik has submitted this change and it was merged. Change subject: core: Clean test AppErrors.properties files ...................................................................... core: Clean test AppErrors.properties files These files are used for tests and should NOT be updated when messages are added/edited, so removing translations from them except the ones used for tests. Change-Id: I035e71740629d802987ed0b4093adef2a86ed6e6 Signed-off-by: Mike Kolesnik <mkolesni(a)redhat.com> --- M backend/manager/modules/utils/src/test/resources/AppErrors.properties M backend/manager/modules/utils/src/test/resources/AppErrors_de.properties M backend/manager/modules/utils/src/test/resources/AppErrors_it.properties 3 files changed, 0 insertions(+), 608 deletions(-) Approvals: Mike Kolesnik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/10852 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I035e71740629d802987ed0b4093adef2a86ed6e6 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

11 years, 9 months

1
0
0 / 0

Change in ovirt-engine[master]: webadmin: improve behavior of bookmark list (1/2)

by gchaplik＠redhat.com

Gilad Chaplik has submitted this change and it was merged. Change subject: webadmin: improve behavior of bookmark list (1/2) ...................................................................... webadmin: improve behavior of bookmark list (1/2) This patch series fixes some problems with the behavior of the bookmark list. This patch fixes: - bookmarks would stay selected after navigating elsewhere in the UI - a selected bookmark would be de-selected when the list was updated Selections will now remain active until navigation or a search is performed. Change-Id: I21e0f807f5855f17d3549468a6ccf182156f12bb Bug-Url: https://bugzilla.redhat.com/880499 Signed-off-by: Greg Padgett <gpadgett(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/bookmarks/BookmarkListModel.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/uicommon/model/BookmarkModelProvider.java 2 files changed, 48 insertions(+), 6 deletions(-) Approvals: Gilad Chaplik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/10781 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I21e0f807f5855f17d3549468a6ccf182156f12bb Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Greg Padgett <gpadgett(a)redhat.com> Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com> Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Greg Padgett <gpadgett(a)redhat.com>

11 years, 9 months

1
0
0 / 0

Change in ovirt-engine[master]: core: DB fix duplicate prefix upgrade script

by yzaslavs＠redhat.com

Yair Zaslavsky has submitted this change and it was merged. Change subject: core: DB fix duplicate prefix upgrade script ...................................................................... core: DB fix duplicate prefix upgrade script Change-Id: Ie23330d15204173f37e986b86575cfcf14ed1b46 Signed-off-by: Eli Mesika <emesika(a)redhat.com> --- R backend/manager/dbscripts/upgrade/03_02_0320_fix_principal_name_in_users_for_ad_users 1 file changed, 0 insertions(+), 0 deletions(-) Approvals: Yair Zaslavsky: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/10860 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie23330d15204173f37e986b86575cfcf14ed1b46 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

11 years, 9 months

1
0
0 / 0

Change in ovirt-engine[master]: core:no task id in engine log for revert task

by emesika＠redhat.com

Eli Mesika has submitted this change and it was merged. Change subject: core:no task id in engine log for revert task ...................................................................... core:no task id in engine log for revert task This patch write to the log when a task is reverted by the compensation mechanism the task type and also the task id. Change-Id: Ie6a1dbeadfb512bbed81c3d2fa7e18ee4a997d92 Signed-off-by: Eli Mesika <emesika(a)redhat.com> Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=878943 --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AbstractSPMAsyncTaskHandler.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandBase.java 2 files changed, 9 insertions(+), 5 deletions(-) Approvals: Eli Mesika: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/10804 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie6a1dbeadfb512bbed81c3d2fa7e18ee4a997d92 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

11 years, 9 months

1
0
0 / 0

Change in ovirt-engine[master]: core: Fix DB storing for principal names as provided by Acti...

by yzaslavs＠redhat.com

Yair Zaslavsky has submitted this change and it was merged. Change subject: core: Fix DB storing for principal names as provided by Active-Directory ...................................................................... core: Fix DB storing for principal names as provided by Active-Directory IPA provides principal correctly (format of user@domain). AD provides only the username. We would like to present at UI in format of principal name. Since this issue may occur with other directory services, I prefered to handle this at the LdapBrokerCommandBase , regardless of provider type. The upgrade script is required to handle already existing users. Bug-Url: https://bugzilla.redhat.com/888736 Change-Id: Ia9f8b60280d76b72a26f0d1feaf2650c4ef1ce3f Signed-off-by: Yair Zaslavsky <yzaslavs(a)redhat.com> --- A backend/manager/dbscripts/upgrade/03_02_0310_fix_principal_name_in_users_for_ad_users M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/adbroker/LdapBrokerCommandBase.java 2 files changed, 5 insertions(+), 1 deletion(-) Approvals: Yair Zaslavsky: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/10844 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia9f8b60280d76b72a26f0d1feaf2650c4ef1ce3f Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

11 years, 9 months

1
0
0 / 0

Change in ovirt-engine[master]: core: add "disabled" feature to template

by ofrenkel＠redhat.com

Omer Frenkel has submitted this change and it was merged. Change subject: core: add "disabled" feature to template ...................................................................... core: add "disabled" feature to template this is the engine core implementation for disabled templates, if template is disabled, it cannot be used to create vms. Change-Id: Ia9f8b60280d76b73a26f0d5feaf6650c7ef7ce7e Signed-off-by: Omer Frenkel <ofrenkel(a)redhat.com> --- M backend/manager/dbscripts/create_views.sql A backend/manager/dbscripts/upgrade/03_02_0310_add_disabled_to_vm_static.sql M backend/manager/dbscripts/vm_templates_sp.sql M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmTemplateHandler.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VmTemplate.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/VdcBllMessages.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VmTemplateDAODbFacadeImpl.java M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ovf/OvfTemplateReader.java M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ovf/OvfTemplateWriter.java M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties 14 files changed, 42 insertions(+), 5 deletions(-) Approvals: Omer Frenkel: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/10502 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia9f8b60280d76b73a26f0d5feaf6650c7ef7ce7e Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Frank Kobzik <fkobzik(a)redhat.com> Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>

11 years, 9 months

1
0
0 / 0

Change in samples-portals[master]: python: support for oVirt SDK

by shavivi＠redhat.com

Shahar Havivi has submitted this change and it was merged. Change subject: python: support for oVirt SDK ...................................................................... python: support for oVirt SDK Change the connection with oVirt engine to work with oVirt SDK and not via direct RESTful calls Change-Id: I8ab241473b714dacdf57909e02fe1cb579c252e6 Signed-off-by: Shahar Havivi <shavivi(a)redhat.com> --- A python/OVirtDispatcher.py M python/README D python/RestClient.py D python/RestCommand.py M python/WebHandler.py 5 files changed, 139 insertions(+), 200 deletions(-) Approvals: Shahar Havivi: Verified; Looks good to me, approved Oved Ourfali: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/10624 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8ab241473b714dacdf57909e02fe1cb579c252e6 Gerrit-PatchSet: 4 Gerrit-Project: samples-portals Gerrit-Branch: master Gerrit-Owner: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com>

11 years, 9 months

1
0
0 / 0

Change in ovirt-engine[master]: packaging: Don't require Maven packages for build

by juan.hernandez＠redhat.com

Juan Hernandez has submitted this change and it was merged. Change subject: packaging: Don't require Maven packages for build ...................................................................... packaging: Don't require Maven packages for build The .spec that we use has a lot of build requirements for maven plugins. This was copied copied from the official Fedora package, but they are not needed as we don't build using mvn-rpmbuild but using plain mvn. This requirements complicate the build as it requires a lot of additional packages that then aren't used at all. Change-Id: I9c924ecc53df483976b2bc5ea1777249c120f0ff Bug-Url: https://bugzilla.redhat.com/878976 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M packaging/fedora/spec/ovirt-engine.spec.in 1 file changed, 0 insertions(+), 17 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/9400 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9c924ecc53df483976b2bc5ea1777249c120f0ff Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Alex Lourie <alourie(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>

11 years, 9 months

1
0
0 / 0

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

Engine-commits January 2013