January 2013 - Engine-commits - oVirt List Archives

Change in ovirt-engine-sdk-java[master]: sdk: change commons-beanutils from 1.8.4-SNAPSHOT to 1.8.3
by mpastern＠redhat.com 13 Jan '13

13 Jan '13

Michael Pasternak has submitted this change and it was merged. Change subject: sdk: change commons-beanutils from 1.8.4-SNAPSHOT to 1.8.3 ...................................................................... sdk: change commons-beanutils from 1.8.4-SNAPSHOT to 1.8.3 Change-Id: Ie2639e6e8877f89de03896e742636757b5d6dd25 Signed-off-by: Michael Pasternak <mpastern(a)redhat.com> --- M ovirt-engine-sdk-java/pom.xml 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Michael Pasternak: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/10937 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie2639e6e8877f89de03896e742636757b5d6dd25 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine-sdk-java Gerrit-Branch: master Gerrit-Owner: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com>

1 0

Change in ovirt-host-deploy[master]: build: improve handling .gitignore with empty lines during c...
by Alon Bar-Lev 13 Jan '13

13 Jan '13

Alon Bar-Lev has submitted this change and it was merged. Change subject: build: improve handling .gitignore with empty lines during clean ...................................................................... build: improve handling .gitignore with empty lines during clean Change-Id: I5dfa78a86585e9b885a1a8297828b9cbcd5ba0ec Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M Makefile.am 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Alon Bar-Lev: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/10936 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5dfa78a86585e9b885a1a8297828b9cbcd5ba0ec Gerrit-PatchSet: 1 Gerrit-Project: ovirt-host-deploy Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>

1 0

Change in otopi[master]: build: improve handling .gitignore with empty lines during c...
by Alon Bar-Lev 13 Jan '13

13 Jan '13

Alon Bar-Lev has submitted this change and it was merged. Change subject: build: improve handling .gitignore with empty lines during clean ...................................................................... build: improve handling .gitignore with empty lines during clean Change-Id: If2e1a256d3ee4f4806043cd7b3ab4668fd37f67a Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M Makefile.am 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Alon Bar-Lev: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/10935 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If2e1a256d3ee4f4806043cd7b3ab4668fd37f67a Gerrit-PatchSet: 1 Gerrit-Project: otopi Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Replace ImagesHandler#isVmDown method
by ofrenkel＠redhat.com 13 Jan '13

13 Jan '13

Omer Frenkel has submitted this change and it was merged. Change subject: core: Replace ImagesHandler#isVmDown method ...................................................................... core: Replace ImagesHandler#isVmDown method Replace ImagesHandler#isVmDown method with VM#isDown method. ImagesHander is not the place for utility method that checks VM status. VM status is a property of VM, thus VM instance should be able to express whether it's down or not, passing a VM instance to another class in order to check its status doesn't make sense. Change-Id: I3f15c8b9a307d5ecb239750dbdbac3faea7b802a Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CreateAllSnapshotsFromVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImagesHandler.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VM.java 3 files changed, 13 insertions(+), 9 deletions(-) Approvals: Omer Frenkel: Looks good to me, approved Arik Hadas: Verified -- To view, visit http://gerrit.ovirt.org/10779 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3f15c8b9a307d5ecb239750dbdbac3faea7b802a Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Root and Frontend maven poms cleanup
by asaf＠redhat.com 13 Jan '13

13 Jan '13

Asaf Shakarchi has submitted this change and it was merged. Change subject: core: Root and Frontend maven poms cleanup ...................................................................... core: Root and Frontend maven poms cleanup - Moved gwt plugin repo from frontend module into root pom - Description changes to modules description tag - Organized project properties into sections with comments. Change-Id: I4fb4647e0d704fc6c2bece9b1b7ea42ea53fac15 Signed-off-by: Asaf Shakarchi <asaf(a)redhat.com> --- M frontend/pom.xml M frontend/webadmin/pom.xml M pom.xml 3 files changed, 22 insertions(+), 16 deletions(-) Approvals: Asaf Shakarchi: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/10245 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4fb4647e0d704fc6c2bece9b1b7ea42ea53fac15 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Asaf Shakarchi <asaf(a)redhat.com> Gerrit-Reviewer: Asaf Shakarchi <asaf(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: fix changing a VM cluster
by rgolan＠redhat.com 13 Jan '13

13 Jan '13

Roy Golan has submitted this change and it was merged. Change subject: core: fix changing a VM cluster ...................................................................... core: fix changing a VM cluster Due to the latest refactoring of VM entity the check for updating vds_group_id in ChangeVmClusterCommand is no longer valid. Modified vds_group_id vdsGroupId. Verified with DOWN VMs. TODO the weak implementation of VMHandler should be changed. Change-Id: I3a92158800571358bf59f15972f811f7c0e9d3fe Signed-off-by: Roy Golan <rgolan(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ChangeVMClusterCommand.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Roy Golan: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/10926 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3a92158800571358bf59f15972f811f7c0e9d3fe Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com>

1 0

Change in ovirt-engine-sdk-java[master]: sdk: add <scm> meta to pom
by mpastern＠redhat.com 13 Jan '13

13 Jan '13

Michael Pasternak has submitted this change and it was merged. Change subject: sdk: add <scm> meta to pom ...................................................................... sdk: add <scm> meta to pom Change-Id: Ic3b769455dc76cb06ffc1ccb25cff500a33eb00d Signed-off-by: Michael Pasternak <mpastern(a)redhat.com> --- M ovirt-engine-sdk-java/pom.xml 1 file changed, 5 insertions(+), 0 deletions(-) Approvals: Michael Pasternak: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/10931 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic3b769455dc76cb06ffc1ccb25cff500a33eb00d Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine-sdk-java Gerrit-Branch: master Gerrit-Owner: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com>

1 0

Change in ovirt-engine[master]: engine: Removed duplicate repo definition in webadmin root p...
by asaf＠redhat.com 13 Jan '13

13 Jan '13

Asaf Shakarchi has submitted this change and it was merged. Change subject: engine: Removed duplicate repo definition in webadmin root pom ...................................................................... engine: Removed duplicate repo definition in webadmin root pom Removed duplicate repo definitio in webadmin root pom Change-Id: If1bc90db3a71d0de6152cc5fe4dc3c115f20fe93 Signed-off-by: Asaf Shakarchi <asaf(a)redhat.com> --- M frontend/webadmin/modules/pom.xml 1 file changed, 0 insertions(+), 10 deletions(-) Approvals: Asaf Shakarchi: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/10239 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If1bc90db3a71d0de6152cc5fe4dc3c115f20fe93 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Asaf Shakarchi <asaf(a)redhat.com> Gerrit-Reviewer: Asaf Shakarchi <asaf(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: fixing dual PM handling code
by emesika＠redhat.com 13 Jan '13

13 Jan '13

Eli Mesika has submitted this change and it was merged. Change subject: core: fixing dual PM handling code ...................................................................... core: fixing dual PM handling code This patch changes the executor assignment in the run method to this.executor as it should be. The local parameter masks the class variable and it is not used correctly when waitForStatus is called without this change. this patch is mandatory for RFE https://bugzilla.redhat.com/show_bug.cgi?id=773108 Change-Id: I0366b9615739f5e76b14beef5bc996645ee4f15b Signed-off-by: Eli Mesika <emesika(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/FenceVdsBaseCommand.java 1 file changed, 3 insertions(+), 3 deletions(-) Approvals: Eli Mesika: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/10807 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0366b9615739f5e76b14beef5bc996645ee4f15b Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: fix drop old uuid functions for pg9.x
by emesika＠redhat.com 13 Jan '13

13 Jan '13

Eli Mesika has submitted this change and it was merged. Change subject: core: fix drop old uuid functions for pg9.x ...................................................................... core: fix drop old uuid functions for pg9.x In pg9.x we can not drop the functions without dropping first the extension (uuid-ossp) This patch adds a DROP EXTENSION of uuid-ossp for pg 9.x Change-Id: I45ecf68b27cc04d4592b30e23c774b87e451cabc Signed-off-by: Eli Mesika <emesika(a)redhat.com> --- M backend/manager/dbscripts/drop_old_uuid_functions.sql 1 file changed, 26 insertions(+), 11 deletions(-) Approvals: Eli Mesika: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/10778 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I45ecf68b27cc04d4592b30e23c774b87e451cabc Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0