January 2013 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: core: Upgrade from 3.1 to 3.2 fails : upgrade...
by emesika＠redhat.com 30 Jan '13

30 Jan '13

Eli Mesika has submitted this change and it was merged. Change subject: core: Upgrade from 3.1 to 3.2 fails : upgrade... ...................................................................... core: Upgrade from 3.1 to 3.2 fails : upgrade... Upgrade from 3.1 to 3.2 fails : upgrade 03_01_1470_add_smartcard.sql is not being installed This bug is a result of the following: 1) 03_02_0080_add_user_vm_manager_to_vm_power_users.sql was originally named 03_01_1470_add_user_vm_manager_to_vm_power_users.sql 2) some installations already installed it as 03_01_1470 3)03_01_1470_add_user_vm_manager_to_vm_power_users.sql was renamed to 03_02_0080_add_user_vm_manager_to_vm_power_users.sql 4)03_01_1470_add_smartcard.sql was added 5)upon upgrade 03_01_1470_add_smartcard.sql will not installed because 03_01_1470_add_user_vm_manager_to_vm_power_users.sql was already installed Solution is to copy 03_01_1470_add_smartcard.sql to 03_01_1540_fix_add_smartcard.sql This will solve the problem in all the possible cases 1) Clean install : only 03_01_1470_add_smartcard.sql will be installed 03_01_1540_fix_add_smartcard.sql will be skipped since it has an identical md5 2) Upgrade on a DB that already has 03_01_1470_add_user_vm_manager_to_vm_power_users.sql: In this case 03_01_1540_fix_add_smartcard.sql will be installed and 03_02_0080_add_user_vm_manager_to_vm_power_users.sql will be skipped since it has the same md5 as the installed one. 3) upgrade on a DB that has the correct 03_01_1470_add_smartcard.sql : In this case 03_01_1540_fix_add_smartcard.sql will be skipped since it has the same md5 as the original Change-Id: I5e827d5b684459703315c5ecc46c1142a58d8e84 Signed-off-by: Eli Mesika <emesika(a)redhat.com> Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=903604 --- A backend/manager/dbscripts/upgrade/03_01_1540_add_smartcard.sql 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Eli Mesika: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/11382 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5e827d5b684459703315c5ecc46c1142a58d8e84 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Fixing duplicate scripts recognition
by emesika＠redhat.com 30 Jan '13

30 Jan '13

Eli Mesika has submitted this change and it was merged. Change subject: core: Fixing duplicate scripts recognition ...................................................................... core: Fixing duplicate scripts recognition The upgrade utility should recognize that a script was installed before with a different prefix in order to only record it an skip its execution. This is done by recording in the database the md5 for each upgrade script so if a script is already installed and have the current script md5 , the new script will be recorded to the schema_version with a SKIPPED state and a comment saying which is the script that was already installed the contained code. This functionality of the upgrade utility was broken as a result of the following commit : 38e8f8aae8b4a92e6c191ca1d4df1b54eae581f2 This fix is mandatory for fixing the original bug and therefor ordered as a pre-patch of it. As a result of this change the following fix has been reverted: "When running create_db.sh scripts 03_00_0420 and beyond are executed but not inserted to the schema_version table. This is caused to a race since execute_command is running in a loop and creates a temporary file in each iteration. Solution is to gather all inserts in one file and execute them at once." Since this is just a problem with the logging to schema_version table and the scripts are executed correctly I am reverting this fix since the problem caused by it is much higher than the minor lack of recorded data. Change-Id: I2e887acc0e3bb266354af2ac5e77e5aec8537454 Signed-off-by: Eli Mesika <emesika(a)redhat.com> Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=903604 --- M backend/manager/dbscripts/dbfunctions.sh 1 file changed, 1 insertion(+), 3 deletions(-) Approvals: Eli Mesika: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/11381 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2e887acc0e3bb266354af2ac5e77e5aec8537454 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: create prop in frontend pom for engine core
by tnisan＠redhat.com 30 Jan '13

30 Jan '13

Tal Nisan has submitted this change and it was merged. Change subject: core: create prop in frontend pom for engine core ...................................................................... core: create prop in frontend pom for engine core Create a property "engine.core.groupId" in frontend pom and use it in all inheriting poms instead of using hardcoded string for group id "org.ovirt.engine.core" The change allows more clear use(reuse) of a package name and will also allow more easy refactoring/renaming if such occurs in the future Similar to using engine.version constant for example... Change-Id: I06b4e2886196ae4fdb7580033a83ec651adf1b11 Signed-off-by: Alissa Bonas <abonas(a)redhat.com> --- M frontend/pom.xml M frontend/wars/rmw-war/pom.xml M frontend/webadmin/modules/frontend/pom.xml M frontend/webadmin/modules/gwt-extension/pom.xml M frontend/webadmin/modules/uicommonweb/pom.xml M frontend/webadmin/modules/uicompat/pom.xml M frontend/webadmin/modules/userportal-gwtp/pom.xml M frontend/webadmin/modules/webadmin/pom.xml 8 files changed, 14 insertions(+), 13 deletions(-) Approvals: Tal Nisan: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/11365 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I06b4e2886196ae4fdb7580033a83ec651adf1b11 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com> Gerrit-Reviewer: Laszlo Hornyak <lhornyak(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin: [RFE] Display Address Override
by tjelinek＠redhat.com 30 Jan '13

30 Jan '13

Tomas Jelinek has submitted this change and it was merged. Change subject: webadmin: [RFE] Display Address Override ...................................................................... webadmin: [RFE] Display Address Override Detailed description: http://wiki.ovirt.org/wiki/Features/Display_Address_Override The following gui changes has been introduced: - Enriched the HostPopupView by a Console side tab in which the display address override is defined (a checkbox which enables it and a text field with hostname or ip validation to actually define it) - General subtab of the Cluster main tab enriched by a warning message which is shown when some hosts in the cluster overrides the display address and some not - Hosts subtab of the Cluster main tab enriched by a column which shows if the specific host has or has not overridden the console address This patch also extracts the InLineAlertWidget (the warning from the General subtab of the Hosts main tab) to a standalone reusable class. Change-Id: I47674a1ecde457c51934e8ad262639567902a9be Signed-off-by: Tomas Jelinek <tjelinek(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/CommonApplicationTemplates.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/presenter/AbstractSubTabPresenter.java A frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/editor/EntityModelCheckBoxOnlyEditor.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/AbstractVmPopupWidget.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/pool/PoolEditPopupWidget.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/pool/PoolNewPopupWidget.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/template/TemplateNewPopupWidget.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/vm/VmClonePopupWidget.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/vm/VmDesktopNewPopupWidget.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/vm/VmServerNewPopupWidget.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/clusters/ClusterGeneralModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/validation/IValidation.java M frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/section/main/view/popup/template/TemplateNewPopupView.java M frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/section/main/view/popup/vm/VmClonePopupView.java M frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/section/main/view/popup/vm/VmDesktopNewPopupView.java M frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/section/main/view/popup/vm/VmServerNewPopupView.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/ApplicationConstants.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/ApplicationTemplates.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/presenter/popup/host/HostPopupPresenterWidget.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/presenter/tab/cluster/SubTabClusterGeneralPresenter.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/HostPopupView.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/HostPopupView.ui.xml M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/pool/PoolEditPopupView.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/pool/PoolNewPopupView.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/template/TemplateNewPopupView.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/vm/VmClonePopupView.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/vm/VmDesktopNewPopupView.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/vm/VmServerNewPopupView.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/cluster/SubTabClusterGeneralView.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/cluster/SubTabClusterGeneralView.ui.xml M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/cluster/SubTabClusterHostView.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/host/SubTabHostGeneralView.java A frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/alert/InLineAlertWidget.java 35 files changed, 346 insertions(+), 111 deletions(-) Approvals: Tomas Jelinek: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/9023 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I47674a1ecde457c51934e8ad262639567902a9be Gerrit-PatchSet: 9 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Frank Kobzik <fkobzik(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>

1 0

Change in ovirt-engine[master]: engine: Added IsDisplayAddressConsistentInClusterQuery
by ofrenkel＠redhat.com 30 Jan '13

30 Jan '13

Omer Frenkel has submitted this change and it was merged. Change subject: engine: Added IsDisplayAddressConsistentInClusterQuery ...................................................................... engine: Added IsDisplayAddressConsistentInClusterQuery This query returns true if the display address is overridden for some hosts in a cluster and for some not. Returns false othervise. It is needed by the http://wiki.ovirt.org/Features/Display_Address_Override to avoid this calculation on the frontend. Change-Id: I1955c35a3739680f6f80c9e8b29a21a14c5b8b7a Signed-off-by: Tomas Jelinek <tjelinek(a)redhat.com> --- A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/IsDisplayAddressConsistentInClusterQuery.java A backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/IsDisplayAddressConsistentInClusterQueryTest.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/VdcQueryType.java 3 files changed, 195 insertions(+), 0 deletions(-) Approvals: Tomas Jelinek: Verified Gilad Chaplik: Looks good to me, but someone else must approve Omer Frenkel: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/11375 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1955c35a3739680f6f80c9e8b29a21a14c5b8b7a Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>

1 0

Change in ovirt-engine-sdk-java[master]: sdk: release 1.0.0.3-1
by mpastern＠redhat.com 30 Jan '13

30 Jan '13

Michael Pasternak has submitted this change and it was merged. Change subject: sdk: release 1.0.0.3-1 ...................................................................... sdk: release 1.0.0.3-1 added -1 suffix to comply with previous releases Change-Id: Ib2d4869b66778bfeb88405768f3d1a349eba4b27 Signed-off-by: Michael Pasternak <mpastern(a)redhat.com> --- M ovirt-engine-sdk-java/pom.xml 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Michael Pasternak: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/11540 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib2d4869b66778bfeb88405768f3d1a349eba4b27 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine-sdk-java Gerrit-Branch: master Gerrit-Owner: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com>

1 0

Change in ovirt-engine-sdk-java[master]: sdk: release 1.0.0.3-1
by mpastern＠redhat.com 30 Jan '13

30 Jan '13

Michael Pasternak has submitted this change and it was merged. Change subject: sdk: release 1.0.0.3-1 ...................................................................... sdk: release 1.0.0.3-1 - added persistent authentication support - added support for the method overloads based on url/headers params - added delete methods overloads with body as parameters holder - to host added overidable [display.address] property - user can specify own ticket now in vm.ticket() via [action.ticket.value] Change-Id: I26bc882e7b0302be0740030aa1f56deba039ae6a Signed-off-by: Michael Pasternak <mpastern(a)redhat.com> --- M ovirt-engine-sdk-java/pom.xml 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Michael Pasternak: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/11539 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I26bc882e7b0302be0740030aa1f56deba039ae6a Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine-sdk-java Gerrit-Branch: master Gerrit-Owner: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com>

1 0

Change in ovirt-engine-sdk-java[master]: sdk: regenerate against latest api
by mpastern＠redhat.com 30 Jan '13

30 Jan '13

Michael Pasternak has submitted this change and it was merged. Change subject: sdk: regenerate against latest api ...................................................................... sdk: regenerate against latest api - to host added overidable [display.address] property - user can specify own ticket now in vm.ticket() via [action.ticket.value] Change-Id: Ia313cbaedba5ac0a4ff8d68c88efbda987d7f5d7 Signed-off-by: Michael Pasternak <mpastern(a)redhat.com> --- M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/Host.java M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/Hosts.java M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/VM.java M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/entities/Hook.java M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/entities/Host.java M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/entities/ObjectFactory.java 6 files changed, 1,482 insertions(+), 1,399 deletions(-) Approvals: Michael Pasternak: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/11538 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia313cbaedba5ac0a4ff8d68c88efbda987d7f5d7 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine-sdk-java Gerrit-Branch: master Gerrit-Owner: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com>

1 0

Change in ovirt-engine-sdk-java[master]: codegen: refactor DeleteMethodTemplate
by mpastern＠redhat.com 30 Jan '13

30 Jan '13

Michael Pasternak has submitted this change and it was merged. Change subject: codegen: refactor DeleteMethodTemplate ...................................................................... codegen: refactor DeleteMethodTemplate refactor DeleteMethodTemplate to include private use-case of delete - DeleteMethodWithBodyTemplate. Change-Id: I07d65aae848d2961cd1d11d14b2acb955444acb4 Signed-off-by: Michael Pasternak <mpastern(a)redhat.com> --- M ovirt-engine-sdk-java-codegen/src/main/java/org/ovirt/engine/sdk/codegen/rsdl/RsdlCodegen.java M ovirt-engine-sdk-java-codegen/src/main/java/org/ovirt/engine/sdk/codegen/templates/DeleteMethodTemplate.java M ovirt-engine-sdk-java-codegen/src/main/java/org/ovirt/engine/sdk/codegen/templates/DeleteMethodWithBodyTemplate.java 3 files changed, 55 insertions(+), 52 deletions(-) Approvals: Michael Pasternak: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/11535 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I07d65aae848d2961cd1d11d14b2acb955444acb4 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine-sdk-java Gerrit-Branch: master Gerrit-Owner: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com>

1 0

Change in ovirt-engine[master]: engineencryptutils: test: add encrypt/decrypt test
by yzaslavs＠redhat.com 30 Jan '13

30 Jan '13

Yair Zaslavsky has submitted this change and it was merged. Change subject: engineencryptutils: test: add encrypt/decrypt test ...................................................................... engineencryptutils: test: add encrypt/decrypt test Change-Id: Ia0e623ac0d88a2244c49173f76afa454f39090e3 Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M backend/manager/modules/engineencryptutils/src/test/java/org/ovirt/engine/core/engineencryptutils/EncryptionUtilsTest.java A backend/manager/modules/engineencryptutils/src/test/resources/key.p12 2 files changed, 66 insertions(+), 0 deletions(-) Approvals: Yair Zaslavsky: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/11498 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia0e623ac0d88a2244c49173f76afa454f39090e3 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0