Change in ovirt-engine[master]: engineencryptutils: cleanup
by yzaslavs＠redhat.com
Yair Zaslavsky has submitted this change and it was merged.
Change subject: engineencryptutils: cleanup
......................................................................
engineencryptutils: cleanup
Remove dead code.
Remove redundant variables.
Rework to reach somewhat similar structure between functions.
Remove the use of StringHelper.
Not that the result is good... but at least something in the right way.
Change-Id: I9c1004e42ee92347cbf97011e3216a1ac5c23173
Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com>
---
M backend/manager/modules/engineencryptutils/pom.xml
M backend/manager/modules/engineencryptutils/src/main/java/org/ovirt/engine/core/engineencryptutils/EncryptionUtils.java
2 files changed, 20 insertions(+), 114 deletions(-)
Approvals:
Yair Zaslavsky: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/11497
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I9c1004e42ee92347cbf97011e3216a1ac5c23173
Gerrit-PatchSet: 6
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>
11 years, 2 months
Change in ovirt-engine[master]: compat: remove unsafe and unneeded Encoding class
by yzaslavs＠redhat.com
Yair Zaslavsky has submitted this change and it was merged.
Change subject: compat: remove unsafe and unneeded Encoding class
......................................................................
compat: remove unsafe and unneeded Encoding class
Left over from legacy code.
Base64 usage is thread unsafe.
String usage is not required.
Change-Id: Ie7a540d9c69b55ce8431839c1164927024161d30
Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com>
---
M backend/manager/modules/compat/pom.xml
D backend/manager/modules/compat/src/main/java/org/ovirt/engine/core/compat/Encoding.java
M backend/manager/modules/compat/src/main/java/org/ovirt/engine/core/compat/backendcompat/XmlTextWriter.java
D backend/manager/modules/compat/src/test/java/org/ovirt/engine/core/compat/EncodingTest.java
M backend/manager/modules/engineencryptutils/pom.xml
M backend/manager/modules/engineencryptutils/src/main/java/org/ovirt/engine/core/engineencryptutils/EncryptionUtils.java
M backend/manager/modules/utils/pom.xml
M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/Ticketing.java
M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ovf/OvfWriter.java
9 files changed, 24 insertions(+), 111 deletions(-)
Approvals:
Yair Zaslavsky: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/11495
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ie7a540d9c69b55ce8431839c1164927024161d30
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>
11 years, 2 months
Change in ovirt-engine[master]: packaging: compress log files using xz
by juan.hernandez＠redhat.com
Juan Hernandez has submitted this change and it was merged.
Change subject: packaging: compress log files using xz
......................................................................
packaging: compress log files using xz
Compress logs using xz instead of gzip -9.
Change-Id: I2487d1a2505a43aa525b8d0d7af3557ce357d685
Bug-Url: https://bugzilla.redhat.com/889795
Signed-off-by: Greg Padgett <gpadgett(a)redhat.com>
---
M packaging/fedora/spec/ovirt-engine.spec.in
M packaging/resources/ovirtlogrot.sh
2 files changed, 7 insertions(+), 6 deletions(-)
Approvals:
Juan Hernandez: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/11508
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I2487d1a2505a43aa525b8d0d7af3557ce357d685
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Greg Padgett <gpadgett(a)redhat.com>
Gerrit-Reviewer: Alex Lourie <alourie(a)redhat.com>
Gerrit-Reviewer: Greg Padgett <gpadgett(a)redhat.com>
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Kiril Nesenko <knesenko(a)redhat.com>
Gerrit-Reviewer: Laszlo Hornyak <lhornyak(a)redhat.com>
Gerrit-Reviewer: Moran Goldboim <mgoldboi(a)redhat.com>
11 years, 2 months
Change in ovirt-engine[master]: tests: fix MoveDisksCommandTest for vmNotInPreview
by derez＠redhat.com
Daniel Erez has submitted this change and it was merged.
Change subject: tests: fix MoveDisksCommandTest for vmNotInPreview
......................................................................
tests: fix MoveDisksCommandTest for vmNotInPreview
In this patch:
* fix the MoveDisksCommandTest that were failing during the
vmNotInPreview validation
* add a new canDoActionVmInPreview test to verify the vmNotInPreview
validation
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=865021
Change-Id: I79a5c0e519f70d887d0f84017d870c4c475ea8e9
Signed-off-by: Federico Simoncelli <fsimonce(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MoveDisksCommand.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/MoveDisksCommandTest.java
2 files changed, 42 insertions(+), 2 deletions(-)
Approvals:
Federico Simoncelli: Verified
Daniel Erez: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/11510
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I79a5c0e519f70d887d0f84017d870c4c475ea8e9
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
11 years, 2 months
Change in otopi[master]: dialog: support template hint for queryString
by Alon Bar-Lev
Alon Bar-Lev has submitted this change and it was merged.
Change subject: dialog: support template hint for queryString
......................................................................
dialog: support template hint for queryString
Change-Id: Ia204c59e9b553a4b6b76f40b7b1d4d2c55bd19cb
Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com>
---
M src/otopi/dialog.py
M src/plugins/otopi/dialog/human.py
M src/plugins/otopi/dialog/machine.py
3 files changed, 53 insertions(+), 13 deletions(-)
Approvals:
Alon Bar-Lev: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/11524
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ia204c59e9b553a4b6b76f40b7b1d4d2c55bd19cb
Gerrit-PatchSet: 1
Gerrit-Project: otopi
Gerrit-Branch: master
Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>
11 years, 2 months
Change in otopi[master]: dialog: support case insensitive queryString
by Alon Bar-Lev
Alon Bar-Lev has submitted this change and it was merged.
Change subject: dialog: support case insensitive queryString
......................................................................
dialog: support case insensitive queryString
Change-Id: I99c56db902b7d47a6523b126463f54ef5b305738
Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com>
---
M src/otopi/dialog.py
M src/plugins/otopi/dialog/human.py
M src/plugins/otopi/dialog/machine.py
3 files changed, 14 insertions(+), 0 deletions(-)
Approvals:
Alon Bar-Lev: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/11523
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I99c56db902b7d47a6523b126463f54ef5b305738
Gerrit-PatchSet: 1
Gerrit-Project: otopi
Gerrit-Branch: master
Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>
11 years, 2 months
Change in otopi[master]: dialog: cli: perform dialog at lowest priority
by Alon Bar-Lev
Alon Bar-Lev has submitted this change and it was merged.
Change subject: dialog: cli: perform dialog at lowest priority
......................................................................
dialog: cli: perform dialog at lowest priority
This gives a chance for other common plugins to
manage environment before cli.
Change-Id: If5e857dd3216f273cc1f73a333febf24eddcde53
Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com>
---
M src/plugins/otopi/dialog/cli.py
1 file changed, 2 insertions(+), 0 deletions(-)
Approvals:
Alon Bar-Lev: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/11522
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: If5e857dd3216f273cc1f73a333febf24eddcde53
Gerrit-PatchSet: 1
Gerrit-Project: otopi
Gerrit-Branch: master
Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>
11 years, 2 months
Change in otopi[master]: core: logging: prefix all logs with 'otopi.'
by Alon Bar-Lev
Alon Bar-Lev has submitted this change and it was merged.
Change subject: core: logging: prefix all logs with 'otopi.'
......................................................................
core: logging: prefix all logs with 'otopi.'
This is needed so that external implementations will use the same
log hierarchy.
Change-Id: I46329f3e85eafeb01e3234dfc177168fb487c2b4
Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com>
---
M src/otopi/base.py
1 file changed, 8 insertions(+), 1 deletion(-)
Approvals:
Alon Bar-Lev: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/11518
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I46329f3e85eafeb01e3234dfc177168fb487c2b4
Gerrit-PatchSet: 2
Gerrit-Project: otopi
Gerrit-Branch: master
Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>
11 years, 2 months
Change in otopi[master]: core: plugin: add environment append to execute
by Alon Bar-Lev
Alon Bar-Lev has submitted this change and it was merged.
Change subject: core: plugin: add environment append to execute
......................................................................
core: plugin: add environment append to execute
Change-Id: I9e62ed1f47a2ed4d4660b90c6222bfe0a3e8b4a6
Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com>
---
M src/otopi/plugin.py
1 file changed, 9 insertions(+), 0 deletions(-)
Approvals:
Alon Bar-Lev: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/11517
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I9e62ed1f47a2ed4d4660b90c6222bfe0a3e8b4a6
Gerrit-PatchSet: 2
Gerrit-Project: otopi
Gerrit-Branch: master
Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>
11 years, 2 months
Change in otopi[master]: core: filetransaction: return original file name if content ...
by Alon Bar-Lev
Alon Bar-Lev has submitted this change and it was merged.
Change subject: core: filetransaction: return original file name if content is same
......................................................................
core: filetransaction: return original file name if content is same
Change-Id: I64aa6db80f4804fc2b0ec88a8757430966e15659
Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com>
---
M src/otopi/filetransaction.py
1 file changed, 7 insertions(+), 4 deletions(-)
Approvals:
Alon Bar-Lev: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/11516
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I64aa6db80f4804fc2b0ec88a8757430966e15659
Gerrit-PatchSet: 2
Gerrit-Project: otopi
Gerrit-Branch: master
Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>
11 years, 2 months