Change in ovirt-engine[master]: engine: Delete disk permissions when disk is deleted
by derez＠redhat.com
Daniel Erez has submitted this change and it was merged.
Change subject: engine: Delete disk permissions when disk is deleted
......................................................................
engine: Delete disk permissions when disk is deleted
The patch assures that permissions set for a delete disk
are being deleted as well.
Change-Id: I71210a641e21c211fce106096742bd72cf37c150
Bug-Url: http://bugzilla.redhat.com/892642
Signed-off-by: Moti Asayag <masayag(a)redhat.com>
---
M backend/manager/dbscripts/base_disks_sp.sql
1 file changed, 3 insertions(+), 0 deletions(-)
Approvals:
Daniel Erez: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/10798
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I71210a641e21c211fce106096742bd72cf37c150
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
11 years, 9 months
Change in ovirt-engine[master]: engine: Fixed version check issue
by emesika＠redhat.com
Eli Mesika has submitted this change and it was merged.
Change subject: engine: Fixed version check issue
......................................................................
engine: Fixed version check issue
Change-Id: I0bc95eed3fd8258a431b549e4be7fae77c1ffe8e
Signed-off-by: Dhandapani <dgopal(a)redhat.com>
---
M backend/manager/dbscripts/common_sp.sql
1 file changed, 3 insertions(+), 3 deletions(-)
Approvals:
Eli Mesika: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/10613
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I0bc95eed3fd8258a431b549e4be7fae77c1ffe8e
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Dhandapani Gopal <dgopal(a)redhat.com>
Gerrit-Reviewer: Dhandapani Gopal <dgopal(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
11 years, 9 months
Change in ovirt-engine[master]: restapi: Added detach only options on VM remove
by tnisan＠redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: restapi: Added detach only options on VM remove
......................................................................
restapi: Added detach only options on VM remove
Change-Id: Id5ba4a2cec3184340bc302558cad3a0bfea0c7ac
Signed-off-by: Tal Nisan <tnisan(a)redhat.com>
---
M backend/manager/modules/restapi/interface/definition/src/main/resources/api.xsd
M backend/manager/modules/restapi/interface/definition/src/main/resources/rsdl_metadata_v-3.1.yaml
M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendVmsResource.java
M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendVmsResourceTest.java
4 files changed, 28 insertions(+), 7 deletions(-)
Approvals:
Tal Nisan: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/10682
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Id5ba4a2cec3184340bc302558cad3a0bfea0c7ac
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com>
Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com>
Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
11 years, 9 months
Change in ovirt-reports[master]: reports: fixed exception in certain locales
by ydary＠redhat.com
Yaniv Dary has submitted this change and it was merged.
Change subject: reports: fixed exception in certain locales
......................................................................
reports: fixed exception in certain locales
This was because toLocalizedPattern was used that changed
pattern to problematic localized pattern that was to be printed
and not used.
Change-Id: Ic8c23e8a16f3cb92514d1d7c12c63628e8a420e2
Signed-off-by: Yaniv Dary <ydary(a)redhat.com>
---
M reports/repository_files/resources/Reports/Inventory/Hosts_Inventory_files/Hosts_Inventory_jrxml.data
M reports/repository_files/resources/Reports/Inventory/VM_Inventory_files/VM_Inventory_jrxml.data
M reports/repository_files/resources/Reports/Inventory/ccp_vm_inventory_br44_files/ccp_vm_inventory_br44_jrxml.data
M reports/repository_files/resources/Reports/Inventory/storage_domains_inventory_br47_files/storage_domains_inventory_br47_jrxml.data
4 files changed, 8 insertions(+), 8 deletions(-)
Approvals:
Yaniv Dary: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/10802
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ic8c23e8a16f3cb92514d1d7c12c63628e8a420e2
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-reports
Gerrit-Branch: master
Gerrit-Owner: Yaniv Dary <ydary(a)redhat.com>
Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com>
11 years, 9 months
Change in ovirt-engine[master]: core: DB 3.0 to 3.1 upgrade
by emesika＠redhat.com
Eli Mesika has submitted this change and it was merged.
Change subject: core: DB 3.0 to 3.1 upgrade
......................................................................
core: DB 3.0 to 3.1 upgrade
This patch fixes the following errors
1) psql:upgrade/03_01_0410_remove_image_templates_table.sql:2: ERROR:
constraint "image_templates_images" of relation "images" does not exist
2)psql:upgrade/03_01_0950_add_permissions_on_storage_to_users.sql:122:
ERROR: duplicate key value violates unique constraint
"idx_combined_ad_role_object"
1) was solved by adding two functions fn_db_add/drop_constraint that
checks if constraint not exists/exists before attempting to add/drop it
Then all upgrade scripts adding/dropping table constraints were modified
to use those safe functions, this will ensure that in the next round we
will not got this type of errors anymore.
2) was solved by adding a missing check for duplicate key.
All changes are safe and not change functionality.
Change-Id: I7d0a37abb58f080338b3161d0694c8ba30217d99
Signed-off-by: Eli Mesika <emesika(a)redhat.com>
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=892532
---
M backend/manager/dbscripts/common_sp.sql
M backend/manager/dbscripts/upgrade/03_01_0100_migrate_templates_to_vm_static.sql
M backend/manager/dbscripts/upgrade/03_01_0300_vds_static_unique_fields.sql
M backend/manager/dbscripts/upgrade/03_01_0410_remove_image_templates_table.sql
M backend/manager/dbscripts/upgrade/03_01_0430_add_image_domain_map_table.sql
M backend/manager/dbscripts/upgrade/03_01_0500_add_unique_name_constraint.sql
M backend/manager/dbscripts/upgrade/03_01_0720_remove_unused_images_columns.sql
M backend/manager/dbscripts/upgrade/03_01_0950_add_permissions_on_storage_to_users.sql
M backend/manager/dbscripts/upgrade/03_01_1090_gluster_brick_option_id.sql
M backend/manager/dbscripts/upgrade/03_01_1260_remove_time_lease_vm_pool_map_table.sql
M backend/manager/dbscripts/upgrade/03_01_1520_add_fk_vm_interface_vm_static_template.sql
M backend/manager/dbscripts/upgrade/03_02_0270_gluster_volume_name_unique_constraint.sql
12 files changed, 52 insertions(+), 32 deletions(-)
Approvals:
Eli Mesika: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/10735
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I7d0a37abb58f080338b3161d0694c8ba30217d99
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>
11 years, 9 months
Change in ovirt-engine[master]: core: fixes to import/OvfDataUpdater issues
by tnisan＠redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: core: fixes to import/OvfDataUpdater issues
......................................................................
core: fixes to import/OvfDataUpdater issues
The following patch fixes a case in which we attempt to insert a record
to vm_ovf_generations table when we already have a record for the same
guid, which will cause us to pk violation error.
This issue currently occurs in import vm/template flows when we attempt
to use
the same id as exported and the record for that key in
vm_ovf_generations table hasn't been deleted yet due to failure
during the import (compensation doesn't remove record from the ovf
table) or because the vm/template has been removed from the
DB, but not from the storage side by ovf data updater.
Change-Id: I272b39f99d582462c0d1ea4cf268edd7e5c42b6d
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=890951
Signed-off-by: Liron Aravot <laravot(a)redhat.com>
---
M backend/manager/dbscripts/vm_templates_sp.sql
M backend/manager/dbscripts/vms_sp.sql
2 files changed, 7 insertions(+), 1 deletion(-)
Approvals:
Tal Nisan: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/10684
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I272b39f99d582462c0d1ea4cf268edd7e5c42b6d
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Liron Aravot <laravot(a)redhat.com>
Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
11 years, 9 months
Change in ovirt-engine[master]: packaging: Switched to checking DB size with admin user
by juan.hernandez＠redhat.com
Juan Hernandez has submitted this change and it was merged.
Change subject: packaging: Switched to checking DB size with admin user
......................................................................
packaging: Switched to checking DB size with admin user
Change-Id: I792ccae137d327f2f62be7053f36acabe921d1d1
Signed-off-by: Alex Lourie <alourie(a)redhat.com>
---
M packaging/fedora/setup/common_utils.py
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Juan Hernandez: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/10769
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I792ccae137d327f2f62be7053f36acabe921d1d1
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Alex Lourie <alourie(a)redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Kiril Nesenko <knesenko(a)redhat.com>
Gerrit-Reviewer: Moran Goldboim <mgoldboi(a)redhat.com>
Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com>
11 years, 9 months
Change in ovirt-reports[master]: reports: session locale now fully sets reports locale (#8923...
by ydary＠redhat.com
Yaniv Dary has submitted this change and it was merged.
Change subject: reports: session locale now fully sets reports locale (#892306)
......................................................................
reports: session locale now fully sets reports locale (#892306)
Bug-Url: https://bugzilla.redhat.com/892306
Change-Id: If11621c01b63075dc263ea094d6e187132192129
Signed-off-by: Yaniv Dary <ydary(a)redhat.com>
---
M reports/repository_files/resources/Reports/Executive/active_vms_by_os_br18_files/active_vms_by_os_br18_jrxml.data
M reports/repository_files/resources/Reports/Executive/active_vms_by_os_br18_files/full details.jrxml.data
M reports/repository_files/resources/Reports/Executive/host_os_break_down_BR22_files/host_os_break_down_BR22_jrxml.data
M reports/repository_files/resources/Reports/Inventory/Hosts_Inventory_files/Hosts_Inventory_jrxml.data
M reports/repository_files/resources/Reports/Inventory/Hosts_Inventory_files/full details br1.jrxml.data
M reports/repository_files/resources/Reports/Inventory/Storage_Domain_Report_BR21_files/full details br21.jrxml.data
M reports/repository_files/resources/Reports/Inventory/VM_Inventory_files/VM_Inventory_jrxml.data
M reports/repository_files/resources/Reports/Inventory/VM_Inventory_files/full details.jrxml.data
M reports/repository_files/resources/Reports/Inventory/ccp_vm_inventory_br44_files/ccp_vm_inventory_br44_jrxml.data
M reports/repository_files/resources/Reports/Inventory/ccp_vm_inventory_br44_files/full details.jrxml.data
M reports/repository_files/resources/Reports/Inventory/storage_domains_inventory_br47_files/full details.jrxml.data
M reports/repository_files/resources/Reports/Inventory/storage_domains_inventory_br47_files/storage_domains_inventory_br47_jrxml.data
M reports/repository_files/resources/Reports/Service_level/Hosts/cluster_quality_of_service_hosts_br6_files/full details br13.jrxml.data
M reports/repository_files/resources/Reports/Service_level/Hosts/cluster_uptime_br7_files/br7 full details.jrxml.data
M reports/repository_files/resources/Reports/Service_level/Hosts/single_host_uptime_br8_files/br8 full details.jrxml.data
M reports/repository_files/resources/Reports/Service_level/Hosts/top_10_downtime_hosts_br7b_files/br7b full details.jrxml.data
M reports/repository_files/resources/Reports/Service_level/VMs/cluster_quality_of_service_vms_br13_files/full details.jrxml.data
M reports/repository_files/resources/Reports/Service_level/VMs/single_vm_uptime_br46_files/full details.jrxml.data
M reports/repository_files/resources/Reports/Trend/Hosts/Five_most_utilized_hosts_over_time_files/br7 full details.jrxml.data
M reports/repository_files/resources/Reports/Trend/Hosts/five_least_utilized_hosts_br5_files/br7 full details.jrxml.data
M reports/repository_files/resources/Reports/Trend/Hosts/multiple_hosts_resource_usage_br3_files/br3 full details.jrxml.data
M reports/repository_files/resources/Reports/Trend/Hosts/single_host_resource_br2a_files/br2 full details.jrxml.data
M reports/repository_files/resources/Reports/Trend/Hosts/single_host_resource_usage_dow_br2b_files/br2 full details.jrxml.data
M reports/repository_files/resources/Reports/Trend/Hosts/single_host_resource_usage_hour_of_day_br2c_files/br2 full details.jrxml.data
M reports/repository_files/resources/Reports/Trend/Hosts/single_host_resource_usage_hour_of_day_br2c_files/single_host_resource_usage_hour_of_day_br2c_jrxml.data
M reports/repository_files/resources/Reports/Trend/Virtual_machines/five_least_utilized_vms_Over_Time_BR12_files/full details.jrxml.data
M reports/repository_files/resources/Reports/Trend/Virtual_machines/five_most_utilized_vms_over_time_br11_files/full details.jrxml.data
M reports/repository_files/resources/Reports/Trend/Virtual_machines/multiple_vms_resource_usage_over_time_br16_files/report3.jrxml.data
M reports/repository_files/resources/Reports/Trend/Virtual_machines/single_vm_resources_days_week_BR10B_files/br2 full details.jrxml.data
M reports/repository_files/resources/Reports/Trend/Virtual_machines/single_vm_resources_days_week_BR10B_files/single_vm_resources_days_week_BR10B_jrxml.data
M reports/repository_files/resources/Reports/Trend/Virtual_machines/single_vm_resources_hour_of_day_BR10c_files/br10 full details.jrxml.data
M reports/repository_files/resources/Reports/Trend/Virtual_machines/single_vm_resources_hour_of_day_BR10c_files/single_vm_resources_hour_of_day_BR10c_jrxml.data
M reports/repository_files/resources/Reports/Trend/Virtual_machines/single_vm_resources_over_time_BR10A_files/br10 full details.jrxml.data
M reports/repository_files/resources/Reports/Trend/Virtual_machines/single_vm_resources_over_time_BR10A_files/single_vm_resources_over_time_BR10A_jrxml.data
M reports/repository_files/resources/Reports/users_usage/users_spice_sessions_activity_br45_files/full details.jrxml.data
M reports/repository_files/resources/Reports/users_usage/users_spice_sessions_activity_br45_files/users_spice_sessions_activity_br45_jrxml.data
M reports/repository_files/resources/reports_resources/embedded_reports/Inventory_Dashboard/active_entities_by_os_BR18A_files/active_entities_by_os_BR18A_jrxml.data
37 files changed, 1,322 insertions(+), 1,104 deletions(-)
Approvals:
Yaniv Dary: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/10794
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: If11621c01b63075dc263ea094d6e187132192129
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-reports
Gerrit-Branch: master
Gerrit-Owner: Yaniv Dary <ydary(a)redhat.com>
Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com>
11 years, 9 months
Change in ovirt-engine[master]: webadmin: Added gateway format validation
by alkaplan＠redhat.com
Alona Kaplan has submitted this change and it was merged.
Change subject: webadmin: Added gateway format validation
......................................................................
webadmin: Added gateway format validation
When editing the management network in the host network setup dialog,
added a check that the default gateway field is formatted as a valid IP
address.
Change-Id: I272285019b5e87d8324c2192ea601aeed91cdbbf
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=890177
Signed-off-by: Lior Vernia <lvernia(a)redhat.com>
---
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostManagementNetworkModel.java
1 file changed, 2 insertions(+), 1 deletion(-)
Approvals:
Alona Kaplan: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/10765
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I272285019b5e87d8324c2192ea601aeed91cdbbf
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Lior Vernia <lvernia(a)redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com>
Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com>
Gerrit-Reviewer: Livnat Peer <lpeer(a)redhat.com>
Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com>
11 years, 9 months
Change in ovirt-engine[master]: engine: Extract common code for network used
by masayag＠redhat.com
Moti Asayag has submitted this change and it was merged.
Change subject: engine: Extract common code for network used
......................................................................
engine: Extract common code for network used
This validation is the same for hosts, VMs and templates; so extracted
it to a common method that handles the core validation logic, and the
calling methods need just to supply the entities and a replacement for
their verbal representation in the message.
Change-Id: I42fdbca64b805cc5d506b2b63add176062b93124
Signed-off-by: Mike Kolesnik <mkolesni(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/dc/NetworkCommon.java
1 file changed, 12 insertions(+), 25 deletions(-)
Approvals:
Mike Kolesnik: Verified
Moti Asayag: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/10768
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I42fdbca64b805cc5d506b2b63add176062b93124
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Mike Kolesnik <mkolesni(a)redhat.com>
Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
11 years, 9 months