October 2013 - Engine-commits - Ovirt List Archives

Change in ovirt-engine[master]: webadmin: Fixed some typos

by lvernia＠redhat.com

Lior Vernia has submitted this change and it was merged. Change subject: webadmin: Fixed some typos ...................................................................... webadmin: Fixed some typos A couple of String constants were named "inteface" instead of "interface". Change-Id: Id6ba703b9e116cc98b5b764ff12a1460fe258a49 Signed-off-by: Lior Vernia <lvernia(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/CommonApplicationConstants.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/table/column/NicActivateStatusColumn.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/networkinterface/NetworkInterfacePopupWidget.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/template/TemplateInterfaceListModelTable.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/vm/PoolInterfaceListModelTable.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/vm/VmInterfaceListModelTable.java 6 files changed, 33 insertions(+), 33 deletions(-) Approvals: Lior Vernia: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/19435 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id6ba703b9e116cc98b5b764ff12a1460fe258a49 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

11 years, 1 month

1
0
0 / 0

Change in ovirt-engine[ovirt-engine-3.3]: restapi: Fixing action host install parameters

by iheim＠redhat.com

Itamar Heim has submitted this change and it was merged. Change subject: restapi: Fixing action host install parameters ...................................................................... restapi: Fixing action host install parameters Adding to yaml all missing ssh fields for action install. Change-Id: If72e4744d370e16e6eaf310fe25907872c726af2 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1013637 Signed-off-by: Yaniv Bronhaim <ybronhei(a)redhat.com> --- M backend/manager/modules/restapi/interface/definition/src/main/resources/rsdl_metadata.yaml 1 file changed, 2 insertions(+), 1 deletion(-) Approvals: Itamar Heim: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/20024 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If72e4744d370e16e6eaf310fe25907872c726af2 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.3 Gerrit-Owner: Yaniv Bronhaim <ybronhei(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

11 years, 1 month

1
0
0 / 0

Change in ovirt-hosted-engine-setup[master]: bin: add --vm-start-paused to hosted-engine

by sbonazzo＠redhat.com

Sandro Bonazzola has submitted this change and it was merged. Change subject: bin: add --vm-start-paused to hosted-engine ...................................................................... bin: add --vm-start-paused to hosted-engine Allow to start the hosted engine VM qith qemu paused. Change-Id: I749e877fe1fb259b99f1dfa46f580bcb1a5ec724 Bug-Url: https://bugzilla.redhat.com/1020858 Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M man/hosted-engine.8 M src/bin/hosted-engine.in 2 files changed, 17 insertions(+), 1 deletion(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/20443 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I749e877fe1fb259b99f1dfa46f580bcb1a5ec724 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-hosted-engine-setup Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Greg Padgett <gpadgett(a)redhat.com> Gerrit-Reviewer: Leonid Natapov <leonidnatapov(a)gmail.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

11 years, 1 month

1
0
0 / 0

Change in ovirt-engine[ovirt-engine-3.3]: core: scheduling: avoid running external filters in CDA

by iheim＠redhat.com

Itamar Heim has submitted this change and it was merged. Change subject: core: scheduling: avoid running external filters in CDA ...................................................................... core: scheduling: avoid running external filters in CDA External code is user responsibility, so for the sake of performance, avoiding running external plugins in CanDoAction. Bug-Url: https://bugzilla.redhat.com/1014698 Change-Id: I319ca2a5d9dbbc6634639e7b842beac1cf6c6ad9 Signed-off-by: Gilad Chaplik <gchaplik(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/SchedulingManager.java 1 file changed, 11 insertions(+), 5 deletions(-) Approvals: Itamar Heim: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/20450 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I319ca2a5d9dbbc6634639e7b842beac1cf6c6ad9 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.3 Gerrit-Owner: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

11 years, 1 month

1
0
0 / 0

Change in ovirt-engine[ovirt-engine-3.3]: engine: Fail import vm if mac addresses are missing

by iheim＠redhat.com

Itamar Heim has submitted this change and it was merged. Change subject: engine: Fail import vm if mac addresses are missing ...................................................................... engine: Fail import vm if mac addresses are missing When a vm is imported as new entity, there is a mac allocation for any imported vnic. If the mac addresses pool has insufficient addresses, the action fails during the execution. The patch fails the operation on can-do-action with a proper message to the user for the failure reason. Change-Id: I86680baa28c22def751c9c092f4cfde26ab1c45c Bug-Url: https://bugzilla.redhat.com/1008168 Signed-off-by: Moti Asayag <masayag(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImportVmCommand.java 1 file changed, 5 insertions(+), 0 deletions(-) Approvals: Itamar Heim: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/20589 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I86680baa28c22def751c9c092f4cfde26ab1c45c Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.3 Gerrit-Owner: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

11 years, 1 month

1
0
0 / 0

Change in ovirt-engine[ovirt-engine-3.3.1]: frontend: NPE in Import*Model

by iheim＠redhat.com

Itamar Heim has submitted this change and it was merged. Change subject: frontend: NPE in Import*Model ...................................................................... frontend: NPE in Import*Model There was a NPE vulnerability in ImportTemplateModel and ImportVmModel. The problem was that the VmBackupModel.restore() called first the setItems() and than init(). The setItems have done some async call and set the result to the super.setItems(), while the init() already needed this in initDisksStorageDomainsList() method (which is also called in a callback). So if the callback from setItems returned sooner than the ones in init() it worked. If not, the initDisksStorageDomainsList failed on NPE. Fixed by calling the real init() logic only when the data are really prepared. Change-Id: Id97c8368ecf80ceb7ef1aa456d32a022dd5043bb Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1019862 Signed-off-by: Tomas Jelinek <tjelinek(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/VmBackupModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/templates/ImportTemplateModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/ImportVmModel.java 3 files changed, 68 insertions(+), 63 deletions(-) Approvals: Tomas Jelinek: Verified Daniel Erez: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/20544 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id97c8368ecf80ceb7ef1aa456d32a022dd5043bb Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.3.1 Gerrit-Owner: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

11 years, 1 month

1
0
0 / 0

Change in ovirt-engine[ovirt-engine-3.3]: packaging: services: ovirt-engine: enforce log level for ser...

by iheim＠redhat.com

Itamar Heim has submitted this change and it was merged. Change subject: packaging: services: ovirt-engine: enforce log level for server.log ...................................................................... packaging: services: ovirt-engine: enforce log level for server.log due to unknown reason there was report that server.log was put into debug level. so let's be consistent and enforce its level as well. Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1021346 Change-Id: Id1ec5786ef64986e38e3766b2aabd22f5e544225 Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M packaging/services/ovirt-engine/ovirt-engine.xml.in 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Itamar Heim: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/20559 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id1ec5786ef64986e38e3766b2aabd22f5e544225 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.3 Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

11 years, 1 month

1
0
0 / 0

Change in ovirt-engine[ovirt-engine-3.3]: packaging: fix typo in java detection caused only version match

by iheim＠redhat.com

Itamar Heim has submitted this change and it was merged. Change subject: packaging: fix typo in java detection caused only version match ...................................................................... packaging: fix typo in java detection caused only version match Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1023538 Change-Id: Ia0224b3bd1172ef5167c7085d2dd29aba72abaff Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M packaging/bin/java-home 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Itamar Heim: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/20560 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia0224b3bd1172ef5167c7085d2dd29aba72abaff Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.3 Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

11 years, 1 month

1
0
0 / 0

Change in ovirt-engine[master]: webadmin: wrong string comparison in comment column

by gchaplik＠redhat.com

Gilad Chaplik has submitted this change and it was merged. Change subject: webadmin: wrong string comparison in comment column ...................................................................... webadmin: wrong string comparison in comment column Change-Id: Ice1087a8042a76697ef0b7f296cb485885dcb069 Signed-off-by: Gilad Chaplik <gchaplik(a)redhat.com> --- M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/table/column/CommentColumn.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Gilad Chaplik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/20592 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ice1087a8042a76697ef0b7f296cb485885dcb069 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

11 years, 1 month

1
0
0 / 0

Change in ovirt-engine[master]: packaging: engine-backup: Safer password input

by sbonazzo＠redhat.com

Sandro Bonazzola has submitted this change and it was merged. Change subject: packaging: engine-backup: Safer password input ...................................................................... packaging: engine-backup: Safer password input Allow passing db password also interactively and using an environment variable, in addition to using a file and using a command line option. Bug-Url: https://bugzilla.redhat.com/1002401 Change-Id: Icbc497af2653417beab54a9be307332cdf69a48a Signed-off-by: Yedidyah Bar David <didi(a)redhat.com> --- M packaging/bin/engine-backup.sh 1 file changed, 36 insertions(+), 2 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/20423 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Icbc497af2653417beab54a9be307332cdf69a48a Gerrit-PatchSet: 12 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: Alex Lourie <alourie(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com>

11 years, 1 month

1
0
0 / 0

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

Engine-commits October 2013