October 2013 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: engine: Allow using vnic profiles internally
by masayag＠redhat.com 31 Oct '13

31 Oct '13

Moti Asayag has submitted this change and it was merged. Change subject: engine: Allow using vnic profiles internally ...................................................................... engine: Allow using vnic profiles internally When action is being executed internally, there is no user associated with the action, and the action should be treated as executed by the admin. In that case, there is no need to search for a permissions on a vnic profile to be used by the user. Change-Id: I7665d5d53519cdb2560ae2aed0b02c4229c80964 Bug-Url: https://bugzilla.redhat.com/1018229 Signed-off-by: Moti Asayag <masayag(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmFromSnapshotCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImportVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImportVmTemplateCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RestoreAllSnapshotsCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/TryBackToAllSnapshotsOfVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/template/VmTemplateInterfaceCommandBase.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/vm/AbstractVmInterfaceCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/vm/VnicProfileHelper.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/snapshots/SnapshotsManager.java 9 files changed, 32 insertions(+), 26 deletions(-) Approvals: Moti Asayag: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/20718 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7665d5d53519cdb2560ae2aed0b02c4229c80964 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: packaging: setup: properly support relative answer file
by sbonazzo＠redhat.com 31 Oct '13

31 Oct '13

Sandro Bonazzola has submitted this change and it was merged. Change subject: packaging: setup: properly support relative answer file ...................................................................... packaging: setup: properly support relative answer file Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1025313 Change-Id: I72d8e8c46528e492aa3339ff83227104bfb3ba9b Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M packaging/setup/plugins/ovirt-engine-common/core/answerfile.py 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/20761 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I72d8e8c46528e492aa3339ff83227104bfb3ba9b Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com>

1 0

Change in ovirt-engine[master]: engine: Make VmBase isoPath field editable
by ofrenkel＠redhat.com 31 Oct '13

31 Oct '13

Omer Frenkel has submitted this change and it was merged. Change subject: engine: Make VmBase isoPath field editable ...................................................................... engine: Make VmBase isoPath field editable Make isoPath editable even when the VM is not 'Down' Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1014035 Change-Id: I07a8531e3254e4c297b7e6c8040de2c9fbbd7166 Signed-off-by: Martin Betak <mbetak(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VmBase.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Omer Frenkel: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/20288 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I07a8531e3254e4c297b7e6c8040de2c9fbbd7166 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Betak <mbetak(a)redhat.com> Gerrit-Reviewer: Martin Betak <mbetak(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: fix typo in OvfReader comment
by amureini＠redhat.com 31 Oct '13

31 Oct '13

Allon Mureinik has submitted this change and it was merged. Change subject: core: fix typo in OvfReader comment ...................................................................... core: fix typo in OvfReader comment s/in in/it in Change-Id: I509b16b422721ec8bba332976a8e5facf4c6ec8a Signed-off-by: Vered Volansky <vvolansk(a)redhat.com> --- M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ovf/OvfReader.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Allon Mureinik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/20733 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I509b16b422721ec8bba332976a8e5facf4c6ec8a Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Vered Volansky <vvolansk(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: db: changedbowner.sh: fix usage typos
by emesika＠redhat.com 31 Oct '13

31 Oct '13

Eli Mesika has submitted this change and it was merged. Change subject: db: changedbowner.sh: fix usage typos ...................................................................... db: changedbowner.sh: fix usage typos Change-Id: I7cc12d340f549fe0c46892ad92cb6268608e745e Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M packaging/setup/dbutils/changedbowner.sh 1 file changed, 3 insertions(+), 3 deletions(-) Approvals: Eli Mesika: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/20670 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7cc12d340f549fe0c46892ad92cb6268608e745e Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>

1 0

Change in ovirt-engine[master]: gluster: rename gluster volumes to volumes in remove brick s...
by ofrenkel＠redhat.com 31 Oct '13

31 Oct '13

Omer Frenkel has submitted this change and it was merged. Change subject: gluster: rename gluster volumes to volumes in remove brick start event log ...................................................................... gluster: rename gluster volumes to volumes in remove brick start event log Renaming 'Gluster Volumes' to 'Volume' in remove brick start event log messages. Change-Id: If172ab0d56344192ade014cefb54a3595a91fbeb Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1022516 Signed-off-by: Ramesh Nachimuthu <rnachimu(a)redhat.com> --- M backend/manager/modules/dal/src/main/resources/bundles/AuditLogMessages.properties M frontend/webadmin/modules/uicompat/src/main/resources/org/ovirt/engine/ui/uicompat/LocalizedEnums.properties 2 files changed, 4 insertions(+), 4 deletions(-) Approvals: Omer Frenkel: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/20688 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If172ab0d56344192ade014cefb54a3595a91fbeb Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ramesh N <rnachimu(a)redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayilsa(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Ramesh N <rnachimu(a)redhat.com> Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com> Gerrit-Reviewer: Shubhendu Tripathi <shtripat(a)redhat.com>

1 0

Change in ovirt-reports[master]: packaging: setup: fix ENGINE_DB database name
by ydary＠redhat.com 31 Oct '13

31 Oct '13

Yaniv Dary has submitted this change and it was merged. Change subject: packaging: setup: fix ENGINE_DB database name ...................................................................... packaging: setup: fix ENGINE_DB database name Change-Id: I8b5c616c0a87e772026127a138435403a80bbc92 Bug-Url: https://bugzilla.redhat.com/1024797 Signed-off-by: Alex Lourie <alourie(a)redhat.com> --- M packaging/ovirt-engine-reports-setup.py 1 file changed, 4 insertions(+), 4 deletions(-) Approvals: Sandro Bonazzola: Looks good to me, but someone else must approve Alex Lourie: Verified Yaniv Dary: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/20748 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8b5c616c0a87e772026127a138435403a80bbc92 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-reports Gerrit-Branch: master Gerrit-Owner: Alex Lourie <alourie(a)redhat.com> Gerrit-Reviewer: Alex Lourie <alourie(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com>

1 0

Change in ovirt-engine-cli[master]: cli: add the option to retrieve partial history using CLI(#9...
by mpastern＠redhat.com 31 Oct '13

31 Oct '13

Michael Pasternak has submitted this change and it was merged. Change subject: cli: add the option to retrieve partial history using CLI(#957499) ...................................................................... cli: add the option to retrieve partial history using CLI(#957499) add the option to retrieve partial history ( e.g history --last 3 ) using CLI instead of retrieving all history . adds history --last n and history --first n to retrive the last or first n history elements Change-Id: I2321ccc7e3cce2521e0b86f67de2797a8a2b4276 Bug-Url: https://bugzilla.redhat.com/957499 Signed-off-by: Ravi Nori <rnori(a)redhat.com> --- M src/ovirtcli/command/history.py M src/ovirtcli/infrastructure/historymanager.py M src/ovirtcli/shell/historycmdshell.py 3 files changed, 99 insertions(+), 19 deletions(-) Approvals: Michael Pasternak: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/20272 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2321ccc7e3cce2521e0b86f67de2797a8a2b4276 Gerrit-PatchSet: 11 Gerrit-Project: ovirt-engine-cli Gerrit-Branch: master Gerrit-Owner: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: fix issue with search on OSs
by rgolan＠redhat.com 31 Oct '13

31 Oct '13

Roy Golan has submitted this change and it was merged. Change subject: core: fix issue with search on OSs ...................................................................... core: fix issue with search on OSs * fix the search validation of template * on UI load - set the search dependencies once the cache population is done - prevents null list of OSs * make the auto-completion case insensitive * show the full list when the input is blank Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1003804 Change-Id: I9434189173939ba595862a40483d8da5107228b2 Signed-off-by: Roy Golan <rgolan(a)redhat.com> --- M backend/manager/modules/searchbackend/src/main/java/org/ovirt/engine/core/searchbackend/OsValueAutoCompleter.java M backend/manager/modules/searchbackend/src/main/java/org/ovirt/engine/core/searchbackend/VmTemplateConditionFieldAutoCompleter.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/system/BaseApplicationInit.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/dataprovider/AsyncDataProvider.java 4 files changed, 15 insertions(+), 11 deletions(-) Approvals: Roy Golan: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/20396 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9434189173939ba595862a40483d8da5107228b2 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: engine: Audit log for brick status change
by kmayilsa＠redhat.com 31 Oct '13

31 Oct '13

Kanagaraj M has submitted this change and it was merged. Change subject: engine: Audit log for brick status change ...................................................................... engine: Audit log for brick status change During periodic sync of gluster with engine if change in brick status is detected this needs to be logged. Added corresponding entries for event notification Change-Id: If1764dd5c41b484637595b0fa20598849f9ba347 Bug-Url: https://bugzilla.redhat.com/958813 Signed-off-by: Sahina Bose <sabose(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GlusterSyncJob.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/AuditLogType.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/VdcEventNotificationUtils.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/auditloghandling/AuditLogDirector.java M backend/manager/modules/dal/src/main/resources/bundles/AuditLogMessages.properties M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/LocalizedEnums.java M frontend/webadmin/modules/uicompat/src/main/resources/org/ovirt/engine/ui/uicompat/LocalizedEnums.properties A packaging/dbscripts/upgrade/03_04_0080_add_brick_status_change_event_map.sql 8 files changed, 24 insertions(+), 0 deletions(-) Approvals: Kanagaraj M: Looks good to me, approved Sahina Bose: Verified -- To view, visit http://gerrit.ovirt.org/20433 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If1764dd5c41b484637595b0fa20598849f9ba347 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Sahina Bose <sabose(a)redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayilsa(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Ramesh N <rnachimu(a)redhat.com> Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com> Gerrit-Reviewer: Shubhendu Tripathi <shtripat(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0