October 2013 - Engine-commits - oVirt List Archives

Change in ovirt-engine[ovirt-engine-3.3]: webadmin: Added scrolling to vNIC section in add VM
by iheim＠redhat.com 31 Oct '13

31 Oct '13

Itamar Heim has submitted this change and it was merged. Change subject: webadmin: Added scrolling to vNIC section in add VM ...................................................................... webadmin: Added scrolling to vNIC section in add VM Added a vertical scroll bar to the vNIC section in the add VM dialog. Change-Id: I0d1c45470c23fdb561bfb5573e133591c138c276 Bug-Url: https://bugzilla.redhat.com/1012798 Signed-off-by: Lior Vernia <lvernia(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/profile/ProfilesInstanceTypeEditor.ui.xml 1 file changed, 4 insertions(+), 2 deletions(-) Approvals: Itamar Heim: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/20566 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0d1c45470c23fdb561bfb5573e133591c138c276 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.3 Gerrit-Owner: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.3]: webadmin: Added scrolling to vNIC profiles
by iheim＠redhat.com 31 Oct '13

31 Oct '13

Itamar Heim has submitted this change and it was merged. Change subject: webadmin: Added scrolling to vNIC profiles ...................................................................... webadmin: Added scrolling to vNIC profiles In add/edit network, added a vertical scroll bar to the vNIC profile section. Change-Id: I2fedc75dfcd534775fdb80b3364b81d99aab74eb Bug-Url: https://bugzilla.redhat.com/1012798 Signed-off-by: Lior Vernia <lvernia(a)redhat.com> --- M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/AbstractNetworkPopupView.ui.xml M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/vnicProfile/VnicProfilesEditor.ui.xml 2 files changed, 7 insertions(+), 8 deletions(-) Approvals: Itamar Heim: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/20565 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2fedc75dfcd534775fdb80b3364b81d99aab74eb Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.3 Gerrit-Owner: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in otopi[master]: core: add prefix directories to pluin name
by Alon Bar-Lev 31 Oct '13

31 Oct '13

Alon Bar-Lev has submitted this change and it was merged. Change subject: core: add prefix directories to pluin name ...................................................................... core: add prefix directories to pluin name Change-Id: I9391cff6b74b108e47798431aad6129c1f2ea3f7 Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M src/otopi/context.py 1 file changed, 31 insertions(+), 13 deletions(-) Approvals: Alon Bar-Lev: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/20727 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9391cff6b74b108e47798431aad6129c1f2ea3f7 Gerrit-PatchSet: 2 Gerrit-Project: otopi Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin: Pools VMs sub-tab - fix name column
by derez＠redhat.com 30 Oct '13

30 Oct '13

Daniel Erez has submitted this change and it was merged. Change subject: webadmin: Pools VMs sub-tab - fix name column ...................................................................... webadmin: Pools VMs sub-tab - fix name column Pools -> VMs sub-tab: added width to name column for making it visible again. Change-Id: I8b8397d3d669682a21fb2ad73ad1840a707e326e Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/pool/SubTabPoolVmView.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Daniel Erez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/20322 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8b8397d3d669682a21fb2ad73ad1840a707e326e Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: webadmin: prevent npe on VdcActionUtils canExecute
by derez＠redhat.com 30 Oct '13

30 Oct '13

Daniel Erez has submitted this change and it was merged. Change subject: webadmin: prevent npe on VdcActionUtils canExecute ...................................................................... webadmin: prevent npe on VdcActionUtils canExecute VmSnapshotListModel -> updateActionAvailability: passing an empty list to VdcActionUtils.canExecute when VM is null to avoid an NPE. Change-Id: I63e3570b48f8039642a5f1ce3af1f9c4599d688c Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmSnapshotListModel.java 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Daniel Erez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/20446 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I63e3570b48f8039642a5f1ce3af1f9c4599d688c Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-dwh[master]: packaging: changed the db dict get method
by ydary＠redhat.com 30 Oct '13

30 Oct '13

Yaniv Dary has submitted this change and it was merged. Change subject: packaging: changed the db dict get method ...................................................................... packaging: changed the db dict get method Engine now saved config values with quotes marks. This breaks the current db dict get method. Added replace for these values. Change-Id: I68b69296bffd98c7262751bc807da54885791b28 Signed-off-by: Yaniv Dary <ydary(a)redhat.com> --- M packaging/ovirt-engine-dwh-setup.py 1 file changed, 5 insertions(+), 5 deletions(-) Approvals: Sandro Bonazzola: Looks good to me, but someone else must approve Alex Lourie: Looks good to me, but someone else must approve Yaniv Dary: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/20700 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I68b69296bffd98c7262751bc807da54885791b28 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-dwh Gerrit-Branch: master Gerrit-Owner: Yaniv Dary <ydary(a)redhat.com> Gerrit-Reviewer: Alex Lourie <alourie(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com>

1 0

Change in ovirt-reports[master]: packaging: changed the db dict get method
by ydary＠redhat.com 30 Oct '13

30 Oct '13

Yaniv Dary has submitted this change and it was merged. Change subject: packaging: changed the db dict get method ...................................................................... packaging: changed the db dict get method Engine now saved config values with quotes marks. This breaks the current db dict get method. Added replace for these values. Change-Id: I72e386787f7b074f365506dedb9976fed2554dc4 Signed-off-by: Yaniv Dary <ydary(a)redhat.com> --- M packaging/ovirt-engine-reports-setup.py 1 file changed, 5 insertions(+), 5 deletions(-) Approvals: Yaniv Dary: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/20701 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I72e386787f7b074f365506dedb9976fed2554dc4 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-reports Gerrit-Branch: master Gerrit-Owner: Yaniv Dary <ydary(a)redhat.com> Gerrit-Reviewer: Alex Lourie <alourie(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: RemoveStorageDomainCommandTest: local var
by amureini＠redhat.com 30 Oct '13

30 Oct '13

Allon Mureinik has submitted this change and it was merged. Change subject: core: RemoveStorageDomainCommandTest: local var ...................................................................... core: RemoveStorageDomainCommandTest: local var Convert useless members to local variables in the setUp() method. Change-Id: I4323e3d644168fcbc07705ac5a32b1d792a4da56 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/RemoveStorageDomainCommandTest.java 1 file changed, 3 insertions(+), 6 deletions(-) Approvals: Allon Mureinik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/20681 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4323e3d644168fcbc07705ac5a32b1d792a4da56 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: RemoveStorageDomainCommandTest: generics
by amureini＠redhat.com 30 Oct '13

30 Oct '13

Allon Mureinik has submitted this change and it was merged. Change subject: core: RemoveStorageDomainCommandTest: generics ...................................................................... core: RemoveStorageDomainCommandTest: generics Use Java7 generics syntax to make the code easier to read. Change-Id: I49473952c318ede46f9a2c95184b07f27c933324 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/RemoveStorageDomainCommandTest.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Allon Mureinik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/20682 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I49473952c318ede46f9a2c95184b07f27c933324 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: RemoveStorageDomainCommandTest: annotations
by amureini＠redhat.com 30 Oct '13

30 Oct '13

Allon Mureinik has submitted this change and it was merged. Change subject: core: RemoveStorageDomainCommandTest: annotations ...................................................................... core: RemoveStorageDomainCommandTest: annotations Use the modern @Mock annotation instead of explicitly calling Mockito.mock. The resulting class is easier to understand since the mocking does not interrupt the flow of reading setUp(). Change-Id: I3f2c9d3ccf1810f0532b2200acda27679fee158d Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/RemoveStorageDomainCommandTest.java 1 file changed, 7 insertions(+), 4 deletions(-) Approvals: Allon Mureinik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/20680 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3f2c9d3ccf1810f0532b2200acda27679fee158d Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0