October 2013 - Engine-commits - Ovirt List Archives

Change in ovirt-engine[master]: core: RemoveStorageDomainCommandTest spelling

by amureini＠redhat.com

Allon Mureinik has submitted this change and it was merged. Change subject: core: RemoveStorageDomainCommandTest spelling ...................................................................... core: RemoveStorageDomainCommandTest spelling Fixed typos and spelling mistakes. Change-Id: I9a4031c6a362589c96d6b2a41ee3f32193959aea Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/RemoveStorageDomainCommandTest.java 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Allon Mureinik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/20679 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9a4031c6a362589c96d6b2a41ee3f32193959aea Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

10 years, 5 months

1
0
0 / 0

Change in ovirt-engine[master]: core: differentiate command test utils

by amureini＠redhat.com

Allon Mureinik has submitted this change and it was merged. Change subject: core: differentiate command test utils ...................................................................... core: differentiate command test utils CommandAssertUtils and CanDoActionTestUtils contained duplicated logic as both were used to test canDoAction() methods. This patch moves all the (remaining) canDoAction() tests to use CanDoActionTestUtils and removes the redundant methods from CommandAssertUtils, leaving it as a utility to test execute() methods only. Change-Id: Iadce121f4cf3d04e4eab8200c679230e4b4adf8b Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/CommandAssertUtils.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/ForceSelectSPMCommandTest.java 2 files changed, 19 insertions(+), 45 deletions(-) Approvals: Allon Mureinik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/20685 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iadce121f4cf3d04e4eab8200c679230e4b4adf8b Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

10 years, 5 months

1
0
0 / 0

Change in ovirt-engine[master]: core: Unify RemoveStorageDomain[Command]Test

by amureini＠redhat.com

Allon Mureinik has submitted this change and it was merged. Change subject: core: Unify RemoveStorageDomain[Command]Test ...................................................................... core: Unify RemoveStorageDomain[Command]Test RemoveStorageDomainTest and RemoveStorageDomainCommandTest both test the same command. Neither sets up any special environment, and in fact, they have multiple duplications. This patch streamlines the testing of RemoveStorageDomainCommand to a single test case (RemoveStorageDomainCommandTest, as per JUnit convention). It includes: 1. Removing duplicate tests. 2. Bundling all the tests for executeAction() in a single method. 3. Cleaning up the mocking scheme (minor refactoring to the command itself was required in order to achieve this). Change-Id: Id85d95109b48f9191e972218f9a1a220db5aeeeb Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/RemoveStorageDomainCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/StorageDomainCommandBase.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/StorageHandlingCommandBase.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/RemoveStorageDomainCommandTest.java D backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/RemoveStorageDomainTest.java 5 files changed, 133 insertions(+), 316 deletions(-) Approvals: Allon Mureinik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/20684 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id85d95109b48f9191e972218f9a1a220db5aeeeb Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

10 years, 5 months

1
0
0 / 0

Change in ovirt-engine[master]: core: RemoveStorageDomainCommandTest: CDATestUtils

by amureini＠redhat.com

Allon Mureinik has submitted this change and it was merged. Change subject: core: RemoveStorageDomainCommandTest: CDATestUtils ...................................................................... core: RemoveStorageDomainCommandTest: CDATestUtils Use CanDoActionTestUtils instead of CommandAssertUtils in order to streamline the code. This patch is part of a series of patches designed to clearly separate between CanDoActionTestUtils and CommandAssertUtils. Change-Id: Ibf1f0b05f1ed2320131071f928372e259584b040 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/CanDoActionTestUtils.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/RemoveStorageDomainCommandTest.java 2 files changed, 83 insertions(+), 15 deletions(-) Approvals: Allon Mureinik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/20683 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ibf1f0b05f1ed2320131071f928372e259584b040 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

10 years, 5 months

1
0
0 / 0

Change in ovirt-engine[master]: core: add missing mock of config value in GlusterHookSyncJob...

by amureini＠redhat.com

Allon Mureinik has submitted this change and it was merged. Change subject: core: add missing mock of config value in GlusterHookSyncJobTest ...................................................................... core: add missing mock of config value in GlusterHookSyncJobTest Change-Id: I058db989c6ef0bee6a6dcc6fb37b9af30e24bbd5 Signed-off-by: Alissa Bonas <abonas(a)redhat.com> --- M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/gluster/GlusterHookSyncJobTest.java 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Allon Mureinik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/20719 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I058db989c6ef0bee6a6dcc6fb37b9af30e24bbd5 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Liran Zelkha <liran.zelkha(a)gmail.com> Gerrit-Reviewer: oVirt Jenkins CI Server

10 years, 5 months

1
0
0 / 0

Change in ovirt-engine[ovirt-engine-3.3.1]: packaging: ovirt-engine-3.3.1

by iheim＠redhat.com

Itamar Heim has submitted this change and it was merged. Change subject: packaging: ovirt-engine-3.3.1 ...................................................................... packaging: ovirt-engine-3.3.1 Updated version to 3.3.1-1 Change-Id: I8150af7dbdef4bda92cb4532f05e5595de86d70f Bug-Url: https://bugzilla.redhat.com/1019391 Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M ovirt-engine.spec.in M version.mak 2 files changed, 5 insertions(+), 2 deletions(-) Approvals: Sandro Bonazzola: Verified Itamar Heim: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/20706 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8150af7dbdef4bda92cb4532f05e5595de86d70f Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.3.1 Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Michael Burns <mburns(a)redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

10 years, 5 months

1
0
0 / 0

Change in ovirt-engine[master]: restapi: fix vm link for template's watchdog

by gchaplik＠redhat.com

Gilad Chaplik has submitted this change and it was merged. Change subject: restapi: fix vm link for template's watchdog ...................................................................... restapi: fix vm link for template's watchdog Change-Id: Ie84c9809a8cbb0fddf0daf39f22be97a8eadb938 Bug-Url: https://bugzilla.redhat.com/1019211 Signed-off-by: Gilad Chaplik <gchaplik(a)redhat.com> --- M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendTemplateResource.java A backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendTemplateWatchdogsResource.java 2 files changed, 25 insertions(+), 1 deletion(-) Approvals: Gilad Chaplik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/20529 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie84c9809a8cbb0fddf0daf39f22be97a8eadb938 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

10 years, 5 months

1
0
0 / 0

Change in ovirt-engine[master]: restapi: NPE in setJobLink flow

by gchaplik＠redhat.com

Gilad Chaplik has submitted this change and it was merged. Change subject: restapi: NPE in setJobLink flow ...................................................................... restapi: NPE in setJobLink flow Action should be initialized prior to setting a job id. Change-Id: Iadfd502de54cd34d9cc5e4dc70d4bd6f52f83cf7 Signed-off-by: Gilad Chaplik <gchaplik(a)redhat.com> --- M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendResource.java 1 file changed, 3 insertions(+), 3 deletions(-) Approvals: Gilad Chaplik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/20629 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iadfd502de54cd34d9cc5e4dc70d4bd6f52f83cf7 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

10 years, 5 months

1
0
0 / 0

Change in ovirt-engine[master]: engine: fix typo in ManageDomainsResult

by amureini＠redhat.com

Allon Mureinik has submitted this change and it was merged. Change subject: engine: fix typo in ManageDomainsResult ...................................................................... engine: fix typo in ManageDomainsResult Change-Id: I4d9d92d34f6267d359e22adf90e940f1034a2f3e Signed-off-by: Alissa Bonas <abonas(a)redhat.com> --- M backend/manager/tools/src/main/java/org/ovirt/engine/core/domains/ManageDomainsResult.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Allon Mureinik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/20601 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4d9d92d34f6267d359e22adf90e940f1034a2f3e Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

10 years, 5 months

1
0
0 / 0

Change in ovirt-engine[ovirt-engine-3.3]: webadmin: Don't display DCs that imported external network

by iheim＠redhat.com

Itamar Heim has submitted this change and it was merged. Change subject: webadmin: Don't display DCs that imported external network ...................................................................... webadmin: Don't display DCs that imported external network Changed the import networks dialog so that the choice of DC to import an external network to, will only include DCs where the network doesn't exist yet. This required modification of the backend query to not only retrieve all the external networks that exist on a provider, but also map each network to the set of DCs where that network had already been imported. This set is then used to efficiently check whether a certain external network had been imported to a certain DC. Change-Id: Ifd76b527500957ec47db6d60894b0d7316d17058 Bug-Url: https://bugzilla.redhat.com/989909 Signed-off-by: Lior Vernia <lvernia(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/provider/network/GetAllExternalNetworksOnProviderQuery.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/provider/network/GetAllExternalNetworksOnProviderQueryTest.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/StoragePoolDAO.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/StoragePoolDAODbFacadeImpl.java M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/FixturesTool.java M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/StoragePoolDAOTest.java M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/network/NetworkDaoTest.java M backend/manager/modules/dal/src/test/resources/fixtures.xml M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/dataprovider/AsyncDataProvider.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/networks/ImportNetworksModel.java M packaging/dbscripts/storages_sp.sql 11 files changed, 135 insertions(+), 18 deletions(-) Approvals: Itamar Heim: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/20605 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ifd76b527500957ec47db6d60894b0d7316d17058 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.3 Gerrit-Owner: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

10 years, 5 months

1
0
0 / 0

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

Engine-commits October 2013