October 2013 - Engine-commits - oVirt List Archives

Change in ovirt-engine[ovirt-engine-3.3]: packaging: setup: cleanup: sort generated files
by iheim＠redhat.com 24 Oct '13

24 Oct '13

Itamar Heim has submitted this change and it was merged. Change subject: packaging: setup: cleanup: sort generated files ...................................................................... packaging: setup: cleanup: sort generated files Related-To: https://bugzilla.redhat.com/show_bug.cgi?id=1020675 Change-Id: I69e8e030e8619282804cf1990af199941211b3d4 Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M .gitignore M Makefile 2 files changed, 15 insertions(+), 15 deletions(-) Approvals: Itamar Heim: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/20514 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I69e8e030e8619282804cf1990af199941211b3d4 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.3 Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: [db]Upgrade from ovirt-engine-3.3 to master fails
by emesika＠redhat.com 24 Oct '13

24 Oct '13

Eli Mesika has submitted this change and it was merged. Change subject: [db]Upgrade from ovirt-engine-3.3 to master fails ...................................................................... [db]Upgrade from ovirt-engine-3.3 to master fails This patch renames a script that should be prefixed with 03_04 and had wrong 03_03 prefix which cause to version duplication on upgrade from 3.3 stable branch Change-Id: I5f79c47e8122bc5a7ae96f508996f6b318a54e45 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1023048 Signed-off-by: Eli Mesika <emesika(a)redhat.com> --- R packaging/dbscripts/upgrade/03_04_0060_add_snapshot_id_column_to_vm_device.sql 1 file changed, 0 insertions(+), 0 deletions(-) Approvals: Eli Mesika: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/20525 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5f79c47e8122bc5a7ae96f508996f6b318a54e45 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: removal of unused method
by mlipchuk＠redhat.com 24 Oct '13

24 Oct '13

Maor Lipchuk has submitted this change and it was merged. Change subject: core: removal of unused method ...................................................................... core: removal of unused method ImagesHandler.getActiveVolume isn't used anymore, therefore it can be removed. Change-Id: I33debd24aab205e8fd31f7ad7ed6c2a2b1ea2117 Signed-off-by: Liron Aravot <laravot(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImagesHandler.java 1 file changed, 0 insertions(+), 4 deletions(-) Approvals: Maor Lipchuk: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/20533 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I33debd24aab205e8fd31f7ad7ed6c2a2b1ea2117 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liron Ar <laravot(a)redhat.com> Gerrit-Reviewer: Liron Ar <laravot(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-log-collector[master]: conf: use ovirt-engine-lib configfile
by sbonazzo＠redhat.com 24 Oct '13

24 Oct '13

Sandro Bonazzola has submitted this change and it was merged. Change subject: conf: use ovirt-engine-lib configfile ...................................................................... conf: use ovirt-engine-lib configfile Use ovirt-engine-lib configfile module for reading configuration files. The previous implementation had an issue if a variable was defined recursively in more than one config file. Change-Id: I1f47875a279953bae783407dca41102904a70061 Bug-Url: http://bugzilla.redhat.com/1022557 Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M ovirt-log-collector.spec.in M src/Makefile.am M src/__main__.py D src/util.py 4 files changed, 6 insertions(+), 110 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved Kiril Nesenko: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/20531 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1f47875a279953bae783407dca41102904a70061 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-log-collector Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Alex Lourie <alourie(a)redhat.com> Gerrit-Reviewer: Keith Robertson <kroberts(a)redhat.com> Gerrit-Reviewer: Kiril Nesenko <knesenko(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: webadmin - Fix report error msg on selecting entities across...
by derez＠redhat.com 24 Oct '13

24 Oct '13

Daniel Erez has submitted this change and it was merged. Change subject: webadmin - Fix report error msg on selecting entities across DCs ...................................................................... webadmin - Fix report error msg on selecting entities across DCs When selecting multiple Hosts/VMs from different DCs and opening a report Via Webadmin. An incorrect error message is displayed "Please select reports from the same data center" The message has been rephrased "Please select entities from the same data center" Change-Id: Ied2cbfd83aca1add35d7575fb117ed255385a0dc Bug-Url: https://bugzilla.redhat.com/885983 Signed-off-by: Ravi Nori <rnori(a)redhat.com> --- M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/ApplicationConstants.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/presenter/ReportPresenterWidget.java 2 files changed, 3 insertions(+), 3 deletions(-) Approvals: Ravi Nori: Verified Daniel Erez: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/20365 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ied2cbfd83aca1add35d7575fb117ed255385a0dc Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine-cli[master]: cli: do not ask for credentials when -h--/help in args
by mpastern＠redhat.com 24 Oct '13

24 Oct '13

Michael Pasternak has submitted this change and it was merged. Change subject: cli: do not ask for credentials when -h--/help in args ...................................................................... cli: do not ask for credentials when -h--/help in args Change-Id: I26eb25ef079bd7335c71bcc935276176ff781b66 Signed-off-by: Michael pasternak <mpastern(a)redhat.com> --- M src/cli/context.py 1 file changed, 4 insertions(+), 1 deletion(-) Approvals: Michael Pasternak: Verified; Looks good to me, approved Ravi Nori: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/20521 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I26eb25ef079bd7335c71bcc935276176ff781b66 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine-cli Gerrit-Branch: master Gerrit-Owner: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com>

1 0

Change in ovirt-engine-cli[master]: cli: implement PromptManager
by mpastern＠redhat.com 24 Oct '13

24 Oct '13

Michael Pasternak has submitted this change and it was merged. Change subject: cli: implement PromptManager ...................................................................... cli: implement PromptManager Change-Id: Ic29a274eeefef65e75987a35aa0214b4c0eb76ac Signed-off-by: Michael pasternak <mpastern(a)redhat.com> --- M src/ovirtcli/shell/engineshell.py A src/ovirtcli/shell/promptmanager.py 2 files changed, 115 insertions(+), 88 deletions(-) Approvals: Michael Pasternak: Verified; Looks good to me, approved Ravi Nori: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/20520 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic29a274eeefef65e75987a35aa0214b4c0eb76ac Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine-cli Gerrit-Branch: master Gerrit-Owner: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com>

1 0

Change in ovirt-engine-cli[master]: cli: move history management to the core
by mpastern＠redhat.com 24 Oct '13

24 Oct '13

Michael Pasternak has submitted this change and it was merged. Change subject: cli: move history management to the core ...................................................................... cli: move history management to the core Change-Id: I588d8df43f7af186da09ba9ed567cd89943cbe73 Signed-off-by: Michael pasternak <mpastern(a)redhat.com> --- M src/ovirtcli/command/connect.py M src/ovirtcli/command/disconnect.py M src/ovirtcli/shell/engineshell.py 3 files changed, 2 insertions(+), 2 deletions(-) Approvals: Michael Pasternak: Verified; Looks good to me, approved Ravi Nori: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/20519 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I588d8df43f7af186da09ba9ed567cd89943cbe73 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine-cli Gerrit-Branch: master Gerrit-Owner: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com>

1 0

Change in ovirt-engine-cli[master]: cli: introducing FiniteStateMachine (2/2)
by mpastern＠redhat.com 24 Oct '13

24 Oct '13

Michael Pasternak has submitted this change and it was merged. Change subject: cli: introducing FiniteStateMachine (2/2) ...................................................................... cli: introducing FiniteStateMachine (2/2) this patch: - completes state management cycle. - moves visualisation experience away from the shell/commands to the state callbacks making engineshell only maintainer. Change-Id: Ia739a5484b83ebd4cbdf0c4fabf7e763a20fa58f Signed-off-by: Michael pasternak <mpastern(a)redhat.com> --- M src/cli/error.py M src/ovirtcli/command/connect.py M src/ovirtcli/command/disconnect.py M src/ovirtcli/listeners/errorlistener.py M src/ovirtcli/shell/connectcmdshell.py M src/ovirtcli/shell/disconnectcmdshell.py M src/ovirtcli/shell/engineshell.py D src/ovirtcli/state/dfsaeventcontext.py M src/ovirtcli/state/dfsastate.py M src/ovirtcli/state/finitestatemachine.py M src/ovirtcli/state/statemachine.py 11 files changed, 119 insertions(+), 142 deletions(-) Approvals: Michael Pasternak: Verified; Looks good to me, approved Ravi Nori: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/20508 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia739a5484b83ebd4cbdf0c4fabf7e763a20fa58f Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine-cli Gerrit-Branch: master Gerrit-Owner: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com>

1 0

Change in ovirt-engine-cli[master]: cli: introducing FiniteStateMachine (1/2)
by mpastern＠redhat.com 24 Oct '13

24 Oct '13

Michael Pasternak has submitted this change and it was merged. Change subject: cli: introducing FiniteStateMachine (1/2) ...................................................................... cli: introducing FiniteStateMachine (1/2) This patch moves shell state management to the Deterministic Finite State Machine (DFSA). Change-Id: Ic3ea3cf7fa82eb82c2323d96231de0a5e1094056 Signed-off-by: Michael pasternak <mpastern(a)redhat.com> --- M src/cli/error.py M src/ovirtcli/__init__.py M src/ovirtcli/annotations/requires.py A src/ovirtcli/annotations/singleton.py M src/ovirtcli/command/connect.py M src/ovirtcli/command/disconnect.py D src/ovirtcli/listeners/exitlistener.py A src/ovirtcli/meta/__init__.py A src/ovirtcli/meta/singleton.py M src/ovirtcli/shell/engineshell.py A src/ovirtcli/state/__init__.py A src/ovirtcli/state/dfsaevent.py A src/ovirtcli/state/dfsaeventcontext.py A src/ovirtcli/state/dfsastate.py A src/ovirtcli/state/finitestatemachine.py A src/ovirtcli/state/statemachine.py 16 files changed, 884 insertions(+), 77 deletions(-) Approvals: Michael Pasternak: Verified; Looks good to me, approved Ravi Nori: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/20451 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic3ea3cf7fa82eb82c2323d96231de0a5e1094056 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine-cli Gerrit-Branch: master Gerrit-Owner: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com>

1 0