Change in ovirt-engine-cli[master]: cli: cleanup
by mpastern@redhat.com
Michael Pasternak has submitted this change and it was merged.
Change subject: cli: cleanup
......................................................................
cli: cleanup
Change-Id: I051dd8ee06bbbc115ca963cbc1bc1be2c816ae6c
Signed-off-by: Michael pasternak <mpastern(a)redhat.com>
---
M src/ovirtcli/command/action.py
M src/ovirtcli/command/add.py
M src/ovirtcli/command/connect.py
M src/ovirtcli/command/console.py
M src/ovirtcli/command/disconnect.py
M src/ovirtcli/command/info.py
M src/ovirtcli/command/list.py
M src/ovirtcli/command/ping.py
M src/ovirtcli/command/remove.py
M src/ovirtcli/command/show.py
M src/ovirtcli/command/update.py
M src/ovirtcli/utils/colorhelper.py
12 files changed, 380 insertions(+), 184 deletions(-)
Approvals:
Michael Pasternak: Verified; Looks good to me, approved
Ravi Nori: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/20355
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I051dd8ee06bbbc115ca963cbc1bc1be2c816ae6c
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine-cli
Gerrit-Branch: master
Gerrit-Owner: Michael Pasternak <mpastern(a)redhat.com>
Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com>
Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com>
11 years, 2 months
Change in ovirt-engine-cli[master]: cli: limit history length to 3000
by mpastern@redhat.com
Michael Pasternak has submitted this change and it was merged.
Change subject: cli: limit history length to 3000
......................................................................
cli: limit history length to 3000
Change-Id: Iab4633d3ea9640eabf357d19ff93190688ae187f
Signed-off-by: Michael pasternak <mpastern(a)redhat.com>
---
M src/ovirtcli/historymanager.py
1 file changed, 1 insertion(+), 0 deletions(-)
Approvals:
Michael Pasternak: Verified; Looks good to me, approved
Ravi Nori: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/20353
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Iab4633d3ea9640eabf357d19ff93190688ae187f
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine-cli
Gerrit-Branch: master
Gerrit-Owner: Michael Pasternak <mpastern(a)redhat.com>
Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com>
Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com>
11 years, 2 months
Change in ovirt-engine-cli[master]: cli: raise CommandError on generic errors
by mpastern@redhat.com
Michael Pasternak has submitted this change and it was merged.
Change subject: cli: raise CommandError on generic errors
......................................................................
cli: raise CommandError on generic errors
Change-Id: I7bf173b4a1ab112d4fbc30fbfe797b9fe4929800
Signed-off-by: Michael pasternak <mpastern(a)redhat.com>
---
M src/ovirtcli/shell/engineshell.py
1 file changed, 2 insertions(+), 1 deletion(-)
Approvals:
Michael Pasternak: Verified; Looks good to me, approved
Ravi Nori: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/20328
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I7bf173b4a1ab112d4fbc30fbfe797b9fe4929800
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine-cli
Gerrit-Branch: master
Gerrit-Owner: Michael Pasternak <mpastern(a)redhat.com>
Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com>
Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com>
11 years, 2 months
Change in ovirt-engine-cli[master]: cli: implement /exit events listener
by mpastern@redhat.com
Michael Pasternak has submitted this change and it was merged.
Change subject: cli: implement /exit events listener
......................................................................
cli: implement /exit events listener
ExitListener is listens for the /exit events and triggers
/disconnect command,
this way even if shell will be killed via ctrl-d event
(not via standard way of exiting - /exit command), /disconnect
command still will be triggered releasing local and remote
resources.
Change-Id: If5dcd1a7433f71f4b4321641b168e72659f13058
Signed-off-by: Michael pasternak <mpastern(a)redhat.com>
---
M src/ovirtcli/command/disconnect.py
A src/ovirtcli/listeners/exitlistener.py
M src/ovirtcli/shell/engineshell.py
3 files changed, 48 insertions(+), 4 deletions(-)
Approvals:
Michael Pasternak: Verified; Looks good to me, approved
Ravi Nori: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/20323
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: If5dcd1a7433f71f4b4321641b168e72659f13058
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine-cli
Gerrit-Branch: master
Gerrit-Owner: Michael Pasternak <mpastern(a)redhat.com>
Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com>
Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com>
11 years, 2 months
Change in ovirt-engine-cli[master]: cli: introducing event driven messaging
by mpastern@redhat.com
Michael Pasternak has submitted this change and it was merged.
Change subject: cli: introducing event driven messaging
......................................................................
cli: introducing event driven messaging
Change-Id: I110a2b7d25a03ed1f256f24058f3c54535e27100
Signed-off-by: Michael pasternak <mpastern(a)redhat.com>
---
A src/ovirtcli/annotations/__init__.py
A src/ovirtcli/annotations/requires.py
A src/ovirtcli/events/__init__.py
A src/ovirtcli/events/abstractevent.py
A src/ovirtcli/events/event.py
A src/ovirtcli/events/ievent.py
A src/ovirtcli/listeners/__init__.py
A src/ovirtcli/listeners/abstractlistener.py
A src/ovirtcli/listeners/errorlistener.py
A src/ovirtcli/listeners/ilistener.py
M src/ovirtcli/shell/cmdshell.py
M src/ovirtcli/shell/engineshell.py
12 files changed, 391 insertions(+), 31 deletions(-)
Approvals:
Michael Pasternak: Verified; Looks good to me, approved
Ravi Nori: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/20321
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I110a2b7d25a03ed1f256f24058f3c54535e27100
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine-cli
Gerrit-Branch: master
Gerrit-Owner: Michael Pasternak <mpastern(a)redhat.com>
Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com>
Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com>
11 years, 2 months
Change in ovirt-engine-cli[master]: cli: introducing new state UNAUTHORIZED
by mpastern@redhat.com
Michael Pasternak has submitted this change and it was merged.
Change subject: cli: introducing new state UNAUTHORIZED
......................................................................
cli: introducing new state UNAUTHORIZED
AUTHENTICATION_ERROR can occur when authentication session expires,
this is yet another recoverable error that exposed via own state -
UNAUTHORIZED
Change-Id: I287743f00ba34997d7e2bbc1aaf5a65c86038ade
Signed-off-by: Michael pasternak <mpastern(a)redhat.com>
---
M src/cli/context.py
M src/ovirtcli/command/connect.py
M src/ovirtcli/prompt.py
M src/ovirtcli/settings.py
M src/ovirtcli/shell/engineshell.py
5 files changed, 57 insertions(+), 29 deletions(-)
Approvals:
Michael Pasternak: Verified; Looks good to me, approved
Ravi Nori: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/20245
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I287743f00ba34997d7e2bbc1aaf5a65c86038ade
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine-cli
Gerrit-Branch: master
Gerrit-Owner: Michael Pasternak <mpastern(a)redhat.com>
Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com>
Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com>
11 years, 2 months
Change in ovirt-engine-cli[master]: cli: implement visualization effects
by mpastern@redhat.com
Michael Pasternak has submitted this change and it was merged.
Change subject: cli: implement visualization effects
......................................................................
cli: implement visualization effects
Change-Id: I074e6d03f46f42261f96a71024fe28f871bd0c65
Signed-off-by: Michael pasternak <mpastern(a)redhat.com>
---
M src/cli/command/command.py
M src/cli/context.py
M src/cli/error.py
M src/cli/messages.py
A src/cli/warning.py
M src/ovirtcli/shell/engineshell.py
A src/ovirtcli/utils/colorhelper.py
7 files changed, 182 insertions(+), 20 deletions(-)
Approvals:
Michael Pasternak: Verified; Looks good to me, approved
Ravi Nori: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/20147
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I074e6d03f46f42261f96a71024fe28f871bd0c65
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine-cli
Gerrit-Branch: master
Gerrit-Owner: Michael Pasternak <mpastern(a)redhat.com>
Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com>
Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com>
11 years, 2 months
Change in ovirt-engine-cli[master]: cli: validate args in /connect command
by mpastern@redhat.com
Michael Pasternak has submitted this change and it was merged.
Change subject: cli: validate args in /connect command
......................................................................
cli: validate args in /connect command
Change-Id: I785672abf85b317379604e9b30db0687b8a9653d
Signed-off-by: Michael pasternak <mpastern(a)redhat.com>
---
M src/ovirtcli/command/connect.py
1 file changed, 14 insertions(+), 8 deletions(-)
Approvals:
Michael Pasternak: Verified; Looks good to me, approved
Ravi Nori: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/20141
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I785672abf85b317379604e9b30db0687b8a9653d
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine-cli
Gerrit-Branch: master
Gerrit-Owner: Michael Pasternak <mpastern(a)redhat.com>
Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com>
Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com>
11 years, 2 months
Change in ovirt-engine-cli[master]: cli: expose api capabilities in cli 2/2 #891227
by mpastern@redhat.com
Michael Pasternak has submitted this change and it was merged.
Change subject: cli: expose api capabilities in cli 2/2 #891227
......................................................................
cli: expose api capabilities in cli 2/2 #891227
add indentation to command output
Bug-Url: https://bugzilla.redhat.com/891227
Change-Id: I035a4a4f6bf45d237c5751473bb0a9b424b7c2d1
Signed-off-by: Michael pasternak <mpastern(a)redhat.com>
---
M src/ovirtcli/command/capabilities.py
1 file changed, 2 insertions(+), 3 deletions(-)
Approvals:
Michael Pasternak: Verified; Looks good to me, approved
Ravi Nori: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/20139
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I035a4a4f6bf45d237c5751473bb0a9b424b7c2d1
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine-cli
Gerrit-Branch: master
Gerrit-Owner: Michael Pasternak <mpastern(a)redhat.com>
Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com>
Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com>
11 years, 2 months
Change in ovirt-engine[ovirt-engine-3.3]: engine: Prevent empty MAC Address range
by iheim@redhat.com
Itamar Heim has submitted this change and it was merged.
Change subject: engine: Prevent empty MAC Address range
......................................................................
engine: Prevent empty MAC Address range
The patch prevents a user from entering a mac address
range which might result in an empty pool, for example
a range which contains multicast mac addresses only.
Change-Id: I24113379e8fbbc15a63bdb1be4e6c719d7cb764f
Bug-Url: https://bugzilla.redhat.com/1011912
Signed-off-by: Moti Asayag <masayag(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/MacPoolManager.java
A backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/MacAddressRangeUtils.java
M backend/manager/tools/src/main/java/org/ovirt/engine/core/config/entity/helper/MacAddressPoolRangesValueHelper.java
M backend/manager/tools/src/test/java/org/ovirt/engine/core/config/entity/helper/MacAddressPoolRangesValueHelperTest.java
4 files changed, 73 insertions(+), 73 deletions(-)
Approvals:
Itamar Heim: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/20177
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I24113379e8fbbc15a63bdb1be4e6c719d7cb764f
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.3
Gerrit-Owner: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com>
Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
11 years, 2 months