October 2013 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: webadmin: remove quota comsumer is broken
by gchaplik＠redhat.com 20 Oct '13

20 Oct '13

Gilad Chaplik has submitted this change and it was merged. Change subject: webadmin: remove quota comsumer is broken ...................................................................... webadmin: remove quota comsumer is broken Although we use MLA dialogs, there is another treatment for consume_quota role (i.e. hiding it). generalizing it with other remove permission dialog creates an error. Change-Id: I794983826b8b6fc9fffc6f504db11fce00788633 Signed-off-by: Gilad Chaplik <gchaplik(a)redhat.com> --- M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/gin/uicommon/QuotaModule.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Gilad Chaplik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/19959 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I794983826b8b6fc9fffc6f504db11fce00788633 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com> Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.3]: packaging: setup: No spaces in /etc/sysconfig/nfs
by oschreib＠redhat.com 20 Oct '13

20 Oct '13

Ofer Schreiber has submitted this change and it was merged. Change subject: packaging: setup: No spaces in /etc/sysconfig/nfs ...................................................................... packaging: setup: No spaces in /etc/sysconfig/nfs Do not put spaces around '=' in lines added to /etc/sysconfig/nfs . Adding them breaks sysvinit-based nfs init sh scripts. Bug-Url: https://bugzilla.redhat.com/1013347 Change-Id: Ib9e1442b764cc9aef88044b7c1595236903edecf Signed-off-by: Yedidyah Bar David <didi(a)redhat.com> --- M packaging/setup/plugins/ovirt-engine-setup/system/nfs.py 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Ofer Schreiber: Looks good to me, approved Yedidyah Bar David: Verified -- To view, visit http://gerrit.ovirt.org/20316 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib9e1442b764cc9aef88044b7c1595236903edecf Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.3 Gerrit-Owner: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: packaging: setup: No spaces in /etc/sysconfig/nfs
by oschreib＠redhat.com 20 Oct '13

20 Oct '13

Ofer Schreiber has submitted this change and it was merged. Change subject: packaging: setup: No spaces in /etc/sysconfig/nfs ...................................................................... packaging: setup: No spaces in /etc/sysconfig/nfs Do not put spaces around '=' in lines added to /etc/sysconfig/nfs . Adding them breaks sysvinit-based nfs init sh scripts. Bug-Url: https://bugzilla.redhat.com/1013347 Change-Id: Ib9e1442b764cc9aef88044b7c1595236903edecf Signed-off-by: Yedidyah Bar David <didi(a)redhat.com> --- M packaging/setup/plugins/ovirt-engine-setup/system/nfs.py 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Ofer Schreiber: Looks good to me, approved Yedidyah Bar David: Verified -- To view, visit http://gerrit.ovirt.org/20315 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib9e1442b764cc9aef88044b7c1595236903edecf Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com>

1 0

Change in ovirt-engine[master]: gluster: Added missing entries to AbstractGlusterBrokerCommand
by kmayilsa＠redhat.com 18 Oct '13

18 Oct '13

Kanagaraj M has submitted this change and it was merged. Change subject: gluster: Added missing entries to AbstractGlusterBrokerCommand ...................................................................... gluster: Added missing entries to AbstractGlusterBrokerCommand Added missing entries into AbstractGlusterBrokerCommand class for gluster async tasks. Change-Id: I66da63298cee49f108cd6a8c967969194939da98 Signed-off-by: Shubhendu Tripathi <shtripat(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/gluster/AbstractGlusterBrokerCommand.java 1 file changed, 2 insertions(+), 0 deletions(-) Approvals: Kanagaraj M: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/20140 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I66da63298cee49f108cd6a8c967969194939da98 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shubhendu Tripathi <shtripat(a)redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayilsa(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: gluster: Removed check of async task details in volume
by kmayilsa＠redhat.com 18 Oct '13

18 Oct '13

Kanagaraj M has submitted this change and it was merged. Change subject: gluster: Removed check of async task details in volume ...................................................................... gluster: Removed check of async task details in volume Removed checking the existence of async task details in volume entity for the purpose of checking the rebalance execution status on a volume. This is not required and we should always depend upon the actual value returned from glusterfs for the rebalance status as that value would be the uptodate and correct value. Change-Id: I54a0f0949cfc8c2fb46bec816519449e583a6b65 Signed-off-by: Shubhendu Tripathi <shtripat(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GetGlusterVolumeRebalanceStatusQuery.java 1 file changed, 9 insertions(+), 10 deletions(-) Approvals: Kanagaraj M: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/19864 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I54a0f0949cfc8c2fb46bec816519449e583a6b65 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shubhendu Tripathi <shtripat(a)redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayilsa(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com> Gerrit-Reviewer: Shubhendu Tripathi <shtripat(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: engine: add missing exclude-filters
by ecohen＠redhat.com 17 Oct '13

17 Oct '13

Einav Cohen has submitted this change and it was merged. Change subject: engine: add missing exclude-filters ...................................................................... engine: add missing exclude-filters - Added missing exclude-filters in new branding module. Change-Id: Ib884665517f18a0e2c53d101696cc0c94ed8044a Signed-off-by: Alexander Wels <awels(a)redhat.com> --- A backend/manager/modules/branding/exclude-filters.xml 1 file changed, 2 insertions(+), 0 deletions(-) Approvals: Einav Cohen: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/20270 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib884665517f18a0e2c53d101696cc0c94ed8044a Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com> Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: bugfix in correlationId machanism
by masayag＠redhat.com 17 Oct '13

17 Oct '13

Moti Asayag has submitted this change and it was merged. Change subject: core: bugfix in correlationId machanism ...................................................................... core: bugfix in correlationId machanism In commit http://gerrit.ovirt.org/#/c/15795/16 a bug was introduced causing certain commands to not log their correlationId (see bug description comment). correlationId must be written on thread local to get logged. Change-Id: Ie416d6f48f6209985f3cae36566a475e7fa90963 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=987915 Signed-off-by: Mooli Tayer <mtayer(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandBase.java 1 file changed, 9 insertions(+), 4 deletions(-) Approvals: mooli tayer: Verified Moti Asayag: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/20160 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie416d6f48f6209985f3cae36566a475e7fa90963 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: mooli tayer <mtayer(a)redhat.com> Gerrit-Reviewer: Eli Mesika <elimesika(a)gmail.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: mooli tayer <mtayer(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: backend: Remove duplicate read of TimeZone in OvfVmReader
by ofrenkel＠redhat.com 17 Oct '13

17 Oct '13

Omer Frenkel has submitted this change and it was merged. Change subject: backend: Remove duplicate read of TimeZone in OvfVmReader ...................................................................... backend: Remove duplicate read of TimeZone in OvfVmReader Removed duplicate read of TimeZone ovf-field which was not sanitized against empty strings causing creation of Vm with invalid timezone "" (correctly should be normalized to null). Also removed the temporary fix in TimeZoneValidator since now all cases should be covered and the empty string time-zone always normalized to null. Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1015049 Change-Id: I9152bc347a5358ca794ee8c237e4486f444862ee Signed-off-by: Martin Betak <mbetak(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/validation/TimeZoneValidator.java M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ovf/OvfVmReader.java 2 files changed, 1 insertion(+), 5 deletions(-) Approvals: Omer Frenkel: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/19987 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9152bc347a5358ca794ee8c237e4486f444862ee Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Betak <mbetak(a)redhat.com> Gerrit-Reviewer: Martin Betak <mbetak(a)redhat.com> Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: gluster: Corrected the remove bricks status at issue
by ofrenkel＠redhat.com 17 Oct '13

17 Oct '13

Omer Frenkel has submitted this change and it was merged. Change subject: gluster: Corrected the remove bricks status at issue ...................................................................... gluster: Corrected the remove bricks status at issue Corrected to set the correct value of the started at field value for the task started for removal of gluster volumes bricks. Change-Id: I0d6d5dacffef2306545e269c2d7df08238e4e166 Signed-off-by: Shubhendu Tripathi <shtripat(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GetGlusterVolumeRemoveBricksStatusQuery.java 1 file changed, 8 insertions(+), 4 deletions(-) Approvals: Omer Frenkel: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/20181 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0d6d5dacffef2306545e269c2d7df08238e4e166 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shubhendu Tripathi <shtripat(a)redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayilsa(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com> Gerrit-Reviewer: Shubhendu Tripathi <shtripat(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: engine: Query to get gluster volume by task id
by ofrenkel＠redhat.com 17 Oct '13

17 Oct '13

Omer Frenkel has submitted this change and it was merged. Change subject: engine: Query to get gluster volume by task id ...................................................................... engine: Query to get gluster volume by task id Added a query to return volume associated with a given gluster task id Change-Id: Id02dd690619f2fe204e42a9972f20a6c9ce8146b Signed-off-by: Sahina Bose <sabose(a)redhat.com> --- A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GetGlusterVolumeByTaskIdQuery.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/VdcQueryType.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/gluster/GlusterVolumeDaoDbFacadeImpl.java 3 files changed, 20 insertions(+), 0 deletions(-) Approvals: Omer Frenkel: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/19914 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id02dd690619f2fe204e42a9972f20a6c9ce8146b Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Sahina Bose <sabose(a)redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayilsa(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com> Gerrit-Reviewer: Shubhendu Tripathi <shtripat(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0