Change in ovirt-engine[ovirt-engine-3.3]: restapi: Inconsistent schema implementation in PayloadFile #...
by iheim＠redhat.com
Itamar Heim has submitted this change and it was merged.
Change subject: restapi: Inconsistent schema implementation in PayloadFile #1019618
......................................................................
restapi: Inconsistent schema implementation in PayloadFile #1019618
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1019618
Change-Id: I82ec264bb18798fd911143741b60a4e9469efd48
Signed-off-by: Michael pasternak <mpastern(a)redhat.com>
---
M backend/manager/modules/restapi/interface/definition/src/main/resources/api.xsd
M backend/manager/modules/restapi/interface/definition/src/main/resources/rsdl_metadata.yaml
M backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/VmMapper.java
3 files changed, 18 insertions(+), 28 deletions(-)
Approvals:
Itamar Heim: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/20163
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I82ec264bb18798fd911143741b60a4e9469efd48
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.3
Gerrit-Owner: Michael Pasternak <mpastern(a)redhat.com>
Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com>
Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com>
Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com>
Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
11 years, 2 months
Change in ovirt-engine[ovirt-engine-3.3]: core: Fix the numbering of the last db upgrade script
by iheim＠redhat.com
Itamar Heim has submitted this change and it was merged.
Change subject: core: Fix the numbering of the last db upgrade script
......................................................................
core: Fix the numbering of the last db upgrade script
Change-Id: Ib4f03433f502a092a53ac0e43ba458bc7fa52f64
Signed-off-by: Martin Sivak <msivak(a)redhat.com>
---
R packaging/dbscripts/upgrade/03_03_0950_pin_to_host_first_in_powersaving_policy.sql
1 file changed, 0 insertions(+), 0 deletions(-)
Approvals:
Martin Sivák: Verified
Itamar Heim: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/20217
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ib4f03433f502a092a53ac0e43ba458bc7fa52f64
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.3
Gerrit-Owner: Martin Sivák <msivak(a)redhat.com>
Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com>
Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com>
Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com>
Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
11 years, 2 months
Change in ovirt-engine[master]: core: adding HA score with proper scheduling policies
by dfediuck＠redhat.com
Doron Fediuck has submitted this change and it was merged.
Change subject: core: adding HA score with proper scheduling policies
......................................................................
core: adding HA score with proper scheduling policies
This patch adds the HA score to VdsStatistics, filling it up where
relevant, and using it when scheduling the hosted engine VM.
Change-Id: I24879ed64cab829969556fd71786b32d3aaaf0c7
Signed-off-by: Oved Ourfali <oourfali(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/PolicyUnitImpl.java
A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/policyunits/HostedEngineHAClusterFilterPolicyUnit.java
A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/policyunits/HostedEngineHAClusterWeightPolicyUnit.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VDS.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VdsStatistics.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/VdcBllMessages.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VdsDAODbFacadeImpl.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VdsStatisticsDAODbFacadeImpl.java
M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties
M backend/manager/modules/dal/src/test/resources/fixtures.xml
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsUpdateRunTimeInfo.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsBrokerObjectsBuilder.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsProperties.java
M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java
M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties
M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties
M packaging/dbscripts/create_views.sql
A packaging/dbscripts/upgrade/03_04_0030_add_ha_score_to_vds_statistics.sql
A packaging/dbscripts/upgrade/03_04_0040_add_ha_policy_units.sql
M packaging/dbscripts/vds_sp.sql
20 files changed, 169 insertions(+), 10 deletions(-)
Approvals:
Doron Fediuck: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/20018
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I24879ed64cab829969556fd71786b32d3aaaf0c7
Gerrit-PatchSet: 10
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com>
Gerrit-Reviewer: Greg Padgett <gpadgett(a)redhat.com>
Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
11 years, 2 months
Change in ovirt-engine[master]: webadmin: Sort configure roles
by gchaplik＠redhat.com
Gilad Chaplik has submitted this change and it was merged.
Change subject: webadmin: Sort configure roles
......................................................................
webadmin: Sort configure roles
- Added sorting to 'Configure->roles'
Change-Id: If22cba5d1114cc43be39c2e770b770582ac18033
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=953570
Signed-off-by: Alexander Wels <awels(a)redhat.com>
---
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/configure/roles_ui/RoleListModel.java
1 file changed, 2 insertions(+), 1 deletion(-)
Approvals:
Gilad Chaplik: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/20207
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: If22cba5d1114cc43be39c2e770b770582ac18033
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alexander Wels <awels(a)redhat.com>
Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com>
Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com>
Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com>
Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
11 years, 2 months
Change in ovirt-engine[ovirt-engine-3.3]: packaging: setup: revert nfs config on cleanup
by iheim＠redhat.com
Itamar Heim has submitted this change and it was merged.
Change subject: packaging: setup: revert nfs config on cleanup
......................................................................
packaging: setup: revert nfs config on cleanup
Revert /etc/sysconfig/nfs to its original contents on cleanup.
Added a function editConfigContent in util to generalize edit loops
that read conf files and do some changes to them. Used it to edit
/etc/sysconfig/nfs as well as /etc/httpd/conf.d/ssl.conf and
/var/lib/pgsql/data/postgresql.conf.
Bug-Url: https://bugzilla.redhat.com/1013347
Change-Id: I74dd4c1556bd6479fcf10f85fcbe083f215e0854
Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com>
Signed-off-by: Yedidyah Bar David <didi(a)redhat.com>
---
M packaging/setup/ovirt_engine_setup/util.py
M packaging/setup/plugins/ovirt-engine-setup/apache/ssl.py
M packaging/setup/plugins/ovirt-engine-setup/provisioning/postgres.py
M packaging/setup/plugins/ovirt-engine-setup/system/nfs.py
4 files changed, 203 insertions(+), 79 deletions(-)
Approvals:
Itamar Heim: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/20204
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I74dd4c1556bd6479fcf10f85fcbe083f215e0854
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.3
Gerrit-Owner: Yedidyah Bar David <didi(a)redhat.com>
Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com>
Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
11 years, 2 months
Change in ovirt-engine[ovirt-engine-3.3]: packaging: setup: partial cleanup - db only
by iheim＠redhat.com
Itamar Heim has submitted this change and it was merged.
Change subject: packaging: setup: partial cleanup - db only
......................................................................
packaging: setup: partial cleanup - db only
Before this change, if during cleanup the user only asked to delete
only the database, then ran setup again, setup wrongly identified
the system as being legacy 3.2 and tried to upgrade, which failed.
This change makes the identification of upgrade from 3.2 legacy
more strict and in such a situation setup-engine will continue as
a new setup.
Bug-Url: https://bugzilla.redhat.com/987939
Change-Id: Id9aa1791eb7ccdbc8c679e72ed6eaa4f72ac29c6
Signed-off-by: Yedidyah Bar David <didi(a)redhat.com>
---
M packaging/setup/ovirt_engine_setup/constants.py
M packaging/setup/plugins/ovirt-engine-setup/legacy/core.py
M packaging/setup/plugins/ovirt-engine-setup/legacy/database.py
3 files changed, 73 insertions(+), 18 deletions(-)
Approvals:
Itamar Heim: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/20203
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Id9aa1791eb7ccdbc8c679e72ed6eaa4f72ac29c6
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.3
Gerrit-Owner: Yedidyah Bar David <didi(a)redhat.com>
Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com>
Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
11 years, 2 months
Change in ovirt-engine[ovirt-engine-3.3]: webadmin: Made profile name checks consistent
by iheim＠redhat.com
Itamar Heim has submitted this change and it was merged.
Change subject: webadmin: Made profile name checks consistent
......................................................................
webadmin: Made profile name checks consistent
Fixed the frontend validation to be as restrictive as the backend one
(e.g. not allowing dots), as well as added a frontend validation of
the profile names in the add/edit network dialog.
Change-Id: Ided5e902faae928608a7558a08ed1768e3d8cb81
Bug-Url: https://bugzilla.redhat.com/1012032
Signed-off-by: Lior Vernia <lvernia(a)redhat.com>
---
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/datacenters/NetworkModel.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/profiles/VnicProfileModel.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/key_value/KeyValueModel.java
3 files changed, 13 insertions(+), 4 deletions(-)
Approvals:
Itamar Heim: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/20200
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ided5e902faae928608a7558a08ed1768e3d8cb81
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.3
Gerrit-Owner: Lior Vernia <lvernia(a)redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com>
Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com>
Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
11 years, 2 months
Change in ovirt-engine[ovirt-engine-3.3]: webadmin: Hide "public" InfoIcon if checkbox hidden
by iheim＠redhat.com
Itamar Heim has submitted this change and it was merged.
Change subject: webadmin: Hide "public" InfoIcon if checkbox hidden
......................................................................
webadmin: Hide "public" InfoIcon if checkbox hidden
In previous patches disregarded the fact that the public checkbox
could be hidden, in which case the InfoIcon should also be hidden.
Change-Id: Ib3dc7a083ca212c7e5dd5e2f2e5ff8b54fa8f573
Bug-Url: https://bugzilla.redhat.com/1000804
Signed-off-by: Lior Vernia <lvernia(a)redhat.com>
---
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/vnicProfile/VnicProfileWidget.java
1 file changed, 3 insertions(+), 2 deletions(-)
Approvals:
Itamar Heim: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/20199
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ib3dc7a083ca212c7e5dd5e2f2e5ff8b54fa8f573
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.3
Gerrit-Owner: Lior Vernia <lvernia(a)redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com>
Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com>
Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
11 years, 2 months
Change in ovirt-engine[ovirt-engine-3.3]: [core] rename VdsStatic hostname to hostName.
by iheim＠redhat.com
Itamar Heim has submitted this change and it was merged.
Change subject: [core] rename VdsStatic hostname to hostName.
......................................................................
[core] rename VdsStatic hostname to hostName.
Change field name to match setters and getters.
in UpdateVdsCommand changed attribute names are derived
from getters/setters while the list of changeable fields
are derived from the field name (see vdsHandler.Init())
Change-Id: Ie6461e1ed17506f7ea2a8897ad2a3847d466268f
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1003282
Signed-off-by: Mooli Tayer <mtayer(a)redhat.com>
---
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VdsStatic.java
1 file changed, 6 insertions(+), 6 deletions(-)
Approvals:
Itamar Heim: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/19932
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ie6461e1ed17506f7ea2a8897ad2a3847d466268f
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.3
Gerrit-Owner: mooli tayer <mtayer(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: mooli tayer <mtayer(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
11 years, 2 months
Change in ovirt-engine[ovirt-engine-3.3]: engine: adding no-arg constructor to RemoveVdsParameters
by iheim＠redhat.com
Itamar Heim has submitted this change and it was merged.
Change subject: engine: adding no-arg constructor to RemoveVdsParameters
......................................................................
engine: adding no-arg constructor to RemoveVdsParameters
According to GWT serialization policy the classes used
in serialization should have a no-arg constructor.
Added a no-arg constructor to RemoveVdsParameters class
Change-Id: Ice662caf5e6a96858cf9d1f788cbf4b4744dcf7a
Bug-Url: https://bugzilla.redhat.com/1012826
Signed-off-by: Kanagaraj M <kmayilsa(a)redhat.com>
---
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/RemoveVdsParameters.java
1 file changed, 3 insertions(+), 0 deletions(-)
Approvals:
Itamar Heim: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/19947
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ice662caf5e6a96858cf9d1f788cbf4b4744dcf7a
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.3
Gerrit-Owner: Kanagaraj M <kmayilsa(a)redhat.com>
Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com>
Gerrit-Reviewer: Kanagaraj M <kmayilsa(a)redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
11 years, 2 months