October 2013 - Engine-commits - oVirt List Archives

Change in ovirt-hosted-engine-ha[master]: lib: fix acceptance of keyword arguments for vdsm api
by gpadgett＠redhat.com 15 Oct '13

15 Oct '13

Greg Padgett has submitted this change and it was merged. Change subject: lib: fix acceptance of keyword arguments for vdsm api ...................................................................... lib: fix acceptance of keyword arguments for vdsm api A prior refactoring broke keyword argument usage in calls to the run_vds_client_cmd() method. This fix allows for both argument lists and keyword arguments, and automatically converts the keyword arguments to a dict that is accepted by the vdsm api. Callers should be careful to use the proper parameter form as required by the vdsm api. Change-Id: I9931d6c87b0798152bf344ddd8b9328ce01565a8 Bug-Url: https://bugzilla.redhat.com/1015721 Signed-off-by: Greg Padgett <gpadgett(a)redhat.com> --- M ovirt_hosted_engine_ha/lib/vds_client.py 1 file changed, 8 insertions(+), 3 deletions(-) Approvals: Greg Padgett: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/19872 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9931d6c87b0798152bf344ddd8b9328ce01565a8 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-hosted-engine-ha Gerrit-Branch: master Gerrit-Owner: Greg Padgett <gpadgett(a)redhat.com> Gerrit-Reviewer: Greg Padgett <gpadgett(a)redhat.com> Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-hosted-engine-ha[master]: client: API to retrieve local host score
by gpadgett＠redhat.com 14 Oct '13

14 Oct '13

Greg Padgett has submitted this change and it was merged. Change subject: client: API to retrieve local host score ...................................................................... client: API to retrieve local host score Add client API to retrieve score of local host. Part of a series of patches to enable maintenance mode for the HA hosts and engine VM. Change-Id: I49043a33e927393941e63a89e4e93519431f3695 Bug-Url: https://bugzilla.redhat.com/1015724 Signed-off-by: Greg Padgett <gpadgett(a)redhat.com> --- M ovirt_hosted_engine_ha/client/client.py 1 file changed, 28 insertions(+), 0 deletions(-) Approvals: Greg Padgett: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/20128 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I49043a33e927393941e63a89e4e93519431f3695 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-hosted-engine-ha Gerrit-Branch: master Gerrit-Owner: Greg Padgett <gpadgett(a)redhat.com> Gerrit-Reviewer: Greg Padgett <gpadgett(a)redhat.com> Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-hosted-engine-ha[master]: lib, agent, client: change host_id key to int
by gpadgett＠redhat.com 14 Oct '13

14 Oct '13

Greg Padgett has submitted this change and it was merged. Change subject: lib, agent, client: change host_id key to int ...................................................................... lib, agent, client: change host_id key to int get_stats_from_storage() previously returned a dict with the host_id as a string. With all valid host_id values being integers, it makes the api cleaner to return an integer. Change-Id: I56b204080391cf09b2606316d9195bf12905034f Bug-Url: https://bugzilla.redhat.com/1015724 Signed-off-by: Greg Padgett <gpadgett(a)redhat.com> --- M ovirt_hosted_engine_ha/agent/hosted_engine.py M ovirt_hosted_engine_ha/client/client.py M ovirt_hosted_engine_ha/lib/brokerlink.py 3 files changed, 9 insertions(+), 9 deletions(-) Approvals: Greg Padgett: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/20127 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I56b204080391cf09b2606316d9195bf12905034f Gerrit-PatchSet: 2 Gerrit-Project: ovirt-hosted-engine-ha Gerrit-Branch: master Gerrit-Owner: Greg Padgett <gpadgett(a)redhat.com> Gerrit-Reviewer: Greg Padgett <gpadgett(a)redhat.com> Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: engine: insert formatting options with default value.
by amureini＠redhat.com 14 Oct '13

14 Oct '13

Allon Mureinik has submitted this change and it was merged. Change subject: engine: insert formatting options with default value. ...................................................................... engine: insert formatting options with default value. Add formatting options that were not in the configuration file, but were used by the formatter with their default values anyway. So adding those formatting options with same default value gives better visibility. Change-Id: Iba5ae1aa8154a8a778735749419ac8184f001d36 Signed-off-by: Alissa Bonas <abonas(a)redhat.com> --- M config/engine-code-format.xml 1 file changed, 11 insertions(+), 0 deletions(-) Approvals: Allon Mureinik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/20159 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iba5ae1aa8154a8a778735749419ac8184f001d36 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>

1 0

Change in ovirt-engine[master]: engine: remove handling GetStorageDomainListError after getI...
by amureini＠redhat.com 14 Oct '13

14 Oct '13

Allon Mureinik has submitted this change and it was merged. Change subject: engine: remove handling GetStorageDomainListError after getImagesList ...................................................................... engine: remove handling GetStorageDomainListError after getImagesList getImagesList API used by GetImagesListCommand can't return GetStorageDomainListError therefore special handling of this error is removed. Change-Id: I56d639d83bd24e6b3939933998d17c5498670b5a Signed-off-by: Sergey Gotliv <sgotliv(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/GetImagesListVDSCommand.java 1 file changed, 6 insertions(+), 22 deletions(-) Approvals: Allon Mureinik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/19858 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I56d639d83bd24e6b3939933998d17c5498670b5a Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Sergey Gotliv <sgotliv(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Liron Ar <laravot(a)redhat.com> Gerrit-Reviewer: Sergey Gotliv <sgotliv(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: engine: Remove calls to getImageDomainsList API
by amureini＠redhat.com 14 Oct '13

14 Oct '13

Allon Mureinik has submitted this change and it was merged. Change subject: engine: Remove calls to getImageDomainsList API ...................................................................... engine: Remove calls to getImageDomainsList API This API is deprecated in VDSM. Use getImagesList instead. Change-Id: I33069871db34e8b129c4d80098523654cd2a0629 Signed-off-by: Sergey Gotliv <sgotliv(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MoveOrCopyTemplateCommand.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/AddVmCommandTest.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/CommonVmPoolWithVmsCommandTestAbstract.java A backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/MoveOrCopyTemplateCommandTest.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/VdcBllMessages.java D backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/GetImageDomainsListVDSCommandParameters.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/VDSCommandType.java M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties D backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/GetImageDomainsListVDSCommand.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/IIrsServer.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/IrsServerWrapper.java M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties 13 files changed, 182 insertions(+), 127 deletions(-) Approvals: Allon Mureinik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/15951 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I33069871db34e8b129c4d80098523654cd2a0629 Gerrit-PatchSet: 8 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Sergey Gotliv <sgotliv(a)redhat.com> Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Eduardo <ewarszaw(a)redhat.com> Gerrit-Reviewer: Liron Ar <laravot(a)redhat.com> Gerrit-Reviewer: Sergey Gotliv <sgotliv(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: liron aravot <liron.aravot(a)gmail.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-hosted-engine-ha[master]: agent: use vdsm domain monitor
by gpadgett＠redhat.com 14 Oct '13

14 Oct '13

Greg Padgett has submitted this change and it was merged. Change subject: agent: use vdsm domain monitor ...................................................................... agent: use vdsm domain monitor Ensure that the storage domain is monitored by VDSM using the repoStats and startMonitoringDomain APIs. Change-Id: I9bab369784fecbf972622922a925fd0b45de123f Requires: http://gerrit.ovirt.org/19762 Requires: http://gerrit.ovirt.org/20099 Bug-Url: https://bugzilla.redhat.com/1017406 Signed-off-by: Greg Padgett <gpadgett(a)redhat.com> --- M ovirt-hosted-engine-ha.spec.in M ovirt_hosted_engine_ha/agent/constants.py.in M ovirt_hosted_engine_ha/agent/hosted_engine.py 3 files changed, 82 insertions(+), 4 deletions(-) Approvals: Greg Padgett: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/20051 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9bab369784fecbf972622922a925fd0b45de123f Gerrit-PatchSet: 5 Gerrit-Project: ovirt-hosted-engine-ha Gerrit-Branch: master Gerrit-Owner: Greg Padgett <gpadgett(a)redhat.com> Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com> Gerrit-Reviewer: Greg Padgett <gpadgett(a)redhat.com> Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-hosted-engine-ha[master]: packaging: distribute ovirt-hosted-engine-ha.spec.in in tarball
by gpadgett＠redhat.com 14 Oct '13

14 Oct '13

Greg Padgett has submitted this change and it was merged. Change subject: packaging: distribute ovirt-hosted-engine-ha.spec.in in tarball ...................................................................... packaging: distribute ovirt-hosted-engine-ha.spec.in in tarball .spec.in file is needed for a complete rebuild from the tarball. Change-Id: I86c804f39a23b4cc905d52f74fb7621bf9e80bc4 Bug-Url: https://bugzilla.redhat.com/1018278 Signed-off-by: Greg Padgett <gpadgett(a)redhat.com> --- M Makefile.am 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Greg Padgett: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/20120 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I86c804f39a23b4cc905d52f74fb7621bf9e80bc4 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-hosted-engine-ha Gerrit-Branch: master Gerrit-Owner: Greg Padgett <gpadgett(a)redhat.com> Gerrit-Reviewer: Greg Padgett <gpadgett(a)redhat.com> Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-hosted-engine-ha[master]: packaging: fixed sudoers generation
by gpadgett＠redhat.com 14 Oct '13

14 Oct '13

Greg Padgett has submitted this change and it was merged. Change subject: packaging: fixed sudoers generation ...................................................................... packaging: fixed sudoers generation sudoers is now generated at build time. Bug-Url: https://bugzilla.redhat.com/1013563 Change-Id: I1e069cefbd55a4aa7a85abd48beded57846ce78f Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M sudoers/Makefile.am 1 file changed, 5 insertions(+), 0 deletions(-) Approvals: Sandro Bonazzola: Verified Greg Padgett: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/20164 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1e069cefbd55a4aa7a85abd48beded57846ce78f Gerrit-PatchSet: 1 Gerrit-Project: ovirt-hosted-engine-ha Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Greg Padgett <gpadgett(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-hosted-engine-ha[master]: build: ovirt-hosted-engine-ha-0.1.0-0.3.beta1
by gpadgett＠redhat.com 14 Oct '13

14 Oct '13

Greg Padgett has submitted this change and it was merged. Change subject: build: ovirt-hosted-engine-ha-0.1.0-0.3.beta1 ...................................................................... build: ovirt-hosted-engine-ha-0.1.0-0.3.beta1 Change-Id: I5dae97f99e60e5bafac49c89ba679b05846601f0 Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M configure.ac M ovirt-hosted-engine-ha.spec.in 2 files changed, 4 insertions(+), 1 deletion(-) Approvals: Sandro Bonazzola: Verified Greg Padgett: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/20165 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5dae97f99e60e5bafac49c89ba679b05846601f0 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-hosted-engine-ha Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Greg Padgett <gpadgett(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0