October 2013 - Engine-commits - oVirt List Archives

Change in ovirt-engine[ovirt-engine-3.3]: core: Use pin to host only when present in cluster policy
by iheim＠redhat.com 15 Oct '13

15 Oct '13

Itamar Heim has submitted this change and it was merged. Change subject: core: Use pin to host only when present in cluster policy ...................................................................... core: Use pin to host only when present in cluster policy This removes the explicit pin to host check in scheduling. The check is already present in cluster policy and will be used when the policy unit is selected by the administrator. It also restores the optimization we had in the code that used Pin To Host logic as the first filter for the provided cluster policies. Change-Id: If2c0496327c9f692b0dbe92e1cf481f900f4a747 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1007282 Signed-off-by: Martin Sivak <msivak(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/SchedulingManager.java M backend/manager/modules/dal/src/main/resources/bundles/AuditLogMessages.properties A packaging/dbscripts/upgrade/03_03_0990_pin_to_host_first_in_powersaving_policy.sql 3 files changed, 14 insertions(+), 54 deletions(-) Approvals: Itamar Heim: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/20153 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If2c0496327c9f692b0dbe92e1cf481f900f4a747 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.3 Gerrit-Owner: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.3]: core: Fix PinToHostPolicyUnit when PinToHost is enabled
by iheim＠redhat.com 15 Oct '13

15 Oct '13

Itamar Heim has submitted this change and it was merged. Change subject: core: Fix PinToHostPolicyUnit when PinToHost is enabled ...................................................................... core: Fix PinToHostPolicyUnit when PinToHost is enabled We have to return an empty list of available hosts when PinToHost is enabled and the pinned Host was already filtered out. Otherwise the whole PolicyUnit has no effect. This is fixing one issue out of two that caused the referenced bug. The issues are independent on each other and so I did want to preserve the history. Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1007282 Change-Id: Id5a49813d433a10debe607f17783057d7d4a767b Signed-off-by: Martin Sivak <msivak(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/policyunits/PinToHostPolicyUnit.java 1 file changed, 6 insertions(+), 0 deletions(-) Approvals: Itamar Heim: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/20094 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id5a49813d433a10debe607f17783057d7d4a767b Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.3 Gerrit-Owner: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: log instead of CanDo on illegal memory value
by ofrenkel＠redhat.com 15 Oct '13

15 Oct '13

Omer Frenkel has submitted this change and it was merged. Change subject: core: log instead of CanDo on illegal memory value ...................................................................... core: log instead of CanDo on illegal memory value Change-Id: I6ab029a1bec86cac86b0e29a8e9aaa38bcdf6c87 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1014952 Signed-off-by: Roy Golan <rgolan(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmTemplateCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommonVmPoolWithVmsCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVmTemplateCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmHandler.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/AddVmCommandTest.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/CommonVmPoolWithVmsCommandTestAbstract.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/UpdateVmCommandTest.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/VdcBllMessages.java M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties 14 files changed, 47 insertions(+), 81 deletions(-) Approvals: Omer Frenkel: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/20178 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6ab029a1bec86cac86b0e29a8e9aaa38bcdf6c87 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: [frontend] Add Client IP to VM session tab
by tjelinek＠redhat.com 15 Oct '13

15 Oct '13

Tomas Jelinek has submitted this change and it was merged. Change subject: [frontend] Add Client IP to VM session tab ...................................................................... [frontend] Add Client IP to VM session tab As per request we're now showing the Client IP in the session tab to indicate the IP of a currently connected user. Change-Id: I021ed69b99cf9d474a1f4d23e83dd12b5e1cf701 Bug-Url: https://bugzilla.redhat.com/1016844 Signed-off-by: Vinzenz Feenstra <vfeenstr(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/CommonApplicationConstants.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/vm/VmSessionsModelForm.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmSessionsModel.java 3 files changed, 15 insertions(+), 1 deletion(-) Approvals: Tomas Jelinek: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/20186 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I021ed69b99cf9d474a1f4d23e83dd12b5e1cf701 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Vinzenz Feenstra <vfeenstr(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: webadmin: Made profile name checks consistent
by lvernia＠redhat.com 15 Oct '13

15 Oct '13

Lior Vernia has submitted this change and it was merged. Change subject: webadmin: Made profile name checks consistent ...................................................................... webadmin: Made profile name checks consistent Fixed the frontend validation to be as restrictive as the backend one (e.g. not allowing dots), as well as added a frontend validation of the profile names in the add/edit network dialog. Change-Id: Ided5e902faae928608a7558a08ed1768e3d8cb81 Bug-Url: https://bugzilla.redhat.com/1012032 Signed-off-by: Lior Vernia <lvernia(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/datacenters/NetworkModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/profiles/VnicProfileModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/key_value/KeyValueModel.java 3 files changed, 13 insertions(+), 4 deletions(-) Approvals: Lior Vernia: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/20180 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ided5e902faae928608a7558a08ed1768e3d8cb81 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: webadmin: Hide "public" InfoIcon if checkbox hidden
by lvernia＠redhat.com 15 Oct '13

15 Oct '13

Lior Vernia has submitted this change and it was merged. Change subject: webadmin: Hide "public" InfoIcon if checkbox hidden ...................................................................... webadmin: Hide "public" InfoIcon if checkbox hidden In previous patches disregarded the fact that the public checkbox could be hidden, in which case the InfoIcon should also be hidden. Change-Id: Ib3dc7a083ca212c7e5dd5e2f2e5ff8b54fa8f573 Bug-Url: https://bugzilla.redhat.com/1000804 Signed-off-by: Lior Vernia <lvernia(a)redhat.com> --- M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/vnicProfile/VnicProfileWidget.java 1 file changed, 3 insertions(+), 2 deletions(-) Approvals: Lior Vernia: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/20182 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib3dc7a083ca212c7e5dd5e2f2e5ff8b54fa8f573 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-hosted-engine-ha[master]: build: ovirt-hosted-engine-ha-0.1.0-0.3.1.beta1
by gpadgett＠redhat.com 15 Oct '13

15 Oct '13

Greg Padgett has submitted this change and it was merged. Change subject: build: ovirt-hosted-engine-ha-0.1.0-0.3.1.beta1 ...................................................................... build: ovirt-hosted-engine-ha-0.1.0-0.3.1.beta1 Change-Id: I83dbc1a904a9e4fe5df12c5611e3cd601b6212f5 Signed-off-by: Yedidyah Bar David <didi(a)redhat.com> --- M configure.ac M ovirt-hosted-engine-ha.spec.in 2 files changed, 4 insertions(+), 1 deletion(-) Approvals: Sandro Bonazzola: Looks good to me, but someone else must approve Greg Padgett: Verified; Looks good to me, approved Yedidyah Bar David: Verified -- To view, visit http://gerrit.ovirt.org/20195 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I83dbc1a904a9e4fe5df12c5611e3cd601b6212f5 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-hosted-engine-ha Gerrit-Branch: master Gerrit-Owner: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: Greg Padgett <gpadgett(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: Remove non-existent Storage Domain will be rolled forw...
by mlipchuk＠redhat.com 15 Oct '13

15 Oct '13

Maor Lipchuk has submitted this change and it was merged. Change subject: core: Remove non-existent Storage Domain will be rolled forward. ...................................................................... core: Remove non-existent Storage Domain will be rolled forward. Removal of a Storage Domain which no longer exists causes a failure in the engine and blocks the user from removing the storage. The following patch validates the storage domain was not removed due to the reason of non existence, and if so it will roll-forward and delete it any how. Change-Id: I9515a5ddfcaa965c2bad1883f0543494915b8c7d Bug-Url: https://bugzilla.redhat.com/1001626 Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/RemoveStorageDomainCommand.java 1 file changed, 15 insertions(+), 3 deletions(-) Approvals: Maor Lipchuk: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/20158 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9515a5ddfcaa965c2bad1883f0543494915b8c7d Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Liron Ar <laravot(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Sergey Gotliv <sgotliv(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: gluster: fix indentation error in rest api test code
by mpastern＠redhat.com 15 Oct '13

15 Oct '13

Michael Pasternak has submitted this change and it was merged. Change subject: gluster: fix indentation error in rest api test code ...................................................................... gluster: fix indentation error in rest api test code fix some intentation errors in methods testSetOptionInvalidParams, testResetOptionInvalidParams Change-Id: I7d86b202556cca4702b9b9fda5e3ce4093cc9fb9 Signed-off-by: Timothy Asir <tjeyasin(a)redhat.com> --- M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/gluster/BackendGlusterVolumeResourceTest.java 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Michael Pasternak: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/19044 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7d86b202556cca4702b9b9fda5e3ce4093cc9fb9 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Timothy Asir <tjeyasin(a)redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayilsa(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com> Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com> Gerrit-Reviewer: Shubhendu Tripathi <shtripat(a)redhat.com> Gerrit-Reviewer: Timothy Asir <tjeyasin(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-dwh[master]: history-etl: service: update discovery of JAVA_HOME
by ydary＠redhat.com 15 Oct '13

15 Oct '13

Yaniv Dary has submitted this change and it was merged. Change subject: history-etl: service: update discovery of JAVA_HOME ...................................................................... history-etl: service: update discovery of JAVA_HOME The new implementation uses engine's script /usr/share/ovirt-engine/bin/java-home to detect JAVA_HOME location. Change-Id: I34dd5891cfc76242bb3bb50bf77bb48ad50839c8 Bug-Url: https://bugzilla.redhat.com/1019178 Related-To: https://bugzilla.redhat.com/1009863 Signed-off-by: Alex Lourie <alourie(a)redhat.com> --- M data-warehouse/history_etl/history_service/history_service.sh 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Yaniv Dary: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/20184 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I34dd5891cfc76242bb3bb50bf77bb48ad50839c8 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-dwh Gerrit-Branch: master Gerrit-Owner: Alex Lourie <alourie(a)redhat.com> Gerrit-Reviewer: Alex Lourie <alourie(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com>

1 0