Change in ovirt-engine[master]: webadmin: Removed unused variable from VnicProfileWidget
by lvernia@redhat.com
Lior Vernia has submitted this change and it was merged.
Change subject: webadmin: Removed unused variable from VnicProfileWidget
......................................................................
webadmin: Removed unused variable from VnicProfileWidget
Change-Id: I0a43a425af36f414c4f6d69d18d487e58aa247b9
Signed-off-by: Lior Vernia <lvernia(a)redhat.com>
---
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/vnicProfile/VnicProfileWidget.java
1 file changed, 0 insertions(+), 2 deletions(-)
Approvals:
Gilad Chaplik: Looks good to me, approved
Lior Vernia: Verified
--
To view, visit http://gerrit.ovirt.org/20080
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I0a43a425af36f414c4f6d69d18d487e58aa247b9
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Lior Vernia <lvernia(a)redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com>
Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
11 years, 2 months
Change in ovirt-hosted-engine-ha[master]: agent: clean vdsm state if vm dies unexpectedly
by gpadgett@redhat.com
Greg Padgett has submitted this change and it was merged.
Change subject: agent: clean vdsm state if vm dies unexpectedly
......................................................................
agent: clean vdsm state if vm dies unexpectedly
If the hosted engine vm dies unexpectedly, vdsm will hold onto some
queryable state for the vm. An attempt to start the vm will be met
with an error, "Virtual machine already exists".
To prevent this, check for VM state and attempt to clean it before a
startup attempt by using the vdsm 'destroy' verb.
Change-Id: I52c8f41c28fbc1942a8b392b275359df57c1b5ef
Bug-Url: https://bugzilla.redhat.com/1013638
Signed-off-by: Greg Padgett <gpadgett(a)redhat.com>
---
M ovirt_hosted_engine_ha/agent/hosted_engine.py
1 file changed, 46 insertions(+), 0 deletions(-)
Approvals:
Greg Padgett: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/19874
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I52c8f41c28fbc1942a8b392b275359df57c1b5ef
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-hosted-engine-ha
Gerrit-Branch: master
Gerrit-Owner: Greg Padgett <gpadgett(a)redhat.com>
Gerrit-Reviewer: Greg Padgett <gpadgett(a)redhat.com>
Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
11 years, 2 months
Change in ovirt-engine[ovirt-engine-3.3]: backend: don't stop tasks on storagePoolUpEvent
by iheim@redhat.com
Itamar Heim has submitted this change and it was merged.
Change subject: backend: don't stop tasks on storagePoolUpEvent
......................................................................
backend: don't stop tasks on storagePoolUpEvent
When a new SPM is elected all the tasks are already stopped by
definition.
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1003506
Change-Id: I2014a2e5c839f2c061b67e6b147c9577914f7101
Signed-off-by: Federico Simoncelli <fsimonce(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AsyncTaskManager.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VdsEventListener.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/IVdsEventListener.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/IrsBrokerCommand.java
4 files changed, 5 insertions(+), 38 deletions(-)
Approvals:
Itamar Heim: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/20044
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I2014a2e5c839f2c061b67e6b147c9577914f7101
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.3
Gerrit-Owner: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
11 years, 2 months
Change in ovirt-engine[ovirt-engine-3.3.0.1]: packaging: ovirt-engine-3.3.0.1
by sbonazzo@redhat.com
Sandro Bonazzola has submitted this change and it was merged.
Change subject: packaging: ovirt-engine-3.3.0.1
......................................................................
packaging: ovirt-engine-3.3.0.1
Updated version to 3.3.0.1-1
Change-Id: I47dd2cc5782e4da14c56d3b856555419941f9172
Bug-Url: https://bugzilla.redhat.com/1011800
Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com>
---
M version.mak
1 file changed, 2 insertions(+), 2 deletions(-)
Approvals:
Sandro Bonazzola: Verified
Ofer Schreiber: Looks good to me, but someone else must approve
Itamar Heim: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/20055
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I47dd2cc5782e4da14c56d3b856555419941f9172
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.3.0.1
Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com>
Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
11 years, 2 months
Change in ovirt-engine[master]: webadmin: DiskSizeRenderer properly handles input size unit
by derez@redhat.com
Daniel Erez has submitted this change and it was merged.
Change subject: webadmin: DiskSizeRenderer properly handles input size unit
......................................................................
webadmin: DiskSizeRenderer properly handles input size unit
Make DiskSizeRenderer correctly handle input in other units than bytes.
Change-Id: Ief6751c9fb457e6b43166f39b7f46d30cfb938f2
Signed-off-by: Sergey Gotliv <sgotliv(a)redhat.com>
---
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/renderer/DiskSizeRenderer.java
1 file changed, 5 insertions(+), 3 deletions(-)
Approvals:
Daniel Erez: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/20049
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ief6751c9fb457e6b43166f39b7f46d30cfb938f2
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Sergey Gotliv <sgotliv(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com>
Gerrit-Reviewer: Sergey Gotliv <sgotliv(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
11 years, 2 months
Change in ovirt-engine[ovirt-engine-3.3.0.1]: core: support the newly-tagged vdsm-4.13
by iheim@redhat.com
Itamar Heim has submitted this change and it was merged.
Change subject: core: support the newly-tagged vdsm-4.13
......................................................................
core: support the newly-tagged vdsm-4.13
vdsm-4.13 would be part of oVirt-3.3.1.
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1017285
Change-Id: I12dacd46973cde693105c21ae5bc41aec7fe7863
Signed-off-by: Dan Kenigsberg <danken(a)redhat.com>
---
M packaging/dbscripts/upgrade/pre_upgrade/0000_config.sql
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Sandro Bonazzola: Looks good to me, but someone else must approve
Yaniv Bronhaim: Verified
Itamar Heim: Verified; Looks good to me, approved
Omer Frenkel: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/20036
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I12dacd46973cde693105c21ae5bc41aec7fe7863
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.3.0.1
Gerrit-Owner: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
11 years, 2 months
Change in ovirt-engine[master]: backend: remove vm check from LiveMigrateDiskCommand
by derez@redhat.com
Daniel Erez has submitted this change and it was merged.
Change subject: backend: remove vm check from LiveMigrateDiskCommand
......................................................................
backend: remove vm check from LiveMigrateDiskCommand
This patch shifts the VM status check from the LiveMigrateDiskCommand
to VmReplicateDiskStartTaskHandler.
This will:
* prevent CreateImagePlaceholderTaskHandler from failing if the VM
crashes during its execution
* shift the failure to the appropriate handler (VmReplicateDiskStart)
* allow the CreateImagePlaceholderTaskHandler compensation to take
place and remove the destination image when necessary
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=957703
Change-Id: Iac42a5d10373a0c1fcf9a224fb902f0ce481d3b7
Signed-off-by: Federico Simoncelli <fsimonce(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/lsm/LiveMigrateDiskCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/lsm/VmReplicateDiskStartTaskHandler.java
2 files changed, 12 insertions(+), 2 deletions(-)
Approvals:
Daniel Erez: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/19876
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Iac42a5d10373a0c1fcf9a224fb902f0ce481d3b7
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Sergey Gotliv <sgotliv(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
11 years, 2 months
Change in ovirt-engine[master]: webadmin: import VM - NICs - enable column resizing
by derez@redhat.com
Daniel Erez has submitted this change and it was merged.
Change subject: webadmin: import VM - NICs - enable column resizing
......................................................................
webadmin: import VM - NICs - enable column resizing
Import VM dialog -> NICs table:
enable column resizing.
Change-Id: I897a1cef966a270b3c9be1bfafb62b456b57a7fe
Signed-off-by: Daniel Erez <derez(a)redhat.com>
---
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/storage/backup/ImportVmPopupView.java
1 file changed, 1 insertion(+), 0 deletions(-)
Approvals:
Daniel Erez: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/20059
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I897a1cef966a270b3c9be1bfafb62b456b57a7fe
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
11 years, 2 months
Change in ovirt-engine[master]: webadmin: import VM - disks - enable column resizing
by derez@redhat.com
Daniel Erez has submitted this change and it was merged.
Change subject: webadmin: import VM - disks - enable column resizing
......................................................................
webadmin: import VM - disks - enable column resizing
Import VM dialog -> disks table:
enable column resizing.
Change-Id: Iab62f8d6989ca25cdf523645adf9112ed0529b1c
Signed-off-by: Daniel Erez <derez(a)redhat.com>
---
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/storage/backup/ImportVmPopupView.java
1 file changed, 6 insertions(+), 5 deletions(-)
Approvals:
Daniel Erez: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/20058
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Iab62f8d6989ca25cdf523645adf9112ed0529b1c
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
11 years, 2 months
Change in ovirt-engine[master]: webadmin: import VM - rename disk alias column
by derez@redhat.com
Daniel Erez has submitted this change and it was merged.
Change subject: webadmin: import VM - rename disk alias column
......................................................................
webadmin: import VM - rename disk alias column
Import VM dialog -> disks table:
s/Name/Alias
Change-Id: Id77574d77a92ebaeb13bdd5d681e2e96880b3154
Signed-off-by: Daniel Erez <derez(a)redhat.com>
---
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/CommonApplicationConstants.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/storage/backup/ImportVmPopupView.java
2 files changed, 2 insertions(+), 5 deletions(-)
Approvals:
Daniel Erez: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/20057
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Id77574d77a92ebaeb13bdd5d681e2e96880b3154
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
11 years, 2 months