October 2013 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: webadmin: bootable column in import VM disks table
by derez＠redhat.com 10 Oct '13

10 Oct '13

Daniel Erez has submitted this change and it was merged. Change subject: webadmin: bootable column in import VM disks table ...................................................................... webadmin: bootable column in import VM disks table Added bootable icon column to disks table in import VM dialog. Change-Id: I7c0e7bf591697c73143343bbfe14beeed0a11c62 Bug-Url: https://bugzilla.redhat.com/1015185 Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/storage/backup/ImportVmPopupView.java 1 file changed, 22 insertions(+), 0 deletions(-) Approvals: Daniel Erez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/20056 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7c0e7bf591697c73143343bbfe14beeed0a11c62 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: webadmin: adding activities colume to Bricks tab
by kmayilsa＠redhat.com 10 Oct '13

10 Oct '13

Kanagaraj M has submitted this change and it was merged. Change subject: webadmin: adding activities colume to Bricks tab ...................................................................... webadmin: adding activities colume to Bricks tab Added a new activities column to Bricks table. This is similar to the Actvities colume in the volumes tab. But the cell in this column is visible only if the task is of type REMOVE_BRICK. Added new icons to show the different stages of remove brick operation. All the brick removal related(stop/commit) operations are moved to the row. The same actions will be available in the volume row as well. Stop/Commit removal command availbility will be decided based on the task type and status. Refactored the code which populates the bricks in the table. Change-Id: I820c8b2e2e948d1c2ce0811d2d5a78784eeafc2b Signed-off-by: Kanagaraj M <kmayilsa(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/gluster/VolumeBrickListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/volumes/VolumeListModel.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/ApplicationConstants.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/ApplicationResources.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/ApplicationTemplates.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/MainTabVolumeView.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/gluster/SubTabVolumeBrickView.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/table/column/VolumeActivityColumn.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/table/column/VolumeActivityCompositeCell.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/table/column/VolumeActivityStatusCell.java A frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/webadmin/images/glusterAsyncTasks/remove_brick_commit_required.png A frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/webadmin/images/glusterAsyncTasks/remove_brick_failed.png A frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/webadmin/images/glusterAsyncTasks/remove_brick_running.png A frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/webadmin/images/glusterAsyncTasks/remove_brick_stopped.png 14 files changed, 173 insertions(+), 60 deletions(-) Approvals: Kanagaraj M: Verified Gilad Chaplik: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/20009 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I820c8b2e2e948d1c2ce0811d2d5a78784eeafc2b Gerrit-PatchSet: 8 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Kanagaraj M <kmayilsa(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayilsa(a)redhat.com> Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: webadmin: volume rebalance status icons updated
by kmayilsa＠redhat.com 10 Oct '13

10 Oct '13

Kanagaraj M has submitted this change and it was merged. Change subject: webadmin: volume rebalance status icons updated ...................................................................... webadmin: volume rebalance status icons updated Replaced the old volume rebalance status icons with newer ones. Renamed the icon directory to 'glusterAsyncTasks'. Change-Id: Iae29a3582ea98132224f52928d18c63ae4634a8d Signed-off-by: Kanagaraj M <kmayilsa(a)redhat.com> --- M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/ApplicationResources.java A frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/webadmin/images/glusterAsyncTasks/rebalance_completed.png A frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/webadmin/images/glusterAsyncTasks/rebalance_failed.png A frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/webadmin/images/glusterAsyncTasks/rebalance_running.png A frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/webadmin/images/glusterAsyncTasks/rebalance_stopped.png D frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/webadmin/images/glusterRebalance/rebalance_completed.png D frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/webadmin/images/glusterRebalance/rebalance_failed.png D frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/webadmin/images/glusterRebalance/rebalance_running.png D frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/webadmin/images/glusterRebalance/rebalance_stopped.png 9 files changed, 5 insertions(+), 5 deletions(-) Approvals: Kanagaraj M: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/19593 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iae29a3582ea98132224f52928d18c63ae4634a8d Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Kanagaraj M <kmayilsa(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayilsa(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: Sync Template disks with new GUID.
by mlipchuk＠redhat.com 10 Oct '13

10 Oct '13

Maor Lipchuk has submitted this change and it was merged. Change subject: core: Sync Template disks with new GUID. ...................................................................... core: Sync Template disks with new GUID. Currently ImportVmTemplateCommand use two different kinds of containers when importing a Template, disks GUIDs and image GUIDs. Those two containers are correlated, and should be reflected in a map so it will remain in sync, same as we use in ImportVmCommand. Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com> Change-Id: I5d0ef009e24aac07e2623dbef0fb762ca333888c --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImportVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImportVmTemplateCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MoveOrCopyTemplateCommand.java 3 files changed, 11 insertions(+), 16 deletions(-) Approvals: Maor Lipchuk: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/20002 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5d0ef009e24aac07e2623dbef0fb762ca333888c Gerrit-PatchSet: 8 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Sergey Gotliv <sgotliv(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: Update managed device map when importing a cloned VM.
by mlipchuk＠redhat.com 10 Oct '13

10 Oct '13

Maor Lipchuk has submitted this change and it was merged. Change subject: core: Update managed device map when importing a cloned VM. ...................................................................... core: Update managed device map when importing a cloned VM. When importing a cloned VM or Template, we generate a new guid for each disk. Those new guids should be correlated with the mangedDeviceMap contained in the VM/Template, so it will keep all the devices configuration as in the old VM/Template. Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com> Bug-Url: https://bugzilla.redhat.com/976469 Change-Id: I65a99cc0783f670b9288cc9a066cda4d253492a6 --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImportVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImportVmTemplateCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MoveOrCopyTemplateCommand.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/ImportVmCommandTest.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/ImportVmTemplateCommandTest.java 5 files changed, 116 insertions(+), 25 deletions(-) Approvals: Maor Lipchuk: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/19954 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I65a99cc0783f670b9288cc9a066cda4d253492a6 Gerrit-PatchSet: 11 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Sergey Gotliv <sgotliv(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: webadmin: Defer item selection 'til after items are set
by lvernia＠redhat.com 10 Oct '13

10 Oct '13

Lior Vernia has submitted this change and it was merged. Change subject: webadmin: Defer item selection 'til after items are set ...................................................................... webadmin: Defer item selection 'til after items are set So far the selection was performed before the list of items was refreshed in the view, and (presumably because of GWT implementation) this caused the list of items to not be refreshed immediately. Change-Id: I9ab512bc315a5f01e9ddb3fe7321b596b83e7cf3 Bug-Url: https://bugzilla.redhat.com/999882 Signed-off-by: Lior Vernia <lvernia(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/vm/VmInterfaceListModelTable.java 1 file changed, 11 insertions(+), 2 deletions(-) Approvals: Lior Vernia: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/19736 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9ab512bc315a5f01e9ddb3fe7321b596b83e7cf3 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.3]: engine: Block hot updating internal to external network
by iheim＠redhat.com 10 Oct '13

10 Oct '13

Itamar Heim has submitted this change and it was merged. Change subject: engine: Block hot updating internal to external network ...................................................................... engine: Block hot updating internal to external network Hot updating was blocked but broken due to bad code change, fixing it. Change-Id: I13581ac002bd2b0592e7a26f7524ba8824563f20 Bug-Url: https://bugzilla.redhat.com/1016982 Signed-off-by: Mike Kolesnik <mkolesni(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/vm/UpdateVmInterfaceCommand.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Itamar Heim: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/20021 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I13581ac002bd2b0592e7a26f7524ba8824563f20 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.3 Gerrit-Owner: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.3]: core: mark GetVirtioScsiControllers as user query
by iheim＠redhat.com 09 Oct '13

09 Oct '13

Itamar Heim has submitted this change and it was merged. Change subject: core: mark GetVirtioScsiControllers as user query ...................................................................... core: mark GetVirtioScsiControllers as user query Marking GetVirtioScsiControllers query as VdcQueryAuthType.User since it's being used by the user portal. Change-Id: I268b39bc85525a270998c10b67c2463a45a08a26 Bug-Url: https://bugzilla.redhat.com/1016826 Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetVirtioScsiControllersQuery.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/utils/VmDeviceUtils.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/VdcQueryType.java 3 files changed, 8 insertions(+), 3 deletions(-) Approvals: Itamar Heim: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/20038 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I268b39bc85525a270998c10b67c2463a45a08a26 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.3 Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.3]: core: fix NPE in decreasePendingVms
by iheim＠redhat.com 09 Oct '13

09 Oct '13

Itamar Heim has submitted this change and it was merged. Change subject: core: fix NPE in decreasePendingVms ...................................................................... core: fix NPE in decreasePendingVms There was a race between the VdsUpdateRunTimeInfo thread that invokes RunVmCommandBase#decreasePendingVms method through OnPowerringUp callback and the thread that invokes MigrateVmCommand#rerun (the thread is created in VdsEventListener#rerun). The 'rerun thread' was doing 'setVm(null)' in order to refresh the VM on the next getVm invocation and the VdsUpdateRunTimeInfo thread was trying to the get the VM using the 'getVm' method VM in the same time - as a result of this race, the VdsUpdateRunTimeInfo thread might end up with null VM which results in NPE. The solution is to change the VdsUpdateRunTimeInfo thread to fetch the VM directly from the DB instead of using the 'getVm' method, And since we don't need the dynamic info of the VM we can query only the static part of the VM. Change-Id: Icaca2a3849a9fefbc33b055c6f4d2dd32959ad28 Bug-Url: https://bugzilla.redhat.com/1000824 Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RunVmCommandBase.java 1 file changed, 24 insertions(+), 8 deletions(-) Approvals: Itamar Heim: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/19885 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Icaca2a3849a9fefbc33b055c6f4d2dd32959ad28 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.3 Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-dwh[master]: packaging: service: run dwh service as an ovirt user
by ydary＠redhat.com 09 Oct '13

09 Oct '13

Yaniv Dary has submitted this change and it was merged. Change subject: packaging: service: run dwh service as an ovirt user ...................................................................... packaging: service: run dwh service as an ovirt user Change-Id: I5dcf067725e787dc5ea3c158900e57203eef50fe Bug-Url: https://bugzilla.redhat.com/772001 Signed-off-by: Alex Lourie <alourie(a)redhat.com> --- M data-warehouse/history_etl/history_service/ovirt-engine-dwhd M packaging/ovirt-engine-dwh.spec.in 2 files changed, 9 insertions(+), 8 deletions(-) Approvals: Alex Lourie: Verified Yaniv Dary: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/17311 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5dcf067725e787dc5ea3c158900e57203eef50fe Gerrit-PatchSet: 2 Gerrit-Project: ovirt-dwh Gerrit-Branch: master Gerrit-Owner: Alex Lourie <alourie(a)redhat.com> Gerrit-Reviewer: Alex Lourie <alourie(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com>

1 0