October 2013 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: API: Fixing action host install parameters
by mpastern＠redhat.com 08 Oct '13

08 Oct '13

Michael Pasternak has submitted this change and it was merged. Change subject: API: Fixing action host install parameters ...................................................................... API: Fixing action host install parameters dding to yaml all missing ssh fields for action install. Change-Id: If72e4744d370e16e6eaf310fe25907872c726af2 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1013637 Signed-off-by: Yaniv Bronhaim <ybronhei(a)redhat.com> --- M backend/manager/modules/restapi/interface/definition/src/main/resources/rsdl_metadata.yaml 1 file changed, 2 insertions(+), 1 deletion(-) Approvals: Michael Pasternak: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/19700 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If72e4744d370e16e6eaf310fe25907872c726af2 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim <ybronhei(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>

1 0

Change in ovirt-engine-cli[master]: cli: incorrect property to python built-in symbol encapsulat...
by mpastern＠redhat.com 08 Oct '13

08 Oct '13

Michael Pasternak has submitted this change and it was merged. Change subject: cli: incorrect property to python built-in symbol encapsulation (#1015975) ...................................................................... cli: incorrect property to python built-in symbol encapsulation (#1015975) If a object has a property with the same name as an internal property. We do not append '_' to the property name. Change-Id: Ie6efa65f785b33ccd46fc23bf4e223fa8e76dfad Bug-Url: https://bugzilla.redhat.com/1015975 Signed-off-by: Ravi Nori <rnori(a)redhat.com> --- M src/ovirtcli/command/command.py 1 file changed, 2 insertions(+), 1 deletion(-) Approvals: Michael Pasternak: Looks good to me, approved Ravi Nori: Verified -- To view, visit http://gerrit.ovirt.org/19940 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie6efa65f785b33ccd46fc23bf4e223fa8e76dfad Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine-cli Gerrit-Branch: master Gerrit-Owner: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com>

1 0

Change in ovirt-engine[ovirt-engine-3.3]: engine: Fix NPE in UpdateVmDiskCommand
by iheim＠redhat.com 08 Oct '13

08 Oct '13

Itamar Heim has submitted this change and it was merged. Change subject: engine: Fix NPE in UpdateVmDiskCommand ...................................................................... engine: Fix NPE in UpdateVmDiskCommand The patch http://gerrit.ovirt.org/#/c/19446/ introduces a change which set quota_id as NULL instead of Guid.Empty. It causes NullPointerException in UpdateVmDiskCommand. Change-Id: If689b77cfe4b4a466b70cd9194e99f0eeafcca09 Bug-Url: https://bugzilla.redhat.com/1015872 Signed-off-by: Sergey Gotliv <sgotliv(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVmDiskCommand.java 1 file changed, 6 insertions(+), 2 deletions(-) Approvals: Itamar Heim: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/19971 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If689b77cfe4b4a466b70cd9194e99f0eeafcca09 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.3 Gerrit-Owner: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Sergey Gotliv <sgotliv(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.3]: webadmin: Disable + sign in custom properties
by iheim＠redhat.com 08 Oct '13

08 Oct '13

Itamar Heim has submitted this change and it was merged. Change subject: webadmin: Disable + sign in custom properties ...................................................................... webadmin: Disable + sign in custom properties When there are no more possible values disable the + sign in custom properties Change-Id: I40e391566dd3bcced2a345ce6a56e2244ac94294 Bug-Url: https://bugzilla.redhat.com/1001159 Signed-off-by: Noam Slomianko <nslomian(a)redhat.com> Signed-off-by: Gilad Chaplik <gchaplik(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/form/key_value/KeyValueLineWidget.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/form/key_value/KeyValueWidget.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/key_value/KeyValueModel.java 3 files changed, 27 insertions(+), 1 deletion(-) Approvals: Itamar Heim: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/19972 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I40e391566dd3bcced2a345ce6a56e2244ac94294 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.3 Gerrit-Owner: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Noam Slomianko <nslomian(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[ovirt-engine-3.3]: core: Audit log failed external scheduler discovery
by iheim＠redhat.com 08 Oct '13

08 Oct '13

Itamar Heim has submitted this change and it was merged. Change subject: core: Audit log failed external scheduler discovery ...................................................................... core: Audit log failed external scheduler discovery When the external scheduler thread fails discovery no further external operations occure. Now we let the user know about it. Change-Id: I198b4fd6300d903fcce55afc400a3075af1ea11c Bug-Url: https://bugzilla.redhat.com/1001986 Signed-off-by: Noam Slomianko <nslomian(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/external/ExternalSchedulerDiscoveryThread.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/AuditLogType.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/auditloghandling/AuditLogDirector.java M backend/manager/modules/dal/src/main/resources/bundles/AuditLogMessages.properties 4 files changed, 11 insertions(+), 1 deletion(-) Approvals: Itamar Heim: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/19967 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I198b4fd6300d903fcce55afc400a3075af1ea11c Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.3 Gerrit-Owner: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Noam Slomianko <nslomian(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: engine: Fix for return value issue in StopRebalanceGlusterVo...
by kmayilsa＠redhat.com 08 Oct '13

08 Oct '13

Kanagaraj M has submitted this change and it was merged. Change subject: engine: Fix for return value issue in StopRebalanceGlusterVolumeCommand ...................................................................... engine: Fix for return value issue in StopRebalanceGlusterVolumeCommand Discarding the status values returned from StopRebalance command as it has issue during deserialization. Also the return value is no where used. Change-Id: I90ec8b8495ede37a1dc6b8929cf80b445598a234 Signed-off-by: Ramesh Nachimuthu <rnachimu(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/StopRebalanceGlusterVolumeCommand.java 1 file changed, 3 insertions(+), 3 deletions(-) Approvals: Kanagaraj M: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/19921 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I90ec8b8495ede37a1dc6b8929cf80b445598a234 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ramesh N <rnachimu(a)redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayilsa(a)redhat.com> Gerrit-Reviewer: Ramesh N <rnachimu(a)redhat.com> Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: support the newly-tagged vdsm-4.13
by yzaslavs＠redhat.com 08 Oct '13

08 Oct '13

Yair Zaslavsky has submitted this change and it was merged. Change subject: core: support the newly-tagged vdsm-4.13 ...................................................................... core: support the newly-tagged vdsm-4.13 vdsm-4.13 would be part of oVirt-3.3.1. Change-Id: I12dacd46973cde693105c21ae5bc41aec7fe7863 Signed-off-by: Dan Kenigsberg <danken(a)redhat.com> --- M packaging/dbscripts/upgrade/pre_upgrade/0000_config.sql 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Yair Zaslavsky: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/19913 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I12dacd46973cde693105c21ae5bc41aec7fe7863 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg <danken(a)redhat.com> Gerrit-Reviewer: David Caro <dcaroest(a)redhat.com> Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[ovirt-engine-3.3]: packaging: setup: Do not create a new db on upgrade
by iheim＠redhat.com 08 Oct '13

08 Oct '13

Itamar Heim has submitted this change and it was merged. Change subject: packaging: setup: Do not create a new db on upgrade ...................................................................... packaging: setup: Do not create a new db on upgrade Before this change, the following scenario made engine-setup emit a warning and create a new db: 1. engine-setup 2. service ovirt-engine stop; service postgresql stop 3. engine-setup This change changes the warning to an error (exception) unless it's during cleanup. Bug-Url: https://bugzilla.redhat.com/1014012 Change-Id: Ia336e951860f6e1a6a829cabf5e6b5e10592089b Signed-off-by: Yedidyah Bar David <didi(a)redhat.com> --- M packaging/setup/plugins/ovirt-engine-common/db/connection.py 1 file changed, 14 insertions(+), 10 deletions(-) Approvals: Itamar Heim: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/19930 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia336e951860f6e1a6a829cabf5e6b5e10592089b Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.3 Gerrit-Owner: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: engine: Datasource configuration fixes
by yzaslavs＠redhat.com 08 Oct '13

08 Oct '13

Yair Zaslavsky has submitted this change and it was merged. Change subject: engine: Datasource configuration fixes ...................................................................... engine: Datasource configuration fixes Fix database configuration based on JBoss team suggestion. Allow to recover from DB failure. Change-Id: Ib7cbe97f0baf85f8b6785726380a7a4dcb9d20f8 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=995084 Signed-off-by: lzelkha(a)redhat.com <liran.zelkha(a)gmail.com> --- M packaging/services/ovirt-engine/ovirt-engine.conf.in M packaging/services/ovirt-engine/ovirt-engine.xml.in 2 files changed, 3 insertions(+), 2 deletions(-) Approvals: Yair Zaslavsky: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/19735 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib7cbe97f0baf85f8b6785726380a7a4dcb9d20f8 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liran Zelkha <liran.zelkha(a)gmail.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Eli Mesika <elimesika(a)gmail.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Liran Zelkha <liran.zelkha(a)gmail.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-live[master]: Text fixes
by obasan＠redhat.com 08 Oct '13

08 Oct '13

Ohad Basan has submitted this change and it was merged. Change subject: Text fixes ...................................................................... Text fixes Fixed typos and text issues: htts -> https ovirt -> oVirt (as per style of http://www.ovirt.org) ovirt-engine -> oVirt (for consistency between CentOS and Fedora) Change-Id: I06fda5e0cd7abc9dfd04c55532b9438f9554b2ca Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M centos/oVirtLiveFiles/root/home/liveuser/oVirtLiveFiles/engine-setup-yad.sh M fedora/oVirtLiveFiles/engine-setup-yad.sh 2 files changed, 2 insertions(+), 2 deletions(-) Approvals: Nir Soffer: Looks good to me, but someone else must approve Ohad Basan: Looks good to me, approved Allon Mureinik: Verified -- To view, visit http://gerrit.ovirt.org/19957 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I06fda5e0cd7abc9dfd04c55532b9438f9554b2ca Gerrit-PatchSet: 1 Gerrit-Project: ovirt-live Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com> Gerrit-Reviewer: Ohad Basan <obasan(a)redhat.com>

1 0