October 2013 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: core: change policy unit names
by gchaplik＠redhat.com 03 Oct '13

03 Oct '13

Gilad Chaplik has submitted this change and it was merged. Change subject: core: change policy unit names ...................................................................... core: change policy unit names Rename "PowerSaving" to "OptimalForPowerSaving" Rename "EvenDistribution" to "OptimalForEvenDistribution" Change-Id: I5f8b2fc699eb70c39ded790ed9c13ce6b456046c Bug-Url: https://bugzilla.redhat.com/999539 Signed-off-by: Noam Slomianko <nslomian(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/PolicyUnitImpl.java A packaging/dbscripts/upgrade/03_03_0950_change_policy_names.sql 2 files changed, 6 insertions(+), 2 deletions(-) Approvals: Gilad Chaplik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/18645 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5f8b2fc699eb70c39ded790ed9c13ce6b456046c Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Noam Slomianko <nslomian(a)redhat.com> Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Noam Slomianko <nslomian(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: fix NPE in decreasePendingVms
by ofrenkel＠redhat.com 03 Oct '13

03 Oct '13

Omer Frenkel has submitted this change and it was merged. Change subject: core: fix NPE in decreasePendingVms ...................................................................... core: fix NPE in decreasePendingVms There was a race between the VdsUpdateRunTimeInfo thread that invokes RunVmCommandBase#decreasePendingVms method through OnPowerringUp callback and the thread that invokes MigrateVmCommand#rerun (the thread is created in VdsEventListener#rerun). The 'rerun thread' was doing 'setVm(null)' in order to refresh the VM on the next getVm invocation and the VdsUpdateRunTimeInfo thread was trying to the get the VM using the 'getVm' method VM in the same time - as a result of this race, the VdsUpdateRunTimeInfo thread might end up with null VM which results in NPE. The solution is to change the VdsUpdateRunTimeInfo thread to fetch the VM directly from the DB instead of using the 'getVm' method, And since we don't need the dynamic info of the VM we can query only the static part of the VM. Change-Id: Icaca2a3849a9fefbc33b055c6f4d2dd32959ad28 Bug-Url: https://bugzilla.redhat.com/1000824 Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RunVmCommandBase.java 1 file changed, 24 insertions(+), 8 deletions(-) Approvals: Omer Frenkel: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/19683 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Icaca2a3849a9fefbc33b055c6f4d2dd32959ad28 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-hosted-engine-ha[master]: doc: add versioning readme
by gpadgett＠redhat.com 03 Oct '13

03 Oct '13

Greg Padgett has submitted this change and it was merged. Change subject: doc: add versioning readme ...................................................................... doc: add versioning readme Change-Id: I95ae0908a2849edf4e51e61c1474058be293e798 Signed-off-by: Greg Padgett <gpadgett(a)redhat.com> --- A doc/README.versioning 1 file changed, 29 insertions(+), 0 deletions(-) Approvals: Greg Padgett: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/19584 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I95ae0908a2849edf4e51e61c1474058be293e798 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-hosted-engine-ha Gerrit-Branch: master Gerrit-Owner: Greg Padgett <gpadgett(a)redhat.com> Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com> Gerrit-Reviewer: Greg Padgett <gpadgett(a)redhat.com> Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-hosted-engine-ha[master]: packaging: fix sudoers packaging
by gpadgett＠redhat.com 03 Oct '13

03 Oct '13

Greg Padgett has submitted this change and it was merged. Change subject: packaging: fix sudoers packaging ...................................................................... packaging: fix sudoers packaging Previously sudoers file was distributed instead of sudoers.in. But sudoers is a config file generated by configure and use paths from the host which has built the tarball that may differ from the ones where the package is installed. Now sudoers.in is correctly packaged and sudoers correctly generated during rpm creation or installation on host. Change-Id: Ia5b7e548439d4444216942e0ee0ba567302770dc Bug-Url: https://bugzilla.redhat.com/1013563 Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M .gitignore M sudoers/Makefile.am 2 files changed, 11 insertions(+), 1 deletion(-) Approvals: Sandro Bonazzola: Verified Greg Padgett: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/19772 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia5b7e548439d4444216942e0ee0ba567302770dc Gerrit-PatchSet: 1 Gerrit-Project: ovirt-hosted-engine-ha Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Alex Lourie <alourie(a)redhat.com> Gerrit-Reviewer: Greg Padgett <gpadgett(a)redhat.com> Gerrit-Reviewer: Leonid Natapov <leonidnatapov(a)gmail.com> Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: remove memory volumes without tasks on import vm failure
by ofrenkel＠redhat.com 03 Oct '13

03 Oct '13

Omer Frenkel has submitted this change and it was merged. Change subject: core: remove memory volumes without tasks on import vm failure ...................................................................... core: remove memory volumes without tasks on import vm failure On failure to import vm with snapshots that contain memory state, we remove the imported memory volumes. This patch fix a bug which is relevant for the memory volumes removal in this scenario, that was caused by not adding the tasks properly (not override the getTaskType method in CommandBase). The solution is to remove those imported memory volumes without tasks, in a similar way to the solution done for I3830992f46b2c3fbea47e69f21a6711718408e95. Change-Id: I596ea3164c70b6c2a4e2c161737421259457a179 Bug-Url: https://bugzilla.redhat.com/1015080 Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImportVmCommand.java 1 file changed, 23 insertions(+), 6 deletions(-) Approvals: Omer Frenkel: Looks good to me, approved Arik Hadas: Verified -- To view, visit http://gerrit.ovirt.org/19769 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I596ea3164c70b6c2a4e2c161737421259457a179 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.3]: core: osinfo - change OSs audio device
by iheim＠redhat.com 03 Oct '13

03 Oct '13

Itamar Heim has submitted this change and it was merged. Change subject: core: osinfo - change OSs audio device ...................................................................... core: osinfo - change OSs audio device Esentially old OSs[1] supports ac97 emulated sound device while all the new supports ich6 - intell HD audio definition. [1] RHEL 3,4,5, Windows XP, Windows 2003 32/64 Change-Id: I1a614d7be71cae8beaf1df36056b6945f84ae981 Bug-Url: https://bugzilla.redhat.com/1002695 Signed-off-by: Roy Golan <rgolan(a)redhat.com> --- M packaging/conf/osinfo-defaults.properties 1 file changed, 16 insertions(+), 9 deletions(-) Approvals: Itamar Heim: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/19717 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1a614d7be71cae8beaf1df36056b6945f84ae981 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.3 Gerrit-Owner: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.3]: tools: fix notifier's support of smtp over ssl
by iheim＠redhat.com 03 Oct '13

03 Oct '13

Itamar Heim has submitted this change and it was merged. Change subject: tools: fix notifier's support of smtp over ssl ...................................................................... tools: fix notifier's support of smtp over ssl Change-Id: Ifecec2d5972610e6d8fbb4435c1c29c4ad6b32cd Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1008975 Signed-off-by: Mooli Tayer <mtayer(a)redhat.com> --- M backend/manager/tools/src/main/java/org/ovirt/engine/core/notifier/utils/sender/mail/JavaMailSender.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Itamar Heim: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/19824 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ifecec2d5972610e6d8fbb4435c1c29c4ad6b32cd Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.3 Gerrit-Owner: mooli tayer <mtayer(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: mooli tayer <mtayer(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.3]: webadmin: Only display gateway if feature supported
by iheim＠redhat.com 03 Oct '13

03 Oct '13

Itamar Heim has submitted this change and it was merged. Change subject: webadmin: Only display gateway if feature supported ...................................................................... webadmin: Only display gateway if feature supported Set the visibility of the gateway field, when editing a non-management host network, according to whether the multiple gateway feature is supported, so it wouldn't show in older clusters. Change-Id: Ic31614a9a86e68a0840331f63ec2ac711ab8ac5f Bug-Url: https://bugzilla.redhat.com/1008999 Signed-off-by: Lior Vernia <lvernia(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostInterfaceModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostSetupNetworksModel.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/HostInterfacePopupView.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/SetupNetworksInterfacePopupView.java 4 files changed, 7 insertions(+), 4 deletions(-) Approvals: Itamar Heim: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/19771 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic31614a9a86e68a0840331f63ec2ac711ab8ac5f Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.3 Gerrit-Owner: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.3]: webadmin: Override getEntity() in HostSetupNetworksModel
by iheim＠redhat.com 03 Oct '13

03 Oct '13

Itamar Heim has submitted this change and it was merged. Change subject: webadmin: Override getEntity() in HostSetupNetworksModel ...................................................................... webadmin: Override getEntity() in HostSetupNetworksModel It always returns VDS, so no reason to cast every time it's called. Change-Id: I9e879938d5d3b80d680aa759cc172f957ba77571 Bug-Url: https://bugzilla.redhat.com/1008999 Signed-off-by: Lior Vernia <lvernia(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostSetupNetworksModel.java 1 file changed, 10 insertions(+), 5 deletions(-) Approvals: Itamar Heim: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/19770 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9e879938d5d3b80d680aa759cc172f957ba77571 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.3 Gerrit-Owner: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.3]: core: delete connections on block domain removal
by iheim＠redhat.com 03 Oct '13

03 Oct '13

Itamar Heim has submitted this change and it was merged. Change subject: core: delete connections on block domain removal ...................................................................... core: delete connections on block domain removal When removing a block storage domain, the relevant connections must be removed from the DB before removing the corresponding luns (as we can't retrieve connections by VG without the luns). Change-Id: If1be645779e5ad28e9c2672246e6e68d5aecb00e Bug-Url: https://bugzilla.redhat.com/1011569 Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/ISCSIStorageHelper.java 1 file changed, 9 insertions(+), 7 deletions(-) Approvals: Itamar Heim: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/19806 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If1be645779e5ad28e9c2672246e6e68d5aecb00e Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.3 Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0