Change in ovirt-engine[master]: core: delete connections on block domain removal
by derez＠redhat.com
Daniel Erez has submitted this change and it was merged.
Change subject: core: delete connections on block domain removal
......................................................................
core: delete connections on block domain removal
When removing a block storage domain, the relevant connections must
be removed from the DB before removing the corresponding luns
(as we can't retrieve connections by VG without the luns).
Change-Id: If1be645779e5ad28e9c2672246e6e68d5aecb00e
Bug-Url: https://bugzilla.redhat.com/1011569
Signed-off-by: Daniel Erez <derez(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/ISCSIStorageHelper.java
1 file changed, 9 insertions(+), 7 deletions(-)
Approvals:
Daniel Erez: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/19753
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: If1be645779e5ad28e9c2672246e6e68d5aecb00e
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 7 months
Change in ovirt-engine[master]: userportal: Dynamic guide link
by vszocs＠redhat.com
Vojtech Szocs has submitted this change and it was merged.
Change subject: userportal: Dynamic guide link
......................................................................
userportal: Dynamic guide link
- Dynamically switch guide link between basic guide
and power user guide based on active tab
- Fixed issue where the place managers where not singleton
accross modules.
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=948653
Change-Id: If6374df0da70fa6f6edf044d4ebadafc7fb1a105
Signed-off-by: Alexander Wels <awels(a)redhat.com>
---
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/gin/BaseSystemModule.java
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/presenter/AbstractHeaderPresenterWidget.java
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/utils/DynamicMessages.java
M frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/ApplicationDynamicMessages.java
M frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/section/main/presenter/MainSectionPresenter.java
M packaging/branding/ovirt.brand/external_resources.properties
6 files changed, 55 insertions(+), 7 deletions(-)
Approvals:
Vojtech Szocs: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/19298
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: If6374df0da70fa6f6edf044d4ebadafc7fb1a105
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alexander Wels <awels(a)redhat.com>
Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com>
Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com>
Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com>
Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 7 months
Change in ovirt-hosted-engine-setup[ovirt-hosted-engine-setup-1.0]: packaging: setup: host id must not be saved in answer file
by sbonazzo＠redhat.com
Sandro Bonazzola has submitted this change and it was merged.
Change subject: packaging: setup: host id must not be saved in answer file
......................................................................
packaging: setup: host id must not be saved in answer file
saving the host id in the answer file leads to having
the same host id of the first host also on additional
hosts. With this patch the host id is not saved
anymore in the answer file.
Bug-Url: https://bugzilla.redhat.com/1014004
Change-Id: Ia742cfe1fd2c3c3c140edb0fa290bdff7b9f4e38
Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com>
---
M src/ovirt_hosted_engine_setup/constants.py
1 file changed, 0 insertions(+), 1 deletion(-)
Approvals:
Sandro Bonazzola: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/19793
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ia742cfe1fd2c3c3c140edb0fa290bdff7b9f4e38
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-hosted-engine-setup
Gerrit-Branch: ovirt-hosted-engine-setup-1.0
Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
10 years, 7 months
Change in ovirt-engine[master]: frontend: Select an empty profile does not work
by tjelinek＠redhat.com
Tomas Jelinek has submitted this change and it was merged.
Change subject: frontend: Select an empty profile does not work
......................................................................
frontend: Select an empty profile does not work
There were the following issuse:
- the empty profile is represented by null but the ListModelTypeAheadListBox
did not supported it. Fixed by adding the null as a supported value
- the null has been rendered by NullSafeSuggestBoxRenderer as an empty String
but it was nearly invisable in the editor. Fixed by adding a specific
template for this case into the CommonApplicationTemplates
- the network name was not set (only the profile id). While the network
name is depricated, it is still used by
VmInterfaceManager.updateNicForBackwardCompatibility and expected to
be set
Change-Id: I199d4ce14b55b3f552cf6138b7c3c5d21d620ccc
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1003609
Signed-off-by: Tomas Jelinek <tjelinek(a)redhat.com>
---
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/CommonApplicationTemplates.java
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/editor/BaseListModelSuggestBox.java
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/editor/ListModelTypeAheadListBox.java
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/editor/ListModelTypeAheadListBoxEditor.java
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/profile/ProfileInstanceTypeEditor.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmInterfaceCreatingManager.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmInterfaceModel.java
7 files changed, 30 insertions(+), 16 deletions(-)
Approvals:
Tomas Jelinek: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/18791
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I199d4ce14b55b3f552cf6138b7c3c5d21d620ccc
Gerrit-PatchSet: 6
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Tomas Jelinek <tjelinek(a)redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com>
Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>
Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 7 months
Change in ovirt-hosted-engine-setup[master]: packaging: setup: host id must not be saved in answer file
by sbonazzo＠redhat.com
Sandro Bonazzola has submitted this change and it was merged.
Change subject: packaging: setup: host id must not be saved in answer file
......................................................................
packaging: setup: host id must not be saved in answer file
saving the host id in the answer file leads to having
the same host id of the first host also on additional
hosts. With this patch the host id is not saved
anymore in the answer file.
Bug-Url: https://bugzilla.redhat.com/1014004
Change-Id: Ia742cfe1fd2c3c3c140edb0fa290bdff7b9f4e38
Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com>
---
M src/ovirt_hosted_engine_setup/constants.py
1 file changed, 0 insertions(+), 1 deletion(-)
Approvals:
Sandro Bonazzola: Verified; Looks good to me, approved
Yedidyah Bar David: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/19788
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ia742cfe1fd2c3c3c140edb0fa290bdff7b9f4e38
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-hosted-engine-setup
Gerrit-Branch: master
Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Alex Lourie <alourie(a)redhat.com>
Gerrit-Reviewer: Greg Padgett <gpadgett(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 7 months
Change in ovirt-engine[ovirt-engine-3.3]: packaging: build: fix 2nd time installation
by iheim＠redhat.com
Itamar Heim has submitted this change and it was merged.
Change subject: packaging: build: fix 2nd time installation
......................................................................
packaging: build: fix 2nd time installation
remove files symlink before creating new.
Related-To: https://bugzilla.redhat.com/show_bug.cgi?id=997418
Change-Id: I5c78b4de6fc50d5445f6aff854cb01df8bddc41d
Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com>
---
M Makefile
1 file changed, 3 insertions(+), 0 deletions(-)
Approvals:
Itamar Heim: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/19756
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I5c78b4de6fc50d5445f6aff854cb01df8bddc41d
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.3
Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com>
Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 7 months
Change in ovirt-engine[ovirt-engine-3.3]: packaging: introduce generic file serving
by iheim＠redhat.com
Itamar Heim has submitted this change and it was merged.
Change subject: packaging: introduce generic file serving
......................................................................
packaging: introduce generic file serving
current implementation adds a reference for each file within root
web.xml, this is inflexible to manage and add new files as needed.
new implementation defines maps /ovirt-engine-files URI into
/usr/share/ovirt-engine/files, every file within that directory will be
exposed to application.
packaging can add misc files or symlinks to expose files based on
specific location or capabilities.
moved:
1. spice
2. spice-html5
3. novnc
usbfilter.txt moved out of spice directory as it is application provided
and not spice artifact.
Related-To: https://bugzilla.redhat.com/show_bug.cgi?id=997418
Change-Id: I1cd8b39ff2647bc006e09d50c9fc7088fcef7434
Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com>
---
M Makefile
M backend/manager/modules/root/src/main/webapp/WEB-INF/web.xml
M backend/manager/modules/root/src/main/webapp/ovirt-engine-novnc-main.html
M backend/manager/modules/root/src/main/webapp/ovirt-engine-spicehtml5-main.html
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/Configurator.java
M frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/uicommon/UserPortalConfigurator.java
M ovirt-engine.spec.in
M packaging/conf/ovirt-engine-proxy.conf.v2.in
M packaging/services/ovirt-engine/ovirt-engine.conf.in
9 files changed, 41 insertions(+), 144 deletions(-)
Approvals:
Itamar Heim: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/19722
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I1cd8b39ff2647bc006e09d50c9fc7088fcef7434
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.3
Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Frank Kobzik <fkobzik(a)redhat.com>
Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com>
Gerrit-Reviewer: Kiril Nesenko <knesenko(a)redhat.com>
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com>
Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 7 months
Change in ovirt-engine[ovirt-engine-3.3]: packaging: add manual reference
by iheim＠redhat.com
Itamar Heim has submitted this change and it was merged.
Change subject: packaging: add manual reference
......................................................................
packaging: add manual reference
empty manual to allow application to handle using single execution path.
as this is not really a manual, move out of /usr/share/doc/
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1002353
Change-Id: I00c6a0a554bf684c38f7db21fcbf31621996a0bd
Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com>
---
M Makefile
M ovirt-engine.spec.in
A packaging/manual/DocumentationPath.csv
A packaging/manual/UserPortalDocumentationPath.csv
M packaging/services/ovirt-engine/ovirt-engine.conf.in
5 files changed, 3 insertions(+), 2 deletions(-)
Approvals:
Itamar Heim: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/19721
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I00c6a0a554bf684c38f7db21fcbf31621996a0bd
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.3
Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com>
Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com>
Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com>
Gerrit-Reviewer: Kiril Nesenko <knesenko(a)redhat.com>
Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 7 months
Change in ovirt-engine[master]: core: fix a possible null dereference in CpuLevelFilterPolic...
by oourfali＠redhat.com
Oved Ourfali has submitted this change and it was merged.
Change subject: core: fix a possible null dereference in CpuLevelFilterPolicyUnit
......................................................................
core: fix a possible null dereference in CpuLevelFilterPolicyUnit
Change-Id: I01e9196fd4d48dffe5ee136c0137f16a0cd77094
Signed-off-by: Oved Ourfali <oourfali(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/policyunits/CpuLevelFilterPolicyUnit.java
1 file changed, 15 insertions(+), 13 deletions(-)
Approvals:
Oved Ourfali: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/19780
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I01e9196fd4d48dffe5ee136c0137f16a0cd77094
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 7 months
Change in ovirt-engine[ovirt-engine-3.3]: Use FQDN from guest agent for RDP
by iheim＠redhat.com
Itamar Heim has submitted this change and it was merged.
Change subject: Use FQDN from guest agent for RDP
......................................................................
Use FQDN from guest agent for RDP
This commit adds the support for retrieving the guestFQDN value from VDSM
and stores it in the VmDynamic database.
We're not storing FQDN which are localhost or localhost.localdomain
Additionally a new vdc_option "RdpUseFqdnIfAvailable" has been introduced,
to give the administrators the option to disable this feature.
If RdpUseFqdnIfAvailable is true (default) RDP will use the reported FQDN
if it is not null or an empty string.
The value can now be read on the Frontend from the RdpConsoleModel and
it will check whether or not the vdc_option RdpUseFqdnIfAvailable was set.
The FQDN value is now also part of the GuestInfo data in the REST API.
Change-Id: I1e7f8e46c6a71ccbfe9af9bf85271d7294b03526
Bug-Url: https://bugzilla.redhat.com/1014546
Signed-off-by: Vinzenz Feenstra <vfeenstr(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImportVmCommand.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VM.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VmDynamic.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/config/ConfigValues.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/ConfigurationValues.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VmDAODbFacadeImpl.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VmDynamicDAODbFacadeImpl.java
M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/VmDynamicDAOTest.java
M backend/manager/modules/dal/src/test/resources/fixtures.xml
M backend/manager/modules/restapi/interface/definition/src/main/resources/api.xsd
M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/utils/FeaturesHelper.java
M backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/VmMapper.java
M backend/manager/modules/restapi/types/src/test/java/org/ovirt/engine/api/restapi/types/VmMapperTest.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/ResourceManager.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsBrokerObjectsBuilder.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsProperties.java
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/CommonApplicationConstants.java
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/vm/VmGeneralModelForm.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/Cloner.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/RdpConsoleModel.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmGeneralModel.java
M packaging/dbscripts/create_dwh_views.sql
M packaging/dbscripts/create_views.sql
A packaging/dbscripts/upgrade/03_03_0920_add_fqdn_to_vm_dynamic.sql
M packaging/dbscripts/upgrade/pre_upgrade/0000_config.sql
M packaging/dbscripts/vms_sp.sql
27 files changed, 158 insertions(+), 14 deletions(-)
Approvals:
Vinzenz Feenstra: Verified
Itamar Heim: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/19748
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I1e7f8e46c6a71ccbfe9af9bf85271d7294b03526
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.3
Gerrit-Owner: Vinzenz Feenstra <vfeenstr(a)redhat.com>
Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com>
Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com>
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>
Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>
Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr(a)redhat.com>
Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 7 months