Change in ovirt-engine[ovirt-engine-3.3]: backend, frontend: add more specific glance errors
by iheim＠redhat.com
Itamar Heim has submitted this change and it was merged.
Change subject: backend,frontend: add more specific glance errors
......................................................................
backend,frontend: add more specific glance errors
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1003902
Change-Id: Iecba90adfc2be50fb1471ac93908fde176696404
Signed-off-by: Federico Simoncelli <fsimonce(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImportRepoImageCommand.java
A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/provider/OpenStackImageException.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/provider/OpenStackImageProviderProxy.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/VdcBllMessages.java
M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties
M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java
M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties
7 files changed, 85 insertions(+), 17 deletions(-)
Approvals:
Itamar Heim: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/19752
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Iecba90adfc2be50fb1471ac93908fde176696404
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.3
Gerrit-Owner: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 6 months
Change in ovirt-engine[ovirt-engine-3.3]: webadmin: overlapping event notification text
by iheim＠redhat.com
Itamar Heim has submitted this change and it was merged.
Change subject: webadmin: overlapping event notification text
......................................................................
webadmin: overlapping event notification text
- Fixed issue where the height of a row was fixed and it
would overflow onto the next line if the text was too
long.
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=987943
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=911071
Change-Id: Ib6ec7edbbf6d0cd391a2e8d5a28c0b1fa978b832
Signed-off-by: Alexander Wels <awels(a)redhat.com>
---
M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/webadmin/css/NotificationsTree.css
1 file changed, 2 insertions(+), 2 deletions(-)
Approvals:
Itamar Heim: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/19750
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ib6ec7edbbf6d0cd391a2e8d5a28c0b1fa978b832
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.3
Gerrit-Owner: Alexander Wels <awels(a)redhat.com>
Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com>
Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com>
Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com>
Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com>
Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 6 months
Change in ovirt-engine[master]: packaging: build: fix 2nd time installation
by oschreib＠redhat.com
Ofer Schreiber has submitted this change and it was merged.
Change subject: packaging: build: fix 2nd time installation
......................................................................
packaging: build: fix 2nd time installation
remove files symlink before creating new.
Change-Id: I5c78b4de6fc50d5445f6aff854cb01df8bddc41d
Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com>
---
M Makefile
1 file changed, 3 insertions(+), 0 deletions(-)
Approvals:
Alon Bar-Lev: Verified
Ofer Schreiber: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/19754
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I5c78b4de6fc50d5445f6aff854cb01df8bddc41d
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
10 years, 6 months
Change in ovirt-engine[ovirt-engine-3.3]: core: remove memory volumes without tasks on snapshot creati...
by iheim＠redhat.com
Itamar Heim has submitted this change and it was merged.
Change subject: core: remove memory volumes without tasks on snapshot creation failure
......................................................................
core: remove memory volumes without tasks on snapshot creation failure
On the end-action phase of snapshot creation command, we check if the VM
is runningto see whether we should take live snapshot or not. If the VM
is not running and we created images that will be used to store the
memory, we try to remove those images. There was a problem that the
remove image operations created tasks that were not polled (they are not
polled automatically since we're in the end-action phase, and we didn't
explicitly asked to poll them).
Since we have nothing to do in case of failure (if the file deletion
didn't work, it most probably won't work on retry), we now don't create
tasks on those delete image operations.
New command RemoveMemoryVolumesCommand is added to do so, to achieve
better separation of concerns, which will also make it possible to reuse
it on other cases.
Change-Id: I3830992f46b2c3fbea47e69f21a6711718408e95
Bug-Url: https://bugzilla.redhat.com/1011474
Signed-off-by: Arik Hadas <ahadas(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CreateAllSnapshotsFromVmCommand.java
A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveMemoryVolumesCommand.java
A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/RemoveMemoryVolumesParameters.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/VdcActionType.java
4 files changed, 159 insertions(+), 1 deletion(-)
Approvals:
Omer Frenkel: Looks good to me, approved
Arik Hadas: Verified
--
To view, visit http://gerrit.ovirt.org/19740
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I3830992f46b2c3fbea47e69f21a6711718408e95
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.3
Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 6 months
Change in ovirt-engine[master]: Use FQDN from guest agent for RDP
by ofrenkel＠redhat.com
Omer Frenkel has submitted this change and it was merged.
Change subject: Use FQDN from guest agent for RDP
......................................................................
Use FQDN from guest agent for RDP
This commit adds the support for retrieving the guestFQDN value from VDSM
and stores it in the VmDynamic database.
We're not storing FQDN which are localhost or localhost.localdomain
Additionally a new vdc_option "RdpUseFqdnIfAvailable" has been introduced,
to give the administrators the option to disable this feature.
If RdpUseFqdnIfAvailable is true (default) RDP will use the reported FQDN
if it is not null or an empty string.
The value can now be read on the Frontend from the RdpConsoleModel and
it will check whether or not the vdc_option RdpUseFqdnIfAvailable was set.
The FQDN value is now also part of the GuestInfo data in the REST API.
Change-Id: I1e7f8e46c6a71ccbfe9af9bf85271d7294b03526
Signed-off-by: Vinzenz Feenstra <vfeenstr(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImportVmCommand.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VM.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VmDynamic.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/config/ConfigValues.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/ConfigurationValues.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VmDAODbFacadeImpl.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VmDynamicDAODbFacadeImpl.java
M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/VmDynamicDAOTest.java
M backend/manager/modules/dal/src/test/resources/fixtures.xml
M backend/manager/modules/restapi/interface/definition/src/main/resources/api.xsd
M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/utils/FeaturesHelper.java
M backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/VmMapper.java
M backend/manager/modules/restapi/types/src/test/java/org/ovirt/engine/api/restapi/types/VmMapperTest.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/ResourceManager.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsBrokerObjectsBuilder.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsProperties.java
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/CommonApplicationConstants.java
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/vm/VmGeneralModelForm.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/Cloner.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/RdpConsoleModel.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmGeneralModel.java
M packaging/dbscripts/create_dwh_views.sql
M packaging/dbscripts/create_views.sql
A packaging/dbscripts/upgrade/03_03_0920_add_fqdn_to_vm_dynamic.sql
M packaging/dbscripts/upgrade/pre_upgrade/0000_config.sql
M packaging/dbscripts/vms_sp.sql
27 files changed, 158 insertions(+), 14 deletions(-)
Approvals:
Vinzenz Feenstra: Verified
Omer Frenkel: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/17709
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I1e7f8e46c6a71ccbfe9af9bf85271d7294b03526
Gerrit-PatchSet: 14
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Vinzenz Feenstra <vfeenstr(a)redhat.com>
Gerrit-Reviewer: Laszlo Hornyak <lhornyak(a)redhat.com>
Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com>
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>
Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>
Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr(a)redhat.com>
Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 6 months
Change in ovirt-dwh[master]: packaging: setup: added welcome message
by ydary＠redhat.com
Yaniv Dary has submitted this change and it was merged.
Change subject: packaging: setup: added welcome message
......................................................................
packaging: setup: added welcome message
Change-Id: I5f34088ffeb6f66be72ac97cae0339f6ae645745
Bug-Url: https://bugzilla.redhat.com/1011542
Signed-off-by: Alex Lourie <alourie(a)redhat.com>
---
M packaging/ovirt-engine-dwh-setup.py
1 file changed, 1 insertion(+), 0 deletions(-)
Approvals:
Alex Lourie: Verified
Yaniv Dary: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/19746
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I5f34088ffeb6f66be72ac97cae0339f6ae645745
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-dwh
Gerrit-Branch: master
Gerrit-Owner: Alex Lourie <alourie(a)redhat.com>
Gerrit-Reviewer: Alex Lourie <alourie(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com>
10 years, 6 months
Change in ovirt-hosted-engine-ha[master]: agent: missing log message parameters
by gpadgett＠redhat.com
Greg Padgett has submitted this change and it was merged.
Change subject: agent: missing log message parameters
......................................................................
agent: missing log message parameters
Fix a missing log message parameter, causing the agent to fail if it
detects that the vm should be migrated away to a better host
Change-Id: Icb5bd3bd46b63ecbeeb8e1d0fdc8ca9b2c9e0f23
Bug-Url: https://bugzilla.redhat.com/1014112
Signed-off-by: Greg Padgett <gpadgett(a)redhat.com>
---
M ovirt_hosted_engine_ha/agent/hosted_engine.py
1 file changed, 3 insertions(+), 2 deletions(-)
Approvals:
Greg Padgett: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/19738
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Icb5bd3bd46b63ecbeeb8e1d0fdc8ca9b2c9e0f23
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-hosted-engine-ha
Gerrit-Branch: master
Gerrit-Owner: Greg Padgett <gpadgett(a)redhat.com>
Gerrit-Reviewer: Greg Padgett <gpadgett(a)redhat.com>
Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 6 months
Change in ovirt-engine[ovirt-engine-3.3.0.1]: packaging: ovirt-engine-3.3.0.1
by oschreib＠redhat.com
Ofer Schreiber has submitted this change and it was merged.
Change subject: packaging: ovirt-engine-3.3.0.1
......................................................................
packaging: ovirt-engine-3.3.0.1
Update fix_release and rpm_release to match ovirt-engine-3.3.0.1
upcoming release.
Change-Id: I988a8479ee0afb54bb7d6117ac3b2b5b782b389e
Signed-off-by: Ofer Schreiber <oschreib(a)redhat.com>
---
M version.mak
1 file changed, 3 insertions(+), 3 deletions(-)
Approvals:
Ofer Schreiber: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/19672
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I988a8479ee0afb54bb7d6117ac3b2b5b782b389e
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.3.0.1
Gerrit-Owner: Ofer Schreiber <oschreib(a)redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com>
Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
10 years, 6 months
Change in ovirt-engine[master]: webadmin: resizable dialogs - missing resize symbol
by ecohen＠redhat.com
Einav Cohen has submitted this change and it was merged.
Change subject: webadmin: resizable dialogs - missing resize symbol
......................................................................
webadmin: resizable dialogs - missing resize symbol
On resizable dialogs [1], the resize symbol [2]
(on bottom-right corner) was missing.
Hence:
* Extracted the image into 'branding/../images/dialog' folder.
* Added '.gwt-DialogBox .dialogBottomRight.resize' style
to 'gwt_common.css' file.
* Modified ResizableDialogBox file accordingly.
[1] only Disk and Storage dialogs are currently resizable
[2] screenshot - http://i.imgur.com/nnMwcPh.png
Change-Id: I7e9cc8a3140ca62c677b9ac53c00c5460d3b0009
Signed-off-by: Daniel Erez <derez(a)redhat.com>
---
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/dialog/ResizableDialogBox.java
M packaging/branding/ovirt.brand/gwt_common.css
R packaging/branding/ovirt.brand/images/dialog/panel_edge_BR_resize.png
3 files changed, 19 insertions(+), 12 deletions(-)
Approvals:
Einav Cohen: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/19701
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I7e9cc8a3140ca62c677b9ac53c00c5460d3b0009
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 6 months
Change in ovirt-engine[master]: engine: fix typo
by ofrenkel＠redhat.com
Omer Frenkel has submitted this change and it was merged.
Change subject: engine: fix typo
......................................................................
engine: fix typo
Wair for launch -> Wait for launch
Change-Id: I99c62ee25ff60328b1a6510a39374a50694ae610
Bug-Url: https://bugzilla.redhat.com/1013998
Signed-off-by: Frantisek Kobzik <fkobzik(a)redhat.com>
---
M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties
M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java
M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties
M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties
4 files changed, 4 insertions(+), 4 deletions(-)
Approvals:
Frank Kobzik: Verified
Omer Frenkel: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/19734
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I99c62ee25ff60328b1a6510a39374a50694ae610
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Frank Kobzik <fkobzik(a)redhat.com>
Gerrit-Reviewer: Frank Kobzik <fkobzik(a)redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 6 months
