Change in otopi[otopi-1.1]: core: Suppress dump of certain env keys
by Alon Bar-Lev
Alon Bar-Lev has submitted this change and it was merged.
Change subject: core: Suppress dump of certain env keys
......................................................................
core: Suppress dump of certain env keys
Fix a bug in the code that was already meant to do that.
Change-Id: I7148d6e7828a392b5b0b8391931685b40ed3a477
Signed-off-by: Yedidyah Bar David <didi(a)redhat.com>
---
M ChangeLog
M src/otopi/context.py
2 files changed, 4 insertions(+), 1 deletion(-)
Approvals:
Alon Bar-Lev: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/19779
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I7148d6e7828a392b5b0b8391931685b40ed3a477
Gerrit-PatchSet: 1
Gerrit-Project: otopi
Gerrit-Branch: otopi-1.1
Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com>
10 years, 8 months
Change in ovirt-engine[ovirt-engine-3.3]: engine: fix typo
by iheim＠redhat.com
Itamar Heim has submitted this change and it was merged.
Change subject: engine: fix typo
......................................................................
engine: fix typo
Wair for launch -> Wait for launch
Change-Id: I99c62ee25ff60328b1a6510a39374a50694ae610
Bug-Url: https://bugzilla.redhat.com/1013998
Bug-Url: https://bugzilla.redhat.com/1005689
Signed-off-by: Frantisek Kobzik <fkobzik(a)redhat.com>
Signed-off-by: Tomas Jelinek <tjelinek(a)redhat.com>
---
M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties
M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java
M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties
M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties
4 files changed, 4 insertions(+), 4 deletions(-)
Approvals:
Itamar Heim: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/19766
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I99c62ee25ff60328b1a6510a39374a50694ae610
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.3
Gerrit-Owner: Tomas Jelinek <tjelinek(a)redhat.com>
Gerrit-Reviewer: Frank Kobzik <fkobzik(a)redhat.com>
Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 8 months
Change in otopi[master]: doc: core: Suppress dump of certain env keys
by Alon Bar-Lev
Alon Bar-Lev has submitted this change and it was merged.
Change subject: doc: core: Suppress dump of certain env keys
......................................................................
doc: core: Suppress dump of certain env keys
Change-Id: Ia8a6d934461f8010b67a886a3d49f841b27d93af
Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com>
---
M ChangeLog
1 file changed, 1 insertion(+), 0 deletions(-)
Approvals:
Alon Bar-Lev: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/19778
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ia8a6d934461f8010b67a886a3d49f841b27d93af
Gerrit-PatchSet: 1
Gerrit-Project: otopi
Gerrit-Branch: master
Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>
10 years, 8 months
Change in otopi[master]: core: Suppress dump of certain env keys
by Alon Bar-Lev
Alon Bar-Lev has submitted this change and it was merged.
Change subject: core: Suppress dump of certain env keys
......................................................................
core: Suppress dump of certain env keys
Fix a bug in the code that was already meant to do that.
Change-Id: I7148d6e7828a392b5b0b8391931685b40ed3a477
Signed-off-by: Yedidyah Bar David <didi(a)redhat.com>
---
M src/otopi/context.py
1 file changed, 3 insertions(+), 1 deletion(-)
Approvals:
Alon Bar-Lev: Verified; Looks good to me, approved
Sandro Bonazzola: Looks good to me, but someone else must approve
Yedidyah Bar David: Verified
--
To view, visit http://gerrit.ovirt.org/19776
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I7148d6e7828a392b5b0b8391931685b40ed3a477
Gerrit-PatchSet: 1
Gerrit-Project: otopi
Gerrit-Branch: master
Gerrit-Owner: Yedidyah Bar David <didi(a)redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com>
10 years, 8 months
Change in ovirt-engine[master]: restapi: VmMapper test - Move mock to class level
by oliel＠redhat.com
Ori Liel has submitted this change and it was merged.
Change subject: restapi: VmMapper test - Move mock to class level
......................................................................
restapi: VmMapper test - Move mock to class level
When mapping OsType, the code references a service which is currently mocked.
But it's not mocked everywhere it should be, and the result is a strange
behavior: when all the test method in VmMapperTest are run sequentially,
one after the other - they pass. But if only 'testRoundTrip()' is run - it
fails.
The current change takes the necessary mocking up to the class level. The mocking
is static and should only happen once - that's why the class level is the
right place. And this way all test methods benefit from the mocking.
Change-Id: Iaa9794a268551461263ff0aecb12a12cda279bd1
Signed-off-by: Ori Liel <oliel(a)redhat.com>
---
M backend/manager/modules/restapi/types/src/test/java/org/ovirt/engine/api/restapi/types/VmMapperTest.java
1 file changed, 6 insertions(+), 4 deletions(-)
Approvals:
Ori Liel: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/19777
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Iaa9794a268551461263ff0aecb12a12cda279bd1
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Ori Liel <oliel(a)redhat.com>
Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com>
10 years, 8 months
Change in ovirt-engine[ovirt-engine-3.3]: core, frontend: allow console reconnect incorrectly handled
by iheim＠redhat.com
Itamar Heim has submitted this change and it was merged.
Change subject: core,frontend: allow console reconnect incorrectly handled
......................................................................
core,frontend: allow console reconnect incorrectly handled
Problems:
- it was not dependent on the VM Type
- by default it was not checked but since the default VM Type is server it
should have been
- it was completly ignored on the pool (both on FE and on BE)
This patch fixes all of this issues.
Change-Id: I16c364133ce5da37517007960ba6fb4af79a6aea
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1005689
Signed-off-by: Tomas Jelinek <tjelinek(a)redhat.com>
---
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VmStatic.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/pools/PoolListModel.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/NewVmModelBehavior.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/PoolModelBehaviorBase.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/UnitVmModel.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmModelBehaviorBase.java
6 files changed, 8 insertions(+), 4 deletions(-)
Approvals:
Itamar Heim: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/19765
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I16c364133ce5da37517007960ba6fb4af79a6aea
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.3
Gerrit-Owner: Tomas Jelinek <tjelinek(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 8 months
Change in ovirt-engine[master]: resatpi: Eliminate Exceptions in Mapper Tests
by oliel＠redhat.com
Ori Liel has submitted this change and it was merged.
Change subject: resatpi: Eliminate Exceptions in Mapper Tests
......................................................................
resatpi: Eliminate Exceptions in Mapper Tests
Up until now, mapper tests silently ignored several failures to
instantiated new objects using reflection. There were two types of problems:
- Instantiation of objects with no empty constructor (namely XMLGregorianCalendar)
- Mismatch between plural and singular entity name, e.g:
'Floppies.java' vs 'Floppy.java' (differenct than truncating the suffix 's')
All exceptional cases have been handled in this patch, and all methods that
had a try/catch clause, which swallowed the exception, were made to 'throw'
the exception onward instead.
Change-Id: I84cabed0ff38196d8fd57d2f72ffdfe213f2ffed
Signed-off-by: Ori Liel <oliel(a)redhat.com>
---
M backend/manager/modules/restapi/types/src/test/java/org/ovirt/engine/api/restapi/types/AbstractInvertibleMappingTest.java
M backend/manager/modules/restapi/types/src/test/java/org/ovirt/engine/api/restapi/types/GlusterBrickDetailMapperTest.java
M backend/manager/modules/restapi/types/src/test/java/org/ovirt/engine/api/restapi/types/MappingTestHelper.java
3 files changed, 105 insertions(+), 79 deletions(-)
Approvals:
Ori Liel: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/19673
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I84cabed0ff38196d8fd57d2f72ffdfe213f2ffed
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Ori Liel <oliel(a)redhat.com>
Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com>
Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 8 months
Change in ovirt-engine[master]: restapi: Improve Performance in mapper tests
by oliel＠redhat.com
Ori Liel has submitted this change and it was merged.
Change subject: restapi: Improve Performance in mapper tests
......................................................................
restapi: Improve Performance in mapper tests
Change-Id: I29908ea9d5cf232a3079f28927b70ad0ce37a010
Signed-off-by: Ori Liel <oliel(a)redhat.com>
---
M backend/manager/modules/restapi/types/src/test/java/org/ovirt/engine/api/restapi/types/MappingTestHelper.java
M backend/manager/modules/restapi/types/src/test/java/org/ovirt/engine/api/restapi/types/NetworkMapperTest.java
M backend/manager/modules/restapi/types/src/test/java/org/ovirt/engine/api/restapi/types/VmMapperTest.java
3 files changed, 33 insertions(+), 10 deletions(-)
Approvals:
Ori Liel: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/19670
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I29908ea9d5cf232a3079f28927b70ad0ce37a010
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Ori Liel <oliel(a)redhat.com>
Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com>
Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 8 months
Change in ovirt-engine[ovirt-engine-3.3]: webadmin: Fixed public profile in add/edit network
by iheim＠redhat.com
Itamar Heim has submitted this change and it was merged.
Change subject: webadmin: Fixed public profile in add/edit network
......................................................................
webadmin: Fixed public profile in add/edit network
Didn't do nothing before, now actually sets whether the profile may be
used by all users or not.
Change-Id: Ie87563dd45d3343bd963c2f4a1ed228361589823
Bug-Url: https://bugzilla.redhat.com/1000801
Signed-off-by: Lior Vernia <lvernia(a)redhat.com>
---
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/datacenters/NetworkModel.java
1 file changed, 2 insertions(+), 1 deletion(-)
Approvals:
Itamar Heim: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/19773
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ie87563dd45d3343bd963c2f4a1ed228361589823
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.3
Gerrit-Owner: Lior Vernia <lvernia(a)redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com>
Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com>
Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 8 months
Change in ovirt-engine[ovirt-engine-3.3]: engine: add support for ram/vram on QXL device
by iheim＠redhat.com
Itamar Heim has submitted this change and it was merged.
Change subject: engine: add support for ram/vram on QXL device
......................................................................
engine: add support for ram/vram on QXL device
setting support for qxl device with proper ram/vram attributes:
1 Monitor, Single PCI checked 64MB 32MB
2 Monitors, Single PCI checked 128MB 32MB
4 Monitors, Single PCI checked 256MB 32MB
Change-Id: I0d380901daea93c3d6dbdfee48addf190e15ed5a
Bug-Url: https://bugzilla.redhat.com/787578
Signed-off-by: Shahar Havivi <shaharh(a)redhat.com>
Signed-off-by: Omer Frenkel <ofrenkel(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/utils/VmDeviceUtils.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/utils/VmDeviceCommonUtils.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VmInfoBuilder.java
3 files changed, 23 insertions(+), 15 deletions(-)
Approvals:
Itamar Heim: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/19720
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I0d380901daea93c3d6dbdfee48addf190e15ed5a
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.3
Gerrit-Owner: Omer Frenkel <ofrenkel(a)redhat.com>
Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com>
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>
Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 8 months