Change in ovirt-engine[master]: core: Remove unused empty method in VdsHandler
by amureini@redhat.com
Allon Mureinik has submitted this change and it was merged.
Change subject: core: Remove unused empty method in VdsHandler
......................................................................
core: Remove unused empty method in VdsHandler
Change-Id: Iad3736231a24947f896169eace0758bc8d1048a8
Signed-off-by: Allon Mureinik <amureini(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VdsHandler.java
1 file changed, 0 insertions(+), 5 deletions(-)
Approvals:
Allon Mureinik: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/21675
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Iad3736231a24947f896169eace0758bc8d1048a8
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>
Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
11 years, 1 month
Change in ovirt-engine[master]: engine: Search VMs, Templates, and Storage by description
by oourfali@redhat.com
Oved Ourfali has submitted this change and it was merged.
Change subject: engine: Search VMs, Templates, and Storage by description
......................................................................
engine: Search VMs, Templates, and Storage by description
Users have asked for the ability to search for Virtual Machines by
description. Add 'description' as a condition field for all objects which
have a description field in the Database but do not yet support it for
search: VMs, Storage, and VM Templates.
Change-Id: I2909b3444cf6729680018150974a644d2b61a790
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=526471
Signed-off-by: Adam Litke <alitke(a)redhat.com>
---
M backend/manager/modules/searchbackend/src/main/java/org/ovirt/engine/core/searchbackend/StorageDomainFieldAutoCompleter.java
M backend/manager/modules/searchbackend/src/main/java/org/ovirt/engine/core/searchbackend/VmConditionFieldAutoCompleter.java
M backend/manager/modules/searchbackend/src/main/java/org/ovirt/engine/core/searchbackend/VmTemplateConditionFieldAutoCompleter.java
M backend/manager/modules/searchbackend/src/test/java/org/ovirt/engine/core/searchbackend/VmConditionFieldAutoCompleterTest.java
4 files changed, 17 insertions(+), 1 deletion(-)
Approvals:
Oved Ourfali: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/21656
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I2909b3444cf6729680018150974a644d2b61a790
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Adam Litke <alitke(a)redhat.com>
Gerrit-Reviewer: Adam Litke <alitke(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
11 years, 1 month
Change in mom[master]: Add (debug ...) command to enable logging from inside the po...
by alitke@redhat.com
Adam Litke has submitted this change and it was merged.
Change subject: Add (debug ...) command to enable logging from inside the policy
......................................................................
Add (debug ...) command to enable logging from inside the policy
Change-Id: I23dae405908a4d801dc9ac28a9fe2caff698f603
Signed-off-by: Martin Sivak <msivak(a)redhat.com>
Reviewed-on: http://gerrit.ovirt.org/21725
Reviewed-by: Adam Litke <alitke(a)redhat.com>
Tested-by: Adam Litke <alitke(a)redhat.com>
---
M mom/Policy/Parser.py
M tests/ParserTests.py
2 files changed, 17 insertions(+), 2 deletions(-)
Approvals:
Adam Litke: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/21725
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I23dae405908a4d801dc9ac28a9fe2caff698f603
Gerrit-PatchSet: 3
Gerrit-Project: mom
Gerrit-Branch: master
Gerrit-Owner: Martin Sivák <msivak(a)redhat.com>
Gerrit-Reviewer: Adam Litke <alitke(a)redhat.com>
Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com>
11 years, 1 month
Change in ovirt-engine[master]: engine: Fix FileServletTest
by vszocs@redhat.com
Vojtech Szocs has submitted this change and it was merged.
Change subject: engine: Fix FileServletTest
......................................................................
engine: Fix FileServletTest
- A user in engine-devel reported this unit test failing
and we figured out it was because it was trying to read
a file from the environment which was bigger than expected
Fixed the test to read a file from the test resources
instead.
Change-Id: I21794f1838e6161c422561f5023999d0e37f6a71
Signed-off-by: Alexander Wels <awels(a)redhat.com>
---
M backend/manager/modules/utils/src/test/java/org/ovirt/engine/core/utils/servlet/FileServletTest.java
A backend/manager/modules/utils/src/test/resources/org/ovirt/engine/core/utils/servlet/small_file.txt
2 files changed, 10 insertions(+), 5 deletions(-)
Approvals:
Vojtech Szocs: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/21509
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I21794f1838e6161c422561f5023999d0e37f6a71
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alexander Wels <awels(a)redhat.com>
Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com>
Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com>
Gerrit-Reviewer: Gustavo Frederico Temple Pedrosa <gustavo.pedrosa(a)eldorado.org.br>
Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
11 years, 1 month
Change in ovirt-engine[master]: branding: Do not require style sheet files
by vszocs@redhat.com
Vojtech Szocs has submitted this change and it was merged.
Change subject: branding: Do not require style sheet files
......................................................................
branding: Do not require style sheet files
- Removed requirement that style sheet files must be defined in
branding.properties.
- Fixed issue where if a welcome page template would access a key
that wasn't defined in the properties file it would cause a npe.
Change-Id: I6e2b60060557ce15b255d5f30b216d5715b3d095
Signed-off-by: Alexander Wels <awels(a)redhat.com>
---
M README.branding
M backend/manager/modules/branding/src/main/java/org/ovirt/engine/core/branding/BrandingManager.java
M backend/manager/modules/branding/src/main/resources/META-INF/tags/obrand/stylesheets.tag
M packaging/branding/ovirt.brand/branding.properties
4 files changed, 9 insertions(+), 8 deletions(-)
Approvals:
Vojtech Szocs: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/21239
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I6e2b60060557ce15b255d5f30b216d5715b3d095
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alexander Wels <awels(a)redhat.com>
Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com>
Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com>
Gerrit-Reviewer: Kanagaraj M <kmayilsa(a)redhat.com>
Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
11 years, 1 month
Change in ovirt-engine[master]: branding: Allow templates to be replaced
by vszocs@redhat.com
Vojtech Szocs has submitted this change and it was merged.
Change subject: branding: Allow templates to be replaced
......................................................................
branding: Allow templates to be replaced
- Allowed themes the ability to override the default behaviour of
append their templates to previous template. This allows themes
to almost completely replace the entire welcome page.
Change-Id: Id3376500d1ceece80132089d90174e092992d36d
Signed-off-by: Alexander Wels <awels(a)redhat.com>
---
M README.branding
M backend/manager/modules/branding/src/main/java/org/ovirt/engine/core/branding/BrandingManager.java
M backend/manager/modules/branding/src/main/java/org/ovirt/engine/core/branding/BrandingTheme.java
M backend/manager/modules/branding/src/test/java/org/ovirt/engine/core/branding/BrandingThemeTest.java
A backend/manager/modules/branding/src/test/resources/org/ovirt/engine/core/branding/06-test6.brand/branding.properties
A backend/manager/modules/branding/src/test/resources/org/ovirt/engine/core/branding/06-test6.brand/messages.properties
A backend/manager/modules/branding/src/test/resources/org/ovirt/engine/core/branding/06-test6.brand/messages_fr.properties
M packaging/branding/ovirt.brand/branding.properties
8 files changed, 117 insertions(+), 0 deletions(-)
Approvals:
Vojtech Szocs: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/21195
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Id3376500d1ceece80132089d90174e092992d36d
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alexander Wels <awels(a)redhat.com>
Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com>
Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com>
Gerrit-Reviewer: Kanagaraj M <kmayilsa(a)redhat.com>
Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
11 years, 1 month
Change in ovirt-engine[master]: core: rename method in EventDistributionBalancePolicyUnit
by dfediuck@redhat.com
Doron Fediuck has submitted this change and it was merged.
Change subject: core: rename method in EventDistributionBalancePolicyUnit
......................................................................
core: rename method in EventDistributionBalancePolicyUnit
Change-Id: I08bcc8e2037394376009077d1e4fbea7221b1f81
Signed-off-by: Alissa Bonas <abonas(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/policyunits/EvenDistributionBalancePolicyUnit.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/policyunits/PowerSavingBalancePolicyUnit.java
2 files changed, 3 insertions(+), 3 deletions(-)
Approvals:
Doron Fediuck: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/21666
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I08bcc8e2037394376009077d1e4fbea7221b1f81
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alissa Bonas <abonas(a)redhat.com>
Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
11 years, 1 month
Change in ovirt-engine[master]: frontend: stop using keyset in GWTRPCCommunicationProvider
by tnisan@redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: frontend: stop using keyset in GWTRPCCommunicationProvider
......................................................................
frontend: stop using keyset in GWTRPCCommunicationProvider
Continue to patch http://gerrit.ovirt.org/#/c/21618/
Move to use entryset instead. Solves a findbug warning.
Change-Id: I49ad8873174ecbe1c215749741598cf6c1e9e22e
Signed-off-by: Alissa Bonas <abonas(a)redhat.com>
---
M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/communication/GWTRPCCommunicationProvider.java
1 file changed, 6 insertions(+), 6 deletions(-)
Approvals:
Tal Nisan: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/21697
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I49ad8873174ecbe1c215749741598cf6c1e9e22e
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alissa Bonas <abonas(a)redhat.com>
Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com>
Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
11 years, 1 month
Change in ovirt-engine[master]: restapi: Adding support for copy/move disk from disk collect...
by tnisan@redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: restapi: Adding support for copy/move disk from disk collection.
......................................................................
restapi: Adding support for copy/move disk from disk collection.
Adding support for the following urls:
/api/disks/{disk:id}/copy
/api/disks/{disk:id}/move
Change-Id: I516341d3e033a94a997ac5320312e75a5ed1576c
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=911348
Signed-off-by: Sergey Gotliv <sgotliv(a)redhat.com>
---
M backend/manager/modules/restapi/interface/common/jaxrs/src/main/java/org/ovirt/engine/api/common/util/LinkHelper.java
A backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/resource/CopyableResource.java
A backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/resource/MovableCopyableDiskResource.java
A backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/resource/MovableResource.java
M backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/resource/TemplateDiskResource.java
M backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/resource/VmDiskResource.java
M backend/manager/modules/restapi/interface/definition/src/main/resources/rsdl_metadata.yaml
M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendDiskResource.java
M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/utils/FeaturesHelper.java
M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendDiskResourceTest.java
10 files changed, 176 insertions(+), 23 deletions(-)
Approvals:
Tal Nisan: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/13973
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I516341d3e033a94a997ac5320312e75a5ed1576c
Gerrit-PatchSet: 15
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Sergey Gotliv <sgotliv(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com>
Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com>
Gerrit-Reviewer: Sergey Gotliv <sgotliv(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
11 years, 1 month
Change in ovirt-engine[master]: webadmin: Increase width of manage events dialog
by derez@redhat.com
Daniel Erez has submitted this change and it was merged.
Change subject: webadmin: Increase width of manage events dialog
......................................................................
webadmin: Increase width of manage events dialog
Increase the width of Manage Events popup view
dialog to accomodate all the exisiting event names
on single lines.
Change-Id: I77b73f2c5bbf6003b1a99b68eeda70cfaf55c04e
Signed-off-by: Ravi Nori <rnori(a)redhat.com>
---
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/user/ManageEventsPopupView.ui.xml
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Ravi Nori: Verified
Daniel Erez: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/21724
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I77b73f2c5bbf6003b1a99b68eeda70cfaf55c04e
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Ravi Nori <rnori(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
11 years, 1 month