November 2013 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: core: backend search returns only first page...
by ofrenkel＠redhat.com 21 Nov '13

21 Nov '13

Omer Frenkel has submitted this change and it was merged. Change subject: core: backend search returns only first page... ...................................................................... core: backend search returns only first page... backend search returns only first page when given max=-1 Changing the code to get MAX INTEGER records when max = -1 Change-Id: I347c4fe5b4a569d16cb809fee3af7b39b36d9ede Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1025320 Signed-off-by: Eli Mesika <emesika(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/SearchQuery.java 1 file changed, 1 insertion(+), 2 deletions(-) Approvals: Omer Frenkel: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/21375 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I347c4fe5b4a569d16cb809fee3af7b39b36d9ede Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: engine: Update brick status to down when host down
by kmayilsa＠redhat.com 21 Nov '13

21 Nov '13

Kanagaraj M has submitted this change and it was merged. Change subject: engine: Update brick status to down when host down ...................................................................... engine: Update brick status to down when host down When a host goes to non-operation state, update the status of bricks on the host as down Change-Id: Ib29f054c49962551773a63bf7484b4cee43de4de Bug-Url: https://bugzilla.redhat.com/1021441 Signed-off-by: Sahina Bose <sabose(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/SetNonOperationalVdsCommand.java 1 file changed, 14 insertions(+), 0 deletions(-) Approvals: Kanagaraj M: Looks good to me, approved Sahina Bose: Verified -- To view, visit http://gerrit.ovirt.org/21444 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib29f054c49962551773a63bf7484b4cee43de4de Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Sahina Bose <sabose(a)redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayilsa(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Ramesh N <rnachimu(a)redhat.com> Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com> Gerrit-Reviewer: Shubhendu Tripathi <shtripat(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: gluster: consider rebalance failed case in stop rebalance
by ofrenkel＠redhat.com 21 Nov '13

21 Nov '13

Omer Frenkel has submitted this change and it was merged. Change subject: gluster: consider rebalance failed case in stop rebalance ...................................................................... gluster: consider rebalance failed case in stop rebalance Considering the rebalance failed case in stop rebalance BLL and update the task status correctly. Mark the task status same as the status returned from stop rebalance vdsm. If status is empty, mark the status as aborted. Refactored the GlusterTaskUtils.isTaskSuccess() to accept JobExecutionStatus instead of step. Change-Id: I147c43c6925b8a52cf8a7667a5d7f101969f5368 Bug-Url: https://bugzilla.redhat.com/1019598 Signed-off-by: Ramesh Nachimuthu <rnachimu(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/StopRebalanceGlusterVolumeCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/tasks/GlusterTaskUtils.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/gluster/StopRebalanceGlusterVolumeCommandTest.java 3 files changed, 13 insertions(+), 10 deletions(-) Approvals: Omer Frenkel: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/21339 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I147c43c6925b8a52cf8a7667a5d7f101969f5368 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ramesh N <rnachimu(a)redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayilsa(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Ramesh N <rnachimu(a)redhat.com> Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com> Gerrit-Reviewer: Shubhendu Tripathi <shtripat(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: engine: Avoid race condition between gluster peer probe and ...
by kmayilsa＠redhat.com 21 Nov '13

21 Nov '13

Kanagaraj M has submitted this change and it was merged. Change subject: engine: Avoid race condition between gluster peer probe and status ...................................................................... engine: Avoid race condition between gluster peer probe and status During add of a gluster host, a gluster peer probe command is executed. If a gluster peer status is also fired at the same time from GlusterSyncJob this results in the newly added host being removed from the engine database, as the gluster peer status has not yet recognized the newly added host. Added lock at cluster level before peer probe to avoid this. Change-Id: Iaa76cea4c5b5bf7c444680260dd4da5b65665428 Bug-Url: https://bugzilla.redhat.com/972619 Signed-off-by: Sahina Bose <sabose(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/InitVdsOnUpCommand.java 1 file changed, 41 insertions(+), 24 deletions(-) Approvals: Kanagaraj M: Looks good to me, approved Sahina Bose: Verified -- To view, visit http://gerrit.ovirt.org/21015 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iaa76cea4c5b5bf7c444680260dd4da5b65665428 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Sahina Bose <sabose(a)redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayilsa(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com> Gerrit-Reviewer: Shubhendu Tripathi <shtripat(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: gluster: set brick status as volume status
by ofrenkel＠redhat.com 21 Nov '13

21 Nov '13

Omer Frenkel has submitted this change and it was merged. Change subject: gluster: set brick status as volume status ...................................................................... gluster: set brick status as volume status In gluster sync job, after volume information are synced, brick status of new volumes are set to down state. Whereas brick statuses are synced by another thread which updates later. This gives unpleasant user experience. This is fixed by setting brick status as volume status for new volumes. Change-Id: Idab3fd6c7d44a2e7a557bcf1e759dcb969a43374 Signed-off-by: Bala.FA <barumuga(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GlusterSyncJob.java 1 file changed, 5 insertions(+), 0 deletions(-) Approvals: Omer Frenkel: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/21067 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Idab3fd6c7d44a2e7a557bcf1e759dcb969a43374 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Bala.FA <barumuga(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Bala.FA <barumuga(a)redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayilsa(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: engine: Gluster syncing lock correction- change cluster
by kmayilsa＠redhat.com 21 Nov '13

21 Nov '13

Kanagaraj M has submitted this change and it was merged. Change subject: engine: Gluster syncing lock correction- change cluster ...................................................................... engine: Gluster syncing lock correction- change cluster While moving clusters - there is a "gluster peer detach" as well as a "gluster peer probe", and we need to make sure that it does not interfere with the gluster sync job that updates servers in the cluster. Introducing a lock before these 2 operations alone for gluster lock. Change-Id: Ibe28b5eb5baee573f0fa875e06d7ae945ffdb9f9 Signed-off-by: Sahina Bose <sabose(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ChangeVDSClusterCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GlusterJob.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GlusterSyncJob.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/utils/GlusterUtil.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/VdcBllMessages.java M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties 8 files changed, 84 insertions(+), 47 deletions(-) Approvals: Kanagaraj M: Looks good to me, approved Sahina Bose: Verified -- To view, visit http://gerrit.ovirt.org/20647 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ibe28b5eb5baee573f0fa875e06d7ae945ffdb9f9 Gerrit-PatchSet: 8 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Sahina Bose <sabose(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayilsa(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com> Gerrit-Reviewer: Shubhendu Tripathi <shtripat(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: gluster: Update task status everytime while querying
by kmayilsa＠redhat.com 21 Nov '13

21 Nov '13

Kanagaraj M has submitted this change and it was merged. Change subject: gluster: Update task status everytime while querying ...................................................................... gluster: Update task status everytime while querying Modified to update the task status in engine DB everytime a remove bricks status query is fired. This makes sure the details in the DB are up-to-date with query status. This makes sure correct working of Retain and Commit actions on the remobe bricks for volume. Change-Id: I3e8fa7ab590e15ee5821ae2f3fb41650c195c0fa Bug-Url: https://bugzilla.redhat.com/1024782 Signed-off-by: Shubhendu Tripathi <shtripat(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GetGlusterVolumeRemoveBricksStatusQuery.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GlusterAsyncTaskStatusQueryBase.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/gluster/GetGlusterVolumeRebalanceStatusQueryTest.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/gluster/GetGlusterVolumeRemoveBricksStatusQueryTest.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/gluster/GlusterVolumeTaskStatusEntity.java 5 files changed, 94 insertions(+), 4 deletions(-) Approvals: Shubhendu Tripathi: Verified Kanagaraj M: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/21005 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3e8fa7ab590e15ee5821ae2f3fb41650c195c0fa Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shubhendu Tripathi <shtripat(a)redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayilsa(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com> Gerrit-Reviewer: Shubhendu Tripathi <shtripat(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: gluster: Refactored rebalance/remove-brick status queries
by kmayilsa＠redhat.com 21 Nov '13

21 Nov '13

Kanagaraj M has submitted this change and it was merged. Change subject: gluster: Refactored rebalance/remove-brick status queries ...................................................................... gluster: Refactored rebalance/remove-brick status queries Refactored the rebalance and remove bricks status queries and moved the common logic to a base class. Change-Id: I31f7d438641ad05874542fd57b723a0d482a68e4 Signed-off-by: Shubhendu Tripathi <shtripat(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GetGlusterVolumeRebalanceStatusQuery.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GetGlusterVolumeRemoveBricksStatusQuery.java A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GlusterAsyncTaskStatusQueryBase.java 3 files changed, 101 insertions(+), 141 deletions(-) Approvals: Shubhendu Tripathi: Verified Kanagaraj M: Looks good to me, approved Omer Frenkel: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/21448 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I31f7d438641ad05874542fd57b723a0d482a68e4 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shubhendu Tripathi <shtripat(a)redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayilsa(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Ramesh N <rnachimu(a)redhat.com> Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com> Gerrit-Reviewer: Shubhendu Tripathi <shtripat(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-guest-agent[master]: Update README-windows.txt
by vfeenstr＠redhat.com 21 Nov '13

21 Nov '13

Vinzenz Feenstra has submitted this change and it was merged. Change subject: Update README-windows.txt ...................................................................... Update README-windows.txt python OVirtGuestService.py install should be without "-" near install to work as expected. Tested on 3.3. and windows 2003 and 2008 Change-Id: I0e5eb8a6a78a9a6c1a036a4fb451e75bb6fb2d3e Signed-off-by: Vinzenz Feenstra <vfeenstr(a)redhat.com> --- M ovirt-guest-agent/README-windows.txt 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Vinzenz Feenstra: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/21496 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0e5eb8a6a78a9a6c1a036a4fb451e75bb6fb2d3e Gerrit-PatchSet: 1 Gerrit-Project: ovirt-guest-agent Gerrit-Branch: master Gerrit-Owner: Vinzenz Feenstra <vfeenstr(a)redhat.com> Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: backend: confirmDeleteDomain replace println
by emesika＠redhat.com 21 Nov '13

21 Nov '13

Eli Mesika has submitted this change and it was merged. Change subject: backend: confirmDeleteDomain replace println ...................................................................... backend: confirmDeleteDomain replace println User answers should be in the same line of question. Change-Id: I86ee47a9cbca84776be783687f5a2182dda4b959 Signed-off-by: Douglas Schilling Landgraf <dougsland(a)redhat.com> --- M backend/manager/tools/src/main/java/org/ovirt/engine/core/domains/ManageDomains.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Eli Mesika: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/19399 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I86ee47a9cbca84776be783687f5a2182dda4b959 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Douglas Schilling Landgraf <dougsland(a)redhat.com> Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com> Gerrit-Reviewer: Eli Mesika <elimesika(a)gmail.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0