November 2013 - Engine-commits - oVirt List Archives

Change in ovirt-reports[ovirt-3.3.1]: packaging: returned basic auth to html login chain
by ydary＠redhat.com 21 Nov '13

21 Nov '13

Yaniv Dary has submitted this change and it was merged. Change subject: packaging: returned basic auth to html login chain ...................................................................... packaging: returned basic auth to html login chain This is due to fix of api basic authentication mechanism. Change-Id: I196d7429d760de4ea6b8181dd8532655517482ff Related-To: https://bugzilla.redhat.com/1032508 Bug-Url: https://bugzilla.redhat.com/1020340 Signed-off-by: Yaniv Dary <ydary(a)redhat.com> --- M server-customizations/WEB-INF/applicationContext-security-web.xml 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Yaniv Dary: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/21468 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I196d7429d760de4ea6b8181dd8532655517482ff Gerrit-PatchSet: 2 Gerrit-Project: ovirt-reports Gerrit-Branch: ovirt-3.3.1 Gerrit-Owner: Yaniv Dary <ydary(a)redhat.com> Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com>

1 0

Change in ovirt-reports[master]: packaging: returned basic auth to html login chain
by ydary＠redhat.com 21 Nov '13

21 Nov '13

Yaniv Dary has submitted this change and it was merged. Change subject: packaging: returned basic auth to html login chain ...................................................................... packaging: returned basic auth to html login chain This is due to fix of api basic authentication mechanism. Change-Id: I1882f115bd2f14b0e00b907436536664d185bdb9 Related-To: https://bugzilla.redhat.com/1032508 Bug-Url: https://bugzilla.redhat.com/1020340 Signed-off-by: Yaniv Dary <ydary(a)redhat.com> --- M server-customizations/WEB-INF/applicationContext-security-web.xml 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Yaniv Dary: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/21467 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1882f115bd2f14b0e00b907436536664d185bdb9 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-reports Gerrit-Branch: master Gerrit-Owner: Yaniv Dary <ydary(a)redhat.com> Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com>

1 0

Change in ovirt-engine[master]: engine: cleanup AddVdsCommand locking
by kmayilsa＠redhat.com 21 Nov '13

21 Nov '13

Kanagaraj M has submitted this change and it was merged. Change subject: engine: cleanup AddVdsCommand locking ...................................................................... engine: cleanup AddVdsCommand locking AddVdsCommand was overriding getExclusiveLocks to lock the cluster if cluster supports gluster service. But this is not required here as the "gluster peer probe" which requires the lock only happens after the host comes up. Removed the code which does a "gluster peer probe" in case ConfigValues.InstallVds = true. This code gets executed as InitVdsOnUpCommand and is not required here. Change-Id: I6189d7f0046a943a58db9d6734c92fe462c9db52 Bug-Url: https://bugzilla.redhat.com/998799 Signed-off-by: Sahina Bose <sabose(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVdsCommand.java 1 file changed, 2 insertions(+), 50 deletions(-) Approvals: Kanagaraj M: Looks good to me, approved Sahina Bose: Verified -- To view, visit http://gerrit.ovirt.org/18350 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6189d7f0046a943a58db9d6734c92fe462c9db52 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Sahina Bose <sabose(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayilsa(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com> Gerrit-Reviewer: Shubhendu Tripathi <shtripat(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: gluster: fix typo and cleanup rsdl_metadata.yaml
by kmayilsa＠redhat.com 21 Nov '13

21 Nov '13

Kanagaraj M has submitted this change and it was merged. Change subject: gluster: fix typo and cleanup rsdl_metadata.yaml ...................................................................... gluster: fix typo and cleanup rsdl_metadata.yaml Change-Id: I17d73257a1b28f3362bae8ca41dc578a37b88b2e Signed-off-by: Timothy Asir <tjeyasin(a)redhat.com> --- M backend/manager/modules/restapi/interface/definition/src/main/resources/rsdl_metadata.yaml 1 file changed, 5 insertions(+), 5 deletions(-) Approvals: Timothy Asir: Verified Kanagaraj M: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/19186 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I17d73257a1b28f3362bae8ca41dc578a37b88b2e Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Timothy Asir <tjeyasin(a)redhat.com> Gerrit-Reviewer: Gustavo Frederico Temple Pedrosa <gustavo.pedrosa(a)eldorado.org.br> Gerrit-Reviewer: Kanagaraj M <kmayilsa(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com> Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com> Gerrit-Reviewer: Shubhendu Tripathi <shtripat(a)redhat.com> Gerrit-Reviewer: Timothy Asir <tjeyasin(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: gluster: During import check host existence by UUID
by kmayilsa＠redhat.com 21 Nov '13

21 Nov '13

Kanagaraj M has submitted this change and it was merged. Change subject: gluster: During import check host existence by UUID ...................................................................... gluster: During import check host existence by UUID Modified to check the existence of hosts in the cluster by UUID, while impporting the hosts into console which got added from CLI. This makes sure no self entries get listed because of virbr0 bridge and also resolves the hanging issue while importing the hosts added from CLI. Also added logic to discard a host ifrom the list if there is no fingerprint available for the same. Change-Id: I60f5fdf16c6b2cf717a041b34f9e62e0ac6b78f3 Bug-Url: https://bugzilla.redhat.com/1021773 Signed-off-by: Shubhendu Tripathi <shtripat(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GetAddedGlusterServersQuery.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/gluster/GetAddedGlusterServersQueryTest.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/gluster/GlusterDBUtils.java 3 files changed, 90 insertions(+), 17 deletions(-) Approvals: Kanagaraj M: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/20697 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I60f5fdf16c6b2cf717a041b34f9e62e0ac6b78f3 Gerrit-PatchSet: 8 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shubhendu Tripathi <shtripat(a)redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayilsa(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com> Gerrit-Reviewer: Shubhendu Tripathi <shtripat(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: gluster: Modified to fail remove host if already removed fro...
by kmayilsa＠redhat.com 21 Nov '13

21 Nov '13

Kanagaraj M has submitted this change and it was merged. Change subject: gluster: Modified to fail remove host if already removed from CLI ...................................................................... gluster: Modified to fail remove host if already removed from CLI Modified to fail remove host if already removed from CLI and not yet synchronized with UI. Earlier it was not failing in the UI and was successfully removing the host from UI. Bug-Url: https://bugzilla.redhat.com/1024183 Change-Id: I1e8c79bcbf9c3dc733641812f505170e369448a1 Signed-off-by: Shubhendu Tripathi <shtripat(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveVdsCommand.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/VdcBllErrors.java M backend/manager/modules/dal/src/main/resources/bundles/VdsmErrors.properties M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/gluster/AbstractGlusterBrokerCommand.java M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/VdsmErrors.java M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/VdsmErrors.properties 6 files changed, 17 insertions(+), 12 deletions(-) Approvals: Shubhendu Tripathi: Verified Kanagaraj M: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/20655 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1e8c79bcbf9c3dc733641812f505170e369448a1 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shubhendu Tripathi <shtripat(a)redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayilsa(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com> Gerrit-Reviewer: Shubhendu Tripathi <shtripat(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-dwh[ovirt-3.3.1]: packaging: service: update log permissions
by ydary＠redhat.com 20 Nov '13

20 Nov '13

Yaniv Dary has submitted this change and it was merged. Change subject: packaging: service: update log permissions ...................................................................... packaging: service: update log permissions Change-Id: I23747b45456af0961b7af3a0297f49e92c77cac7 Bug-Url: https://bugzilla.redhat.com/1031992 Signed-off-by: Alex Lourie <alourie(a)redhat.com> --- M data-warehouse/history_etl/history_service/ovirt-engine-dwhd 1 file changed, 5 insertions(+), 0 deletions(-) Approvals: Alex Lourie: Verified Yaniv Dary: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/21458 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I23747b45456af0961b7af3a0297f49e92c77cac7 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-dwh Gerrit-Branch: ovirt-3.3.1 Gerrit-Owner: Alex Lourie <alourie(a)redhat.com> Gerrit-Reviewer: Alex Lourie <alourie(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com>

1 0

Change in ovirt-dwh[master]: packaging: service: update log permission
by ydary＠redhat.com 20 Nov '13

20 Nov '13

Yaniv Dary has submitted this change and it was merged. Change subject: packaging: service: update log permission ...................................................................... packaging: service: update log permission Change-Id: I23747b45456af0961b7af3a0297f49e92c77cac7 Bug-Url: https://bugzilla.redhat.com/1031992 Signed-off-by: Alex Lourie <alourie(a)redhat.com> --- M data-warehouse/history_etl/history_service/ovirt-engine-dwhd 1 file changed, 5 insertions(+), 0 deletions(-) Approvals: Yaniv Dary: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/21457 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I23747b45456af0961b7af3a0297f49e92c77cac7 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-dwh Gerrit-Branch: master Gerrit-Owner: Alex Lourie <alourie(a)redhat.com> Gerrit-Reviewer: Alex Lourie <alourie(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com>

1 0

Change in ovirt-engine[ovirt-engine-3.3]: webadmin: Use /api/ instead of /api
by iheim＠redhat.com 20 Nov '13

20 Nov '13

Itamar Heim has submitted this change and it was merged. Change subject: webadmin: Use /api/ instead of /api ...................................................................... webadmin: Use /api/ instead of /api The GUI uses the /api URL to get a RESTAPI session that can then be used by plugins. When using basic authentication this means that the browser will remember the credentials and send them back to any request for URLs with paths starting with /, all. With the trailing slash it will send them only to URLs ending with /api/. Change-Id: I096a8769ff018f60366ab4ec8d2425c7f8d0f7e2 Bug-Url: https://bugzilla.redhat.com/1032508 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/plugin/restapi/RestApiSessionManager.java 1 file changed, 4 insertions(+), 1 deletion(-) Approvals: Juan Hernandez: Verified Alexander Wels: Looks good to me, but someone else must approve Einav Cohen: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/21472 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I096a8769ff018f60366ab4ec8d2425c7f8d0f7e2 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.3 Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: webadmin: Use /api/ instead of /api
by ecohen＠redhat.com 20 Nov '13

20 Nov '13

Einav Cohen has submitted this change and it was merged. Change subject: webadmin: Use /api/ instead of /api ...................................................................... webadmin: Use /api/ instead of /api The GUI uses the /api URL to get a RESTAPI session that can then be used by plugins. When using basic authentication this means that the browser will remember the credentials and send them back to any request for URLs with paths starting with /, all. With the trailing slash it will send them only to URLs ending with /api/. Change-Id: I096a8769ff018f60366ab4ec8d2425c7f8d0f7e2 Bug-Url: https://bugzilla.redhat.com/1032508 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/plugin/restapi/RestApiSessionManager.java 1 file changed, 4 insertions(+), 1 deletion(-) Approvals: Michael Pasternak: Looks good to me, approved Juan Hernandez: Verified Alexander Wels: Looks good to me, but someone else must approve Einav Cohen: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/21431 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I096a8769ff018f60366ab4ec8d2425c7f8d0f7e2 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0