November 2013 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: core: exportDbSchema scripts generates output...
by ofrenkel＠redhat.com 24 Nov '13

24 Nov '13

Omer Frenkel has submitted this change and it was merged. Change subject: core: exportDbSchema scripts generates output... ...................................................................... core: exportDbSchema scripts generates output... exportDbSchema scripts generates output file with wrong name 1) Fixing the file name by using psql directly 2) Fixing -v to display more info 3) Adding a missing PORT parameter Change-Id: I3d05e96f4abc66e293db23af89285b0653025537 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1009899 Signed-off-by: Eli Mesika <emesika(a)redhat.com> --- M packaging/dbscripts/exportDbSchema.sh 1 file changed, 6 insertions(+), 3 deletions(-) Approvals: Omer Frenkel: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/19679 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3d05e96f4abc66e293db23af89285b0653025537 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: engine: Revert parts of 34a62959369617e6191ca71c3ec73f93e002...
by gchaplik＠redhat.com 24 Nov '13

24 Nov '13

Gilad Chaplik has submitted this change and it was merged. Change subject: engine: Revert parts of 34a62959369617e6191ca71c3ec73f93e002e957 ...................................................................... engine: Revert parts of 34a62959369617e6191ca71c3ec73f93e002e957 This should have never got to the patchset. Probably a rebase leftover... Change-Id: I6f1bdb083e4fde3025dff6f79b9145a257338c37 Signed-off-by: Martin Sivak <msivak(a)redhat.com> --- M backend/manager/modules/dal/src/main/resources/bundles/VdsmErrors.properties M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/VdsmErrors.java M frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/ApplicationMessages.java M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/VdsmErrors.properties M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/ApplicationMessages.java M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/VdsmErrors.properties 7 files changed, 35 insertions(+), 20 deletions(-) Approvals: Gilad Chaplik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/21511 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6f1bdb083e4fde3025dff6f79b9145a257338c37 Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: case-insensitive name uniqueness validation on DCs and...
by oourfali＠redhat.com 24 Nov '13

24 Nov '13

Oved Ourfali has submitted this change and it was merged. Change subject: core: case-insensitive name uniqueness validation on DCs and Clusters ...................................................................... core: case-insensitive name uniqueness validation on DCs and Clusters This patch ensures no two DCs and Clusters are created with the same name, using a case-insensitive validation (rather than the current implementation which is case-sensitive). Change-Id: I316efa401f742638c070561b75fc863178d8c1a8 Bug-Url: https://bugzilla.redhat.com/828080 Signed-off-by: Oved Ourfali <oourfali(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVdsGroupCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVdsGroupCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VdsGroupOperationCommandBase.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/AddEmptyStoragePoolCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/StoragePoolManagementCommandBase.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/UpdateStoragePoolCommand.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/UpdateVdsGroupCommandTest.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/UpdateStoragePoolCommandTest.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/StoragePoolDAO.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/StoragePoolDAODbFacadeImpl.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VdsGroupDAO.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VdsGroupDAODbFacadeImpl.java M packaging/dbscripts/storages_sp.sql M packaging/dbscripts/vds_groups_sp.sql 14 files changed, 78 insertions(+), 15 deletions(-) Approvals: Oved Ourfali: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/21214 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I316efa401f742638c070561b75fc863178d8c1a8 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: webadmin: change search to be case-insensitive
by oourfali＠redhat.com 24 Nov '13

24 Nov '13

Oved Ourfali has submitted this change and it was merged. Change subject: webadmin: change search to be case-insensitive ...................................................................... webadmin: change search to be case-insensitive This patch adds a case sensitive flag in the search bar, passing it over to the engine (this functionality is already supported in the engine) Change-Id: Ia2c5f48cf565533c330c80a02ee24596ee039e2d Bug-Url: https://bugzilla.redhat.com/828080 Signed-off-by: Oved Ourfali <oourfali(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/CommonModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/SearchableListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/clusters/ClusterListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/datacenters/DataCenterListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/disks/DiskListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/events/EventListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/networks/NetworkListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/pools/PoolListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/profiles/VnicProfileListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/providers/ProviderListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/quota/QuotaListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/StorageListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/templates/TemplateListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/users/UserListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/volumes/VolumeListModel.java 17 files changed, 28 insertions(+), 15 deletions(-) Approvals: Oved Ourfali: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/21213 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia2c5f48cf565533c330c80a02ee24596ee039e2d Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: Removing leftover of rootPassword
by emesika＠redhat.com 24 Nov '13

24 Nov '13

Eli Mesika has submitted this change and it was merged. Change subject: core: Removing leftover of rootPassword ...................................................................... core: Removing leftover of rootPassword On host install action (or reinstall) we validated that rootPassword parameter is passed. This validation is a leftover of previous implementation. Currently all parameters in reinstall action are optional. Change-Id: I2c6bc0343e204a41b811989d3153f83aff993e85 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1029050 Signed-off-by: Yaniv Bronhaim <ybronhei(a)redhat.com> --- M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendHostResource.java 1 file changed, 0 insertions(+), 2 deletions(-) Approvals: Eli Mesika: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/21345 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2c6bc0343e204a41b811989d3153f83aff993e85 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim <ybronhei(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: engine : User is not able to see newly added permissions on ...
by emesika＠redhat.com 24 Nov '13

24 Nov '13

Eli Mesika has submitted this change and it was merged. Change subject: engine : User is not able to see newly added permissions on object if he inherited this permission on that object ...................................................................... engine : User is not able to see newly added permissions on object if he inherited this permission on that object In UserPortal if user inherit some permissions on some object, than if he try to add new permissions to object that he inherit permission from, he is not able to see this newly added permissions. >From webadmin portal getAllUsersWithPermission returns false so the original query "GetPermissionsByEntityId" is executed. >From USer portal getAllUsersWithPermission returns true so the new query "GetAllUsersWithPermissionsOnEntityByEntityId" is executed. Change-Id: I9f8f8b110c41665bb6efe2647b654b845d70b7de Bug-Url: https://bugzilla.redhat.com/877906 Signed-off-by: Ravi Nori <rnori(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetPermissionsForObjectQuery.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/GetPermissionsForObjectQueryTest.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/GetPermissionsForObjectParameters.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/PermissionDAO.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/PermissionDAODbFacadeImpl.java M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/PermissionDAOTest.java M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/RoleDAOTest.java M backend/manager/modules/dal/src/test/resources/fixtures.xml M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/configure/PermissionListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/configure/UserPortalPermissionListModel.java M packaging/dbscripts/multi_level_administration_sp.sql 11 files changed, 100 insertions(+), 7 deletions(-) Approvals: Eli Mesika: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/19377 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9f8f8b110c41665bb6efe2647b654b845d70b7de Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-node-plugin-vdsm[node-3.0]: ovirt-node-plugin-vdsm.spec: increase the release
by dougsland＠redhat.com 23 Nov '13

23 Nov '13

Douglas Schilling Landgraf has submitted this change and it was merged. Change subject: ovirt-node-plugin-vdsm.spec: increase the release ...................................................................... ovirt-node-plugin-vdsm.spec: increase the release New build to include: - engine_page: ovirt.node.config.defaults SSH (BZ#901497) Change-Id: Idae89d9203e7ec0861143cbeee3a6f5766baf1e1 Signed-off-by: Douglas Schilling Landgraf <dougsland(a)redhat.com> --- M ovirt-node-plugin-vdsm.spec.in 1 file changed, 4 insertions(+), 1 deletion(-) Approvals: Douglas Schilling Landgraf: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/21558 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Idae89d9203e7ec0861143cbeee3a6f5766baf1e1 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-node-plugin-vdsm Gerrit-Branch: node-3.0 Gerrit-Owner: Douglas Schilling Landgraf <dougsland(a)redhat.com> Gerrit-Reviewer: Barak Azulay <bazulay(a)redhat.com> Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com> Gerrit-Reviewer: Fabian Deutsch <fabiand(a)fedoraproject.org>

1 0

Change in ovirt-engine[ovirt-engine-3.3]: packaging: setup: Fix for typo in setup.
by iheim＠redhat.com 22 Nov '13

22 Nov '13

Itamar Heim has submitted this change and it was merged. Change subject: packaging: setup: Fix for typo in setup. ...................................................................... packaging: setup: Fix for typo in setup. Configurating PostgreSQL and Configurating WebSocket Proxy have been changed to Configuring PostgreSQL and Configuring WebSocket Proxy respectively. Change-Id: I24e2920c24bb2452b58fd355dc59ec76ca784fab https://bugzilla.redhat.com/show_bug.cgi?id=1031543 Signed-off-by: ndarshan <dnarayan(a)redhat.com> --- M packaging/setup/plugins/ovirt-engine-setup/config/websocket_proxy.py M packaging/setup/plugins/ovirt-engine-setup/provisioning/postgres.py 2 files changed, 2 insertions(+), 2 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/21552 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I24e2920c24bb2452b58fd355dc59ec76ca784fab Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.3 Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Darshan N <dnarayan(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-node-plugin-vdsm[node-3.0]: engine_page: ovirt.node.config.defaults SSH
by dougsland＠redhat.com 22 Nov '13

22 Nov '13

Douglas Schilling Landgraf has submitted this change and it was merged. Change subject: engine_page: ovirt.node.config.defaults SSH ...................................................................... engine_page: ovirt.node.config.defaults SSH Use SSH class from ovirt.node.config.defaults to enable SSH password authentication, persist the files and update the node config file. Thanks to Fabian Deutsch Change-Id: I03dda8474aac4c37859a50dd9c1a2a68dc046f6d Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=901497 Signed-off-by: Douglas Schilling Landgraf <dougsland(a)redhat.com> --- M src/engine_page.py 1 file changed, 4 insertions(+), 4 deletions(-) Approvals: Douglas Schilling Landgraf: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/21478 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I03dda8474aac4c37859a50dd9c1a2a68dc046f6d Gerrit-PatchSet: 1 Gerrit-Project: ovirt-node-plugin-vdsm Gerrit-Branch: node-3.0 Gerrit-Owner: Douglas Schilling Landgraf <dougsland(a)redhat.com> Gerrit-Reviewer: Barak Azulay <bazulay(a)redhat.com> Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com> Gerrit-Reviewer: Fabian Deutsch <fabiand(a)fedoraproject.org>

1 0

Change in ovirt-engine[master]: packaging: setup: Fix for typo in setup.
by sbonazzo＠redhat.com 22 Nov '13

22 Nov '13

Sandro Bonazzola has submitted this change and it was merged. Change subject: packaging: setup: Fix for typo in setup. ...................................................................... packaging: setup: Fix for typo in setup. Configurating PostgreSQL and Configurating WebSocket Proxy have been changed to Configuring PostgreSQL and Configuring WebSocket Proxy respectively. Change-Id: I24e2920c24bb2452b58fd355dc59ec76ca784fab https://bugzilla.redhat.com/show_bug.cgi?id=1031543 Signed-off-by: ndarshan <dnarayan(a)redhat.com> --- M packaging/setup/plugins/ovirt-engine-setup/config/websocket_proxy.py M packaging/setup/plugins/ovirt-engine-setup/provisioning/postgres.py 2 files changed, 2 insertions(+), 2 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/21537 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I24e2920c24bb2452b58fd355dc59ec76ca784fab Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Darshan N <dnarayan(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0