November 2013 - Engine-commits - oVirt List Archives

Change in mom[master]: Make the policy language more lisp like
by agl＠us.ibm.com 12 Nov '13

12 Nov '13

Adam Litke has submitted this change and it was merged. Change subject: Make the policy language more lisp like ...................................................................... Make the policy language more lisp like This patch adds: (defun name (vars..) body) (setq name value) It also changes (defvar ..) to define the variable only once. If the current scope already contains the name, the value stays unchanged. Another change was made to (let ..). It now accepts multiple statements to evaluate in the form of: (let (vars) expr1 expr2 ...) Change-Id: I1268df51d730f8128e600b78cf9cc77ed983f7c6 Signed-off-by: Martin Sivak <msivak(a)redhat.com> Reviewed-on: http://gerrit.ovirt.org/21137 Reviewed-by: Adam Litke <agl(a)us.ibm.com> --- M mom/Policy/Parser.py M tests/ParserTests.py 2 files changed, 82 insertions(+), 17 deletions(-) Approvals: Adam Litke: Looks good to me, approved Martin Sivák: Verified -- To view, visit http://gerrit.ovirt.org/21137 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1268df51d730f8128e600b78cf9cc77ed983f7c6 Gerrit-PatchSet: 6 Gerrit-Project: mom Gerrit-Branch: master Gerrit-Owner: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Adam Litke <agl(a)us.ibm.com> Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com>

1 0

Change in mom[master]: Add support for swap information to be used in policy
by agl＠us.ibm.com 12 Nov '13

12 Nov '13

Adam Litke has submitted this change and it was merged. Change subject: Add support for swap information to be used in policy ...................................................................... Add support for swap information to be used in policy This patch adds support for swap size and swap usage values to be collected by guest agent or qemu agent and used in memory calculations. The same variables are also collected from Host and used in pressure detection algorithm. Change-Id: If1f8ae4d090e27a41ee541acc9398cd1a56b459a Signed-off-by: Martin Sivak <msivak(a)redhat.com> Reviewed-on: http://gerrit.ovirt.org/20978 Reviewed-by: Adam Litke <agl(a)us.ibm.com> --- M mom/Collectors/GuestMemory.py M mom/Collectors/GuestQemuAgent.py M mom/Collectors/HostMemory.py M mom/HypervisorInterfaces/libvirtInterface.py M mom/HypervisorInterfaces/vdsmInterface.py 5 files changed, 24 insertions(+), 5 deletions(-) Approvals: Adam Litke: Looks good to me, approved Martin Sivák: Verified -- To view, visit http://gerrit.ovirt.org/20978 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If1f8ae4d090e27a41ee541acc9398cd1a56b459a Gerrit-PatchSet: 6 Gerrit-Project: mom Gerrit-Branch: master Gerrit-Owner: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Adam Litke <agl(a)us.ibm.com> Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com>

1 0

Change in mom[master]: Add support for optional collector fields and (null expr) test
by agl＠us.ibm.com 12 Nov '13

12 Nov '13

Adam Litke has submitted this change and it was merged. Change subject: Add support for optional collector fields and (null expr) test ...................................................................... Add support for optional collector fields and (null expr) test This adds support for fields that might or might not be collected. When that happens the data fields are set to None. The policy can then use (valid expression) to test whether expression evaluates to non-None value. Change-Id: I3a93f0985870b431c315918b14fee6629eac70fb Signed-off-by: Martin Sivak <msivak(a)redhat.com> Reviewed-on: http://gerrit.ovirt.org/21050 Reviewed-by: Adam Litke <agl(a)us.ibm.com> --- M mom/Collectors/Collector.py M mom/Monitor.py M mom/Policy/Parser.py M tests/ParserTests.py 4 files changed, 58 insertions(+), 7 deletions(-) Approvals: Adam Litke: Looks good to me, approved Martin Sivák: Verified -- To view, visit http://gerrit.ovirt.org/21050 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3a93f0985870b431c315918b14fee6629eac70fb Gerrit-PatchSet: 4 Gerrit-Project: mom Gerrit-Branch: master Gerrit-Owner: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Adam Litke <agl(a)us.ibm.com> Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com>

1 0

Change in ovirt-engine[master]: engine: fix find_bugs non-transient variables on WelcomeServlet
by ecohen＠redhat.com 12 Nov '13

12 Nov '13

Einav Cohen has submitted this change and it was merged. Change subject: engine: fix find_bugs non-transient variables on WelcomeServlet ...................................................................... engine: fix find_bugs non-transient variables on WelcomeServlet Set backend and brandingManager variables to transient to avoid find_bugs warnings. Change-Id: I71bbab70988cad7d8e2d2884633803f9cff3152b Signed-off-by: Greg Sheremeta <gshereme(a)redhat.com> --- M backend/manager/modules/welcome/src/main/java/org/ovirt/engine/core/WelcomeServlet.java 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Einav Cohen: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/21071 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I71bbab70988cad7d8e2d2884633803f9cff3152b Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com> Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.3]: core: Adds missing 3rd party dependencies as modules
by iheim＠redhat.com 12 Nov '13

12 Nov '13

Itamar Heim has submitted this change and it was merged. Change subject: core: Adds missing 3rd party dependencies as modules ...................................................................... core: Adds missing 3rd party dependencies as modules Adds these missing 3rd dependencies as JBoss modules: aopalliance:aopalliance:jar:1.0 c3p0:c3p0:jar:0.9.1.1 org.tukaani:xz:jar:1.0 Change-Id: I04070d30a13117fda0a8f297118a5e6a7ea8061b Bug-Url: https://bugzilla.redhat.com/1016716 Signed-off-by: Martin Perina <mperina(a)redhat.com> --- M backend/manager/dependencies/pom.xml A backend/manager/dependencies/src/main/modules/com/mchange/c3p0/main/module.xml A backend/manager/dependencies/src/main/modules/org/aopalliance/main/module.xml M backend/manager/dependencies/src/main/modules/org/apache/commons/compress/main/module.xml M backend/manager/dependencies/src/main/modules/org/quartz/main/module.xml M backend/manager/dependencies/src/main/modules/org/springframework/main/module.xml A backend/manager/dependencies/src/main/modules/org/tukaani/xz/main/module.xml M ovirt-engine.spec.in M pom.xml 9 files changed, 80 insertions(+), 0 deletions(-) Approvals: Itamar Heim: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/21128 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I04070d30a13117fda0a8f297118a5e6a7ea8061b Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.3 Gerrit-Owner: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.3]: packaging: add engine-cleanup man page
by iheim＠redhat.com 12 Nov '13

12 Nov '13

Itamar Heim has submitted this change and it was merged. Change subject: packaging: add engine-cleanup man page ...................................................................... packaging: add engine-cleanup man page Added man page for engine-cleanup utility, based on engine-setup man page. Change-Id: I9a1d13506e1d28e4e52d5f7f9fb2fd06e2ca2768 Signed-off-by: Ofer Schreiber <oschreib(a)redhat.com> Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1021828 --- M ovirt-engine.spec.in A packaging/man/man8/engine-cleanup.8 2 files changed, 29 insertions(+), 0 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved Yedidyah Bar David: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/21183 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9a1d13506e1d28e4e52d5f7f9fb2fd06e2ca2768 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.3 Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.3]: packaging: Avoid using the file command
by iheim＠redhat.com 12 Nov '13

12 Nov '13

Itamar Heim has submitted this change and it was merged. Change subject: packaging: Avoid using the file command ...................................................................... packaging: Avoid using the file command There is no need to execute `file` in order to determine if a given file is an executable, the bulitin -x test is enough. Change-Id: I190571c5b36f08772fc795eca9fbd082ba248c04 Signed-off-by: Ofer Schreiber <oschreib(a)redhat.com> Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1029036 --- M packaging/dbscripts/dbfunctions.sh 1 file changed, 1 insertion(+), 2 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved Yedidyah Bar David: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/21187 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I190571c5b36f08772fc795eca9fbd082ba248c04 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.3 Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: packaging: Avoid using the file command
by sbonazzo＠redhat.com 12 Nov '13

12 Nov '13

Sandro Bonazzola has submitted this change and it was merged. Change subject: packaging: Avoid using the file command ...................................................................... packaging: Avoid using the file command There is no need to execute `file` in order to determine if a given file is an executable, the bulitin -x test is enough. Change-Id: I190571c5b36f08772fc795eca9fbd082ba248c04 Signed-off-by: Ofer Schreiber <oschreib(a)redhat.com> Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1029036 --- M packaging/dbscripts/dbfunctions.sh 1 file changed, 1 insertion(+), 2 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/21176 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I190571c5b36f08772fc795eca9fbd082ba248c04 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ofer Schreiber <oschreib(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-dwh[ovirt-3.3.1]: packaging: setup: update Makefile and spec to include DB set...
by ydary＠redhat.com 12 Nov '13

12 Nov '13

Yaniv Dary has submitted this change and it was merged. Change subject: packaging: setup: update Makefile and spec to include DB settings ...................................................................... packaging: setup: update Makefile and spec to include DB settings Related-To: https://bugzilla.redhat.com/1026089 Change-Id: I8bbe4b4b3a156d127a938cac089272c3ae3fcd90 Signed-off-by: Alex Lourie <alourie(a)redhat.com> --- M Makefile A packaging/10-setup-database-dwh.conf M packaging/ovirt-engine-dwh.spec.in 3 files changed, 8 insertions(+), 0 deletions(-) Approvals: Yaniv Dary: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/21184 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8bbe4b4b3a156d127a938cac089272c3ae3fcd90 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-dwh Gerrit-Branch: ovirt-3.3.1 Gerrit-Owner: Alex Lourie <alourie(a)redhat.com> Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com>

1 0

Change in ovirt-engine[master]: packaging: add engine-cleanup man page
by sbonazzo＠redhat.com 12 Nov '13

12 Nov '13

Sandro Bonazzola has submitted this change and it was merged. Change subject: packaging: add engine-cleanup man page ...................................................................... packaging: add engine-cleanup man page Added man page for engine-cleanup utility, based on engine-setup man page. Change-Id: I9a1d13506e1d28e4e52d5f7f9fb2fd06e2ca2768 Signed-off-by: Ofer Schreiber <oschreib(a)redhat.com> Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1021828 --- M ovirt-engine.spec.in A packaging/man/man8/engine-cleanup.8 2 files changed, 29 insertions(+), 0 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/20915 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9a1d13506e1d28e4e52d5f7f9fb2fd06e2ca2768 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ofer Schreiber <oschreib(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0