November 2013 - Engine-commits - Ovirt List Archives

Change in ovirt-engine[master]: engine: Change loading of VdsGroup to load from cache

by emesika＠redhat.com

Eli Mesika has submitted this change and it was merged. Change subject: engine: Change loading of VdsGroup to load from cache ...................................................................... engine: Change loading of VdsGroup to load from cache Several pieces of code load VdsGroup. This patch modifies them so that they can read VdsGroup from cache (saving about 3ms per call) Change-Id: Id09c10f06d9fa053540d3b240d53772d0e42c754 Signed-off-by: lzelkha(a)redhat.com <lzelkha(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/cluster/NetworkClusterHelper.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/auditloghandling/AuditLogableBase.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsUpdateRunTimeInfo.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VirtMonitoringStrategy.java 4 files changed, 7 insertions(+), 14 deletions(-) Approvals: Eli Mesika: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/20907 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id09c10f06d9fa053540d3b240d53772d0e42c754 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liran Zelkha <lzelkha(a)redhat.com> Gerrit-Reviewer: Barak Azulay <bazulay(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Liran Zelkha <lzelkha(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

11 years, 2 months

1
0
0 / 0

Change in ovirt-engine[master]: engine : Remove unneeded VdsDynamic updates

by emesika＠redhat.com

Eli Mesika has submitted this change and it was merged. Change subject: engine : Remove unneeded VdsDynamic updates ...................................................................... engine : Remove unneeded VdsDynamic updates VdsUpdateRuntimeInfo updates VdsDynamic even if it hasn't changed. This patch fixes it, and reduces the number of DB updates. Change-Id: I0254991f424490d848f84fc951e64787bf54d7bc Bug-Url: https://bugzilla.redhat.com/1016634 Signed-off-by: lzelkha(a)redhat.com <liran.zelkha(a)gmail.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsManager.java 1 file changed, 6 insertions(+), 1 deletion(-) Approvals: Eli Mesika: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/20643 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0254991f424490d848f84fc951e64787bf54d7bc Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liran Zelkha <lzelkha(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Liran Zelkha <lzelkha(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

11 years, 2 months

1
0
0 / 0

Change in ovirt-engine[master]: engine: Add caching to VdsStatic, VdsDynamic, VdsGroup and V...

by emesika＠redhat.com

Eli Mesika has submitted this change and it was merged. Change subject: engine: Add caching to VdsStatic, VdsDynamic, VdsGroup and VdsSpmIdMap ...................................................................... engine: Add caching to VdsStatic, VdsDynamic, VdsGroup and VdsSpmIdMap Since some DAO objects rarely change, it is safe to add an option to read DAOs from cache. This patch will provide the caching interface and some example implementations. Change-Id: Ib72b867c778b5609d5e333c63f5798bdd1a0f55f Signed-off-by: lzelkha(a)redhat.com <lzelkha(a)redhat.com> Bug-Url: https://bugzilla.redhat.com/870330 --- A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/CachedEntity.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VDSGroup.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VdsDynamic.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VdsStatic.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/vds_spm_id_map.java A backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/EntityCache.java A backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/CachedDao.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VdsDAODbFacadeImpl.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VdsDynamicDAO.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VdsDynamicDAODbFacadeImpl.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VdsGroupDAO.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VdsGroupDAODbFacadeImpl.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VdsSpmIdMapDAO.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VdsSpmIdMapDAODbFacadeImpl.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VdsStaticDAO.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VdsStaticDAODbFacadeImpl.java M frontend/webadmin/modules/gwt-common/src/main/resources/org/ovirt/engine/core/Common.gwt.xml 17 files changed, 215 insertions(+), 33 deletions(-) Approvals: Eli Mesika: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/20894 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib72b867c778b5609d5e333c63f5798bdd1a0f55f Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liran Zelkha <lzelkha(a)redhat.com> Gerrit-Reviewer: Barak Azulay <bazulay(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Liran Zelkha <lzelkha(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

11 years, 2 months

1
0
0 / 0

Change in ovirt-engine[master]: engine: Make VDSPartial, a partially loaded VDS object

by emesika＠redhat.com

Eli Mesika has submitted this change and it was merged. Change subject: engine: Make VDSPartial, a partially loaded VDS object ...................................................................... engine: Make VDSPartial, a partially loaded VDS object Since loading a full VDS object is time consuming, this patch introduces a VDSPartial object, that is much faster to load. VDSPartial loading takes 5ms as opposed to 8ms for VDS Change-Id: Ie2401686d43daa6bcfb810b13aea6cc2570e5520 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=992883 Signed-off-by: lzelkha(a)redhat.com <liran.zelkha(a)gmail.com> --- A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VDSPartial.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VdsDAO.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VdsDAODbFacadeImpl.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsManager.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsUpdateRunTimeInfo.java 5 files changed, 748 insertions(+), 3 deletions(-) Approvals: Eli Mesika: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/20587 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie2401686d43daa6bcfb810b13aea6cc2570e5520 Gerrit-PatchSet: 13 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liran Zelkha <lzelkha(a)redhat.com> Gerrit-Reviewer: Barak Azulay <bazulay(a)redhat.com> Gerrit-Reviewer: Eli Mesika <elimesika(a)gmail.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Liran Zelkha <lzelkha(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

11 years, 2 months

1
0
0 / 0

Change in ovirt-engine[master]: packaging: setup: Hide irrelevant fields in configuration pr...

by sbonazzo＠redhat.com

Sandro Bonazzola has submitted this change and it was merged. Change subject: packaging: setup: Hide irrelevant fields in configuration preview during setup ...................................................................... packaging: setup: Hide irrelevant fields in configuration preview during setup Few fields like NFS setup and Datacentre storage type are not relevant when application mode is gluster. So they will not be displayed under configuration preview during engine-setup if application mode is gluster. Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1020190 Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> Signed-off-by: ndarshan <dnarayan(a)redhat.com> Change-Id: I9e4b3fffd37a62d9fc551dff178d5662d610ddd4 --- M packaging/setup/ovirt_engine_setup/constants.py M packaging/setup/plugins/ovirt-engine-setup/config/domain_type.py M packaging/setup/plugins/ovirt-engine-setup/dialog/preview.py 3 files changed, 31 insertions(+), 29 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/20955 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9e4b3fffd37a62d9fc551dff178d5662d610ddd4 Gerrit-PatchSet: 11 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Darshan N <dnarayan(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Aravinda VK <avishwan(a)redhat.com> Gerrit-Reviewer: Darshan N <dnarayan(a)redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayilsa(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

11 years, 2 months

1
0
0 / 0

Change in ovirt-engine[ovirt-engine-3.3]: core: export memory snapshot volumes for diskless vms

by iheim＠redhat.com

Itamar Heim has submitted this change and it was merged. Change subject: core: export memory snapshot volumes for diskless vms ...................................................................... core: export memory snapshot volumes for diskless vms When exporting a diskless vm, the command is ended right away if the vm doesn't have any disks for export, as no tasks would be created. The VM might have no disks, but have snapshots that contain memory snapshots, those memory volumes need to be exported as well otherwise the export data would be partial only. Change-Id: Ie8afa364925dc8a8cdfc1f64939a6f28945fe043 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1029045 Signed-off-by: Liron Aravot <laravot(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ExportVmCommand.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Itamar Heim: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/21108 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie8afa364925dc8a8cdfc1f64939a6f28945fe043 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.3 Gerrit-Owner: Liron Ar <laravot(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Liron Ar <laravot(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

11 years, 2 months

1
0
0 / 0

Change in ovirt-engine[master]: utils: pki-resource: cleanup: levarage enum for constants

by emesika＠redhat.com

Eli Mesika has submitted this change and it was merged. Change subject: utils: pki-resource: cleanup: levarage enum for constants ...................................................................... utils: pki-resource: cleanup: levarage enum for constants use java magic in the attempt of simplify the interface. unsure that the result is simpler than the original. Change-Id: I24da0ff174599ffdeabbf5846eab429bf0d6510d Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetCACertificateQuery.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VdsDeploy.java M backend/manager/modules/services/src/main/java/org/ovirt/engine/core/services/PKIResourceServlet.java M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/PKIResources.java 4 files changed, 110 insertions(+), 148 deletions(-) Approvals: Eli Mesika: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/21073 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I24da0ff174599ffdeabbf5846eab429bf0d6510d Gerrit-PatchSet: 11 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

11 years, 2 months

1
0
0 / 0

Change in ovirt-engine[master]: services: pki-resource: send proper http code when exception

by emesika＠redhat.com

Eli Mesika has submitted this change and it was merged. Change subject: services: pki-resource: send proper http code when exception ...................................................................... services: pki-resource: send proper http code when exception open writer only after validations. Change-Id: Idf4c5157bf7425da5f9bb0d5186c48b4b9cc313c Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M backend/manager/modules/services/src/main/java/org/ovirt/engine/core/services/PKIResourceServlet.java 1 file changed, 5 insertions(+), 3 deletions(-) Approvals: Eli Mesika: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/21133 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Idf4c5157bf7425da5f9bb0d5186c48b4b9cc313c Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

11 years, 2 months

1
0
0 / 0

Change in ovirt-engine[master]: core: rename method to lowercase in VmOperationCommandBase

by tnisan＠redhat.com

Tal Nisan has submitted this change and it was merged. Change subject: core: rename method to lowercase in VmOperationCommandBase ...................................................................... core: rename method to lowercase in VmOperationCommandBase Change-Id: I87b7f3377bf8f754a7c227f63d4088b5a53b56e1 Signed-off-by: Alissa Bonas <abonas(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmOperationCommandBase.java 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Tal Nisan: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/21011 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I87b7f3377bf8f754a7c227f63d4088b5a53b56e1 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Leonardo Bianconi <leonardo.bianconi(a)eldorado.org.br> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

11 years, 2 months

1
0
0 / 0

Change in ovirt-engine[master]: webadmin: send ssh keys in cloud init

by ofrenkel＠redhat.com

Omer Frenkel has submitted this change and it was merged. Change subject: webadmin: send ssh keys in cloud init ...................................................................... webadmin: send ssh keys in cloud init set to ssh keys field the correct value, probably a copy-paste error. Change-Id: Ia98613d7d235900c8b0712c7f8d3e8ce4e690f77 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1004829 Signed-off-by: Omer Frenkel <ofrenkel(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/CloudInitModel.java 1 file changed, 3 insertions(+), 3 deletions(-) Approvals: Omer Frenkel: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/21048 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia98613d7d235900c8b0712c7f8d3e8ce4e690f77 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

11 years, 2 months

1
0
0 / 0

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

Engine-commits November 2013