Change in ovirt-engine[ovirt-engine-3.3]: packaging: setup: properly support relative answer file
by iheim@redhat.com
Itamar Heim has submitted this change and it was merged.
Change subject: packaging: setup: properly support relative answer file
......................................................................
packaging: setup: properly support relative answer file
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1025313
Change-Id: I72d8e8c46528e492aa3339ff83227104bfb3ba9b
Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com>
---
M packaging/setup/plugins/ovirt-engine-common/core/answerfile.py
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Itamar Heim: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/21119
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I72d8e8c46528e492aa3339ff83227104bfb3ba9b
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.3
Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
11 years, 2 months
Change in ovirt-engine[ovirt-engine-3.3]: packaging: osinfo: add README and overwrite warning for defa...
by iheim@redhat.com
Itamar Heim has submitted this change and it was merged.
Change subject: packaging: osinfo: add README and overwrite warning for defaults
......................................................................
packaging: osinfo: add README and overwrite warning for defaults
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1025794
Change-Id: I6ac7a780de042d57775762f72a1cc378b0dd51b1
Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com>
---
M Makefile
M ovirt-engine.spec.in
M packaging/conf/osinfo-defaults.properties
A packaging/etc/osinfo.conf.d/README
4 files changed, 18 insertions(+), 5 deletions(-)
Approvals:
Alon Bar-Lev: Verified
Sandro Bonazzola: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/21121
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I6ac7a780de042d57775762f72a1cc378b0dd51b1
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.3
Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com>
Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
11 years, 2 months
Change in ovirt-engine[master]: webadmin: fix volume bricks tab refresh issue
by kmayilsa@redhat.com
Kanagaraj M has submitted this change and it was merged.
Change subject: webadmin: fix volume bricks tab refresh issue
......................................................................
webadmin: fix volume bricks tab refresh issue
Bricks sub-tab was not showing the data immediately
when the user is navigating in the volume sub-tabs.
This is now fixed.
Refactored remove-brick actions availablity and
avoided setting the entity directly from VolumeListModel.
Change-Id: If91de652fe7e88df063a871948c0abbda7647698
Bug-Url: https://bugzilla.redhat.com/1012871
Signed-off-by: Kanagaraj M <kmayilsa(a)redhat.com>
---
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/gluster/VolumeBrickListModel.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/volumes/VolumeListModel.java
2 files changed, 20 insertions(+), 19 deletions(-)
Approvals:
Kanagaraj M: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/21070
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: If91de652fe7e88df063a871948c0abbda7647698
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Kanagaraj M <kmayilsa(a)redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com>
Gerrit-Reviewer: Kanagaraj M <kmayilsa(a)redhat.com>
Gerrit-Reviewer: Ramesh N <rnachimu(a)redhat.com>
Gerrit-Reviewer: anmolbabu <anbabu(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
11 years, 2 months
Change in ovirt-engine[master]: core: Unifies testing devices are CDs
by emesika@redhat.com
Eli Mesika has submitted this change and it was merged.
Change subject: core: Unifies testing devices are CDs
......................................................................
core: Unifies testing devices are CDs
Utilizes VmDeviceCommonUtils.isCD() on all places where testing if
device is a CD.
Change-Id: I6c1b848969ce1fc38de18aa2e5533fd38486c181
Signed-off-by: Martin Perina <mperina(a)redhat.com>
---
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/utils/VmDeviceCommonUtils.java
1 file changed, 1 insertion(+), 3 deletions(-)
Approvals:
Eli Mesika: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/18160
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I6c1b848969ce1fc38de18aa2e5533fd38486c181
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
11 years, 2 months
Change in ovirt-engine[master]: core: Unifies testing devices are bridges
by emesika@redhat.com
Eli Mesika has submitted this change and it was merged.
Change subject: core: Unifies testing devices are bridges
......................................................................
core: Unifies testing devices are bridges
Utilizes VmDeviceCommonUtils.isBridge() on all places where testing if
device is a bridge.
Change-Id: I9ae36ff5055bf86ae25c14080920f4e72893d417
Signed-off-by: Martin Perina <mperina(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/utils/VmDeviceUtils.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/utils/VmDeviceCommonUtils.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsUpdateRunTimeInfo.java
3 files changed, 8 insertions(+), 9 deletions(-)
Approvals:
Eli Mesika: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/18159
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I9ae36ff5055bf86ae25c14080920f4e72893d417
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
11 years, 2 months
Change in ovirt-engine[master]: core: Unifies testing devices are disks
by emesika@redhat.com
Eli Mesika has submitted this change and it was merged.
Change subject: core: Unifies testing devices are disks
......................................................................
core: Unifies testing devices are disks
Utilizes VmDeviceCommonUtils.isDisk() on all places where testing if
device is a disk.
Change-Id: Id2678f10e4ef8911e3d59bb9bae69a6eba822895
Signed-off-by: Martin Perina <mperina(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/utils/VmDeviceUtils.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/utils/VmDeviceCommonUtils.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsUpdateRunTimeInfo.java
3 files changed, 3 insertions(+), 6 deletions(-)
Approvals:
Eli Mesika: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/18158
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Id2678f10e4ef8911e3d59bb9bae69a6eba822895
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
11 years, 2 months
Change in ovirt-engine[master]: core: Adds missing 3rd party dependencies as modules
by emesika@redhat.com
Eli Mesika has submitted this change and it was merged.
Change subject: core: Adds missing 3rd party dependencies as modules
......................................................................
core: Adds missing 3rd party dependencies as modules
Adds these missing 3rd dependencies as JBoss modules:
aopalliance:aopalliance:jar:1.0
c3p0:c3p0:jar:0.9.1.1
org.tukaani:xz:jar:1.0
Change-Id: I35cc0d983010b4e0ab7ca4cea15a80a051fe9254
Bug-Url: https://bugzilla.redhat.com/1016716
Signed-off-by: Martin Perina <mperina(a)redhat.com>
---
M backend/manager/dependencies/pom.xml
A backend/manager/dependencies/src/main/modules/com/mchange/c3p0/main/module.xml
A backend/manager/dependencies/src/main/modules/org/aopalliance/main/module.xml
M backend/manager/dependencies/src/main/modules/org/apache/commons/compress/main/module.xml
M backend/manager/dependencies/src/main/modules/org/quartz/main/module.xml
M backend/manager/dependencies/src/main/modules/org/springframework/main/module.xml
A backend/manager/dependencies/src/main/modules/org/tukaani/xz/main/module.xml
M ovirt-engine.spec.in
M pom.xml
9 files changed, 79 insertions(+), 0 deletions(-)
Approvals:
Eli Mesika: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/20048
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I35cc0d983010b4e0ab7ca4cea15a80a051fe9254
Gerrit-PatchSet: 7
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <elimesika(a)gmail.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com>
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
11 years, 2 months
Change in ovirt-hosted-engine-setup[ovirt-hosted-engine-setup-1.0]: packaging: setup: configure bridge after vdsmd start
by sbonazzo@redhat.com
Sandro Bonazzola has submitted this change and it was merged.
Change subject: packaging: setup: configure bridge after vdsmd start
......................................................................
packaging: setup: configure bridge after vdsmd start
Bug-Url: https://bugzilla.redhat.com/1028752
Change-Id: Ic890cf116085cb97b3c45bdf198582ecd3929f40
Signed-off-by: Yedidyah Bar David <didi(a)redhat.com>
---
M src/plugins/ovirt-hosted-engine-setup/network/bridge.py
1 file changed, 3 insertions(+), 0 deletions(-)
Approvals:
Sandro Bonazzola: Looks good to me, approved
Yedidyah Bar David: Verified
--
To view, visit http://gerrit.ovirt.org/21117
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ic890cf116085cb97b3c45bdf198582ecd3929f40
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-hosted-engine-setup
Gerrit-Branch: ovirt-hosted-engine-setup-1.0
Gerrit-Owner: Yedidyah Bar David <didi(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
11 years, 2 months
Change in ovirt-hosted-engine-setup[master]: packaging: setup: configure bridge after vdsmd start
by sbonazzo@redhat.com
Sandro Bonazzola has submitted this change and it was merged.
Change subject: packaging: setup: configure bridge after vdsmd start
......................................................................
packaging: setup: configure bridge after vdsmd start
Bug-Url: https://bugzilla.redhat.com/1028752
Change-Id: Ic890cf116085cb97b3c45bdf198582ecd3929f40
Signed-off-by: Yedidyah Bar David <didi(a)redhat.com>
---
M src/plugins/ovirt-hosted-engine-setup/network/bridge.py
1 file changed, 3 insertions(+), 0 deletions(-)
Approvals:
Sandro Bonazzola: Looks good to me, approved
Yedidyah Bar David: Verified
--
To view, visit http://gerrit.ovirt.org/21116
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ic890cf116085cb97b3c45bdf198582ecd3929f40
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-hosted-engine-setup
Gerrit-Branch: master
Gerrit-Owner: Yedidyah Bar David <didi(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
11 years, 2 months
Change in ovirt-engine[master]: userportal: error flow of RDP RdpPluginImpl broken
by tjelinek@redhat.com
Tomas Jelinek has submitted this change and it was merged.
Change subject: userportal: error flow of RDP RdpPluginImpl broken
......................................................................
userportal: error flow of RDP RdpPluginImpl broken
There were the following issues which caused the error not to be propagated:
- a regression caused by 625b7452d840793df5e72764193c98c5ba121cdf
which did bring back the crashing of IE if the RDP connection is not
successful (originally fixed by fa10641c3484ea10d0b1b33ef8e3d656b5e6dd35).
- by the same commit (625b7452d840793df5e72764193c98c5ba121cdf) the new method
setParentModel has been introduced but it was not called. It caused a NPE on
RdpPluginImpl.rdpDisconnected:66. Fixed by calling this method on the
relevant places.
- after autologin the Frontend.getInstance().getLoginPassword() returns null
which causes NPE on RdpPluginImpl:113 when setting this pass to
ClearTextPassword. Fixed at AbstractRdp level because the null password for
DbUser class can still be relevant - just needs to be handled differently on
AbstractRdp level.
Change-Id: I85fc3b32c4f544f23864db2aefa5ebcd4d896b75
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1014710
Signed-off-by: Tomas Jelinek <tjelinek(a)redhat.com>
---
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/uicommon/AbstractRdp.java
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/uicommon/RdpPluginImpl.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/RdpConsoleModel.java
3 files changed, 6 insertions(+), 3 deletions(-)
Approvals:
Tomas Jelinek: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/20952
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I85fc3b32c4f544f23864db2aefa5ebcd4d896b75
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Tomas Jelinek <tjelinek(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Frank Kobzik <fkobzik(a)redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
11 years, 2 months