November 2013 - Engine-commits - Ovirt List Archives

Change in ovirt-engine[master]: engine: [cleanup] Rename RunAction to runAction

by tnisan＠redhat.com

Tal Nisan has submitted this change and it was merged. Change subject: engine: [cleanup] Rename RunAction to runAction ...................................................................... engine: [cleanup] Rename RunAction to runAction Findbugs warning message: Backend.java:347, NM_METHOD_NAMING_CONVENTION, Priority: Low The method name org.ovirt.engine.core.bll.Backend.RunAction (VdcActionType, VdcActionParametersBase) doesn't start with a lower case letter Methods should be verbs, in mixed case with the first letter lowercase, with the first letter of each internal word capitalized. Change-Id: I63cc50dcfdd85f97ee55e5bca37982c78fd5e949 Signed-off-by: Adam Litke <alitke(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/Backend.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/interfaces/BackendLocal.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendResource.java M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/AbstractBackendBaseTest.java M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/AbstractBackendCollectionResourceTest.java M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/server/gwt/GenericApiGWTServiceImpl.java 6 files changed, 9 insertions(+), 9 deletions(-) Approvals: Tal Nisan: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/21545 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I63cc50dcfdd85f97ee55e5bca37982c78fd5e949 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Adam Litke <alitke(a)redhat.com> Gerrit-Reviewer: Adam Litke <alitke(a)redhat.com> Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

11 years, 1 month

1
0
0 / 0

Change in ovirt-engine[master]: engine: [cleanup] Rename Initialize to initialize

by tnisan＠redhat.com

Tal Nisan has submitted this change and it was merged. Change subject: engine: [cleanup] Rename Initialize to initialize ...................................................................... engine: [cleanup] Rename Initialize to initialize Findbugs warning message: Backend.java:171, NM_METHOD_NAMING_CONVENTION, Priority: Low The method name org.ovirt.engine.core.bll.Backend.Initialize() doesn't start with a lower case letter Methods should be verbs, in mixed case with the first letter lowercase, with the first letter of each internal word capitalized. Change-Id: I2b48a9368fedd5da6eea764b773785e6df16db23 Signed-off-by: Adam Litke <alitke(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/Backend.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/interfaces/BackendLocal.java 2 files changed, 3 insertions(+), 3 deletions(-) Approvals: Tal Nisan: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/21544 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2b48a9368fedd5da6eea764b773785e6df16db23 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Adam Litke <alitke(a)redhat.com> Gerrit-Reviewer: Adam Litke <alitke(a)redhat.com> Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

11 years, 1 month

1
0
0 / 0

Change in ovirt-engine[master]: gluster: setting the step status to unknown.

by kmayilsa＠redhat.com

Kanagaraj M has submitted this change and it was merged. Change subject: gluster: setting the step status to unknown. ...................................................................... gluster: setting the step status to unknown. when volume is up but gluster does not know of task, step status is set to UNKNOWN. It is explicitly set as the task status is already FINISHED and it is not set by method markStepEnded. https://bugzilla.redhat.com/show_bug.cgi?id=1027743 Change-Id: I9418cec0142e4c170a386d6568f6f624bb098985 Signed-off-by: ndarshan <dnarayan(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GlusterTasksSyncJob.java 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Kanagaraj M: Looks good to me, approved Darshan N: Verified -- To view, visit http://gerrit.ovirt.org/21446 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9418cec0142e4c170a386d6568f6f624bb098985 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Darshan N <dnarayan(a)redhat.com> Gerrit-Reviewer: Darshan N <dnarayan(a)redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayilsa(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com> Gerrit-Reviewer: Shubhendu Tripathi <shtripat(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

11 years, 1 month

1
0
0 / 0

Change in ovirt-engine[master]: engine: Remove gluster hooks from db when no servers in cluster

by kmayilsa＠redhat.com

Kanagaraj M has submitted this change and it was merged. Change subject: engine: Remove gluster hooks from db when no servers in cluster ...................................................................... engine: Remove gluster hooks from db when no servers in cluster If the host being removed is the last server in the cluster clean up the entries for gluster hooks as well. Change-Id: Ib4f99798cb4d0ebe70045c20286939f54d6b1fcc Bug-Url: https://bugzilla.redhat.com/986171 Signed-off-by: Sahina Bose <sabose(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveVdsCommand.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/gluster/GlusterHooksDao.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/gluster/GlusterHooksDaoDbFacadeImpl.java M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/gluster/GlusterHooksDaoTest.java M packaging/dbscripts/gluster_hooks_sp.sql 5 files changed, 39 insertions(+), 3 deletions(-) Approvals: Kanagaraj M: Looks good to me, approved Sahina Bose: Verified -- To view, visit http://gerrit.ovirt.org/21529 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib4f99798cb4d0ebe70045c20286939f54d6b1fcc Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Sahina Bose <sabose(a)redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayilsa(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Ramesh N <rnachimu(a)redhat.com> Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com> Gerrit-Reviewer: Shubhendu Tripathi <shtripat(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

11 years, 1 month

1
0
0 / 0

Change in ovirt-engine[master]: engine: Fixed issue with gluster task cleanup

by kmayilsa＠redhat.com

Kanagaraj M has submitted this change and it was merged. Change subject: engine: Fixed issue with gluster task cleanup ...................................................................... engine: Fixed issue with gluster task cleanup In case there are empty clusters or other clusters with non-operational hosts, the orphan tasks in db were not getting cleared for operational clusters either. Changed the logic to handle the task cleanup cluster-wise. Change-Id: I70cc24e278d112d889dc2d08ee72fce22a457195 Bug-Url: https://bugzilla.redhat.com/1022996 Signed-off-by: Sahina Bose <sabose(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GlusterTasksSyncJob.java 1 file changed, 31 insertions(+), 12 deletions(-) Approvals: Kanagaraj M: Looks good to me, approved Sahina Bose: Verified -- To view, visit http://gerrit.ovirt.org/21497 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I70cc24e278d112d889dc2d08ee72fce22a457195 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Sahina Bose <sabose(a)redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayilsa(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Ramesh N <rnachimu(a)redhat.com> Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com> Gerrit-Reviewer: Shubhendu Tripathi <shtripat(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

11 years, 1 month

1
0
0 / 0

Change in ovirt-engine[master]: core: Cleanup OpenStackImageProviderProxy

by emesika＠redhat.com

Eli Mesika has submitted this change and it was merged. Change subject: core: Cleanup OpenStackImageProviderProxy ...................................................................... core: Cleanup OpenStackImageProviderProxy Remove unused methods. Change-Id: I675fb052b310746dceee0314d7ec2201386ed664 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/provider/OpenStackImageProviderProxy.java 1 file changed, 0 insertions(+), 11 deletions(-) Approvals: Eli Mesika: Verified; Looks good to me, approved Allon Mureinik: Verified -- To view, visit http://gerrit.ovirt.org/21751 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I675fb052b310746dceee0314d7ec2201386ed664 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

11 years, 1 month

1
0
0 / 0

Change in ovirt-engine[master]: core: rm unused SessionDataContainer.containsKey

by emesika＠redhat.com

Eli Mesika has submitted this change and it was merged. Change subject: core: rm unused SessionDataContainer.containsKey ...................................................................... core: rm unused SessionDataContainer.containsKey Change-Id: I9ab7dee562e32657983c11b41189aee884f2880e Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/session/SessionDataContainer.java 1 file changed, 0 insertions(+), 8 deletions(-) Approvals: Eli Mesika: Verified; Looks good to me, approved Allon Mureinik: Verified -- To view, visit http://gerrit.ovirt.org/21753 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9ab7dee562e32657983c11b41189aee884f2880e Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

11 years, 1 month

1
0
0 / 0

Change in ovirt-engine[master]: core: rm CommandContext.serialVersionUUID

by emesika＠redhat.com

Eli Mesika has submitted this change and it was merged. Change subject: core: rm CommandContext.serialVersionUUID ...................................................................... core: rm CommandContext.serialVersionUUID Commit 3600344aa41e559ef6fa145c910e82421b194c13 changed CommandContext to stop being Serializable, but neglected to remove the serialVersionUUID. This patches rectifies that omission. Change-Id: I1204da10d91c7a0435d65450b58f39f9dbf0c48f Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/context/CommandContext.java 1 file changed, 0 insertions(+), 6 deletions(-) Approvals: Eli Mesika: Verified; Looks good to me, approved Allon Mureinik: Verified -- To view, visit http://gerrit.ovirt.org/21746 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1204da10d91c7a0435d65450b58f39f9dbf0c48f Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

11 years, 1 month

1
0
0 / 0

Change in ovirt-engine[master]: core: rm JobRepository unused methods

by amureini＠redhat.com

Allon Mureinik has submitted this change and it was merged. Change subject: core: rm JobRepository unused methods ...................................................................... core: rm JobRepository unused methods Remove various unused update methods from JobRepository and its implementation. Change-Id: I0cfb2c69cb81546521ec60b8c02e980dca988efb Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/job/JobRepository.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/job/JobRepositoryImpl.java 2 files changed, 0 insertions(+), 43 deletions(-) Approvals: Allon Mureinik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/21747 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0cfb2c69cb81546521ec60b8c02e980dca988efb Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

11 years, 1 month

1
0
0 / 0

Change in ovirt-engine[master]: core: rm VmInterfaceManagerTest.createNewNetwork

by amureini＠redhat.com

Allon Mureinik has submitted this change and it was merged. Change subject: core: rm VmInterfaceManagerTest.createNewNetwork ...................................................................... core: rm VmInterfaceManagerTest.createNewNetwork Removed unused method. Change-Id: I74d12f9d5968450a1167016c8eb98b76ee7e70e3 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/network/VmInterfaceManagerTest.java 1 file changed, 0 insertions(+), 8 deletions(-) Approvals: Allon Mureinik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/21748 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I74d12f9d5968450a1167016c8eb98b76ee7e70e3 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

11 years, 1 month

1
0
0 / 0

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

Engine-commits November 2013