December 2013 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: webadmin : Fixed allignment issues in Hosts General sub-tab
by vszocs＠redhat.com 10 Dec '13

10 Dec '13

Vojtech Szocs has submitted this change and it was merged. Change subject: webadmin : Fixed allignment issues in Hosts General sub-tab ...................................................................... webadmin : Fixed allignment issues in Hosts General sub-tab The rows in Hosts General sub-tab were not alligned properly as each of them were of a different type of label. ex : 1. TextBoxLabel were generating a input-class for the values. 2. Other labels(inheriting ValueLabel) were generating a span tag. So,this patch makes it uniform by replacing all ValueLabel by TextBoxLabelBase and its derivatives and hence fixes all the row allignment issues in Host->General. Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1031596 Change-Id: Iba34398f6972f90d81d76196e060c9184665dd22 Signed-off-by: Anmol Babu <anbabu(a)redhat.com> --- A frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/label/BooleanTextBoxLabel.java A frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/label/EnumTextBoxLabel.java A frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/label/MemorySizeTextBoxLabel.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/host/SubTabHostGeneralView.java D frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/label/DetailsLabel.java A frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/label/DetailsTextBoxLabel.java A frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/label/NullableNumberTextBoxLabel.java A frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/label/PercentTextBoxLabel.java A frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/label/VersionTextBoxLabel.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/renderer/DetailsRenderer.java 10 files changed, 142 insertions(+), 58 deletions(-) Approvals: Vojtech Szocs: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/20964 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iba34398f6972f90d81d76196e060c9184665dd22 Gerrit-PatchSet: 21 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: anmolbabu <anbabu(a)redhat.com> Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayilsa(a)redhat.com> Gerrit-Reviewer: Leonardo Bianconi <leonardo.bianconi(a)eldorado.org.br> Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: anmolbabu <anbabu(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.3]: packaging: setup: increase memory threshold check to 10%
by iheim＠redhat.com 10 Dec '13

10 Dec '13

Itamar Heim has submitted this change and it was merged. Change subject: packaging: setup: increase memory threshold check to 10% ...................................................................... packaging: setup: increase memory threshold check to 10% Change-Id: I5fa5ca2fd74940df47e4f137efb8346abcdc4814 Bug-Url: https://bugzilla.redhat.com/1034797 Signed-off-by: Alex Lourie <alourie(a)redhat.com> --- M packaging/setup/ovirt_engine_setup/constants.py M packaging/setup/plugins/ovirt-engine-setup/system/memcheck.py 2 files changed, 12 insertions(+), 2 deletions(-) Approvals: Sandro Bonazzola: Looks good to me, approved Alex Lourie: Verified -- To view, visit http://gerrit.ovirt.org/22231 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5fa5ca2fd74940df47e4f137efb8346abcdc4814 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.3 Gerrit-Owner: Alex Lourie <alourie(a)redhat.com> Gerrit-Reviewer: Alex Lourie <alourie(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: engine: Fix slow API query for list of templates in a Datace...
by emesika＠redhat.com 10 Dec '13

10 Dec '13

Eli Mesika has submitted this change and it was merged. Change subject: engine: Fix slow API query for list of templates in a Datacenter ...................................................................... engine: Fix slow API query for list of templates in a Datacenter This patch improves the performance of SearcQuery for templates by Datacenter. It improves performance by about a factor of 5. Change-Id: I13460ae1aa3d7cb2816ed53b5ca7da64f15b8845 Bug-Url: https://bugzilla.redhat.com/1029106 Signed-off-by: lzelkha(a)redhat.com <lzelkha(a)redhat.com> --- M backend/manager/modules/searchbackend/src/main/java/org/ovirt/engine/core/searchbackend/SyntaxChecker.java 1 file changed, 7 insertions(+), 0 deletions(-) Approvals: Eli Mesika: Verified; Looks good to me, approved Liran Zelkha: Verified -- To view, visit http://gerrit.ovirt.org/21714 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I13460ae1aa3d7cb2816ed53b5ca7da64f15b8845 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liran Zelkha <lzelkha(a)redhat.com> Gerrit-Reviewer: Barak Azulay <bazulay(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Liran Zelkha <lzelkha(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: webadmin: show warning in manage events pop up
by kmayilsa＠redhat.com 10 Dec '13

10 Dec '13

Kanagaraj M has submitted this change and it was merged. Change subject: webadmin: show warning in manage events pop up ...................................................................... webadmin: show warning in manage events pop up Showing a warning note in manage events pop up saying event-notifier should be configured and notifier service should be running to get email notification. Change-Id: I0fd7a7f4dbd1442ff748f64807f10f2bc50b9216 Bug-Url: https://bugzilla.redhat.com/1036500 Signed-off-by: Ramesh Nachimuthu <rnachimu(a)redhat.com> --- M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/ApplicationConstants.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/user/ManageEventsPopupView.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/user/ManageEventsPopupView.ui.xml 3 files changed, 18 insertions(+), 1 deletion(-) Approvals: Kanagaraj M: Looks good to me, approved Ramesh N: Verified -- To view, visit http://gerrit.ovirt.org/22080 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0fd7a7f4dbd1442ff748f64807f10f2bc50b9216 Gerrit-PatchSet: 8 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ramesh N <rnachimu(a)redhat.com> Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com> Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayilsa(a)redhat.com> Gerrit-Reviewer: Ramesh N <rnachimu(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-guest-agent[master]: pam: Fix the pam conversation approach
by vfeenstr＠redhat.com 10 Dec '13

10 Dec '13

Vinzenz Feenstra has submitted this change and it was merged. Change subject: pam: Fix the pam conversation approach ...................................................................... pam: Fix the pam conversation approach Until now our PAM conversation was errorneous using pam_get_user which is not correct for requests other than accquiring the username. To correctly request the Token from the frontend we have to use a PAM conversation. This is done via the pam_prompt function. We also do check now, if the requesting user (if set) is identical with the preset user. If this is not the case we will not unlock the screen. Preset users should only be available if the screen was locked. If the usernames aren't equal, the module will return PAM_CRED_UNAVAIL. Additionally the logging was rewritten to use the syslog and more comments have been added to describe the steps we're doing. Change-Id: I4455ea61ffb27e854fe93bdc51068e12617955a2 Signed-off-by: Vinzenz Feenstra <vfeenstr(a)redhat.com> --- M pam-ovirt-cred/pam_ovirt_cred.c 1 file changed, 59 insertions(+), 26 deletions(-) Approvals: Vinzenz Feenstra: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/20073 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4455ea61ffb27e854fe93bdc51068e12617955a2 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-guest-agent Gerrit-Branch: master Gerrit-Owner: Vinzenz Feenstra <vfeenstr(a)redhat.com> Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com> Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: restapi: correct status code for add brick when volume is down.
by kmayilsa＠redhat.com 10 Dec '13

10 Dec '13

Kanagaraj M has submitted this change and it was merged. Change subject: restapi: correct status code for add brick when volume is down. ...................................................................... restapi: correct status code for add brick when volume is down. In Method resolveCreatedList for populating entity, populate method is used instead of doPopulate. As doPopulate doesnot return proper status code when the volume is down. Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1018904 Change-Id: Ic6c680383ea75d898a6496c86daabe38630f9d18 Signed-off-by: ndarshan <dnarayan(a)redhat.com> --- M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/gluster/BackendGlusterBricksResource.java M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/gluster/BackendGlusterBricksResourceTest.java 2 files changed, 1 insertion(+), 2 deletions(-) Approvals: Kanagaraj M: Looks good to me, approved Darshan N: Verified -- To view, visit http://gerrit.ovirt.org/21941 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic6c680383ea75d898a6496c86daabe38630f9d18 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Darshan N <dnarayan(a)redhat.com> Gerrit-Reviewer: Darshan N <dnarayan(a)redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayilsa(a)redhat.com> Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com> Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com> Gerrit-Reviewer: Shubhendu Tripathi <shtripat(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: webadmin: hide migration for removing replicated bricks
by kmayilsa＠redhat.com 10 Dec '13

10 Dec '13

Kanagaraj M has submitted this change and it was merged. Change subject: webadmin: hide migration for removing replicated bricks ...................................................................... webadmin: hide migration for removing replicated bricks 'Migrate Data' option in 'Remove Bricks' dilog will not be shown if the bricks are not from same sub-volume (Reducing replica count). Change-Id: Ia7fd98c0b262deff26bf9e77839ee347d5869189 Signed-off-by: Kanagaraj M <kmayilsa(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/gluster/VolumeBrickListModel.java 1 file changed, 2 insertions(+), 0 deletions(-) Approvals: Kanagaraj M: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/22185 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia7fd98c0b262deff26bf9e77839ee347d5869189 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Kanagaraj M <kmayilsa(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayilsa(a)redhat.com> Gerrit-Reviewer: Ramesh N <rnachimu(a)redhat.com> Gerrit-Reviewer: anmolbabu <anbabu(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: gluster: fill task parameters in async task status query
by kmayilsa＠redhat.com 10 Dec '13

10 Dec '13

Kanagaraj M has submitted this change and it was merged. Change subject: gluster: fill task parameters in async task status query ...................................................................... gluster: fill task parameters in async task status query Updating the async task with task parameters in async task status query so that task summary gets updated with proper volume name Change-Id: I3cf2f7cc9f633d99a673879a0876919ead5fb843 Bug-Url: https://bugzilla.redhat.com/1037607 Signed-off-by: Ramesh Nachimuthu <rnachimu(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GlusterAsyncTaskStatusQueryBase.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/tasks/GlusterTaskUtils.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/gluster/GlusterTasksSyncJobTest.java 3 files changed, 8 insertions(+), 3 deletions(-) Approvals: Kanagaraj M: Looks good to me, approved Ramesh N: Verified -- To view, visit http://gerrit.ovirt.org/22083 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3cf2f7cc9f633d99a673879a0876919ead5fb843 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ramesh N <rnachimu(a)redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayilsa(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Ramesh N <rnachimu(a)redhat.com> Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com> Gerrit-Reviewer: Shubhendu Tripathi <shtripat(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: gluster: event message for stop remove brick
by kmayilsa＠redhat.com 10 Dec '13

10 Dec '13

Kanagaraj M has submitted this change and it was merged. Change subject: gluster: event message for stop remove brick ...................................................................... gluster: event message for stop remove brick Adding event message for stop remove brick action. Change-Id: I2fdf50f6395e61578edab8319b0740d2c8fb0082 Signed-off-by: Ramesh Nachimuthu <rnachimu(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/VdcEventNotificationUtils.java M backend/manager/modules/dal/src/main/resources/bundles/AuditLogMessages.properties M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/LocalizedEnums.java M frontend/webadmin/modules/uicompat/src/main/resources/org/ovirt/engine/ui/uicompat/LocalizedEnums.properties A packaging/dbscripts/upgrade/03_04_0190_gluster_async_tasks_stop_remove-brick_event_map.sql 5 files changed, 10 insertions(+), 3 deletions(-) Approvals: Kanagaraj M: Looks good to me, approved Ramesh N: Verified -- To view, visit http://gerrit.ovirt.org/21909 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2fdf50f6395e61578edab8319b0740d2c8fb0082 Gerrit-PatchSet: 8 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ramesh N <rnachimu(a)redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayilsa(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Ramesh N <rnachimu(a)redhat.com> Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com> Gerrit-Reviewer: Shubhendu Tripathi <shtripat(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: tools: fix error logging
by yzaslavs＠redhat.com 09 Dec '13

09 Dec '13

Yair Zaslavsky has submitted this change and it was merged. Change subject: tools: fix error logging ...................................................................... tools: fix error logging Bug-Url: https://bugzilla.redhat.com/1037894 This patch fixes error logging for manage-domains tool to log the full stack trace if debug level is turn on. Change-Id: Ibd9a15e5bf1620c8827476da055c88a27d093cf5 Signed-off-by: Yair Zaslavsky <yzaslavs(a)redhat.com> --- M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/kerberos/KerberosConfigCheck.java 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Yair Zaslavsky: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/22062 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ibd9a15e5bf1620c8827476da055c88a27d093cf5 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0