December 2013 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: tools: Fixing edit action of manage-domains
by yzaslavs＠redhat.com 10 Dec '13

10 Dec '13

Yair Zaslavsky has submitted this change and it was merged. Change subject: tools: Fixing edit action of manage-domains ...................................................................... tools: Fixing edit action of manage-domains Bug-Url: https://bugzilla.redhat.com/1037894 The following patches fixes the edit action of manage-domains tool to support edit of values provided by the "ldapServers" argument. Prior to this fix, the change was not stored at the proper location at the vdc_options table. Bare in mind that if -ldapServers is not provided during the edit action no change will be made to the entry. Change-Id: I9f86b8ce2c697931b9c8388ea87fe07d557530c6 Signed-off-by: Yair Zaslavsky <yzaslavs(a)redhat.com> --- M backend/manager/tools/src/main/java/org/ovirt/engine/core/domains/ManageDomains.java 1 file changed, 27 insertions(+), 16 deletions(-) Approvals: Yair Zaslavsky: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/22063 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9f86b8ce2c697931b9c8388ea87fe07d557530c6 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: engine: rename method to lowercase in SyncronizeNumberOfAsyn...
by derez＠redhat.com 10 Dec '13

10 Dec '13

Daniel Erez has submitted this change and it was merged. Change subject: engine: rename method to lowercase in SyncronizeNumberOfAsyncOperations ...................................................................... engine: rename method to lowercase in SyncronizeNumberOfAsyncOperations Change-Id: I9fc019ba6ad4cbf27ed3aa3f3a3939eeeeef9b2a Signed-off-by: Alissa Bonas <abonas(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/RemoveStoragePoolCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/StorageHandlingCommandBase.java M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/SyncronizeNumberOfAsyncOperations.java 3 files changed, 3 insertions(+), 3 deletions(-) Approvals: Daniel Erez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/22169 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9fc019ba6ad4cbf27ed3aa3f3a3939eeeeef9b2a Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: rm unused method in AddDiskToVmCommandTest
by amureini＠redhat.com 10 Dec '13

10 Dec '13

Allon Mureinik has submitted this change and it was merged. Change subject: core: rm unused method in AddDiskToVmCommandTest ...................................................................... core: rm unused method in AddDiskToVmCommandTest Patch 73499ce148500edc73642fb6c548ad597a932f6e changed the mocking scheme of this test. As a result, the method mockStorageDomain(Guid, int, int) remained unused. This patch remove the unneeded method. Change-Id: I5163e6d9615ad3e0c44edcf00d43f3cb04aa3d7c Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/AddDiskToVmCommandTest.java 1 file changed, 0 insertions(+), 4 deletions(-) Approvals: Daniel Erez: Looks good to me, approved Allon Mureinik: Verified -- To view, visit http://gerrit.ovirt.org/22210 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5163e6d9615ad3e0c44edcf00d43f3cb04aa3d7c Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com>

1 0

Change in ovirt-engine[master]: packaging: setup: increase memory threshold check to 10%
by sbonazzo＠redhat.com 10 Dec '13

10 Dec '13

Sandro Bonazzola has submitted this change and it was merged. Change subject: packaging: setup: increase memory threshold check to 10% ...................................................................... packaging: setup: increase memory threshold check to 10% Change-Id: I5fa5ca2fd74940df47e4f137efb8346abcdc4814 Bug-Url: https://bugzilla.redhat.com/1034797 Signed-off-by: Alex Lourie <alourie(a)redhat.com> --- M packaging/setup/ovirt_engine_setup/constants.py M packaging/setup/plugins/ovirt-engine-setup/system/memcheck.py 2 files changed, 12 insertions(+), 2 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/22091 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5fa5ca2fd74940df47e4f137efb8346abcdc4814 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alex Lourie <alourie(a)redhat.com> Gerrit-Reviewer: Alex Lourie <alourie(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-hosted-engine-setup[ovirt-hosted-engine-setup-1.0]: packaging: setup: Support NFSv4 storage domain
by sbonazzo＠redhat.com 10 Dec '13

10 Dec '13

Sandro Bonazzola has submitted this change and it was merged. Change subject: packaging: setup: Support NFSv4 storage domain ...................................................................... packaging: setup: Support NFSv4 storage domain Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1034873 Change-Id: Icca8a5f6296502da3610356620c336ae14e74353 Signed-off-by: Yedidyah Bar David <didi(a)redhat.com> --- M man/ovirt-hosted-engine-setup.8 M src/bin/hosted-engine.in M src/plugins/ovirt-hosted-engine-setup/storage/storage.py M tests/answers 4 files changed, 56 insertions(+), 31 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/22206 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Icca8a5f6296502da3610356620c336ae14e74353 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-hosted-engine-setup Gerrit-Branch: ovirt-hosted-engine-setup-1.0 Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-hosted-engine-setup[master]: packaging: setup: Support NFSv4 storage domain
by sbonazzo＠redhat.com 10 Dec '13

10 Dec '13

Sandro Bonazzola has submitted this change and it was merged. Change subject: packaging: setup: Support NFSv4 storage domain ...................................................................... packaging: setup: Support NFSv4 storage domain Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1034873 Change-Id: Icca8a5f6296502da3610356620c336ae14e74353 Signed-off-by: Yedidyah Bar David <didi(a)redhat.com> --- M man/ovirt-hosted-engine-setup.8 M src/bin/hosted-engine.in M src/plugins/ovirt-hosted-engine-setup/storage/storage.py M tests/answers 4 files changed, 56 insertions(+), 31 deletions(-) Approvals: Sandro Bonazzola: Looks good to me, approved Martin Sivák: Looks good to me, but someone else must approve Greg Padgett: Looks good to me, but someone else must approve Yedidyah Bar David: Verified -- To view, visit http://gerrit.ovirt.org/21902 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Icca8a5f6296502da3610356620c336ae14e74353 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-hosted-engine-setup Gerrit-Branch: master Gerrit-Owner: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: Adam Litke <alitke(a)redhat.com> Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com> Gerrit-Reviewer: Greg Padgett <gpadgett(a)redhat.com> Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: fixing line length
by emesika＠redhat.com 10 Dec '13

10 Dec '13

Eli Mesika has submitted this change and it was merged. Change subject: core: fixing line length ...................................................................... core: fixing line length Fixing a "line too long" error. Change-Id: I0e80f698010dca73daaf84c63b008d38164c6c26 Signed-off-by: Eli Mesika <emesika(a)redhat.com> --- M packaging/setup/ovirt_engine_setup/database.py 1 file changed, 2 insertions(+), 1 deletion(-) Approvals: Eli Mesika: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/22188 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0e80f698010dca73daaf84c63b008d38164c6c26 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-reports[master]: core: modify uri location of engine get session user service
by ydary＠redhat.com 09 Dec '13

09 Dec '13

Yaniv Dary has submitted this change and it was merged. Change subject: core: modify uri location of engine get session user service ...................................................................... core: modify uri location of engine get session user service part of ovirt-engine uri rework, to make it more well behaved application. the location of the servlet was moved. /OvirtEngineWeb/ValidateSession -> /ovirt-engine/services/get-session-user Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=961677 Change-Id: Ie90780b44759afb94cd34f5bf931e9bc0e6f7dba Signed-off-by: Alon Bar-Lev <alon.barlev(a)gmail.com> --- M packaging/ovirt-engine-reports-setup.py M reports/jars/EngineAuthentication/src/main/java/org/ovirt/authentication/EngineSimplePreAuthFilter.java M server-customizations/WEB-INF/applicationContext-security-web.xml 3 files changed, 7 insertions(+), 7 deletions(-) Approvals: Yaniv Dary: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/20789 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie90780b44759afb94cd34f5bf931e9bc0e6f7dba Gerrit-PatchSet: 2 Gerrit-Project: ovirt-reports Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alex Lourie <alourie(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com>

1 0

Change in ovirt-dwh[master]: packaging: setup: add read user validation for alphanumeric ...
by ydary＠redhat.com 09 Dec '13

09 Dec '13

Yaniv Dary has submitted this change and it was merged. Change subject: packaging: setup: add read user validation for alphanumeric chars ...................................................................... packaging: setup: add read user validation for alphanumeric chars Change-Id: Ia7389e7a0394fa08aa39ce9f4d93fa69b10e5ab7 Bug-Url: https://bugzilla.redhat.com/1037861 Signed-off-by: Alex Lourie <alourie(a)redhat.com> --- M packaging/common_utils.py 1 file changed, 6 insertions(+), 1 deletion(-) Approvals: Sandro Bonazzola: Looks good to me, but someone else must approve Alex Lourie: Verified Yaniv Dary: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/22158 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia7389e7a0394fa08aa39ce9f4d93fa69b10e5ab7 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-dwh Gerrit-Branch: master Gerrit-Owner: Alex Lourie <alourie(a)redhat.com> Gerrit-Reviewer: Alex Lourie <alourie(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com>

1 0

Change in ovirt-reports[ovirt-3.3.1]: packaging: refactored package name in setup
by ydary＠redhat.com 09 Dec '13

09 Dec '13

Yaniv Dary has submitted this change and it was merged. Change subject: packaging: refactored package name in setup ...................................................................... packaging: refactored package name in setup Change-Id: Idf0957b481be9f83a0461d942744f7247d79085c Signed-off-by: Yaniv Dary <ydary(a)redhat.com> --- M packaging/ovirt-engine-reports-setup.py 1 file changed, 10 insertions(+), 9 deletions(-) Approvals: Yaniv Dary: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/22193 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Idf0957b481be9f83a0461d942744f7247d79085c Gerrit-PatchSet: 1 Gerrit-Project: ovirt-reports Gerrit-Branch: ovirt-3.3.1 Gerrit-Owner: Yaniv Dary <ydary(a)redhat.com> Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com>

1 0