December 2013 - Engine-commits - oVirt List Archives

Change in ovirt-engine[ovirt-engine-3.3]: engine: Adding Speed optimization option to the scheduler
by iheim＠redhat.com 09 Dec '13

09 Dec '13

Itamar Heim has submitted this change and it was merged. Change subject: engine: Adding Speed optimization option to the scheduler ...................................................................... engine: Adding Speed optimization option to the scheduler Add to cluster entity optimization_type field. this field is a binary representation of cluster optimization possibilities. The first option is optimize for speed, allows to skip host weighing in case there are more than configurable amount of pending scheduling requests. Bug-Url: https://bugzilla.redhat.com/1014696 Change-Id: I0784f89648093e650be73fcc3d850a4854d53c1a Reviewed-on: http://gerrit.ovirt.org/#/c/19270/ Signed-off-by: Gilad Chaplik <gchaplik(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/SchedulingManager.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VDSGroup.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/config/ConfigValues.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/ConfigurationValues.java A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/scheduling/OptimizationType.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VdsGroupDAODbFacadeImpl.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/dataprovider/AsyncDataProvider.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/clusters/ClusterListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/clusters/ClusterModel.java M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/UIMessages.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/ApplicationConstants.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/cluster/ClusterPopupView.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/cluster/ClusterPopupView.ui.xml A packaging/dbscripts/upgrade/03_03_1030_add_vds_group_optimization_field.sql M packaging/dbscripts/upgrade/pre_upgrade/0000_config.sql M packaging/dbscripts/vds_groups_sp.sql M packaging/etc/engine-config/engine-config.properties 17 files changed, 218 insertions(+), 15 deletions(-) Approvals: Itamar Heim: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/22173 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0784f89648093e650be73fcc3d850a4854d53c1a Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.3 Gerrit-Owner: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-hosted-engine-ha[master]: agent: configurable host score factors
by dfediuck＠redhat.com 09 Dec '13

09 Dec '13

Doron Fediuck has submitted this change and it was merged. Change subject: agent: configurable host score factors ...................................................................... agent: configurable host score factors Allow configuration of host score factors in (usually) /etc/ovirt-hosted-engine-ha/agent.conf Change-Id: If485283c133eb517c9a3036ff42d1cd962a1697d Bug-Url: https://bugzilla.redhat.com/1037654 Signed-off-by: Greg Padgett <gpadgett(a)redhat.com> --- M ovirt-hosted-engine-ha.spec.in M ovirt_hosted_engine_ha/agent/Makefile.am A ovirt_hosted_engine_ha/agent/agent.conf M ovirt_hosted_engine_ha/agent/constants.py.in M ovirt_hosted_engine_ha/agent/hosted_engine.py 5 files changed, 69 insertions(+), 17 deletions(-) Approvals: Sandro Bonazzola: Looks good to me, but someone else must approve Martin Sivák: Looks good to me, but someone else must approve Greg Padgett: Verified Doron Fediuck: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/22056 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If485283c133eb517c9a3036ff42d1cd962a1697d Gerrit-PatchSet: 3 Gerrit-Project: ovirt-hosted-engine-ha Gerrit-Branch: master Gerrit-Owner: Greg Padgett <gpadgett(a)redhat.com> Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com> Gerrit-Reviewer: Greg Padgett <gpadgett(a)redhat.com> Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: engine: scheduling: allow placement overbooking in cluster l...
by gchaplik＠redhat.com 09 Dec '13

09 Dec '13

Gilad Chaplik has submitted this change and it was merged. Change subject: engine: scheduling: allow placement overbooking in cluster level ...................................................................... engine: scheduling: allow placement overbooking in cluster level Adding a cluster optimization to enable parallel VM scheduling requests for cluster (skip lock), in case pending requests are greater than configurable threshold. By default this feature is hidden from the user (unless setting config.SchedulerAllowOverBooking to true). Bug-Url: https://bugzilla.redhat.com/1014697 Change-Id: If52abf9974ab71b1f8d52ca268dac8dc39b89dc8 Signed-off-by: Gilad Chaplik <gchaplik(a)redhat.com> --- M backend/manager/modules/bll/exclude-filters.xml M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/SchedulingManager.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/config/ConfigValues.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/ConfigurationValues.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/scheduling/OptimizationType.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/dataprovider/AsyncDataProvider.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/clusters/ClusterListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/clusters/ClusterModel.java M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/UIMessages.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/ApplicationConstants.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/cluster/ClusterPopupView.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/cluster/ClusterPopupView.ui.xml M packaging/dbscripts/upgrade/pre_upgrade/0000_config.sql M packaging/etc/engine-config/engine-config.properties 14 files changed, 187 insertions(+), 7 deletions(-) Approvals: Gilad Chaplik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/19272 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If52abf9974ab71b1f8d52ca268dac8dc39b89dc8 Gerrit-PatchSet: 20 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: engine: Adding Speed optimization option to the scheduler
by gchaplik＠redhat.com 09 Dec '13

09 Dec '13

Gilad Chaplik has submitted this change and it was merged. Change subject: engine: Adding Speed optimization option to the scheduler ...................................................................... engine: Adding Speed optimization option to the scheduler Add to cluster entity optimization_type field. this field is a binary representation of cluster optimization possibilities. The first option is optimize for speed, allows to skip host weighing in case there are more than configurable amount of pending scheduling requests. Bug-Url: https://bugzilla.redhat.com/1014696 Change-Id: I0784f89648093e650be73fcc3d850a4854d53c1a Signed-off-by: Gilad Chaplik <gchaplik(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/SchedulingManager.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VDSGroup.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/config/ConfigValues.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/ConfigurationValues.java A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/scheduling/OptimizationType.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VdsGroupDAODbFacadeImpl.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/dataprovider/AsyncDataProvider.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/clusters/ClusterListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/clusters/ClusterModel.java M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/UIMessages.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/ApplicationConstants.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/cluster/ClusterPopupView.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/cluster/ClusterPopupView.ui.xml A packaging/dbscripts/upgrade/03_04_0180_add_vds_group_optimization_field.sql M packaging/dbscripts/upgrade/pre_upgrade/0000_config.sql M packaging/dbscripts/vds_groups_sp.sql M packaging/etc/engine-config/engine-config.properties 17 files changed, 229 insertions(+), 23 deletions(-) Approvals: Gilad Chaplik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/19270 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0784f89648093e650be73fcc3d850a4854d53c1a Gerrit-PatchSet: 20 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: Verifying storage space for AddDiskCommand
by amureini＠redhat.com 09 Dec '13

09 Dec '13

Allon Mureinik has submitted this change and it was merged. Change subject: core: Verifying storage space for AddDiskCommand ...................................................................... core: Verifying storage space for AddDiskCommand This is the first in a series of patches intended to fix storage space allocation validation throught the system (see bz). Added hasSpaceForNewDisk(s) in StorageDomainValidator. Added test - StorageDomainValidatorFreeSpaceTest. Applied use in AddDiskCommand (former use is buggy). Amended AddDiskToVmCommandTest. Previous tests simulated several space situations. These are now thoroughly tested in StorageDomainValidatorFreeSpaceTest, where they belong, and therefore removed from the command test. What's left to test is that the command actually behaves according to the validator's response. To that end added two new tests. Also amended AddDiskCommand CDA to always check for threshold limits (not only preallocated) since we want to have this leeway. Bug-url: https://bugzilla.redhat.com/960934 Change-Id: I1a33502683ec77fba09efffba1438beb552082f7 Signed-off-by: Vered Volansky <vvolansk(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddDiskCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/StorageDomainValidator.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/AddDiskToVmCommandTest.java A backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/validator/StorageDomainValidatorFreeSpaceTest.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/validator/StorageDomainValidatorTest.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/DiskImage.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/StorageDomain.java 7 files changed, 175 insertions(+), 64 deletions(-) Approvals: Allon Mureinik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/15377 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1a33502683ec77fba09efffba1438beb552082f7 Gerrit-PatchSet: 9 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Vered Volansky <vvolansk(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Liron Ar <laravot(a)redhat.com> Gerrit-Reviewer: Sergey Gotliv <sgotliv(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: Use longs to represent dates in QueryData
by amureini＠redhat.com 09 Dec '13

09 Dec '13

Allon Mureinik has submitted this change and it was merged. Change subject: core: Use longs to represent dates in QueryData ...................................................................... core: Use longs to represent dates in QueryData Use longs representing the amount of milliseconds since the epoch instead of Data instances in order to prevent accidental change of QueryData's internal members externally. Besides being a good defensive practice, this patch solves the EI_EXPOSE_REP and EI_EXPOSE_REP2 FindBugs warnings on this class. Change-Id: I9eb83c123a4fd9a1b2abc3bdb74d91a1391245d2 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/QueryData.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/SearchQuery.java 2 files changed, 5 insertions(+), 7 deletions(-) Approvals: Allon Mureinik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/22144 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9eb83c123a4fd9a1b2abc3bdb74d91a1391245d2 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: engine: Fix typo
by dfediuck＠redhat.com 09 Dec '13

09 Dec '13

Doron Fediuck has submitted this change and it was merged. Change subject: engine: Fix typo ...................................................................... engine: Fix typo Thiss patch fixes a minor spelling issue in MoM policy synchronization; Cluster--> Host --> "Synch Mom Policy" should be "Sync MoM Policy". Change-Id: I325c14e8b5c3fc97d6293d80a7f05d68fe89a1b9 Bug-Url: https://bugzilla.redhat.com/1039275 Signed-off-by: Doron Fediuck <dfediuck(a)redhat.com> --- M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/ApplicationConstants.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Doron Fediuck: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/22168 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I325c14e8b5c3fc97d6293d80a7f05d68fe89a1b9 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Doron Fediuck <dfediuck(a)redhat.com> Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: frontend: remove unused method NotifyRetrieved from Registra...
by tnisan＠redhat.com 09 Dec '13

09 Dec '13

Tal Nisan has submitted this change and it was merged. Change subject: frontend: remove unused method NotifyRetrieved from RegistrationResult ...................................................................... frontend: remove unused method NotifyRetrieved from RegistrationResult The method was causing a findbug warning by starting with capital letter. Since it was not in use, better to remove it than rename. Change-Id: I53d6e76f4446b9c93a203a966a9576f2a20f1dee Signed-off-by: Alissa Bonas <abonas(a)redhat.com> --- M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/RegistrationResult.java 1 file changed, 0 insertions(+), 5 deletions(-) Approvals: Tal Nisan: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/22165 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I53d6e76f4446b9c93a203a966a9576f2a20f1dee Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: webadmin: fix findbug warning in volumes tab
by kmayilsa＠redhat.com 09 Dec '13

09 Dec '13

Kanagaraj M has submitted this change and it was merged. Change subject: webadmin: fix findbug warning in volumes tab ...................................................................... webadmin: fix findbug warning in volumes tab Removed the unused field. Change-Id: I555f3409391616441f9731853fda886a719a20a3 Signed-off-by: Kanagaraj M <kmayilsa(a)redhat.com> --- M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/table/column/VolumeBrickStatusCell.java 1 file changed, 0 insertions(+), 3 deletions(-) Approvals: Kanagaraj M: Verified Gilad Chaplik: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/22166 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I555f3409391616441f9731853fda886a719a20a3 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Kanagaraj M <kmayilsa(a)redhat.com> Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayilsa(a)redhat.com> Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com>

1 0

Change in ovirt-engine[ovirt-engine-3.3]: core: get cd path only when the VM isn't the hosted engine
by iheim＠redhat.com 09 Dec '13

09 Dec '13

Itamar Heim has submitted this change and it was merged. Change subject: core: get cd path only when the VM isn't the hosted engine ...................................................................... core: get cd path only when the VM isn't the hosted engine When the VM we wish to change disk to is the hosted engine VM, getting the CD path fails, as this VM isn't managed by the engine. For that reason, this patch moves this logic to after we know it is not the hosted engine. In addition, it is good to do that not in the constructor but after some validation is done, as it is less error prone. Change-Id: Ie94993f2f43b5c3d2658542f38292b0d8c5503b3 Bug-Url: https://bugzilla.redhat.com/1014030 Signed-off-by: Oved Ourfali <oourfali(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ChangeDiskCommand.java 1 file changed, 9 insertions(+), 8 deletions(-) Approvals: Omer Frenkel: Looks good to me, approved Oved Ourfali: Verified -- To view, visit http://gerrit.ovirt.org/22164 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie94993f2f43b5c3d2658542f38292b0d8c5503b3 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.3 Gerrit-Owner: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0