December 2013 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: ui: rename member to start with lowercase in EntityModel
by tnisan＠redhat.com 26 Dec '13

26 Dec '13

Tal Nisan has submitted this change and it was merged. Change subject: ui: rename member to start with lowercase in EntityModel ...................................................................... ui: rename member to start with lowercase in EntityModel Change-Id: I308ac0c5e4562146b746cb6ea745e58bdd78f1a1 Signed-off-by: Alissa Bonas <abonas(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/EntityModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/LoginModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/clusters/ClusterModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/NfsStorageModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/SanStorageModelBase.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/AbstractDiskModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/CloudInitModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/MigrateModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/RunOnceModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/UnitVmModel.java 10 files changed, 16 insertions(+), 16 deletions(-) Approvals: Tal Nisan: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/22753 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I308ac0c5e4562146b746cb6ea745e58bdd78f1a1 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: ui: rename members to lowercase in *Model classes
by tnisan＠redhat.com 26 Dec '13

26 Dec '13

Tal Nisan has submitted this change and it was merged. Change subject: ui: rename members to lowercase in *Model classes ...................................................................... ui: rename members to lowercase in *Model classes Solves findbugs warnings Change-Id: I77e7ae57d3d95f044fa17c66ab11e4a48a0d6b7d Signed-off-by: Alissa Bonas <abonas(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/CommonModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/SystemTreeModel.java 2 files changed, 5 insertions(+), 5 deletions(-) Approvals: Tal Nisan: Verified; Looks good to me, approved Alissa Bonas: Verified -- To view, visit http://gerrit.ovirt.org/22751 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I77e7ae57d3d95f044fa17c66ab11e4a48a0d6b7d Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-dwh[master]: packaging: build: remove hard coded version from Makefile
by ydary＠redhat.com 26 Dec '13

26 Dec '13

Yaniv Dary has submitted this change and it was merged. Change subject: packaging: build: remove hard coded version from Makefile ...................................................................... packaging: build: remove hard coded version from Makefile Change-Id: I6c8d0a8015964f294734c04f76550855e05d959f Signed-off-by: Alon Bar-Lev <alon.barlev(a)gmail.com> --- M Makefile 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Alon Bar-Lev: Verified Yaniv Dary: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/22752 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6c8d0a8015964f294734c04f76550855e05d959f Gerrit-PatchSet: 1 Gerrit-Project: ovirt-dwh Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com>

1 0

Change in ovirt-dwh[master]: packaging: changed major version to 3.4
by ydary＠redhat.com 26 Dec '13

26 Dec '13

Yaniv Dary has submitted this change and it was merged. Change subject: packaging: changed major version to 3.4 ...................................................................... packaging: changed major version to 3.4 Change-Id: I287ecd8c016510036a2c669d4cc1e0afbfc89f63 Signed-off-by: Yaniv Dary <ydary(a)redhat.com> --- M Makefile M build-tools-root/jboss-modules-maven-plugin/pom.xml M build-tools-root/pom.xml R etl_export/ovirt_engine_dwh/aggregationtodaily_3_4/contexts/Default.properties R etl_export/ovirt_engine_dwh/aggregationtohourly_3_4/contexts/Default.properties R etl_export/ovirt_engine_dwh/configurationsync_3_4/contexts/Default.properties R etl_export/ovirt_engine_dwh/dailytimekeepingjob_3_4/contexts/Default.properties R etl_export/ovirt_engine_dwh/deletetimekeepingjob_3_4/contexts/Default.properties R etl_export/ovirt_engine_dwh/historydelete_3_4/contexts/Default.properties R etl_export/ovirt_engine_dwh/historyetl_3_4/contexts/Default.properties R etl_export/ovirt_engine_dwh/hostconfigcheck_3_4/contexts/Default.properties R etl_export/ovirt_engine_dwh/hourlytimekeepingjob_3_4/contexts/Default.properties R etl_export/ovirt_engine_dwh/minimalversioncheck_3_4/contexts/Default.properties R etl_export/ovirt_engine_dwh/osenumupdate_3_4/contexts/Default.properties R etl_export/ovirt_engine_dwh/parallelrun_3_4/contexts/Default.properties R etl_export/ovirt_engine_dwh/samplerunjobs_3_4/contexts/Default.properties R etl_export/ovirt_engine_dwh/sampletimekeepingjob_3_4/contexts/Default.properties R etl_export/ovirt_engine_dwh/statisticssync_3_4/contexts/Default.properties R etl_export/src/ovirt_engine_dwh/aggregationtodaily_3_4/AggregationToDaily.java R etl_export/src/ovirt_engine_dwh/aggregationtohourly_3_4/AggregationToHourly.java R etl_export/src/ovirt_engine_dwh/configurationsync_3_4/ConfigurationSync.java R etl_export/src/ovirt_engine_dwh/dailytimekeepingjob_3_4/DailyTimeKeepingJob.java R etl_export/src/ovirt_engine_dwh/deletetimekeepingjob_3_4/DeleteTimeKeepingJob.java R etl_export/src/ovirt_engine_dwh/historydelete_3_4/HistoryDelete.java R etl_export/src/ovirt_engine_dwh/historyetl_3_4/HistoryETL.java R etl_export/src/ovirt_engine_dwh/hostconfigcheck_3_4/HostConfigCheck.java R etl_export/src/ovirt_engine_dwh/hourlytimekeepingjob_3_4/HourlyTimeKeepingJob.java R etl_export/src/ovirt_engine_dwh/minimalversioncheck_3_4/MinimalVersionCheck.java R etl_export/src/ovirt_engine_dwh/osenumupdate_3_4/OsEnumUpdate.java R etl_export/src/ovirt_engine_dwh/parallelrun_3_4/ParallelRun.java R etl_export/src/ovirt_engine_dwh/samplerunjobs_3_4/SampleRunJobs.java R etl_export/src/ovirt_engine_dwh/sampletimekeepingjob_3_4/SampleTimeKeepingJob.java R etl_export/src/ovirt_engine_dwh/statisticssync_3_4/StatisticsSync.java M ovirt-engine-dwh/advancedPersistentLookupLib/pom.xml M ovirt-engine-dwh/dependencies/pom.xml M ovirt-engine-dwh/etltermination/pom.xml M ovirt-engine-dwh/historyETL/pom.xml M ovirt-engine-dwh/pom.xml A packaging/dbscripts/create_views_3_4.sql M packaging/dbscripts/dbcustomfunctions.sh M packaging/dbscripts/upgrade/pre_upgrade/set_etl_minimal_version.sql M packaging/services/ovirt-engine-dwhd/ovirt-engine-dwhd.py M pom.xml D tos_project/code/routines/RoutineHistoryETL_0.1.properties D tos_project/code/routines/RoutineHistoryETL_3.3.item R tos_project/code/routines/RoutineHistoryETL_3.4.item R tos_project/code/routines/RoutineHistoryETL_3.4.properties R tos_project/context/connectionJDBC_3.4.item R tos_project/context/connectionJDBC_3.4.properties R tos_project/process/AggregationToDaily_3.4.item R tos_project/process/AggregationToDaily_3.4.properties R tos_project/process/AggregationToHourly_3.4.item R tos_project/process/AggregationToHourly_3.4.properties R tos_project/process/ConfigurationSync_3.4.item R tos_project/process/ConfigurationSync_3.4.properties R tos_project/process/DailyTimeKeepingJob_3.4.item R tos_project/process/DailyTimeKeepingJob_3.4.properties R tos_project/process/DeleteTimeKeepingJob_3.4.item R tos_project/process/DeleteTimeKeepingJob_3.4.properties R tos_project/process/HistoryDelete_3.4.item R tos_project/process/HistoryDelete_3.4.properties R tos_project/process/HistoryETL_3.4.item R tos_project/process/HistoryETL_3.4.properties R tos_project/process/HostConfigCheck_3.4.item R tos_project/process/HostConfigCheck_3.4.properties R tos_project/process/HourlyTimeKeepingJob_3.4.item R tos_project/process/HourlyTimeKeepingJob_3.4.properties R tos_project/process/MinimalVersionCheck_3.4.item R tos_project/process/MinimalVersionCheck_3.4.properties R tos_project/process/OsEnumUpdate_3.4.item R tos_project/process/OsEnumUpdate_3.4.properties R tos_project/process/ParallelRun_3.4.item R tos_project/process/ParallelRun_3.4.properties R tos_project/process/SampleRunJobs_3.4.item R tos_project/process/SampleRunJobs_3.4.properties R tos_project/process/SampleTimeKeepingJob_3.4.item R tos_project/process/SampleTimeKeepingJob_3.4.properties R tos_project/process/StatisticsSync_3.4.item R tos_project/process/StatisticsSync_3.4.properties M tos_project/talend.project 80 files changed, 1,156 insertions(+), 606 deletions(-) Approvals: Yaniv Dary: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/22692 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I287ecd8c016510036a2c669d4cc1e0afbfc89f63 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-dwh Gerrit-Branch: master Gerrit-Owner: Yaniv Dary <ydary(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com>

1 0

Change in ovirt-engine[master]: ui: rename members to start with lowercase
by derez＠redhat.com 26 Dec '13

26 Dec '13

Daniel Erez has submitted this change and it was merged. Change subject: ui: rename members to start with lowercase ...................................................................... ui: rename members to start with lowercase Rename members in several classes to start with lowercase. Resolves findbugs warnings Change-Id: I9675f2ca2f9ad5a0b2c57d70870b2a8fe8c86a17 Signed-off-by: Alissa Bonas <abonas(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/tags/TagListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/tags/TagModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/ConsoleModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/ConsoleModelErrorEventListener.java 4 files changed, 8 insertions(+), 8 deletions(-) Approvals: Daniel Erez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/22732 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9675f2ca2f9ad5a0b2c57d70870b2a8fe8c86a17 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: ui: rename member to lowercase in VmGeneralModel
by derez＠redhat.com 26 Dec '13

26 Dec '13

Daniel Erez has submitted this change and it was merged. Change subject: ui: rename member to lowercase in VmGeneralModel ...................................................................... ui: rename member to lowercase in VmGeneralModel Change-Id: I67c3486f7dc1f44fbaa827262ae0665b6b26ab4e Signed-off-by: Alissa Bonas <abonas(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmGeneralModel.java 1 file changed, 3 insertions(+), 3 deletions(-) Approvals: Daniel Erez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/22733 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I67c3486f7dc1f44fbaa827262ae0665b6b26ab4e Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: restapi: Reload host after cluster update
by juan.hernandez＠redhat.com 25 Dec '13

25 Dec '13

Juan Hernandez has submitted this change and it was merged. Change subject: restapi: Reload host after cluster update ...................................................................... restapi: Reload host after cluster update When a host is updated the backend requires an special handling of the cluster: due to permissions issues it has to be changed with the special ChangeVDSCluster command. The rest of properties of the host can be changed with the UpdateVds command. Due to this limitation the REST API performs the update in two steps: first it checks if the cluster needs to be udpated and then runs the ChangeVDSCluster command, then it updates the rest of the attributes with the UpdateVds command. But the host entity is loaded before the first command, and then passed to the second as a parameter, thus it contains the old cluster id. The UpdateVds command checks this and refuses the execute the operation because it thinks that the cluster is changing. To solve this problem we are reloading the entity after changing the cluster and before sending it to the UpdateVds command. Change-Id: If6470ad9ce07a3a5f68146d0b73b2f50ba508b0f Bug-Url: https://bugzilla.redhat.com/1046336 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendHostResource.java M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendHostResourceTest.java 2 files changed, 8 insertions(+), 3 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/22739 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If6470ad9ce07a3a5f68146d0b73b2f50ba508b0f Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: engine: Initialize Mom Policies Severities
by gchaplik＠redhat.com 25 Dec '13

25 Dec '13

Gilad Chaplik has submitted this change and it was merged. Change subject: engine: Initialize Mom Policies Severities ...................................................................... engine: Initialize Mom Policies Severities When added audit log types for mom policies, their severities should have been initialized. Change-Id: I654845ec76bd876399b4206657a660eef4172612 Signed-off-by: Moti Asayag <masayag(a)redhat.com> --- M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/auditloghandling/AuditLogDirector.java 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Gilad Chaplik: Looks good to me, approved Moti Asayag: Verified -- To view, visit http://gerrit.ovirt.org/22735 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I654845ec76bd876399b4206657a660eef4172612 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: remove redundant fetch of vm disks on run vm
by ofrenkel＠redhat.com 25 Dec '13

25 Dec '13

Omer Frenkel has submitted this change and it was merged. Change subject: core: remove redundant fetch of vm disks on run vm ...................................................................... core: remove redundant fetch of vm disks on run vm There is no need to fetch the VM disks from the DB after we start to create stateless images on run VM as stateless flow. We fetch them in order to update the VM which is local to the RunVmCommand instance with the stateless images. But it is not used later on in the execute phase of the command, and the end-action phase is invoked on a new instance of RunVmCommand anyway. Change-Id: I39f761ce6ed9563dfc1473afd1e7d330bc95bb20 Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RunVmCommand.java 1 file changed, 0 insertions(+), 3 deletions(-) Approvals: Omer Frenkel: Looks good to me, approved Arik Hadas: Verified -- To view, visit http://gerrit.ovirt.org/22662 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I39f761ce6ed9563dfc1473afd1e7d330bc95bb20 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: fix regression that cleared run once flag
by ofrenkel＠redhat.com 25 Dec '13

25 Dec '13

Omer Frenkel has submitted this change and it was merged. Change subject: core: fix regression that cleared run once flag ...................................................................... core: fix regression that cleared run once flag We store a flag that indicates whether the VM is run in run once mode or not. The batch updates in VdsUpdateRuntimeInfo didn't update this flag correctly, which caused it to be cleared always by the monitoring. This patch fix this regression by adding the run-once attribute to the mapper that is used by the batch updates of VmDynamic. Change-Id: Ifc2bfe9c500f649dff39f4bbfae6d4b7e57cf883 Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VmDynamicDAODbFacadeImpl.java 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Omer Frenkel: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/22730 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ifc2bfe9c500f649dff39f4bbfae6d4b7e57cf883 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0