December 2013 - Engine-commits - Ovirt List Archives

Change in ovirt-engine[ovirt-engine-3.3]: core: avoid db deadlock and unneeded db updates for images

by iheim＠redhat.com

Itamar Heim has submitted this change and it was merged. Change subject: core: avoid db deadlock and unneeded db updates for images ...................................................................... core: avoid db deadlock and unneeded db updates for images When adding a VM from template (as part of pool or not), CreateSnapshotFromTemplateCommand is being executed and when the operation ends its end method is being called for each of the disks. In the end method there's an attempt to unlock the template image which causes to numerous issues: 1. There are attempts to update the template disks statuses to ok, as the updates aren't ordered and are executed for each added vm based on that template - db deadlocks occur. 2.Currently the template disks aren't being locked at all (which should be inspected regardless), so there's currently no point in unlocking them. The fix which is introduced is to not update the image status if it's already in the desired status, which will reduce the updates count in general and will prevent possible db deadlocks in the provided scenarios. Change-Id: I26a09ce674cfefd59819f3edf95accab31f0e80e Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1047163 Signed-off-by: Arik Hadas <ahadas(a)redhat.com> Signed-off-by: Liron Aravot <laravot(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/BaseImagesCommand.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Omer Frenkel: Looks good to me, approved Arik Hadas: Verified Liron Ar: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/22844 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I26a09ce674cfefd59819f3edf95accab31f0e80e Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.3 Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Liron Ar <laravot(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

10 years, 12 months

1
0
0 / 0

Change in ovirt-engine[master]: core: add helper for buildStoragePoolDomainsMap

by amureini＠redhat.com

Allon Mureinik has submitted this change and it was merged. Change subject: core: add helper for buildStoragePoolDomainsMap ...................................................................... core: add helper for buildStoragePoolDomainsMap Change-Id: Iefa82eaf8ac6e2ad46a411183668901fd6215368 Signed-off-by: Federico Simoncelli <fsimonce(a)redhat.com> --- A backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/StoragePoolDomainHelper.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/ReconstructMasterVDSCommand.java 2 files changed, 31 insertions(+), 12 deletions(-) Approvals: Allon Mureinik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/22711 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iefa82eaf8ac6e2ad46a411183668901fd6215368 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli <fsimonce(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com> Gerrit-Reviewer: Liron Ar <laravot(a)redhat.com> Gerrit-Reviewer: Sergey Gotliv <sgotliv(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

10 years, 12 months

1
0
0 / 0

Change in ovirt-engine[master]: ui: remove unused AbstractSubTabActionTree and its xml

by derez＠redhat.com

Daniel Erez has submitted this change and it was merged. Change subject: ui: remove unused AbstractSubTabActionTree and its xml ...................................................................... ui: remove unused AbstractSubTabActionTree and its xml Solves 2 findbugs warnings. Change-Id: I7dfe0048c53675bf0e25fc52091601c3d667060e Signed-off-by: Alissa Bonas <abonas(a)redhat.com> --- D frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/tree/AbstractSubTabActionTree.java D frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/tree/AbstractSubTabActionTree.ui.xml 2 files changed, 0 insertions(+), 164 deletions(-) Approvals: Daniel Erez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/22807 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7dfe0048c53675bf0e25fc52091601c3d667060e Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

10 years, 12 months

1
0
0 / 0

Change in ovirt-dwh[ovirt-3.3]: packging: fixed remote install setup

by ydary＠redhat.com

Yaniv Dary has submitted this change and it was merged. Change subject: packging: fixed remote install setup ...................................................................... packging: fixed remote install setup Change-Id: Ic315856f91c60f240c6830fb90e5b259774e9745 Bug-Url: https://bugzilla.redhat.com/1045846 Bug-Url: https://bugzilla.redhat.com/1047392 Bug-Url: https://bugzilla.redhat.com/1045855 Signed-off-by: Yaniv Dary <ydary(a)redhat.com> --- M packaging/common_utils.py M packaging/ovirt-engine-dwh-setup.py 2 files changed, 161 insertions(+), 94 deletions(-) Approvals: Yaniv Dary: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/22840 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic315856f91c60f240c6830fb90e5b259774e9745 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-dwh Gerrit-Branch: ovirt-3.3 Gerrit-Owner: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com>

10 years, 12 months

1
0
0 / 0

Change in ovirt-dwh[master]: packging: fixed remote install setup

by ydary＠redhat.com

Yaniv Dary has submitted this change and it was merged. Change subject: packging: fixed remote install setup ...................................................................... packging: fixed remote install setup Change-Id: Ic315856f91c60f240c6830fb90e5b259774e9745 Bug-Url: https://bugzilla.redhat.com/1045846 Bug-Url: https://bugzilla.redhat.com/1047392 Bug-Url: https://bugzilla.redhat.com/1045855 Signed-off-by: Yaniv Dary <ydary(a)redhat.com> --- M packaging/legacy-setup/common_utils.py M packaging/legacy-setup/ovirt-engine-dwh-setup.py 2 files changed, 161 insertions(+), 94 deletions(-) Approvals: Yaniv Dary: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/22701 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic315856f91c60f240c6830fb90e5b259774e9745 Gerrit-PatchSet: 15 Gerrit-Project: ovirt-dwh Gerrit-Branch: master Gerrit-Owner: Yaniv Dary <ydary(a)redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com>

10 years, 12 months

1
0
0 / 0

Change in ovirt-engine[master]: engine: Add NetworkUtils.isVlan(VdsNetworkInterface)

by masayag＠redhat.com

Moti Asayag has submitted this change and it was merged. Change subject: engine: Add NetworkUtils.isVlan(VdsNetworkInterface) ...................................................................... engine: Add NetworkUtils.isVlan(VdsNetworkInterface) Since the logic of indicating if a nic is a vlan device is repeated all over, it is extracted into a utility method. Change-Id: I05d1f711f2d0ee63b94914f2e133c1c0b7d4bac9 Signed-off-by: Moti Asayag <masayag(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MigrateVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/host/GetAllChildVlanInterfacesQuery.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/host/GetAllSiblingVlanInterfacesQuery.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/host/GetVlanParentQuery.java M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/NetworkUtils.java 5 files changed, 19 insertions(+), 8 deletions(-) Approvals: Moti Asayag: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/22786 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I05d1f711f2d0ee63b94914f2e133c1c0b7d4bac9 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

10 years, 12 months

1
0
0 / 0

Change in ovirt-engine[master]: engine: Remove unnecessary abstraction

by masayag＠redhat.com

Moti Asayag has submitted this change and it was merged. Change subject: engine: Remove unnecessary abstraction ...................................................................... engine: Remove unnecessary abstraction Assuming same parameters command of InterfaceAndIdQueryParameters maybe shared between vms and hosts is incorrect, as it is designed for host only. Change-Id: Ie8ed487f9ffbc52c11627736209c8d1d7b1434ac Signed-off-by: Moti Asayag <masayag(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/host/GetAllChildVlanInterfacesQuery.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/host/GetAllSiblingVlanInterfacesQuery.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/host/GetVlanParentQuery.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/InterfaceAndIdQueryParameters.java 4 files changed, 7 insertions(+), 7 deletions(-) Approvals: Moti Asayag: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/22785 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie8ed487f9ffbc52c11627736209c8d1d7b1434ac Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

10 years, 12 months

1
0
0 / 0

Change in ovirt-engine[master]: engine: Use NetworkUtils.isVlan() where possible

by masayag＠redhat.com

Moti Asayag has submitted this change and it was merged. Change subject: engine: Use NetworkUtils.isVlan() where possible ...................................................................... engine: Use NetworkUtils.isVlan() where possible Change-Id: Icacd36aed514174044e57ef13801c0b4de3cd662 Signed-off-by: Moti Asayag <masayag(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/host/AttachNetworkToVdsInterfaceCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/provider/network/openstack/OpenstackNetworkProviderProxy.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/NetworkValidator.java 3 files changed, 7 insertions(+), 6 deletions(-) Approvals: Moti Asayag: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/22784 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Icacd36aed514174044e57ef13801c0b4de3cd662 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

10 years, 12 months

1
0
0 / 0

Change in ovirt-engine[master]: engine: Extract isVlan into NetworkUtils for reusability

by masayag＠redhat.com

Moti Asayag has submitted this change and it was merged. Change subject: engine: Extract isVlan into NetworkUtils for reusability ...................................................................... engine: Extract isVlan into NetworkUtils for reusability Change-Id: I194bade26462fd91dc1b7a9585cbd2774f11af75 Signed-off-by: Moti Asayag <masayag(a)redhat.com> --- M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/NetworkUtils.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/SetupNetworksVDSCommand.java 2 files changed, 13 insertions(+), 6 deletions(-) Approvals: Moti Asayag: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/22728 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I194bade26462fd91dc1b7a9585cbd2774f11af75 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Leonardo Bianconi <leonardo.bianconi(a)eldorado.org.br> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

10 years, 12 months

1
0
0 / 0

Change in ovirt-dwh[master]: packaging: setup: handle file without newline at end

by ydary＠redhat.com

Yaniv Dary has submitted this change and it was merged. Change subject: packaging: setup: handle file without newline at end ...................................................................... packaging: setup: handle file without newline at end Change-Id: I1ed67d6fb57b0f56e5015460e15b013abeb3654d Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M packaging/legacy-setup/common_utils.py 1 file changed, 4 insertions(+), 0 deletions(-) Approvals: Yaniv Dary: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/22832 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1ed67d6fb57b0f56e5015460e15b013abeb3654d Gerrit-PatchSet: 1 Gerrit-Project: ovirt-dwh Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com>

10 years, 12 months

1
0
0 / 0

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

Engine-commits December 2013