Change in ovirt-engine[ovirt-engine-3.3]: core: allow current master domain to be selected as the new ...
by iheim＠redhat.com
Itamar Heim has submitted this change and it was merged.
Change subject: core: allow current master domain to be selected as the new master
......................................................................
core: allow current master domain to be selected as the new master
Currently the current master domain cannot be selected as the new
master, which can cause to the system to not be able to recover in case
that it's the only available domain.
This patch allows to perform reconstruct using the master domain in case
that we know that it's accessible -
1. Getting WrongMasterDomain error from vdsm means that we could get to
the master domain metadata.
NOTE: in that case, the reconstruct command will be executed with
parameter indicating that the current master can be selected as the new
master - but the host that return the WrongMasterDomain error or the master
domain id as the master domain id as the id of the domain to reconstruct to aren't
being passed to the command - this is being done to avoid possible
issues (for example: failing to reconstruct to that domain although we
can read the metadata, keep trying through the same host..etc).
The intention here is to improve the current situation for most of the
usecases.
2. When the master domain info in the db is different then the
info received from getStoragePoolInfo.
Change-Id: I705298d4f94b4afacc3ca028bb0a4e6080ac5a46
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1016118
Signed-off-by: Liron Aravot <laravot(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VdsEventListener.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/DeactivateStorageDomainCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/ReconstructMasterDomainCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/StorageDomainCommandBase.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/ReconstructMasterParameters.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/IVdsEventListener.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/IrsBrokerCommand.java
7 files changed, 73 insertions(+), 40 deletions(-)
Approvals:
Itamar Heim: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/22431
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I705298d4f94b4afacc3ca028bb0a4e6080ac5a46
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.3
Gerrit-Owner: Liron Ar <laravot(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com>
Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com>
Gerrit-Reviewer: Liron Ar <laravot(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 4 months
Change in ovirt-engine[ovirt-engine-3.3]: core: rm unneeded disconnect when reconstructing
by iheim＠redhat.com
Itamar Heim has submitted this change and it was merged.
Change subject: core: rm unneeded disconnect when reconstructing
......................................................................
core: rm unneeded disconnect when reconstructing
When performing reconstruct in the case that the old master status
isn't changed to inactive there is a call to disconnect from it.
This operation is wrong, there is no need to disconnect from the
current master which can only cause issues.
Change-Id: Ic3a0a3014d19ae78ddb47ef1a8ad4aa950539a9c
Related-To: https://bugzilla.redhat.com/show_bug.cgi?id=1016118
Signed-off-by: Liron Aravot <laravot(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/ReconstructMasterDomainCommand.java
1 file changed, 1 insertion(+), 8 deletions(-)
Approvals:
Itamar Heim: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/22430
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ic3a0a3014d19ae78ddb47ef1a8ad4aa950539a9c
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.3
Gerrit-Owner: Liron Ar <laravot(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com>
Gerrit-Reviewer: Liron Ar <laravot(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 4 months
Change in ovirt-engine[ovirt-engine-3.3]: packaging: setup: Clean up treatment of /etc/exports
by iheim＠redhat.com
Itamar Heim has submitted this change and it was merged.
Change subject: packaging: setup: Clean up treatment of /etc/exports
......................................................................
packaging: setup: Clean up treatment of /etc/exports
Without this change, /etc/exports:
- gets overwritten on setup if there is no /etc/exports.d
- is added empty lines when edited by setup
- is not restored to previous content on cleanup
With this change:
- If there is /etc/exports.d:
-- Setup writes there a file with the iso domain path, which is removed
on cleanup (if not changed since setup)
-- Setup removes this path from /etc/exports if it's there (supposedly
added by a previous legacy Setup), and this change is not reverted on
cleanup
- If there is only /etc/exports:
-- Setup adds to it the path if it's not there already
-- Cleanup reverts this change if the line was not changed since setup
Bug-Url: https://bugzilla.redhat.com/1035511
Change-Id: I035817c048518f77fc666cc6d5212c8e46edd65d
Signed-off-by: Yedidyah Bar David <didi(a)redhat.com>
---
M packaging/setup/plugins/ovirt-engine-setup/system/exportfs.py
1 file changed, 80 insertions(+), 45 deletions(-)
Approvals:
Itamar Heim: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/22318
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I035817c048518f77fc666cc6d5212c8e46edd65d
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.3
Gerrit-Owner: Yedidyah Bar David <didi(a)redhat.com>
Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com>
Gerrit-Reviewer: Kiril Nesenko <knesenko(a)redhat.com>
Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 4 months
Change in ovirt-engine[ovirt-engine-3.3]: frontend: adjust SPICE channels name
by iheim＠redhat.com
Itamar Heim has submitted this change and it was merged.
Change subject: frontend: adjust SPICE channels name
......................................................................
frontend: adjust SPICE channels name
This patch correct legacy SPICE channels names passing to clients.
Change-Id: Ia7d49e2bcf24b5190197e36e4f6d000b9cde54a3
Signed-off-by: Frantisek Kobzik <fkobzik(a)redhat.com>
---
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/uicommon/AbstractSpice.java
A frontend/webadmin/modules/gwt-common/src/test/java/org/ovirt/engine/ui/common/uicommon/AbstractSpiceTest.java
2 files changed, 53 insertions(+), 1 deletion(-)
Approvals:
Tomas Jelinek: Looks good to me, approved
Frank Kobzik: Verified
Michal Skrivanek: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/22531
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ia7d49e2bcf24b5190197e36e4f6d000b9cde54a3
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.3
Gerrit-Owner: Frank Kobzik <fkobzik(a)redhat.com>
Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com>
Gerrit-Reviewer: Frank Kobzik <fkobzik(a)redhat.com>
Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com>
Gerrit-Reviewer: Kiril Nesenko <knesenko(a)redhat.com>
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 4 months
Change in ovirt-engine[master]: engine: Gluster peer probe and status on same server
by kmayilsa＠redhat.com
Kanagaraj M has submitted this change and it was merged.
Change subject: engine: Gluster peer probe and status on same server
......................................................................
engine: Gluster peer probe and status on same server
Gluster peer status and volume info results are
served from the local db of the node, and hence the
results are not consistent if the commands are executed
on different nodes.
- Server is set to UP after a gluster peer probe only
when it is returned in the peer list from another node.
- Changing the up server selection to return the same
server to avoid inconsistent results for non distributed
gluster commands.
Using getRandomUpServer while calling distributed
gluster commands.
Change-Id: I1359a0c8f270b70a6afd3fd1490e5bb602d9b03f
Bug-Url: https://bugzilla.redhat.com/1043032
Signed-off-by: Sahina Bose <sabose(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/InitVdsOnUpCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GetGlusterVolumeAdvancedDetailsQuery.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GlusterCommandBase.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GlusterQueriesCommandBase.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GlusterSyncJob.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/tasks/GlusterTasksService.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/utils/ClusterUtils.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/gluster/GetGlusterVolumeAdvancedDetailsQueryTest.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/gluster/GlusterSyncJobTest.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/config/ConfigValues.java
M packaging/dbscripts/upgrade/pre_upgrade/0000_config.sql
M packaging/dbscripts/vds_sp.sql
12 files changed, 88 insertions(+), 11 deletions(-)
Approvals:
Kanagaraj M: Looks good to me, approved
Sahina Bose: Verified
--
To view, visit http://gerrit.ovirt.org/22448
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I1359a0c8f270b70a6afd3fd1490e5bb602d9b03f
Gerrit-PatchSet: 7
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Sahina Bose <sabose(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Kanagaraj M <kmayilsa(a)redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>
Gerrit-Reviewer: Ramesh N <rnachimu(a)redhat.com>
Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com>
Gerrit-Reviewer: Shubhendu Tripathi <shtripat(a)redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 4 months
Change in ovirt-engine[master]: engine: Fixed redundant null check find bug error
by yzaslavs＠redhat.com
Yair Zaslavsky has submitted this change and it was merged.
Change subject: engine: Fixed redundant null check find bug error
......................................................................
engine: Fixed redundant null check find bug error
Redundant nullcheck of glusterServer, fixed
Change-Id: I9652c52e2886a4c225b5a79985f18f7f372dd4e4
Signed-off-by: Sahina Bose <sabose(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/InitVdsOnUpCommand.java
1 file changed, 1 insertion(+), 2 deletions(-)
Approvals:
Yair Zaslavsky: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/22405
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I9652c52e2886a4c225b5a79985f18f7f372dd4e4
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Sahina Bose <sabose(a)redhat.com>
Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com>
Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com>
Gerrit-Reviewer: Kanagaraj M <kmayilsa(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com>
Gerrit-Reviewer: Timothy Asir <tjeyasin(a)redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 4 months
Change in ovirt-reports[ovirt-3.3]: packaging: setup: update reports DB schema on major release ...
by ydary＠redhat.com
Yaniv Dary has submitted this change and it was merged.
Change subject: packaging: setup: update reports DB schema on major release upgrade
......................................................................
packaging: setup: update reports DB schema on major release upgrade
This addition is required because there is a major schema change
introduced by Jasper Server in 5.5 compared to 4.7; this is needed
for correct operation of export/import functionality.
Change-Id: I0f2557aae870c9f9f3c8076abd67b5c72120b279
Bug-Url: https://bugzilla.redhat.com/1043530
Signed-off-by: Alex Lourie <alourie(a)redhat.com>
---
M packaging/ovirt-engine-reports-setup.py
1 file changed, 35 insertions(+), 0 deletions(-)
Approvals:
Yaniv Dary: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/22549
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I0f2557aae870c9f9f3c8076abd67b5c72120b279
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-reports
Gerrit-Branch: ovirt-3.3
Gerrit-Owner: Yaniv Dary <ydary(a)redhat.com>
Gerrit-Reviewer: Alex Lourie <alourie(a)redhat.com>
Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com>
10 years, 5 months
Change in ovirt-reports[ovirt-3.3]: packaging: setup: update error handling in remote DB flow
by ydary＠redhat.com
Yaniv Dary has submitted this change and it was merged.
Change subject: packaging: setup: update error handling in remote DB flow
......................................................................
packaging: setup: update error handling in remote DB flow
Change-Id: I60af89aee018eb44a63d38de42f2643c0d850d3e
Bug-Url: https://bugzilla.redhat.com/1039946
Signed-off-by: Alex Lourie <alourie(a)redhat.com>
---
M packaging/ovirt-engine-reports-setup.py
1 file changed, 2 insertions(+), 5 deletions(-)
Approvals:
Yaniv Dary: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/22550
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I60af89aee018eb44a63d38de42f2643c0d850d3e
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-reports
Gerrit-Branch: ovirt-3.3
Gerrit-Owner: Yaniv Dary <ydary(a)redhat.com>
Gerrit-Reviewer: Alex Lourie <alourie(a)redhat.com>
Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com>
10 years, 5 months
Change in ovirt-reports[master]: packaging: setup: update error handling in remote DB flow
by ydary＠redhat.com
Yaniv Dary has submitted this change and it was merged.
Change subject: packaging: setup: update error handling in remote DB flow
......................................................................
packaging: setup: update error handling in remote DB flow
Change-Id: I60af89aee018eb44a63d38de42f2643c0d850d3e
Bug-Url: https://bugzilla.redhat.com/1039946
Signed-off-by: Alex Lourie <alourie(a)redhat.com>
---
M packaging/ovirt-engine-reports-setup.py
1 file changed, 2 insertions(+), 5 deletions(-)
Approvals:
Yaniv Dary: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/22235
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I60af89aee018eb44a63d38de42f2643c0d850d3e
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-reports
Gerrit-Branch: master
Gerrit-Owner: Alex Lourie <alourie(a)redhat.com>
Gerrit-Reviewer: Alex Lourie <alourie(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com>
10 years, 5 months
Change in ovirt-reports[master]: packaging: setup: update reports DB schema on major release ...
by ydary＠redhat.com
Yaniv Dary has submitted this change and it was merged.
Change subject: packaging: setup: update reports DB schema on major release upgrade
......................................................................
packaging: setup: update reports DB schema on major release upgrade
This addition is required because there is a major schema change
introduced by Jasper Server in 5.5 compared to 4.7; this is needed
for correct operation of export/import functionality.
Change-Id: I0f2557aae870c9f9f3c8076abd67b5c72120b279
Bug-Url: https://bugzilla.redhat.com/1043530
Signed-off-by: Alex Lourie <alourie(a)redhat.com>
---
M packaging/ovirt-engine-reports-setup.py
1 file changed, 35 insertions(+), 0 deletions(-)
Approvals:
Yaniv Dary: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/22548
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I0f2557aae870c9f9f3c8076abd67b5c72120b279
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-reports
Gerrit-Branch: master
Gerrit-Owner: Alex Lourie <alourie(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com>
Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com>
10 years, 5 months